All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mtd: spi-nor: Sort headers alphabetically
@ 2023-02-02 14:46 ` Tudor Ambarus
  0 siblings, 0 replies; 4+ messages in thread
From: Tudor Ambarus @ 2023-02-02 14:46 UTC (permalink / raw)
  To: pratyush, michael; +Cc: linux-mtd, linux-kernel, Tudor Ambarus

Sort headers alphabetically - it helps locating duplicates, and makes it
easier to figure out where to insert new headers. Alphabetic order should
also prove that each header is self-contained, i.e. can be included without
prerequisites.

Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
 drivers/mtd/spi-nor/core.c    | 13 ++++++-------
 drivers/mtd/spi-nor/debugfs.c |  2 +-
 drivers/mtd/spi-nor/sfdp.c    |  2 +-
 3 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index b500655f7937..247d1014879a 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -9,19 +9,18 @@
 
 #include <linux/err.h>
 #include <linux/errno.h>
-#include <linux/module.h>
+#include <linux/delay.h>
 #include <linux/device.h>
-#include <linux/mutex.h>
 #include <linux/math64.h>
-#include <linux/sizes.h>
-#include <linux/slab.h>
-#include <linux/delay.h>
-
+#include <linux/module.h>
 #include <linux/mtd/mtd.h>
+#include <linux/mtd/spi-nor.h>
+#include <linux/mutex.h>
 #include <linux/of_platform.h>
 #include <linux/sched/task_stack.h>
+#include <linux/sizes.h>
+#include <linux/slab.h>
 #include <linux/spi/flash.h>
-#include <linux/mtd/spi-nor.h>
 
 #include "core.h"
 
diff --git a/drivers/mtd/spi-nor/debugfs.c b/drivers/mtd/spi-nor/debugfs.c
index ff895f6758ea..845b78c7ecc7 100644
--- a/drivers/mtd/spi-nor/debugfs.c
+++ b/drivers/mtd/spi-nor/debugfs.c
@@ -1,9 +1,9 @@
 // SPDX-License-Identifier: GPL-2.0
 
+#include <linux/debugfs.h>
 #include <linux/mtd/spi-nor.h>
 #include <linux/spi/spi.h>
 #include <linux/spi/spi-mem.h>
-#include <linux/debugfs.h>
 
 #include "core.h"
 
diff --git a/drivers/mtd/spi-nor/sfdp.c b/drivers/mtd/spi-nor/sfdp.c
index 3acc01c3a900..fd4daf8fa5df 100644
--- a/drivers/mtd/spi-nor/sfdp.c
+++ b/drivers/mtd/spi-nor/sfdp.c
@@ -5,9 +5,9 @@
  */
 
 #include <linux/bitfield.h>
+#include <linux/mtd/spi-nor.h>
 #include <linux/slab.h>
 #include <linux/sort.h>
-#include <linux/mtd/spi-nor.h>
 
 #include "core.h"
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] mtd: spi-nor: Sort headers alphabetically
@ 2023-02-02 14:46 ` Tudor Ambarus
  0 siblings, 0 replies; 4+ messages in thread
From: Tudor Ambarus @ 2023-02-02 14:46 UTC (permalink / raw)
  To: pratyush, michael; +Cc: linux-mtd, linux-kernel, Tudor Ambarus

Sort headers alphabetically - it helps locating duplicates, and makes it
easier to figure out where to insert new headers. Alphabetic order should
also prove that each header is self-contained, i.e. can be included without
prerequisites.

Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
 drivers/mtd/spi-nor/core.c    | 13 ++++++-------
 drivers/mtd/spi-nor/debugfs.c |  2 +-
 drivers/mtd/spi-nor/sfdp.c    |  2 +-
 3 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index b500655f7937..247d1014879a 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -9,19 +9,18 @@
 
 #include <linux/err.h>
 #include <linux/errno.h>
-#include <linux/module.h>
+#include <linux/delay.h>
 #include <linux/device.h>
-#include <linux/mutex.h>
 #include <linux/math64.h>
-#include <linux/sizes.h>
-#include <linux/slab.h>
-#include <linux/delay.h>
-
+#include <linux/module.h>
 #include <linux/mtd/mtd.h>
+#include <linux/mtd/spi-nor.h>
+#include <linux/mutex.h>
 #include <linux/of_platform.h>
 #include <linux/sched/task_stack.h>
+#include <linux/sizes.h>
+#include <linux/slab.h>
 #include <linux/spi/flash.h>
-#include <linux/mtd/spi-nor.h>
 
 #include "core.h"
 
diff --git a/drivers/mtd/spi-nor/debugfs.c b/drivers/mtd/spi-nor/debugfs.c
index ff895f6758ea..845b78c7ecc7 100644
--- a/drivers/mtd/spi-nor/debugfs.c
+++ b/drivers/mtd/spi-nor/debugfs.c
@@ -1,9 +1,9 @@
 // SPDX-License-Identifier: GPL-2.0
 
+#include <linux/debugfs.h>
 #include <linux/mtd/spi-nor.h>
 #include <linux/spi/spi.h>
 #include <linux/spi/spi-mem.h>
-#include <linux/debugfs.h>
 
 #include "core.h"
 
diff --git a/drivers/mtd/spi-nor/sfdp.c b/drivers/mtd/spi-nor/sfdp.c
index 3acc01c3a900..fd4daf8fa5df 100644
--- a/drivers/mtd/spi-nor/sfdp.c
+++ b/drivers/mtd/spi-nor/sfdp.c
@@ -5,9 +5,9 @@
  */
 
 #include <linux/bitfield.h>
+#include <linux/mtd/spi-nor.h>
 #include <linux/slab.h>
 #include <linux/sort.h>
-#include <linux/mtd/spi-nor.h>
 
 #include "core.h"
 
-- 
2.34.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: spi-nor: Sort headers alphabetically
  2023-02-02 14:46 ` Tudor Ambarus
@ 2023-02-06  8:42   ` Tudor Ambarus
  -1 siblings, 0 replies; 4+ messages in thread
From: Tudor Ambarus @ 2023-02-06  8:42 UTC (permalink / raw)
  To: pratyush, michael, Tudor Ambarus; +Cc: linux-mtd, linux-kernel

On Thu, 02 Feb 2023 16:46:28 +0200, Tudor Ambarus wrote:
> Sort headers alphabetically - it helps locating duplicates, and makes it
> easier to figure out where to insert new headers. Alphabetic order should
> also prove that each header is self-contained, i.e. can be included without
> prerequisites.
> 
> 

Applied to spi-nor/next, thanks!

[1/1] mtd: spi-nor: Sort headers alphabetically
      https://git.kernel.org/mtd/c/893fd950c89d

Best regards,
-- 
Tudor Ambarus <tudor.ambarus@linaro.org>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: spi-nor: Sort headers alphabetically
@ 2023-02-06  8:42   ` Tudor Ambarus
  0 siblings, 0 replies; 4+ messages in thread
From: Tudor Ambarus @ 2023-02-06  8:42 UTC (permalink / raw)
  To: pratyush, michael, Tudor Ambarus; +Cc: linux-mtd, linux-kernel

On Thu, 02 Feb 2023 16:46:28 +0200, Tudor Ambarus wrote:
> Sort headers alphabetically - it helps locating duplicates, and makes it
> easier to figure out where to insert new headers. Alphabetic order should
> also prove that each header is self-contained, i.e. can be included without
> prerequisites.
> 
> 

Applied to spi-nor/next, thanks!

[1/1] mtd: spi-nor: Sort headers alphabetically
      https://git.kernel.org/mtd/c/893fd950c89d

Best regards,
-- 
Tudor Ambarus <tudor.ambarus@linaro.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-06  8:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-02 14:46 [PATCH] mtd: spi-nor: Sort headers alphabetically Tudor Ambarus
2023-02-02 14:46 ` Tudor Ambarus
2023-02-06  8:42 ` Tudor Ambarus
2023-02-06  8:42   ` Tudor Ambarus

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.