All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/python-pytest: remove runtime dependency on python-toml
@ 2023-02-02 15:27 Arnout Vandecappelle
  2023-02-04 19:54 ` Ryan Barnett
  0 siblings, 1 reply; 2+ messages in thread
From: Arnout Vandecappelle @ 2023-02-02 15:27 UTC (permalink / raw)
  To: buildroot

Since version 7.2 [1], with Python 3.11+ pytest no longer uses tomli to
parse pyproject.toml but instead uses tomllib which is part of Python
itself [2]. Note that toml was replaced with tomli in version 7.0, so
the dependency was anyway incorrect.

Note that tomllib is unconditionally installed as part of Python 3.11,
there is no PYTHON3_LIBTOML option or anything like that that needs to
be selected.

[1] https://docs.pytest.org/en/latest/changelog.html#pytest-7-2-0-2022-10-23
[2] https://github.com/pytest-dev/pytest/pull/9741

Signed-off-by: Arnout Vandecappelle <arnout@mind.be>
---
I can't be bother with sending a patch changing toml to tomli for
2022.11 - it's going EOL in two months anyway, and apparently nobody
noticed...
---
 package/python-pytest/Config.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/python-pytest/Config.in b/package/python-pytest/Config.in
index c3956c76d2..9bbc9ea2d2 100644
--- a/package/python-pytest/Config.in
+++ b/package/python-pytest/Config.in
@@ -5,7 +5,6 @@ config BR2_PACKAGE_PYTHON_PYTEST
 	select BR2_PACKAGE_PYTHON_PACKAGING # runtime
 	select BR2_PACKAGE_PYTHON_PLUGGY # runtime
 	select BR2_PACKAGE_PYTHON_PY # runtime
-	select BR2_PACKAGE_PYTHON_TOML # runtime
 	select BR2_PACKAGE_PYTHON3_PYEXPAT # runtime
 	help
 	  pytest is a framework that makes building simple and scalable
-- 
2.39.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH] package/python-pytest: remove runtime dependency on python-toml
  2023-02-02 15:27 [Buildroot] [PATCH] package/python-pytest: remove runtime dependency on python-toml Arnout Vandecappelle
@ 2023-02-04 19:54 ` Ryan Barnett
  0 siblings, 0 replies; 2+ messages in thread
From: Ryan Barnett @ 2023-02-04 19:54 UTC (permalink / raw)
  To: Arnout Vandecappelle; +Cc: buildroot

On Thu, Feb 2, 2023 at 9:28 AM Arnout Vandecappelle <arnout@mind.be> wrote:
>
> Since version 7.2 [1], with Python 3.11+ pytest no longer uses tomli to
> parse pyproject.toml but instead uses tomllib which is part of Python
> itself [2]. Note that toml was replaced with tomli in version 7.0, so
> the dependency was anyway incorrect.
>
> Note that tomllib is unconditionally installed as part of Python 3.11,
> there is no PYTHON3_LIBTOML option or anything like that that needs to
> be selected.
>
> [1] https://docs.pytest.org/en/latest/changelog.html#pytest-7-2-0-2022-10-23
> [2] https://github.com/pytest-dev/pytest/pull/9741
>
> Signed-off-by: Arnout Vandecappelle <arnout@mind.be>

Reviewed-by: Ryan Barnett <ryanbarnett3@gmail.com>

> ---
> I can't be bother with sending a patch changing toml to tomli for
> 2022.11 - it's going EOL in two months anyway, and apparently nobody
> noticed...
> ---
>  package/python-pytest/Config.in | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/package/python-pytest/Config.in b/package/python-pytest/Config.in
> index c3956c76d2..9bbc9ea2d2 100644
> --- a/package/python-pytest/Config.in
> +++ b/package/python-pytest/Config.in
> @@ -5,7 +5,6 @@ config BR2_PACKAGE_PYTHON_PYTEST
>         select BR2_PACKAGE_PYTHON_PACKAGING # runtime
>         select BR2_PACKAGE_PYTHON_PLUGGY # runtime
>         select BR2_PACKAGE_PYTHON_PY # runtime
> -       select BR2_PACKAGE_PYTHON_TOML # runtime
>         select BR2_PACKAGE_PYTHON3_PYEXPAT # runtime
>         help
>           pytest is a framework that makes building simple and scalable
> --
> 2.39.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-04 19:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-02 15:27 [Buildroot] [PATCH] package/python-pytest: remove runtime dependency on python-toml Arnout Vandecappelle
2023-02-04 19:54 ` Ryan Barnett

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.