All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: <qemu-devel@nongnu.org>, <richard.henderson@linaro.org>,
	<pbonzini@redhat.com>, <kwolf@redhat.com>, <hreitz@redhat.com>,
	<imp@bsdimp.com>, <kevans@freebsd.org>, <berrange@redhat.com>,
	<groug@kaod.org>, <qemu_oss@crudebyte.com>, <mst@redhat.com>,
	<philmd@linaro.org>, <peter.maydell@linaro.org>,
	<alistair@alistair23.me>, <jasowang@redhat.com>,
	<kbastian@mail.uni-paderborn.de>, <quintela@redhat.com>,
	<dgilbert@redhat.com>, <michael.roth@amd.com>,
	<kkostiuk@redhat.com>, <tsimpson@quicinc.com>,
	<palmer@dabbelt.com>, <bin.meng@windriver.com>,
	<qemu-block@nongnu.org>, <qemu-arm@nongnu.org>,
	<qemu-riscv@nongnu.org>
Subject: Re: [PATCH v6 07/20] hw/cxl: Clean up includes
Date: Thu, 2 Feb 2023 15:51:49 +0000	[thread overview]
Message-ID: <20230202155149.00002c8a@Huawei.com> (raw)
In-Reply-To: <20230202133830.2152150-8-armbru@redhat.com>

On Thu,  2 Feb 2023 14:38:17 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> This commit was created with scripts/clean-includes.
> 
> All .c should include qemu/osdep.h first.  The script performs three
> related cleanups:
> 
> * Ensure .c files include qemu/osdep.h first.
> * Including it in a .h is redundant, since the .c  already includes
>   it.  Drop such inclusions.
> * Likewise, including headers qemu/osdep.h includes is redundant.
>   Drop these, too.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
>  include/hw/cxl/cxl_component.h | 2 --
>  include/hw/cxl/cxl_host.h      | 1 -
>  include/hw/cxl/cxl_pci.h       | 1 -
>  3 files changed, 4 deletions(-)
> 
> diff --git a/include/hw/cxl/cxl_component.h b/include/hw/cxl/cxl_component.h
> index 5dca21e95b..692d7a5507 100644
> --- a/include/hw/cxl/cxl_component.h
> +++ b/include/hw/cxl/cxl_component.h
> @@ -15,9 +15,7 @@
>  #define CXL2_COMPONENT_CM_REGION_SIZE 0x1000
>  #define CXL2_COMPONENT_BLOCK_SIZE 0x10000
>  
> -#include "qemu/compiler.h"
>  #include "qemu/range.h"
> -#include "qemu/typedefs.h"
>  #include "hw/cxl/cxl_cdat.h"
>  #include "hw/register.h"
>  #include "qapi/error.h"
> diff --git a/include/hw/cxl/cxl_host.h b/include/hw/cxl/cxl_host.h
> index a1b662ce40..c9bc9c7c50 100644
> --- a/include/hw/cxl/cxl_host.h
> +++ b/include/hw/cxl/cxl_host.h
> @@ -7,7 +7,6 @@
>   * COPYING file in the top-level directory.
>   */
>  
> -#include "qemu/osdep.h"
>  #include "hw/cxl/cxl.h"
>  #include "hw/boards.h"
>  
> diff --git a/include/hw/cxl/cxl_pci.h b/include/hw/cxl/cxl_pci.h
> index 01e15ed5b4..407be95b9e 100644
> --- a/include/hw/cxl/cxl_pci.h
> +++ b/include/hw/cxl/cxl_pci.h
> @@ -10,7 +10,6 @@
>  #ifndef CXL_PCI_H
>  #define CXL_PCI_H
>  
> -#include "qemu/compiler.h"
>  
>  #define CXL_VENDOR_ID 0x1e98
>  



WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: <qemu-devel@nongnu.org>, <richard.henderson@linaro.org>,
	<pbonzini@redhat.com>, <kwolf@redhat.com>, <hreitz@redhat.com>,
	<imp@bsdimp.com>, <kevans@freebsd.org>, <berrange@redhat.com>,
	<groug@kaod.org>, <qemu_oss@crudebyte.com>, <mst@redhat.com>,
	<philmd@linaro.org>, <peter.maydell@linaro.org>,
	<alistair@alistair23.me>, <jasowang@redhat.com>,
	<kbastian@mail.uni-paderborn.de>, <quintela@redhat.com>,
	<dgilbert@redhat.com>, <michael.roth@amd.com>,
	<kkostiuk@redhat.com>, <tsimpson@quicinc.com>,
	<palmer@dabbelt.com>, <bin.meng@windriver.com>,
	<qemu-block@nongnu.org>, <qemu-arm@nongnu.org>,
	<qemu-riscv@nongnu.org>
Subject: Re: [PATCH v6 07/20] hw/cxl: Clean up includes
Date: Thu, 2 Feb 2023 15:51:49 +0000	[thread overview]
Message-ID: <20230202155149.00002c8a@Huawei.com> (raw)
In-Reply-To: <20230202133830.2152150-8-armbru@redhat.com>

On Thu,  2 Feb 2023 14:38:17 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> This commit was created with scripts/clean-includes.
> 
> All .c should include qemu/osdep.h first.  The script performs three
> related cleanups:
> 
> * Ensure .c files include qemu/osdep.h first.
> * Including it in a .h is redundant, since the .c  already includes
>   it.  Drop such inclusions.
> * Likewise, including headers qemu/osdep.h includes is redundant.
>   Drop these, too.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
>  include/hw/cxl/cxl_component.h | 2 --
>  include/hw/cxl/cxl_host.h      | 1 -
>  include/hw/cxl/cxl_pci.h       | 1 -
>  3 files changed, 4 deletions(-)
> 
> diff --git a/include/hw/cxl/cxl_component.h b/include/hw/cxl/cxl_component.h
> index 5dca21e95b..692d7a5507 100644
> --- a/include/hw/cxl/cxl_component.h
> +++ b/include/hw/cxl/cxl_component.h
> @@ -15,9 +15,7 @@
>  #define CXL2_COMPONENT_CM_REGION_SIZE 0x1000
>  #define CXL2_COMPONENT_BLOCK_SIZE 0x10000
>  
> -#include "qemu/compiler.h"
>  #include "qemu/range.h"
> -#include "qemu/typedefs.h"
>  #include "hw/cxl/cxl_cdat.h"
>  #include "hw/register.h"
>  #include "qapi/error.h"
> diff --git a/include/hw/cxl/cxl_host.h b/include/hw/cxl/cxl_host.h
> index a1b662ce40..c9bc9c7c50 100644
> --- a/include/hw/cxl/cxl_host.h
> +++ b/include/hw/cxl/cxl_host.h
> @@ -7,7 +7,6 @@
>   * COPYING file in the top-level directory.
>   */
>  
> -#include "qemu/osdep.h"
>  #include "hw/cxl/cxl.h"
>  #include "hw/boards.h"
>  
> diff --git a/include/hw/cxl/cxl_pci.h b/include/hw/cxl/cxl_pci.h
> index 01e15ed5b4..407be95b9e 100644
> --- a/include/hw/cxl/cxl_pci.h
> +++ b/include/hw/cxl/cxl_pci.h
> @@ -10,7 +10,6 @@
>  #ifndef CXL_PCI_H
>  #define CXL_PCI_H
>  
> -#include "qemu/compiler.h"
>  
>  #define CXL_VENDOR_ID 0x1e98
>  



  reply	other threads:[~2023-02-02 15:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-02 13:38 [PATCH v6 00/20] Clean up includes Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 01/20] scripts/clean-includes: Fully skip / ignore files Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 02/20] scripts/clean-includes: Don't claim duplicate headers found when not Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 03/20] scripts/clean-includes: Skip symbolic links Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 04/20] scripts/clean-includes: Improve --git commit message Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 05/20] bsd-user: Clean up includes Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 06/20] crypto: " Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 07/20] hw/cxl: " Markus Armbruster
2023-02-02 15:51   ` Jonathan Cameron via [this message]
2023-02-02 15:51     ` Jonathan Cameron
2023-02-02 13:38 ` [PATCH v6 08/20] hw/input: " Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 09/20] hw/tricore: " Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 10/20] qga: " Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 11/20] migration: " Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 12/20] net: " Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 13/20] target/hexagon: " Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 14/20] riscv: " Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 15/20] block: " Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 16/20] accel: " Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 17/20] Fix non-first inclusions of qemu/osdep.h Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 18/20] Don't include headers already included by qemu/osdep.h Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 19/20] 9p: Drop superfluous include of linux/limits.h Markus Armbruster
2023-02-02 13:38 ` [PATCH v6 20/20] Drop duplicate #include Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230202155149.00002c8a@Huawei.com \
    --to=qemu-devel@nongnu.org \
    --cc=Jonathan.Cameron@Huawei.com \
    --cc=alistair@alistair23.me \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bin.meng@windriver.com \
    --cc=dgilbert@redhat.com \
    --cc=groug@kaod.org \
    --cc=hreitz@redhat.com \
    --cc=imp@bsdimp.com \
    --cc=jasowang@redhat.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=kevans@freebsd.org \
    --cc=kkostiuk@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=mst@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    --cc=tsimpson@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.