* [PATCH] drm/i915: Make sure dsm_size has correct granularity
@ 2023-02-02 18:02 ` Nirmoy Das
0 siblings, 0 replies; 9+ messages in thread
From: Nirmoy Das @ 2023-02-02 18:02 UTC (permalink / raw)
To: intel-gfx
Cc: Andrzej Hajda, Lucas De Marchi, Matthew Auld, dri-devel, Nirmoy Das
DSM granularity is 1MB so make sure we stick to that.
v2: replace "1 * SZ_1M" with SZ_1M (Andrzej).
Cc: Matthew Auld <matthew.auld@intel.com>
Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index 90a967374b1a..d8e06e783e30 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
@@ -909,7 +909,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type,
dsm_base = intel_uncore_read64(uncore, GEN12_DSMBASE) & GEN12_BDSM_MASK;
if (WARN_ON(lmem_size < dsm_base))
return ERR_PTR(-ENODEV);
- dsm_size = lmem_size - dsm_base;
+ dsm_size = ALIGN_DOWN(lmem_size - dsm_base, SZ_1M);
}
io_size = dsm_size;
--
2.39.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Make sure dsm_size has correct granularity
@ 2023-02-02 18:02 ` Nirmoy Das
0 siblings, 0 replies; 9+ messages in thread
From: Nirmoy Das @ 2023-02-02 18:02 UTC (permalink / raw)
To: intel-gfx
Cc: Andrzej Hajda, Lucas De Marchi, Matthew Auld, dri-devel, Nirmoy Das
DSM granularity is 1MB so make sure we stick to that.
v2: replace "1 * SZ_1M" with SZ_1M (Andrzej).
Cc: Matthew Auld <matthew.auld@intel.com>
Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index 90a967374b1a..d8e06e783e30 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
@@ -909,7 +909,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type,
dsm_base = intel_uncore_read64(uncore, GEN12_DSMBASE) & GEN12_BDSM_MASK;
if (WARN_ON(lmem_size < dsm_base))
return ERR_PTR(-ENODEV);
- dsm_size = lmem_size - dsm_base;
+ dsm_size = ALIGN_DOWN(lmem_size - dsm_base, SZ_1M);
}
io_size = dsm_size;
--
2.39.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make sure dsm_size has correct granularity (rev2)
2023-02-02 18:02 ` [Intel-gfx] " Nirmoy Das
(?)
@ 2023-02-02 19:01 ` Patchwork
-1 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-02-02 19:01 UTC (permalink / raw)
To: Nirmoy Das; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3732 bytes --]
== Series Details ==
Series: drm/i915: Make sure dsm_size has correct granularity (rev2)
URL : https://patchwork.freedesktop.org/series/113282/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12684 -> Patchwork_113282v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/index.html
Participating hosts (27 -> 25)
------------------------------
Missing (2): fi-kbl-soraka fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_113282v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-dg1-6: NOTRUN -> [SKIP][1] ([i915#7828])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/bat-dg1-6/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-n3050: [PASS][2] -> [FAIL][3] ([i915#6298])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_lrc:
- bat-dg1-6: [ABORT][4] ([i915#4983]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/bat-dg1-6/igt@i915_selftest@live@gt_lrc.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/bat-dg1-6/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_pm:
- {bat-rpls-2}: [DMESG-FAIL][6] ([i915#4258]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [ABORT][8] ([i915#4983]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/bat-rpls-2/igt@i915_selftest@live@reset.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/bat-rpls-2/igt@i915_selftest@live@reset.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
Build changes
-------------
* Linux: CI_DRM_12684 -> Patchwork_113282v2
CI-20190529: 20190529
CI_DRM_12684: 57eb8680d3ef1213de1d9c607b95e522035036e6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7144: cda71bf809b981a646270963d6b1ccee4fd4643b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113282v2: 57eb8680d3ef1213de1d9c607b95e522035036e6 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
8daa9156f25b drm/i915: Make sure dsm_size has correct granularity
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/index.html
[-- Attachment #2: Type: text/html, Size: 4263 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Make sure dsm_size has correct granularity (rev2)
2023-02-02 18:02 ` [Intel-gfx] " Nirmoy Das
(?)
(?)
@ 2023-02-03 0:38 ` Patchwork
-1 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-02-03 0:38 UTC (permalink / raw)
To: Nirmoy Das; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 21449 bytes --]
== Series Details ==
Series: drm/i915: Make sure dsm_size has correct granularity (rev2)
URL : https://patchwork.freedesktop.org/series/113282/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12684_full -> Patchwork_113282v2_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/index.html
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_113282v2_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- {shard-tglu}: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-tglu-2/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-tglu-6/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- {shard-rkl}: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-4/igt@gem_ctx_isolation@preservation-s3@vcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-3/igt@gem_ctx_isolation@preservation-s3@vcs0.html
Known issues
------------
Here are the changes found in Patchwork_113282v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2846])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-glk1/igt@gem_exec_fair@basic-deadline.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-glk7/igt@gem_exec_fair@basic-deadline.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2346])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#79])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-glk5/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-glk7/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1.html
#### Possible fixes ####
* igt@fbdev@pan:
- {shard-rkl}: [SKIP][11] ([i915#2582]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-4/igt@fbdev@pan.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-6/igt@fbdev@pan.html
* igt@gem_ctx_persistence@many-contexts:
- {shard-rkl}: [INCOMPLETE][13] -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-3/igt@gem_ctx_persistence@many-contexts.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-5/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_eio@suspend:
- {shard-rkl}: [FAIL][15] ([i915#5115] / [i915#7052]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-3/igt@gem_eio@suspend.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-6/igt@gem_eio@suspend.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][17] ([i915#2842]) -> [PASS][18] +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-3/igt@gem_exec_fair@basic-pace@rcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-5/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_reloc@basic-gtt-read-noreloc:
- {shard-rkl}: [SKIP][19] ([i915#3281]) -> [PASS][20] +14 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-4/igt@gem_exec_reloc@basic-gtt-read-noreloc.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-read-noreloc.html
* igt@gem_exec_schedule@wide@rcs0:
- shard-glk: [FAIL][21] ([i915#6659]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-glk6/igt@gem_exec_schedule@wide@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-glk8/igt@gem_exec_schedule@wide@rcs0.html
* igt@gem_mmap_gtt@coherency:
- {shard-rkl}: [SKIP][23] ([fdo#111656]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-4/igt@gem_mmap_gtt@coherency.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-5/igt@gem_mmap_gtt@coherency.html
* igt@gem_partial_pwrite_pread@write:
- {shard-rkl}: [SKIP][25] ([i915#3282]) -> [PASS][26] +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-4/igt@gem_partial_pwrite_pread@write.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-5/igt@gem_partial_pwrite_pread@write.html
* igt@gen9_exec_parse@unaligned-access:
- {shard-rkl}: [SKIP][27] ([i915#2527]) -> [PASS][28] +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-2/igt@gen9_exec_parse@unaligned-access.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-5/igt@gen9_exec_parse@unaligned-access.html
* igt@i915_hangman@engine-engine-error@bcs0:
- {shard-rkl}: [SKIP][29] ([i915#6258]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-5/igt@i915_hangman@engine-engine-error@bcs0.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-2/igt@i915_hangman@engine-engine-error@bcs0.html
* igt@i915_pm_rpm@dpms-lpsp:
- {shard-rkl}: [SKIP][31] ([i915#1397]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-3/igt@i915_pm_rpm@dpms-lpsp.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-6/igt@i915_pm_rpm@dpms-lpsp.html
* igt@i915_pm_rpm@system-suspend-modeset:
- {shard-rkl}: [SKIP][33] ([fdo#109308]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-4/igt@i915_pm_rpm@system-suspend-modeset.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-6/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@i915_suspend@debugfs-reader:
- {shard-rkl}: [FAIL][35] ([fdo#103375]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-3/igt@i915_suspend@debugfs-reader.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-6/igt@i915_suspend@debugfs-reader.html
* igt@kms_atomic@atomic_plane_damage:
- {shard-rkl}: [SKIP][37] ([i915#4098]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-3/igt@kms_atomic@atomic_plane_damage.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-6/igt@kms_atomic@atomic_plane_damage.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- {shard-rkl}: [SKIP][39] ([i915#1845] / [i915#4098]) -> [PASS][40] +27 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-3/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_frontbuffer_tracking@fbc-tiling-linear:
- {shard-rkl}: [SKIP][41] ([i915#1849] / [i915#4098]) -> [PASS][42] +19 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-3/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
* igt@kms_plane@plane-panning-top-left@pipe-a-planes:
- {shard-rkl}: [SKIP][43] ([i915#1849]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-3/igt@kms_plane@plane-panning-top-left@pipe-a-planes.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-6/igt@kms_plane@plane-panning-top-left@pipe-a-planes.html
* igt@kms_psr@sprite_plane_onoff:
- {shard-rkl}: [SKIP][45] ([i915#1072]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-4/igt@kms_psr@sprite_plane_onoff.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-6/igt@kms_psr@sprite_plane_onoff.html
* igt@perf_pmu@idle@rcs0:
- {shard-rkl}: [FAIL][47] ([i915#4349]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-6/igt@perf_pmu@idle@rcs0.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-3/igt@perf_pmu@idle@rcs0.html
* igt@prime_vgem@basic-read:
- {shard-rkl}: [SKIP][49] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-3/igt@prime_vgem@basic-read.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-5/igt@prime_vgem@basic-read.html
* igt@sysfs_timeslice_duration@timeout@rcs0:
- {shard-rkl}: [FAIL][51] ([i915#1755]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12684/shard-rkl-3/igt@sysfs_timeslice_duration@timeout@rcs0.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/shard-rkl-5/igt@sysfs_timeslice_duration@timeout@rcs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5115]: https://gitlab.freedesktop.org/drm/intel/issues/5115
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6659]: https://gitlab.freedesktop.org/drm/intel/issues/6659
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
Build changes
-------------
* Linux: CI_DRM_12684 -> Patchwork_113282v2
CI-20190529: 20190529
CI_DRM_12684: 57eb8680d3ef1213de1d9c607b95e522035036e6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7144: cda71bf809b981a646270963d6b1ccee4fd4643b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113282v2: 57eb8680d3ef1213de1d9c607b95e522035036e6 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v2/index.html
[-- Attachment #2: Type: text/html, Size: 14079 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Make sure dsm_size has correct granularity
2023-02-02 18:02 ` [Intel-gfx] " Nirmoy Das
@ 2023-02-03 18:56 ` Lucas De Marchi
-1 siblings, 0 replies; 9+ messages in thread
From: Lucas De Marchi @ 2023-02-03 18:56 UTC (permalink / raw)
To: Nirmoy Das; +Cc: dri-devel, intel-gfx, Matthew Auld, Andrzej Hajda
On Thu, Feb 02, 2023 at 07:02:43PM +0100, Nirmoy Das wrote:
>DSM granularity is 1MB so make sure we stick to that.
I think we need to be a bit more verbose here, because in future we may
need to refer to this commit if/when things change (e.g. the granularity
or the additional size needed on top of DSM).
The issue this is fixing is that the address set by firmware in GEN12_DSMBASE
and read here doesn't mean "anything above it until the of lmem is part of DSM".
There may be a few KB that is not part of DSM. How large is that space
is platform-dependent, but since it's always less than the DSM
granularity, it can be simplified by simply aligning the size like
is done here.
>
>v2: replace "1 * SZ_1M" with SZ_1M (Andrzej).
>
>Cc: Matthew Auld <matthew.auld@intel.com>
>Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
>Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
>Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Are you ok with me amending the commit message and applying?
After this patch I think you can follow the process to request committer
access.
Lucas De Marchi
>---
> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>index 90a967374b1a..d8e06e783e30 100644
>--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>@@ -909,7 +909,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type,
> dsm_base = intel_uncore_read64(uncore, GEN12_DSMBASE) & GEN12_BDSM_MASK;
> if (WARN_ON(lmem_size < dsm_base))
> return ERR_PTR(-ENODEV);
>- dsm_size = lmem_size - dsm_base;
>+ dsm_size = ALIGN_DOWN(lmem_size - dsm_base, SZ_1M);
> }
>
> io_size = dsm_size;
>--
>2.39.0
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Make sure dsm_size has correct granularity
@ 2023-02-03 18:56 ` Lucas De Marchi
0 siblings, 0 replies; 9+ messages in thread
From: Lucas De Marchi @ 2023-02-03 18:56 UTC (permalink / raw)
To: Nirmoy Das; +Cc: dri-devel, intel-gfx, Matthew Auld, Andrzej Hajda
On Thu, Feb 02, 2023 at 07:02:43PM +0100, Nirmoy Das wrote:
>DSM granularity is 1MB so make sure we stick to that.
I think we need to be a bit more verbose here, because in future we may
need to refer to this commit if/when things change (e.g. the granularity
or the additional size needed on top of DSM).
The issue this is fixing is that the address set by firmware in GEN12_DSMBASE
and read here doesn't mean "anything above it until the of lmem is part of DSM".
There may be a few KB that is not part of DSM. How large is that space
is platform-dependent, but since it's always less than the DSM
granularity, it can be simplified by simply aligning the size like
is done here.
>
>v2: replace "1 * SZ_1M" with SZ_1M (Andrzej).
>
>Cc: Matthew Auld <matthew.auld@intel.com>
>Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
>Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
>Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Are you ok with me amending the commit message and applying?
After this patch I think you can follow the process to request committer
access.
Lucas De Marchi
>---
> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>index 90a967374b1a..d8e06e783e30 100644
>--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>@@ -909,7 +909,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type,
> dsm_base = intel_uncore_read64(uncore, GEN12_DSMBASE) & GEN12_BDSM_MASK;
> if (WARN_ON(lmem_size < dsm_base))
> return ERR_PTR(-ENODEV);
>- dsm_size = lmem_size - dsm_base;
>+ dsm_size = ALIGN_DOWN(lmem_size - dsm_base, SZ_1M);
> }
>
> io_size = dsm_size;
>--
>2.39.0
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Make sure dsm_size has correct granularity
2023-02-03 18:56 ` [Intel-gfx] " Lucas De Marchi
@ 2023-02-03 19:00 ` Das, Nirmoy
-1 siblings, 0 replies; 9+ messages in thread
From: Das, Nirmoy @ 2023-02-03 19:00 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: dri-devel, intel-gfx, Matthew Auld, Andrzej Hajda
Hi Lucas,
On 2/3/2023 7:56 PM, Lucas De Marchi wrote:
> On Thu, Feb 02, 2023 at 07:02:43PM +0100, Nirmoy Das wrote:
>> DSM granularity is 1MB so make sure we stick to that.
>
> I think we need to be a bit more verbose here, because in future we may
> need to refer to this commit if/when things change (e.g. the granularity
> or the additional size needed on top of DSM).
>
> The issue this is fixing is that the address set by firmware in
> GEN12_DSMBASE
> and read here doesn't mean "anything above it until the of lmem is
> part of DSM".
> There may be a few KB that is not part of DSM. How large is that space
> is platform-dependent, but since it's always less than the DSM
> granularity, it can be simplified by simply aligning the size like
> is done here.
>
>>
>> v2: replace "1 * SZ_1M" with SZ_1M (Andrzej).
>>
>> Cc: Matthew Auld <matthew.auld@intel.com>
>> Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
>> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
>
>
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> Are you ok with me amending the commit message and applying?
Yes, I fine that, thanks for doing that. I agree this is very short
description that I have wrote.
>
> After this patch I think you can follow the process to request committer
> access.
Looking for to doing that :)
Nirmoy
>
> Lucas De Marchi
>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>> b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>> index 90a967374b1a..d8e06e783e30 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>> @@ -909,7 +909,7 @@ i915_gem_stolen_lmem_setup(struct
>> drm_i915_private *i915, u16 type,
>> dsm_base = intel_uncore_read64(uncore, GEN12_DSMBASE) &
>> GEN12_BDSM_MASK;
>> if (WARN_ON(lmem_size < dsm_base))
>> return ERR_PTR(-ENODEV);
>> - dsm_size = lmem_size - dsm_base;
>> + dsm_size = ALIGN_DOWN(lmem_size - dsm_base, SZ_1M);
>> }
>>
>> io_size = dsm_size;
>> --
>> 2.39.0
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Make sure dsm_size has correct granularity
@ 2023-02-03 19:00 ` Das, Nirmoy
0 siblings, 0 replies; 9+ messages in thread
From: Das, Nirmoy @ 2023-02-03 19:00 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: dri-devel, intel-gfx, Matthew Auld, Andrzej Hajda
Hi Lucas,
On 2/3/2023 7:56 PM, Lucas De Marchi wrote:
> On Thu, Feb 02, 2023 at 07:02:43PM +0100, Nirmoy Das wrote:
>> DSM granularity is 1MB so make sure we stick to that.
>
> I think we need to be a bit more verbose here, because in future we may
> need to refer to this commit if/when things change (e.g. the granularity
> or the additional size needed on top of DSM).
>
> The issue this is fixing is that the address set by firmware in
> GEN12_DSMBASE
> and read here doesn't mean "anything above it until the of lmem is
> part of DSM".
> There may be a few KB that is not part of DSM. How large is that space
> is platform-dependent, but since it's always less than the DSM
> granularity, it can be simplified by simply aligning the size like
> is done here.
>
>>
>> v2: replace "1 * SZ_1M" with SZ_1M (Andrzej).
>>
>> Cc: Matthew Auld <matthew.auld@intel.com>
>> Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
>> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
>
>
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> Are you ok with me amending the commit message and applying?
Yes, I fine that, thanks for doing that. I agree this is very short
description that I have wrote.
>
> After this patch I think you can follow the process to request committer
> access.
Looking for to doing that :)
Nirmoy
>
> Lucas De Marchi
>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>> b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>> index 90a967374b1a..d8e06e783e30 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>> @@ -909,7 +909,7 @@ i915_gem_stolen_lmem_setup(struct
>> drm_i915_private *i915, u16 type,
>> dsm_base = intel_uncore_read64(uncore, GEN12_DSMBASE) &
>> GEN12_BDSM_MASK;
>> if (WARN_ON(lmem_size < dsm_base))
>> return ERR_PTR(-ENODEV);
>> - dsm_size = lmem_size - dsm_base;
>> + dsm_size = ALIGN_DOWN(lmem_size - dsm_base, SZ_1M);
>> }
>>
>> io_size = dsm_size;
>> --
>> 2.39.0
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] drm/i915: Make sure dsm_size has correct granularity
@ 2023-01-24 15:00 Nirmoy Das
0 siblings, 0 replies; 9+ messages in thread
From: Nirmoy Das @ 2023-01-24 15:00 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi, Matthew Auld, dri-devel, Nirmoy Das
DSM granularity is 1MB so make sure we stick to that.
Cc: Matthew Auld <matthew.auld@intel.com>
Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index 90a967374b1a..0c027263f09e 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
@@ -909,7 +909,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type,
dsm_base = intel_uncore_read64(uncore, GEN12_DSMBASE) & GEN12_BDSM_MASK;
if (WARN_ON(lmem_size < dsm_base))
return ERR_PTR(-ENODEV);
- dsm_size = lmem_size - dsm_base;
+ dsm_size = ALIGN_DOWN(lmem_size - dsm_base, 1 * SZ_1M);
}
io_size = dsm_size;
--
2.39.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-02-03 19:01 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-02 18:02 [PATCH] drm/i915: Make sure dsm_size has correct granularity Nirmoy Das
2023-02-02 18:02 ` [Intel-gfx] " Nirmoy Das
2023-02-02 19:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make sure dsm_size has correct granularity (rev2) Patchwork
2023-02-03 0:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-02-03 18:56 ` [PATCH] drm/i915: Make sure dsm_size has correct granularity Lucas De Marchi
2023-02-03 18:56 ` [Intel-gfx] " Lucas De Marchi
2023-02-03 19:00 ` Das, Nirmoy
2023-02-03 19:00 ` [Intel-gfx] " Das, Nirmoy
-- strict thread matches above, loose matches on Subject: below --
2023-01-24 15:00 Nirmoy Das
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.