* [merged mm-nonmm-stable] kthread_worker-check-all-delayed-works-when-destroy-kthread-worker.patch removed from -mm tree
@ 2023-02-03 6:50 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2023-02-03 6:50 UTC (permalink / raw)
To: mm-commits, tj, pmladek, qiang1.zhang, akpm
The quilt patch titled
Subject: kthread_worker: check all delayed works when destroy kthread worker
has been removed from the -mm tree. Its filename was
kthread_worker-check-all-delayed-works-when-destroy-kthread-worker.patch
This patch was dropped because it was merged into the mm-nonmm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Zqiang <qiang1.zhang@intel.com>
Subject: kthread_worker: check all delayed works when destroy kthread worker
Date: Wed, 4 Jan 2023 22:42:30 +0800
When destroying a kthread worker warn if there are still some pending
delayed works. This indicates that the caller should clear all pending
delayed works before destroying the kthread worker.
Link: https://lkml.kernel.org/r/20230104144230.938521-1-qiang1.zhang@intel.com
Signed-off-by: Zqiang <qiang1.zhang@intel.com>
Acked-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
--- a/kernel/kthread.c~kthread_worker-check-all-delayed-works-when-destroy-kthread-worker
+++ a/kernel/kthread.c
@@ -1382,6 +1382,10 @@ EXPORT_SYMBOL_GPL(kthread_flush_worker);
* Flush and destroy @worker. The simple flush is enough because the kthread
* worker API is used only in trivial scenarios. There are no multi-step state
* machines needed.
+ *
+ * Note that this function is not responsible for handling delayed work, so
+ * caller should be responsible for queuing or canceling all delayed work items
+ * before invoke this function.
*/
void kthread_destroy_worker(struct kthread_worker *worker)
{
@@ -1393,6 +1397,7 @@ void kthread_destroy_worker(struct kthre
kthread_flush_worker(worker);
kthread_stop(task);
+ WARN_ON(!list_empty(&worker->delayed_work_list));
WARN_ON(!list_empty(&worker->work_list));
kfree(worker);
}
_
Patches currently in -mm which might be from qiang1.zhang@intel.com are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-03 6:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-03 6:50 [merged mm-nonmm-stable] kthread_worker-check-all-delayed-works-when-destroy-kthread-worker.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.