* [PATCH v2] drm/i915: Initialize the obj flags for shmem objects
@ 2023-02-03 13:52 ` Aravind Iddamsetty
0 siblings, 0 replies; 12+ messages in thread
From: Aravind Iddamsetty @ 2023-02-03 13:52 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel, stable, Matthew Auld, Tvrtko Ursulin
Obj flags for shmem objects is not being set correctly. Fixes in setting
BO_ALLOC_USER flag which applies to shmem objs as well.
Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally flush the pages on acquire")
Cc: <stable@vger.kernel.org> # v5.15+
v2: Add fixes tag (Tvrtko, Matt A)
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
index 114443096841..37d1efcd3ca6 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
@@ -596,7 +596,7 @@ static int shmem_object_init(struct intel_memory_region *mem,
mapping_set_gfp_mask(mapping, mask);
GEM_BUG_ON(!(mapping_gfp_mask(mapping) & __GFP_RECLAIM));
- i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, 0);
+ i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, flags);
obj->mem_flags |= I915_BO_FLAG_STRUCT_PAGE;
obj->write_domain = I915_GEM_DOMAIN_CPU;
obj->read_domains = I915_GEM_DOMAIN_CPU;
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v2] drm/i915: Initialize the obj flags for shmem objects
@ 2023-02-03 13:52 ` Aravind Iddamsetty
0 siblings, 0 replies; 12+ messages in thread
From: Aravind Iddamsetty @ 2023-02-03 13:52 UTC (permalink / raw)
To: intel-gfx; +Cc: Tvrtko Ursulin, stable, dri-devel, Matthew Auld
Obj flags for shmem objects is not being set correctly. Fixes in setting
BO_ALLOC_USER flag which applies to shmem objs as well.
Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally flush the pages on acquire")
Cc: <stable@vger.kernel.org> # v5.15+
v2: Add fixes tag (Tvrtko, Matt A)
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
index 114443096841..37d1efcd3ca6 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
@@ -596,7 +596,7 @@ static int shmem_object_init(struct intel_memory_region *mem,
mapping_set_gfp_mask(mapping, mask);
GEM_BUG_ON(!(mapping_gfp_mask(mapping) & __GFP_RECLAIM));
- i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, 0);
+ i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, flags);
obj->mem_flags |= I915_BO_FLAG_STRUCT_PAGE;
obj->write_domain = I915_GEM_DOMAIN_CPU;
obj->read_domains = I915_GEM_DOMAIN_CPU;
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915: Initialize the obj flags for shmem objects
@ 2023-02-03 13:52 ` Aravind Iddamsetty
0 siblings, 0 replies; 12+ messages in thread
From: Aravind Iddamsetty @ 2023-02-03 13:52 UTC (permalink / raw)
To: intel-gfx; +Cc: stable, dri-devel, Matthew Auld
Obj flags for shmem objects is not being set correctly. Fixes in setting
BO_ALLOC_USER flag which applies to shmem objs as well.
Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally flush the pages on acquire")
Cc: <stable@vger.kernel.org> # v5.15+
v2: Add fixes tag (Tvrtko, Matt A)
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
index 114443096841..37d1efcd3ca6 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
@@ -596,7 +596,7 @@ static int shmem_object_init(struct intel_memory_region *mem,
mapping_set_gfp_mask(mapping, mask);
GEM_BUG_ON(!(mapping_gfp_mask(mapping) & __GFP_RECLAIM));
- i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, 0);
+ i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, flags);
obj->mem_flags |= I915_BO_FLAG_STRUCT_PAGE;
obj->write_domain = I915_GEM_DOMAIN_CPU;
obj->read_domains = I915_GEM_DOMAIN_CPU;
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Initialize the obj flags for shmem objects
2023-02-03 13:52 ` Aravind Iddamsetty
@ 2023-02-03 14:31 ` Andrzej Hajda
-1 siblings, 0 replies; 12+ messages in thread
From: Andrzej Hajda @ 2023-02-03 14:31 UTC (permalink / raw)
To: Aravind Iddamsetty, intel-gfx; +Cc: stable, dri-devel, Matthew Auld
On 03.02.2023 14:52, Aravind Iddamsetty wrote:
> Obj flags for shmem objects is not being set correctly. Fixes in setting
> BO_ALLOC_USER flag which applies to shmem objs as well.
>
> Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally flush the pages on acquire")
> Cc: <stable@vger.kernel.org> # v5.15+
>
> v2: Add fixes tag (Tvrtko, Matt A)
>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> index 114443096841..37d1efcd3ca6 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> @@ -596,7 +596,7 @@ static int shmem_object_init(struct intel_memory_region *mem,
> mapping_set_gfp_mask(mapping, mask);
> GEM_BUG_ON(!(mapping_gfp_mask(mapping) & __GFP_RECLAIM));
>
> - i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, 0);
> + i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, flags);
> obj->mem_flags |= I915_BO_FLAG_STRUCT_PAGE;
> obj->write_domain = I915_GEM_DOMAIN_CPU;
> obj->read_domains = I915_GEM_DOMAIN_CPU;
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Initialize the obj flags for shmem objects
@ 2023-02-03 14:31 ` Andrzej Hajda
0 siblings, 0 replies; 12+ messages in thread
From: Andrzej Hajda @ 2023-02-03 14:31 UTC (permalink / raw)
To: Aravind Iddamsetty, intel-gfx; +Cc: dri-devel, stable, Matthew Auld
On 03.02.2023 14:52, Aravind Iddamsetty wrote:
> Obj flags for shmem objects is not being set correctly. Fixes in setting
> BO_ALLOC_USER flag which applies to shmem objs as well.
>
> Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally flush the pages on acquire")
> Cc: <stable@vger.kernel.org> # v5.15+
>
> v2: Add fixes tag (Tvrtko, Matt A)
>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> index 114443096841..37d1efcd3ca6 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> @@ -596,7 +596,7 @@ static int shmem_object_init(struct intel_memory_region *mem,
> mapping_set_gfp_mask(mapping, mask);
> GEM_BUG_ON(!(mapping_gfp_mask(mapping) & __GFP_RECLAIM));
>
> - i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, 0);
> + i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, flags);
> obj->mem_flags |= I915_BO_FLAG_STRUCT_PAGE;
> obj->write_domain = I915_GEM_DOMAIN_CPU;
> obj->read_domains = I915_GEM_DOMAIN_CPU;
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Initialize the obj flags for shmem objects
2023-02-03 13:52 ` Aravind Iddamsetty
` (2 preceding siblings ...)
(?)
@ 2023-02-03 17:05 ` Patchwork
-1 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-02-03 17:05 UTC (permalink / raw)
To: Aravind Iddamsetty; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Initialize the obj flags for shmem objects
URL : https://patchwork.freedesktop.org/series/113650/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Initialize the obj flags for shmem objects
2023-02-03 13:52 ` Aravind Iddamsetty
` (3 preceding siblings ...)
(?)
@ 2023-02-03 17:18 ` Patchwork
-1 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-02-03 17:18 UTC (permalink / raw)
To: Aravind Iddamsetty; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 2810 bytes --]
== Series Details ==
Series: drm/i915: Initialize the obj flags for shmem objects
URL : https://patchwork.freedesktop.org/series/113650/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12691 -> Patchwork_113650v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/index.html
Participating hosts (28 -> 25)
------------------------------
Missing (3): fi-kbl-soraka bat-atsm-1 fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_113650v1 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][1] ([i915#5334]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@migrate:
- {bat-adlp-9}: [DMESG-FAIL][3] ([i915#7699]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/bat-adlp-9/igt@i915_selftest@live@migrate.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/bat-adlp-9/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@slpc:
- {bat-rpls-1}: [DMESG-FAIL][5] ([i915#6367]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/bat-rpls-1/igt@i915_selftest@live@slpc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/bat-rpls-1/igt@i915_selftest@live@slpc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6311]: https://gitlab.freedesktop.org/drm/intel/issues/6311
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
Build changes
-------------
* Linux: CI_DRM_12691 -> Patchwork_113650v1
CI-20190529: 20190529
CI_DRM_12691: 2153bc2944d37403c6d5c4e1082d074a34d39ae9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7148: ee8e31cf39c44d3fdbd04d8db239f8a815f86121 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113650v1: 2153bc2944d37403c6d5c4e1082d074a34d39ae9 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
75a486f57d30 drm/i915: Initialize the obj flags for shmem objects
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/index.html
[-- Attachment #2: Type: text/html, Size: 3346 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Initialize the obj flags for shmem objects
2023-02-03 13:52 ` Aravind Iddamsetty
` (4 preceding siblings ...)
(?)
@ 2023-02-04 23:54 ` Patchwork
-1 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-02-04 23:54 UTC (permalink / raw)
To: Aravind Iddamsetty; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 20081 bytes --]
== Series Details ==
Series: drm/i915: Initialize the obj flags for shmem objects
URL : https://patchwork.freedesktop.org/series/113650/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12691_full -> Patchwork_113650v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/index.html
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_113650v1_full:
### CI changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* boot:
- {shard-tglu}: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9]) -> ([PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [FAIL][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-tglu-1/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-tglu-1/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-tglu-1/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-tglu-6/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-tglu-6/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-tglu-6/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-tglu-7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-tglu-7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-tglu-7/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-tglu-1/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-tglu-1/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-tglu-1/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-tglu-6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-tglu-6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-tglu-6/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-tglu-6/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-tglu-7/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-tglu-7/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-tglu-7/boot.html
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_softpin@noreloc-s3:
- {shard-tglu}: NOTRUN -> [ABORT][20]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-tglu-1/igt@gem_softpin@noreloc-s3.html
Known issues
------------
Here are the changes found in Patchwork_113650v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#2842])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-glk5/igt@gem_exec_fair@basic-none@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-glk2/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gen9_exec_parse@allowed-all:
- shard-glk: [PASS][23] -> [ABORT][24] ([i915#5566]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-glk7/igt@gen9_exec_parse@allowed-all.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-glk4/igt@gen9_exec_parse@allowed-all.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][25] ([i915#6268]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-rkl-3/igt@gem_ctx_exec@basic-nohangcheck.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-rkl-5/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_ctx_persistence@hang:
- {shard-rkl}: [SKIP][27] ([i915#6252]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-rkl-5/igt@gem_ctx_persistence@hang.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-rkl-6/igt@gem_ctx_persistence@hang.html
* igt@gem_exec_endless@dispatch@bcs0:
- {shard-rkl}: [SKIP][29] ([i915#6247]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-rkl-5/igt@gem_exec_endless@dispatch@bcs0.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-rkl-6/igt@gem_exec_endless@dispatch@bcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [FAIL][31] ([i915#2842]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-glk9/igt@gem_exec_fair@basic-throttle@rcs0.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_reloc@basic-gtt-read:
- {shard-rkl}: [SKIP][33] ([i915#3281]) -> [PASS][34] +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-rkl-1/igt@gem_exec_reloc@basic-gtt-read.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-read.html
* igt@gem_exec_schedule@semaphore-power:
- {shard-rkl}: [SKIP][35] ([i915#7276]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-rkl-3/igt@gem_exec_schedule@semaphore-power.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-rkl-5/igt@gem_exec_schedule@semaphore-power.html
* igt@gem_pwrite@basic-self:
- {shard-rkl}: [SKIP][37] ([i915#3282]) -> [PASS][38] +5 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-rkl-1/igt@gem_pwrite@basic-self.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-rkl-5/igt@gem_pwrite@basic-self.html
* igt@gen9_exec_parse@shadow-peek:
- {shard-rkl}: [SKIP][39] ([i915#2527]) -> [PASS][40] +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-rkl-3/igt@gen9_exec_parse@shadow-peek.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-rkl-5/igt@gen9_exec_parse@shadow-peek.html
* igt@i915_pm_dc@dc9-dpms:
- {shard-rkl}: [SKIP][41] ([i915#3361]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-rkl-5/igt@i915_pm_dc@dc9-dpms.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-rkl-6/igt@i915_pm_dc@dc9-dpms.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- {shard-rkl}: [SKIP][43] ([i915#1845] / [i915#4098]) -> [PASS][44] +16 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-rkl-5/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-rkl-6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2:
- shard-glk: [FAIL][45] ([i915#79]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-glk7/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-glk4/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html
* igt@kms_frontbuffer_tracking@fbc-modesetfrombusy:
- shard-glk: [FAIL][47] -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-glk6/igt@kms_frontbuffer_tracking@fbc-modesetfrombusy.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-glk3/igt@kms_frontbuffer_tracking@fbc-modesetfrombusy.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-pwrite:
- {shard-rkl}: [SKIP][49] ([i915#1849] / [i915#4098]) -> [PASS][50] +8 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-rkl-1/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-pwrite.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_plane@plane-panning-bottom-right@pipe-a-planes:
- {shard-rkl}: [SKIP][51] ([i915#1849]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-rkl-5/igt@kms_plane@plane-panning-bottom-right@pipe-a-planes.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-rkl-6/igt@kms_plane@plane-panning-bottom-right@pipe-a-planes.html
* igt@kms_psr@cursor_render:
- {shard-rkl}: [SKIP][53] ([i915#1072]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-rkl-5/igt@kms_psr@cursor_render.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-rkl-6/igt@kms_psr@cursor_render.html
* igt@perf@polling-small-buf:
- {shard-rkl}: [FAIL][55] ([i915#1722]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-rkl-3/igt@perf@polling-small-buf.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-rkl-5/igt@perf@polling-small-buf.html
* igt@prime_vgem@basic-fence-read:
- {shard-rkl}: [SKIP][57] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/shard-rkl-1/igt@prime_vgem@basic-fence-read.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/shard-rkl-5/igt@prime_vgem@basic-fence-read.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12691 -> Patchwork_113650v1
CI-20190529: 20190529
CI_DRM_12691: 2153bc2944d37403c6d5c4e1082d074a34d39ae9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7148: ee8e31cf39c44d3fdbd04d8db239f8a815f86121 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113650v1: 2153bc2944d37403c6d5c4e1082d074a34d39ae9 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113650v1/index.html
[-- Attachment #2: Type: text/html, Size: 13642 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Initialize the obj flags for shmem objects
2023-02-03 13:52 ` Aravind Iddamsetty
@ 2023-02-06 9:51 ` Tvrtko Ursulin
-1 siblings, 0 replies; 12+ messages in thread
From: Tvrtko Ursulin @ 2023-02-06 9:51 UTC (permalink / raw)
To: Aravind Iddamsetty, intel-gfx; +Cc: stable, dri-devel, Matthew Auld
On 03/02/2023 13:52, Aravind Iddamsetty wrote:
> Obj flags for shmem objects is not being set correctly. Fixes in setting
> BO_ALLOC_USER flag which applies to shmem objs as well.
>
> Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally flush the pages on acquire")
> Cc: <stable@vger.kernel.org> # v5.15+
These tags should have been grouped with the ones below in one block.
I have tidied this while pushing, thanks for the fix and review!
Regards,
Tvrtko
> v2: Add fixes tag (Tvrtko, Matt A)
>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> index 114443096841..37d1efcd3ca6 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> @@ -596,7 +596,7 @@ static int shmem_object_init(struct intel_memory_region *mem,
> mapping_set_gfp_mask(mapping, mask);
> GEM_BUG_ON(!(mapping_gfp_mask(mapping) & __GFP_RECLAIM));
>
> - i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, 0);
> + i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, flags);
> obj->mem_flags |= I915_BO_FLAG_STRUCT_PAGE;
> obj->write_domain = I915_GEM_DOMAIN_CPU;
> obj->read_domains = I915_GEM_DOMAIN_CPU;
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Initialize the obj flags for shmem objects
@ 2023-02-06 9:51 ` Tvrtko Ursulin
0 siblings, 0 replies; 12+ messages in thread
From: Tvrtko Ursulin @ 2023-02-06 9:51 UTC (permalink / raw)
To: Aravind Iddamsetty, intel-gfx; +Cc: dri-devel, stable, Matthew Auld
On 03/02/2023 13:52, Aravind Iddamsetty wrote:
> Obj flags for shmem objects is not being set correctly. Fixes in setting
> BO_ALLOC_USER flag which applies to shmem objs as well.
>
> Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally flush the pages on acquire")
> Cc: <stable@vger.kernel.org> # v5.15+
These tags should have been grouped with the ones below in one block.
I have tidied this while pushing, thanks for the fix and review!
Regards,
Tvrtko
> v2: Add fixes tag (Tvrtko, Matt A)
>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> index 114443096841..37d1efcd3ca6 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> @@ -596,7 +596,7 @@ static int shmem_object_init(struct intel_memory_region *mem,
> mapping_set_gfp_mask(mapping, mask);
> GEM_BUG_ON(!(mapping_gfp_mask(mapping) & __GFP_RECLAIM));
>
> - i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, 0);
> + i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, flags);
> obj->mem_flags |= I915_BO_FLAG_STRUCT_PAGE;
> obj->write_domain = I915_GEM_DOMAIN_CPU;
> obj->read_domains = I915_GEM_DOMAIN_CPU;
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Initialize the obj flags for shmem objects
2023-02-06 9:51 ` Tvrtko Ursulin
@ 2023-02-06 11:36 ` Iddamsetty, Aravind
-1 siblings, 0 replies; 12+ messages in thread
From: Iddamsetty, Aravind @ 2023-02-06 11:36 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx; +Cc: dri-devel, stable, Matthew Auld
On 06-02-2023 15:21, Tvrtko Ursulin wrote:
>
>
> On 03/02/2023 13:52, Aravind Iddamsetty wrote:
>> Obj flags for shmem objects is not being set correctly. Fixes in setting
>> BO_ALLOC_USER flag which applies to shmem objs as well.
>>
>> Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally flush the pages on
>> acquire")
>> Cc: <stable@vger.kernel.org> # v5.15+
>
> These tags should have been grouped with the ones below in one block.
>
> I have tidied this while pushing, thanks for the fix and review!
Thanks Tvrtko.
Regards,
Aravind.
>
> Regards,
>
> Tvrtko
>
>> v2: Add fixes tag (Tvrtko, Matt A)
>>
>> Cc: Matthew Auld <matthew.auld@intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>> Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
>> b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
>> index 114443096841..37d1efcd3ca6 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
>> @@ -596,7 +596,7 @@ static int shmem_object_init(struct
>> intel_memory_region *mem,
>> mapping_set_gfp_mask(mapping, mask);
>> GEM_BUG_ON(!(mapping_gfp_mask(mapping) & __GFP_RECLAIM));
>> - i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, 0);
>> + i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, flags);
>> obj->mem_flags |= I915_BO_FLAG_STRUCT_PAGE;
>> obj->write_domain = I915_GEM_DOMAIN_CPU;
>> obj->read_domains = I915_GEM_DOMAIN_CPU;
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Initialize the obj flags for shmem objects
@ 2023-02-06 11:36 ` Iddamsetty, Aravind
0 siblings, 0 replies; 12+ messages in thread
From: Iddamsetty, Aravind @ 2023-02-06 11:36 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx; +Cc: stable, dri-devel, Matthew Auld
On 06-02-2023 15:21, Tvrtko Ursulin wrote:
>
>
> On 03/02/2023 13:52, Aravind Iddamsetty wrote:
>> Obj flags for shmem objects is not being set correctly. Fixes in setting
>> BO_ALLOC_USER flag which applies to shmem objs as well.
>>
>> Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally flush the pages on
>> acquire")
>> Cc: <stable@vger.kernel.org> # v5.15+
>
> These tags should have been grouped with the ones below in one block.
>
> I have tidied this while pushing, thanks for the fix and review!
Thanks Tvrtko.
Regards,
Aravind.
>
> Regards,
>
> Tvrtko
>
>> v2: Add fixes tag (Tvrtko, Matt A)
>>
>> Cc: Matthew Auld <matthew.auld@intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>> Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
>> b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
>> index 114443096841..37d1efcd3ca6 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
>> @@ -596,7 +596,7 @@ static int shmem_object_init(struct
>> intel_memory_region *mem,
>> mapping_set_gfp_mask(mapping, mask);
>> GEM_BUG_ON(!(mapping_gfp_mask(mapping) & __GFP_RECLAIM));
>> - i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, 0);
>> + i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, flags);
>> obj->mem_flags |= I915_BO_FLAG_STRUCT_PAGE;
>> obj->write_domain = I915_GEM_DOMAIN_CPU;
>> obj->read_domains = I915_GEM_DOMAIN_CPU;
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-02-06 11:36 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-03 13:52 [PATCH v2] drm/i915: Initialize the obj flags for shmem objects Aravind Iddamsetty
2023-02-03 13:52 ` [Intel-gfx] " Aravind Iddamsetty
2023-02-03 13:52 ` Aravind Iddamsetty
2023-02-03 14:31 ` [Intel-gfx] " Andrzej Hajda
2023-02-03 14:31 ` Andrzej Hajda
2023-02-03 17:05 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2023-02-03 17:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-02-04 23:54 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-02-06 9:51 ` [Intel-gfx] [PATCH v2] " Tvrtko Ursulin
2023-02-06 9:51 ` Tvrtko Ursulin
2023-02-06 11:36 ` Iddamsetty, Aravind
2023-02-06 11:36 ` Iddamsetty, Aravind
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.