* [PATCH] MIPS: Remove CONFIG_MIPS check in Makefile
@ 2023-02-02 9:05 Tiezhu Yang
2023-02-04 14:56 ` Alexander Lobakin
0 siblings, 1 reply; 2+ messages in thread
From: Tiezhu Yang @ 2023-02-02 9:05 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: linux-mips, linux-kernel
CONFIG_MIPS is set as y by default in Kconfig, no need to check
it in Makefile.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
arch/mips/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 490dea0..6ed41c8b 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -316,11 +316,9 @@ KBUILD_CFLAGS += -fno-asynchronous-unwind-tables
KBUILD_LDFLAGS += -m $(ld-emul)
-ifdef CONFIG_MIPS
CHECKFLAGS += $(shell $(CC) $(KBUILD_CFLAGS) -dM -E -x c /dev/null | \
grep -E -vw '__GNUC_(MINOR_|PATCHLEVEL_)?_' | \
sed -e "s/^\#define /-D'/" -e "s/ /'='/" -e "s/$$/'/" -e 's/\$$/&&/g')
-endif
OBJCOPYFLAGS += --remove-section=.reginfo
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: Remove CONFIG_MIPS check in Makefile
2023-02-02 9:05 [PATCH] MIPS: Remove CONFIG_MIPS check in Makefile Tiezhu Yang
@ 2023-02-04 14:56 ` Alexander Lobakin
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Lobakin @ 2023-02-04 14:56 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Alexander Lobakin, Thomas Bogendoerfer, linux-mips, linux-kernel
From: Tiezhu Yang <yangtiezhu@loongson.cn>
Date: Thu, 2 Feb 2023 17:05:02 +0800
> CONFIG_MIPS is set as y by default in Kconfig, no need to check
> it in Makefile.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> arch/mips/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 490dea0..6ed41c8b 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -316,11 +316,9 @@ KBUILD_CFLAGS += -fno-asynchronous-unwind-tables
>
> KBUILD_LDFLAGS += -m $(ld-emul)
>
> -ifdef CONFIG_MIPS
> CHECKFLAGS += $(shell $(CC) $(KBUILD_CFLAGS) -dM -E -x c /dev/null | \
> grep -E -vw '__GNUC_(MINOR_|PATCHLEVEL_)?_' | \
> sed -e "s/^\#define /-D'/" -e "s/ /'='/" -e "s/$$/'/" -e 's/\$$/&&/g')
> -endif
When you run `make clean/mrproper/distclean`, .config is not read. Thus,
this block may actually provoke errors when cleaning, that's why it's
guarded.
At least it was like that a couple years ago, can't say for sure if
these guards are needed, but better recheck.
>
> OBJCOPYFLAGS += --remove-section=.reginfo
>
> --
> 2.1.0
Thanks,
Olek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-04 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-02 9:05 [PATCH] MIPS: Remove CONFIG_MIPS check in Makefile Tiezhu Yang
2023-02-04 14:56 ` Alexander Lobakin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.