All of lore.kernel.org
 help / color / mirror / Atom feed
* [freescale-fslc:5.15-2.2.x-imx 6206/20209] drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1547:18: warning: variable 'len' set but not used
@ 2023-02-04 10:59 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-02-04 10:59 UTC (permalink / raw)
  To: Otavio Salvador; +Cc: oe-kbuild-all

tree:   https://github.com/Freescale/linux-fslc 5.15-2.2.x-imx
head:   3248ffcb12d15a0e40b9a020ba362591b8137923
commit: 6e93c0ab4bc6ae1ea6ea17c5a358da115ed5a441 [6206/20209] staging: media: imx8-mipi: remove obsolete modversions.h includes
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20230204/202302041850.BSVXxszE-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/Freescale/linux-fslc/commit/6e93c0ab4bc6ae1ea6ea17c5a358da115ed5a441
        git remote add freescale-fslc https://github.com/Freescale/linux-fslc
        git fetch --no-tags freescale-fslc 5.15-2.2.x-imx
        git checkout 6e93c0ab4bc6ae1ea6ea17c5a358da115ed5a441
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/accessibility/speakup/ drivers/firmware/imx/ drivers/gpu/drm/imx/ drivers/irqchip/ drivers/mfd/ drivers/soc/imx/ drivers/spi/ drivers/staging/media/imx/ sound/soc/sof/intel/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/staging/media/imx/imx8-mipi-csi2-sam.c: In function 'mipi_csis_imx8mn_parse_resets':
>> drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1547:18: warning: variable 'len' set but not used [-Wunused-but-set-variable]
    1547 |         uint32_t len, rstc_num = 0;
         |                  ^~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c: In function 'mipi_csis_probe':
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1815:29: warning: variable 'mipi_sd' set but not used [-Wunused-but-set-variable]
    1815 |         struct v4l2_subdev *mipi_sd;
         |                             ^~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c: In function 'csis_priv_ioctl':
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1349:17: warning: ignoring return value of 'copy_from_user' declared with attribute 'warn_unused_result' [-Wunused-result]
    1349 |                 copy_from_user(arg, arg_user, sizeof(TYPE));\
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1384:17: note: in expansion of macro 'USER_TO_KERNEL'
    1384 |                 USER_TO_KERNEL(struct csi_sam_format);
         |                 ^~~~~~~~~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1349:17: warning: ignoring return value of 'copy_from_user' declared with attribute 'warn_unused_result' [-Wunused-result]
    1349 |                 copy_from_user(arg, arg_user, sizeof(TYPE));\
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1389:17: note: in expansion of macro 'USER_TO_KERNEL'
    1389 |                 USER_TO_KERNEL(bool);
         |                 ^~~~~~~~~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c: At top level:
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1974:12: warning: 'mipi_csis_runtime_resume' defined but not used [-Wunused-function]
    1974 | static int mipi_csis_runtime_resume(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1960:12: warning: 'mipi_csis_runtime_suspend' defined but not used [-Wunused-function]
    1960 | static int mipi_csis_runtime_suspend(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1947:12: warning: 'mipi_csis_system_resume' defined but not used [-Wunused-function]
    1947 | static int mipi_csis_system_resume(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1942:12: warning: 'mipi_csis_system_suspend' defined but not used [-Wunused-function]
    1942 | static int mipi_csis_system_suspend(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c: In function 'csis_priv_ioctl':
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1390:23: warning: using dangling pointer 'arg' to 'tmp' [-Wdangling-pointer=]
    1390 |                 ret = csis_s_hdr(sd, *(bool *) arg);
         |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1347:22: note: 'tmp' declared here
    1347 |                 TYPE tmp; \
         |                      ^~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1389:17: note: in expansion of macro 'USER_TO_KERNEL'
    1389 |                 USER_TO_KERNEL(bool);
         |                 ^~~~~~~~~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1385:23: warning: using dangling pointer 'arg' to 'tmp' [-Wdangling-pointer=]
    1385 |                 ret = csis_s_fmt(sd, (struct csi_sam_format *)arg);
         |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1347:22: note: 'tmp' declared here
    1347 |                 TYPE tmp; \
         |                      ^~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1384:17: note: in expansion of macro 'USER_TO_KERNEL'
    1384 |                 USER_TO_KERNEL(struct csi_sam_format);
         |                 ^~~~~~~~~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1390:23: warning: using a dangling pointer to 'tmp' [-Wdangling-pointer=]
    1390 |                 ret = csis_s_hdr(sd, *(bool *) arg);
         |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1347:22: note: 'tmp' declared here
    1347 |                 TYPE tmp; \
         |                      ^~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1389:17: note: in expansion of macro 'USER_TO_KERNEL'
    1389 |                 USER_TO_KERNEL(bool);
         |                 ^~~~~~~~~~~~~~
   In function 'csis_s_fmt',
       inlined from 'csis_priv_ioctl' at drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1385:9:
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1286:20: warning: using a dangling pointer to 'tmp' [-Wdangling-pointer=]
    1286 |         switch (fmt->format) {
         |                 ~~~^~~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c: In function 'csis_priv_ioctl':
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1347:22: note: 'tmp' declared here
    1347 |                 TYPE tmp; \
         |                      ^~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1384:17: note: in expansion of macro 'USER_TO_KERNEL'
    1384 |                 USER_TO_KERNEL(struct csi_sam_format);
         |                 ^~~~~~~~~~~~~~
   In function 'csis_s_fmt',
       inlined from 'csis_priv_ioctl' at drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1385:9:
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1319:34: warning: dangling pointer to 'tmp' may be used [-Wdangling-pointer=]
    1319 |         state->format.width = fmt->width;
         |                               ~~~^~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c: In function 'csis_priv_ioctl':
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1347:22: note: 'tmp' declared here
    1347 |                 TYPE tmp; \
         |                      ^~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1384:17: note: in expansion of macro 'USER_TO_KERNEL'
    1384 |                 USER_TO_KERNEL(struct csi_sam_format);
         |                 ^~~~~~~~~~~~~~
   In function 'csis_s_fmt',
       inlined from 'csis_priv_ioctl' at drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1385:9:
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1320:35: warning: dangling pointer to 'tmp' may be used [-Wdangling-pointer=]
    1320 |         state->format.height = fmt->height;
         |                                ~~~^~~~~~~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c: In function 'csis_priv_ioctl':
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1347:22: note: 'tmp' declared here
    1347 |                 TYPE tmp; \
         |                      ^~~
   drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1384:17: note: in expansion of macro 'USER_TO_KERNEL'
    1384 |                 USER_TO_KERNEL(struct csi_sam_format);
         |                 ^~~~~~~~~~~~~~


vim +/len +1547 drivers/staging/media/imx/imx8-mipi-csi2-sam.c

346ee386e32f16 Guoniu.zhou 2019-10-25  1534  
06b8d851396b68 Guoniu.zhou 2020-08-21  1535  /*
06b8d851396b68 Guoniu.zhou 2020-08-21  1536   * IMX8MN platform data
06b8d851396b68 Guoniu.zhou 2020-08-21  1537   */
06b8d851396b68 Guoniu.zhou 2020-08-21  1538  static int mipi_csis_imx8mn_parse_resets(struct csi_state *state)
346ee386e32f16 Guoniu.zhou 2019-10-25  1539  {
346ee386e32f16 Guoniu.zhou 2019-10-25  1540  	int ret;
346ee386e32f16 Guoniu.zhou 2019-10-25  1541  	struct device *dev = state->dev;
346ee386e32f16 Guoniu.zhou 2019-10-25  1542  	struct device_node *np = dev->of_node;
346ee386e32f16 Guoniu.zhou 2019-10-25  1543  	struct device_node *parent, *child;
346ee386e32f16 Guoniu.zhou 2019-10-25  1544  	struct of_phandle_args args;
346ee386e32f16 Guoniu.zhou 2019-10-25  1545  	struct reset_control *rstc;
346ee386e32f16 Guoniu.zhou 2019-10-25  1546  	const char *compat;
346ee386e32f16 Guoniu.zhou 2019-10-25 @1547  	uint32_t len, rstc_num = 0;
346ee386e32f16 Guoniu.zhou 2019-10-25  1548  
346ee386e32f16 Guoniu.zhou 2019-10-25  1549  	ret = of_parse_phandle_with_args(np, "resets", "#reset-cells",
346ee386e32f16 Guoniu.zhou 2019-10-25  1550  					 0, &args);
346ee386e32f16 Guoniu.zhou 2019-10-25  1551  	if (ret)
346ee386e32f16 Guoniu.zhou 2019-10-25  1552  		return ret;
346ee386e32f16 Guoniu.zhou 2019-10-25  1553  
346ee386e32f16 Guoniu.zhou 2019-10-25  1554  	parent = args.np;
346ee386e32f16 Guoniu.zhou 2019-10-25  1555  	for_each_child_of_node(parent, child) {
346ee386e32f16 Guoniu.zhou 2019-10-25  1556  		compat = of_get_property(child, "compatible", NULL);
346ee386e32f16 Guoniu.zhou 2019-10-25  1557  		if (!compat)
346ee386e32f16 Guoniu.zhou 2019-10-25  1558  			continue;
346ee386e32f16 Guoniu.zhou 2019-10-25  1559  
346ee386e32f16 Guoniu.zhou 2019-10-25  1560  		rstc = of_reset_control_array_get(child, false, false, true);
346ee386e32f16 Guoniu.zhou 2019-10-25  1561  		if (IS_ERR(rstc))
346ee386e32f16 Guoniu.zhou 2019-10-25  1562  			continue;
346ee386e32f16 Guoniu.zhou 2019-10-25  1563  
346ee386e32f16 Guoniu.zhou 2019-10-25  1564  		len = strlen(compat);
346ee386e32f16 Guoniu.zhou 2019-10-25  1565  		if (!of_compat_cmp("csi,soft-resetn", compat, len)) {
346ee386e32f16 Guoniu.zhou 2019-10-25  1566  			state->soft_resetn = rstc;
346ee386e32f16 Guoniu.zhou 2019-10-25  1567  			rstc_num++;
346ee386e32f16 Guoniu.zhou 2019-10-25  1568  		} else if (!of_compat_cmp("csi,clk-enable", compat, len)) {
346ee386e32f16 Guoniu.zhou 2019-10-25  1569  			state->clk_enable = rstc;
346ee386e32f16 Guoniu.zhou 2019-10-25  1570  			rstc_num++;
346ee386e32f16 Guoniu.zhou 2019-10-25  1571  		} else if (!of_compat_cmp("csi,mipi-reset", compat, len)) {
346ee386e32f16 Guoniu.zhou 2019-10-25  1572  			state->mipi_reset = rstc;
346ee386e32f16 Guoniu.zhou 2019-10-25  1573  			rstc_num++;
346ee386e32f16 Guoniu.zhou 2019-10-25  1574  		} else {
346ee386e32f16 Guoniu.zhou 2019-10-25  1575  			dev_warn(dev, "invalid csis reset node: %s\n", compat);
346ee386e32f16 Guoniu.zhou 2019-10-25  1576  		}
346ee386e32f16 Guoniu.zhou 2019-10-25  1577  	}
346ee386e32f16 Guoniu.zhou 2019-10-25  1578  
346ee386e32f16 Guoniu.zhou 2019-10-25  1579  	if (!rstc_num) {
346ee386e32f16 Guoniu.zhou 2019-10-25  1580  		dev_err(dev, "no invalid reset control exists\n");
346ee386e32f16 Guoniu.zhou 2019-10-25  1581  		return -EINVAL;
346ee386e32f16 Guoniu.zhou 2019-10-25  1582  	}
346ee386e32f16 Guoniu.zhou 2019-10-25  1583  	of_node_put(parent);
346ee386e32f16 Guoniu.zhou 2019-10-25  1584  
346ee386e32f16 Guoniu.zhou 2019-10-25  1585  	return 0;
346ee386e32f16 Guoniu.zhou 2019-10-25  1586  }
346ee386e32f16 Guoniu.zhou 2019-10-25  1587  

:::::: The code at line 1547 was first introduced by commit
:::::: 346ee386e32f16b271d03d6e8337c2246b4739e3 staging: media: imx: add V4L2 subdev driver for MIPI CSI2 of Samsung

:::::: TO: Guoniu.zhou <guoniu.zhou@nxp.com>
:::::: CC: Dong Aisheng <aisheng.dong@nxp.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-04 10:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-04 10:59 [freescale-fslc:5.15-2.2.x-imx 6206/20209] drivers/staging/media/imx/imx8-mipi-csi2-sam.c:1547:18: warning: variable 'len' set but not used kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.