[Buildroot] [PATCH 1/2] toolchain/Config.in: extend gcc bug 43744 to every sh architecture

[Buildroot] [PATCH 1/2] toolchain/Config.in: extend gcc bug 43744 to every sh architecture

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 toolchain/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index 544b423001..01215e0e96 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -115,7 +115,7 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_43744
 	bool
 	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
 	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9
-	depends on BR2_sh4
+	depends on BR2_sh
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63261. This bug no
 # longer exists in gcc 8.x.
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/postgresql: work around gcc bug 43744

[Giulio Benetti]

Package postgresql suffers from gcc bug 43744 other than 85180, so let's
work around disabling compiler optimization for this gcc bug too.

Fixes:
http://autobuild.buildroot.net/results/cf272cdc5be2faf4070de3d235ec7a0f7190867a

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/postgresql/postgresql.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk
index 5313e03b12..2ffcac6595 100644
--- a/package/postgresql/postgresql.mk
+++ b/package/postgresql/postgresql.mk
@@ -101,7 +101,7 @@ endif
 
 POSTGRESQL_CFLAGS = $(TARGET_CFLAGS)
 
-ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+ifneq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_43744)$(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),)
 POSTGRESQL_CFLAGS += -O0
 endif
 
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] toolchain/Config.in: extend gcc bug 43744 to every sh architecture

[Thomas Petazzoni via buildroot]

On Thu,  2 Feb 2023 16:42:38 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

It would be nice to have a non-empty commit log, which explains which
other CPU is affected by the bug, and perhaps a defconfig that exhibits
the issue, or something like that.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2] toolchain/Config.in: extend gcc bug 43744 to every sh architecture

[Giulio Benetti]

Gcc bug 43744 affects seems to affect all SH family because it already
affects:
1) sh4, here you can find a buildroot defconfig that fails to build:
http://autobuild.buildroot.net/results/1db/1db6c59c98e3c09fa13277076ee2fbe7967f1f6b/defconfig
2) sh4a, here you can find a buildroot defconfig that fails to build:
http://autobuild.buildroot.net/results/cf272cdc5be2faf4070de3d235ec7a0f7190867a/defconfig
Note also that gcc bugzilla entry reports the bug for SH and not for
sub-architectures:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43744

So let's extend the bug to BR2_sh to match the entire SH architecture.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* add a commit log with details about gcc bug 43744 as pointed by Thomas Petazzoni
---
 toolchain/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index 544b423001..01215e0e96 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -115,7 +115,7 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_43744
 	bool
 	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
 	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9
-	depends on BR2_sh4
+	depends on BR2_sh
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63261. This bug no
 # longer exists in gcc 8.x.
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] toolchain/Config.in: extend gcc bug 43744 to every sh architecture

[Thomas Petazzoni via buildroot]

On Sun,  5 Feb 2023 22:25:21 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Gcc bug 43744 affects seems to affect all SH family because it already
> affects:
> 1) sh4, here you can find a buildroot defconfig that fails to build:
> http://autobuild.buildroot.net/results/1db/1db6c59c98e3c09fa13277076ee2fbe7967f1f6b/defconfig
> 2) sh4a, here you can find a buildroot defconfig that fails to build:
> http://autobuild.buildroot.net/results/cf272cdc5be2faf4070de3d235ec7a0f7190867a/defconfig
> Note also that gcc bugzilla entry reports the bug for SH and not for
> sub-architectures:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43744
> 
> So let's extend the bug to BR2_sh to match the entire SH architecture.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * add a commit log with details about gcc bug 43744 as pointed by Thomas Petazzoni
> ---
>  toolchain/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/postgresql: work around gcc bug 43744

[Thomas Petazzoni via buildroot]

Hello Giulio,

On Thu,  2 Feb 2023 16:42:39 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Package postgresql suffers from gcc bug 43744 other than 85180, so let's
> work around disabling compiler optimization for this gcc bug too.
> 
> Fixes:
> http://autobuild.buildroot.net/results/cf272cdc5be2faf4070de3d235ec7a0f7190867a
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/postgresql/postgresql.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks. However, you should have resent a v2 of this
patch together with the v2 of the first patch. Never resend partial
series, but instead always, always, always, always, always, always,
always, always, always, always, always, always, always resend a full
series, even if only one patch changed. Sending partial series is
extremely confusing for the people reviewing/applying the patches.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/postgresql: work around gcc bug 43744

[Giulio Benetti]

Hello Thomas,

On 06/02/23 12:21, Thomas Petazzoni via buildroot wrote:
> Hello Giulio,
> 
> On Thu,  2 Feb 2023 16:42:39 +0100
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> Package postgresql suffers from gcc bug 43744 other than 85180, so let's
>> work around disabling compiler optimization for this gcc bug too.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/cf272cdc5be2faf4070de3d235ec7a0f7190867a
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>   package/postgresql/postgresql.mk | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied to master, thanks. However, you should have resent a v2 of this
> patch together with the v2 of the first patch. Never resend partial
> series, but instead always, always, always, always, always, always,
> always, always, always, always, always, always, always resend a full
> series, even if only one patch changed. Sending partial series is
> extremely confusing for the people reviewing/applying the patches.

You've pointed me this recently too :-/ Sorry!

-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] toolchain/Config.in: extend gcc bug 43744 to every sh architecture

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > Gcc bug 43744 affects seems to affect all SH family because it already
 > affects:
 > 1) sh4, here you can find a buildroot defconfig that fails to build:
 > http://autobuild.buildroot.net/results/1db/1db6c59c98e3c09fa13277076ee2fbe7967f1f6b/defconfig
 > 2) sh4a, here you can find a buildroot defconfig that fails to build:
 > http://autobuild.buildroot.net/results/cf272cdc5be2faf4070de3d235ec7a0f7190867a/defconfig
 > Note also that gcc bugzilla entry reports the bug for SH and not for
 > sub-architectures:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43744

 > So let's extend the bug to BR2_sh to match the entire SH architecture.

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
 > ---
 V1-> V2:
 > * add a commit log with details about gcc bug 43744 as pointed by Thomas Petazzoni

Committed to 2022.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/postgresql: work around gcc bug 43744

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > Package postgresql suffers from gcc bug 43744 other than 85180, so let's
 > work around disabling compiler optimization for this gcc bug too.

 > Fixes:
 > http://autobuild.buildroot.net/results/cf272cdc5be2faf4070de3d235ec7a0f7190867a

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed to 2022.11.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot