* [PATCH] dt-bindings: iio: adc: renesas,rcar-gyroadc: Miscellaneous improvements
@ 2022-10-24 11:34 Geert Uytterhoeven
2022-10-24 12:23 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2022-10-24 11:34 UTC (permalink / raw)
To: Marek Vasut, Jonathan Cameron, Lars-Peter Clausen, Rob Herring,
Krzysztof Kozlowski
Cc: linux-iio, devicetree, linux-renesas-soc, Geert Uytterhoeven
Set limits on the number of power-domains and resets, and make them
required.
Simplify the example, and update it to match reality:
- Convert from obsolete MSTP to CPG/MSSR bindings,
- Examples should use #{address,size}-cells = <1>,
- Add missing resets property,
- Drop soc container and pinctrl properties, which are not needed in
examples.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
.../iio/adc/renesas,rcar-gyroadc.yaml | 60 +++++++++----------
1 file changed, 29 insertions(+), 31 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/renesas,rcar-gyroadc.yaml b/Documentation/devicetree/bindings/iio/adc/renesas,rcar-gyroadc.yaml
index c115e2e99bd9a8a5..1c7aee5ed3e0bfb2 100644
--- a/Documentation/devicetree/bindings/iio/adc/renesas,rcar-gyroadc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/renesas,rcar-gyroadc.yaml
@@ -34,9 +34,11 @@ properties:
clock-names:
const: fck
- power-domains: true
+ power-domains:
+ maxItems: 1
- resets: true
+ resets:
+ maxItems: 1
"#address-cells":
const: 1
@@ -51,6 +53,8 @@ required:
- reg
- clocks
- clock-names
+ - power-domains
+ - resets
- "#address-cells"
- "#size-cells"
@@ -108,36 +112,30 @@ patternProperties:
examples:
- |
- #include <dt-bindings/clock/r8a7791-clock.h>
+ #include <dt-bindings/clock/r8a7791-cpg-mssr.h>
#include <dt-bindings/power/r8a7791-sysc.h>
- soc {
- #address-cells = <2>;
- #size-cells = <2>;
-
- adc@e6e54000 {
- compatible = "renesas,r8a7791-gyroadc", "renesas,rcar-gyroadc";
- reg = <0 0xe6e54000 0 64>;
- clocks = <&mstp9_clks R8A7791_CLK_GYROADC>;
- clock-names = "fck";
- power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
-
- pinctrl-0 = <&adc_pins>;
- pinctrl-names = "default";
-
- #address-cells = <1>;
- #size-cells = <0>;
-
- adc@0 {
- reg = <0>;
- compatible = "maxim,max1162";
- vref-supply = <&vref_max1162>;
- };
-
- adc@1 {
- reg = <1>;
- compatible = "maxim,max1162";
- vref-supply = <&vref_max1162>;
- };
+
+ adc@e6e54000 {
+ compatible = "renesas,r8a7791-gyroadc", "renesas,rcar-gyroadc";
+ reg = <0xe6e54000 64>;
+ clocks = <&cpg CPG_MOD 901>;
+ clock-names = "fck";
+ power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
+ resets = <&cpg 901>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ adc@0 {
+ reg = <0>;
+ compatible = "maxim,max1162";
+ vref-supply = <&vref_max1162>;
+ };
+
+ adc@1 {
+ reg = <1>;
+ compatible = "maxim,max1162";
+ vref-supply = <&vref_max1162>;
};
};
...
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: renesas,rcar-gyroadc: Miscellaneous improvements
2022-10-24 11:34 [PATCH] dt-bindings: iio: adc: renesas,rcar-gyroadc: Miscellaneous improvements Geert Uytterhoeven
@ 2022-10-24 12:23 ` Krzysztof Kozlowski
2022-10-29 12:51 ` Jonathan Cameron
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-24 12:23 UTC (permalink / raw)
To: Geert Uytterhoeven, Marek Vasut, Jonathan Cameron,
Lars-Peter Clausen, Rob Herring, Krzysztof Kozlowski
Cc: linux-iio, devicetree, linux-renesas-soc
On 24/10/2022 07:34, Geert Uytterhoeven wrote:
> Set limits on the number of power-domains and resets, and make them
> required.
>
> Simplify the example, and update it to match reality:
> - Convert from obsolete MSTP to CPG/MSSR bindings,
> - Examples should use #{address,size}-cells = <1>,
> - Add missing resets property,
> - Drop soc container and pinctrl properties, which are not needed in
> examples.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: renesas,rcar-gyroadc: Miscellaneous improvements
2022-10-24 12:23 ` Krzysztof Kozlowski
@ 2022-10-29 12:51 ` Jonathan Cameron
2023-01-31 10:13 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Cameron @ 2022-10-29 12:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Geert Uytterhoeven, Marek Vasut, Lars-Peter Clausen, Rob Herring,
Krzysztof Kozlowski, linux-iio, devicetree, linux-renesas-soc
On Mon, 24 Oct 2022 08:23:43 -0400
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 24/10/2022 07:34, Geert Uytterhoeven wrote:
> > Set limits on the number of power-domains and resets, and make them
> > required.
> >
> > Simplify the example, and update it to match reality:
> > - Convert from obsolete MSTP to CPG/MSSR bindings,
> > - Examples should use #{address,size}-cells = <1>,
> > - Add missing resets property,
> > - Drop soc container and pinctrl properties, which are not needed in
> > examples.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied,
Thanks
Jonathan
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: renesas,rcar-gyroadc: Miscellaneous improvements
2022-10-29 12:51 ` Jonathan Cameron
@ 2023-01-31 10:13 ` Geert Uytterhoeven
2023-02-05 15:00 ` Jonathan Cameron
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2023-01-31 10:13 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Krzysztof Kozlowski, Marek Vasut, Lars-Peter Clausen,
Rob Herring, Krzysztof Kozlowski, linux-iio, devicetree,
linux-renesas-soc
Hi Jonathan,
On Sat, Oct 29, 2022 at 2:39 PM Jonathan Cameron <jic23@kernel.org> wrote:
> On Mon, 24 Oct 2022 08:23:43 -0400
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> > On 24/10/2022 07:34, Geert Uytterhoeven wrote:
> > > Set limits on the number of power-domains and resets, and make them
> > > required.
> > >
> > > Simplify the example, and update it to match reality:
> > > - Convert from obsolete MSTP to CPG/MSSR bindings,
> > > - Examples should use #{address,size}-cells = <1>,
> > > - Add missing resets property,
> > > - Drop soc container and pinctrl properties, which are not needed in
> > > examples.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Applied,
Looks like this fell through the cracks, as I cannot see it applied?
Do you want me to resend?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: renesas,rcar-gyroadc: Miscellaneous improvements
2023-01-31 10:13 ` Geert Uytterhoeven
@ 2023-02-05 15:00 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2023-02-05 15:00 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Krzysztof Kozlowski, Marek Vasut, Lars-Peter Clausen,
Rob Herring, Krzysztof Kozlowski, linux-iio, devicetree,
linux-renesas-soc
On Tue, 31 Jan 2023 11:13:04 +0100
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Hi Jonathan,
>
> On Sat, Oct 29, 2022 at 2:39 PM Jonathan Cameron <jic23@kernel.org> wrote:
> > On Mon, 24 Oct 2022 08:23:43 -0400
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> > > On 24/10/2022 07:34, Geert Uytterhoeven wrote:
> > > > Set limits on the number of power-domains and resets, and make them
> > > > required.
> > > >
> > > > Simplify the example, and update it to match reality:
> > > > - Convert from obsolete MSTP to CPG/MSSR bindings,
> > > > - Examples should use #{address,size}-cells = <1>,
> > > > - Add missing resets property,
> > > > - Drop soc container and pinctrl properties, which are not needed in
> > > > examples.
> > > >
> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > >
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Applied,
>
> Looks like this fell through the cracks, as I cannot see it applied?
> Do you want me to resend?
> Thanks!
Sorry about that. Now applied. Not sure what happened there.
Jonathan
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-05 14:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-24 11:34 [PATCH] dt-bindings: iio: adc: renesas,rcar-gyroadc: Miscellaneous improvements Geert Uytterhoeven
2022-10-24 12:23 ` Krzysztof Kozlowski
2022-10-29 12:51 ` Jonathan Cameron
2023-01-31 10:13 ` Geert Uytterhoeven
2023-02-05 15:00 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.