All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Olliver Schinagl <oliver@schinagl.nl>
Cc: Sander Vanheule <sander@svanheule.net>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: Realtek RTL: select NO_EXCEPT_FILL
Date: Sun, 5 Feb 2023 17:19:29 +0100	[thread overview]
Message-ID: <20230205161929.GD4459@alpha.franken.de> (raw)
In-Reply-To: <46724036-fabf-7bae-41f8-1e95c5f1db5c@schinagl.nl>

On Sat, Jan 28, 2023 at 03:39:59PM +0100, Olliver Schinagl wrote:
> Thanks Thomas, may I take this moment to poke you about a nother issue I
> don't quite understand how to resolve/figure out.
> 
> 
> I made the realtek target work with the GENERIC_MIPS_KERNEL, but only if I
> disable SWAP_IO_SPACE[0].

is this little endian or big endian ? 

> While I could act all smart and ask what this is for, I better ask, why is
> this concidered 'generic'. The comment in mangle-port [1] mentions 'sane
> hardware'. I don't know what is considered sane here, as the number of
> targets following generic mips seem to be around 5.

I always thought that SWAP_IO_SPACE is needed for big endian, but
looking at arch/mips/Kconfig I see a lot of SWAP_IO_SPACE for pure
little endian machines. I need to dig deeper to understand why.

> So any pointers (other then doing SWAP_IO_SPACE if !REALTEK_SOC, which I
> have now) would be appreciated

such a change would defeat the generic part of GENERIC_MIPS_KERNEL,
because it will then only work on REALTEC_SOC and nothing else. 

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

  reply	other threads:[~2023-02-05 16:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-15 12:19 [PATCH] mips: Realtek RTL: select NO_EXCEPT_FILL Sander Vanheule
2023-01-27 16:27 ` Thomas Bogendoerfer
2023-01-28 14:39   ` Olliver Schinagl
2023-02-05 16:19     ` Thomas Bogendoerfer [this message]
2023-02-05 18:33       ` Olliver Schinagl
2023-02-17 17:37         ` Thomas Bogendoerfer
2023-02-17 19:27           ` Olliver Schinagl
2023-02-19  9:02             ` Thomas Bogendoerfer
2023-02-19  9:27               ` Olliver Schinagl
2023-02-19 10:31                 ` Thomas Bogendoerfer
2023-02-19 16:07                   ` Olliver Schinagl
2023-02-22 15:23                     ` Olliver Schinagl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230205161929.GD4459@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=oliver@schinagl.nl \
    --cc=sander@svanheule.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.