From: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com> To: Elliot Berman <quic_eberman@quicinc.com> Cc: Bjorn Andersson <quic_bjorande@quicinc.com>, Alex Elder <elder@linaro.org>, Murali Nalajala <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Carl van Schaik <quic_cvanscha@quicinc.com>, Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Arnd Bergmann <arnd@arndb.de>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Jonathan Corbet <corbet@lwn.net>, Bagas Sanjaya <bagasdotme@gmail.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>, Jassi Brar <jassisinghbrar@gmail.com>, Sudeep Holla <sudeep.holla@arm.com>, <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v9 23/27] virt: gunyah: Add IO handlers Date: Mon, 6 Feb 2023 16:16:37 +0530 [thread overview] Message-ID: <20230206104637.GG332@quicinc.com> (raw) In-Reply-To: <20230120224627.4053418-24-quic_eberman@quicinc.com> * Elliot Berman <quic_eberman@quicinc.com> [2023-01-20 14:46:22]: > +static inline bool gh_vm_io_handler_matches(struct gunyah_vm_io_handler *io_hdlr, u64 addr, > + u64 len, u64 data) > +{ > + u64 mask = BIT_ULL(io_hdlr->len * BITS_PER_BYTE) - 1; > + > + if (io_hdlr->addr != addr) Isn't this test redundant (given that caller would have performed same test)? > + return false; > + > + if (!io_hdlr->datamatch) > + return true; > + > + if (io_hdlr->len != len) > + return false; > + > + return (data & mask) == (io_hdlr->data & mask); > +} > + > +static struct gunyah_vm_io_handler *gh_vm_mgr_find_io_hdlr(struct gunyah_vm *ghvm, u64 addr, > + u64 len, u64 data) > +{ > + struct gunyah_vm_io_handler *io_hdlr = NULL; > + struct rb_node *root = NULL; > + > + root = ghvm->mmio_handler_root.rb_node; > + while (root) { > + io_hdlr = rb_entry(root, struct gunyah_vm_io_handler, node); > + if (addr < io_hdlr->addr) > + root = root->rb_left; > + else if (addr > io_hdlr->addr) > + root = root->rb_right; > + else if (gh_vm_io_handler_matches(io_hdlr, addr, len, data)) In case of handler not matching, don't we need to modify root? Otherwise we can be stuck in infinite loop here AFAICS. > + return io_hdlr; > + } > + return NULL; > +} // snip > +int gh_vm_mgr_add_io_handler(struct gunyah_vm *ghvm, struct gunyah_vm_io_handler *io_hdlr) > +{ > + struct rb_node **root, *parent = NULL; > + > + if (io_hdlr->datamatch && > + (!io_hdlr->len || io_hdlr->len > (sizeof(io_hdlr->data) * BITS_PER_BYTE))) > + return -EINVAL; > + > + root = &ghvm->mmio_handler_root.rb_node; > + while (*root) { > + struct gunyah_vm_io_handler *curr = rb_entry(*root, struct gunyah_vm_io_handler, > + node); > + > + parent = *root; > + if (io_hdlr->addr < curr->addr) > + root = &((*root)->rb_left); > + else if (io_hdlr->addr > curr->addr) > + root = &((*root)->rb_right); > + else We should allow two io_handlers on the same addr, but with different data matches I think. > + return -EEXIST; > + } > + > + rb_link_node(&io_hdlr->node, parent, root); > + rb_insert_color(&io_hdlr->node, &ghvm->mmio_handler_root); > + return 0; > +} > +EXPORT_SYMBOL_GPL(gh_vm_mgr_add_io_handler);
WARNING: multiple messages have this Message-ID (diff)
From: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com> To: Elliot Berman <quic_eberman@quicinc.com> Cc: Bjorn Andersson <quic_bjorande@quicinc.com>, Alex Elder <elder@linaro.org>, Murali Nalajala <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Carl van Schaik <quic_cvanscha@quicinc.com>, Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Arnd Bergmann <arnd@arndb.de>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Jonathan Corbet <corbet@lwn.net>, Bagas Sanjaya <bagasdotme@gmail.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>, Jassi Brar <jassisinghbrar@gmail.com>, Sudeep Holla <sudeep.holla@arm.com>, <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v9 23/27] virt: gunyah: Add IO handlers Date: Mon, 6 Feb 2023 16:16:37 +0530 [thread overview] Message-ID: <20230206104637.GG332@quicinc.com> (raw) In-Reply-To: <20230120224627.4053418-24-quic_eberman@quicinc.com> * Elliot Berman <quic_eberman@quicinc.com> [2023-01-20 14:46:22]: > +static inline bool gh_vm_io_handler_matches(struct gunyah_vm_io_handler *io_hdlr, u64 addr, > + u64 len, u64 data) > +{ > + u64 mask = BIT_ULL(io_hdlr->len * BITS_PER_BYTE) - 1; > + > + if (io_hdlr->addr != addr) Isn't this test redundant (given that caller would have performed same test)? > + return false; > + > + if (!io_hdlr->datamatch) > + return true; > + > + if (io_hdlr->len != len) > + return false; > + > + return (data & mask) == (io_hdlr->data & mask); > +} > + > +static struct gunyah_vm_io_handler *gh_vm_mgr_find_io_hdlr(struct gunyah_vm *ghvm, u64 addr, > + u64 len, u64 data) > +{ > + struct gunyah_vm_io_handler *io_hdlr = NULL; > + struct rb_node *root = NULL; > + > + root = ghvm->mmio_handler_root.rb_node; > + while (root) { > + io_hdlr = rb_entry(root, struct gunyah_vm_io_handler, node); > + if (addr < io_hdlr->addr) > + root = root->rb_left; > + else if (addr > io_hdlr->addr) > + root = root->rb_right; > + else if (gh_vm_io_handler_matches(io_hdlr, addr, len, data)) In case of handler not matching, don't we need to modify root? Otherwise we can be stuck in infinite loop here AFAICS. > + return io_hdlr; > + } > + return NULL; > +} // snip > +int gh_vm_mgr_add_io_handler(struct gunyah_vm *ghvm, struct gunyah_vm_io_handler *io_hdlr) > +{ > + struct rb_node **root, *parent = NULL; > + > + if (io_hdlr->datamatch && > + (!io_hdlr->len || io_hdlr->len > (sizeof(io_hdlr->data) * BITS_PER_BYTE))) > + return -EINVAL; > + > + root = &ghvm->mmio_handler_root.rb_node; > + while (*root) { > + struct gunyah_vm_io_handler *curr = rb_entry(*root, struct gunyah_vm_io_handler, > + node); > + > + parent = *root; > + if (io_hdlr->addr < curr->addr) > + root = &((*root)->rb_left); > + else if (io_hdlr->addr > curr->addr) > + root = &((*root)->rb_right); > + else We should allow two io_handlers on the same addr, but with different data matches I think. > + return -EEXIST; > + } > + > + rb_link_node(&io_hdlr->node, parent, root); > + rb_insert_color(&io_hdlr->node, &ghvm->mmio_handler_root); > + return 0; > +} > +EXPORT_SYMBOL_GPL(gh_vm_mgr_add_io_handler); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-06 10:47 UTC|newest] Thread overview: 154+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-20 22:45 [PATCH v9 00/27] Drivers for gunyah hypervisor Elliot Berman 2023-01-20 22:45 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 01/27] docs: gunyah: Introduce Gunyah Hypervisor Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 02/27] dt-bindings: Add binding for gunyah hypervisor Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 03/27] gunyah: Common types and error codes for Gunyah hypercalls Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-30 9:58 ` Greg Kroah-Hartman 2023-01-30 9:58 ` Greg Kroah-Hartman 2023-01-20 22:46 ` [PATCH v9 04/27] virt: gunyah: Add hypercalls to identify Gunyah Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-30 10:01 ` Greg Kroah-Hartman 2023-01-30 10:01 ` Greg Kroah-Hartman 2023-01-30 19:05 ` Elliot Berman 2023-01-30 19:05 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 05/27] virt: gunyah: Identify hypervisor version Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 06/27] mailbox: Allow direct registration to a channel Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 07/27] virt: gunyah: msgq: Add hypercalls to send and receive messages Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-31 16:16 ` Srinivas Kandagatla 2023-01-31 16:16 ` Srinivas Kandagatla 2023-01-20 22:46 ` [PATCH v9 08/27] mailbox: Add Gunyah message queue mailbox Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-02-02 9:59 ` Srinivas Kandagatla 2023-02-02 9:59 ` Srinivas Kandagatla 2023-02-06 14:00 ` Alex Elder 2023-02-06 14:00 ` Alex Elder 2023-02-08 20:46 ` Elliot Berman 2023-02-08 20:46 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 09/27] gunyah: rsc_mgr: Add resource manager RPC core Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-02-02 11:53 ` Srinivas Kandagatla 2023-02-02 11:53 ` Srinivas Kandagatla 2023-02-06 14:14 ` Alex Elder 2023-02-06 14:14 ` Alex Elder 2023-01-20 22:46 ` [PATCH v9 10/27] gunyah: rsc_mgr: Add VM lifecycle RPC Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-25 6:12 ` Srivatsa Vaddagiri 2023-01-25 6:12 ` Srivatsa Vaddagiri 2023-01-30 21:43 ` Elliot Berman 2023-01-30 21:43 ` Elliot Berman 2023-02-02 12:46 ` Srinivas Kandagatla 2023-02-02 12:46 ` Srinivas Kandagatla 2023-02-06 15:41 ` Alex Elder 2023-02-06 15:41 ` Alex Elder 2023-02-06 17:38 ` Elliot Berman 2023-02-06 17:38 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 11/27] gunyah: vm_mgr: Introduce basic VM Manager Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-02-02 12:54 ` Srinivas Kandagatla 2023-02-02 12:54 ` Srinivas Kandagatla 2023-02-07 0:36 ` Elliot Berman 2023-02-07 0:36 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 12/27] gunyah: rsc_mgr: Add RPC for sharing memory Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-30 10:14 ` Srivatsa Vaddagiri 2023-01-30 10:14 ` Srivatsa Vaddagiri 2023-01-30 21:45 ` Elliot Berman 2023-01-30 21:45 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 13/27] gunyah: vm_mgr: Add/remove user memory regions Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-25 13:34 ` Srivatsa Vaddagiri 2023-01-25 13:34 ` Srivatsa Vaddagiri 2023-01-30 21:46 ` Elliot Berman 2023-01-30 21:46 ` Elliot Berman 2023-02-06 16:12 ` Srinivas Kandagatla 2023-02-06 16:12 ` Srinivas Kandagatla 2023-02-06 23:23 ` Elliot Berman 2023-02-06 23:23 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 14/27] gunyah: vm_mgr: Add ioctls to support basic non-proxy VM boot Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-30 8:53 ` Srivatsa Vaddagiri 2023-01-30 8:53 ` Srivatsa Vaddagiri 2023-01-30 21:44 ` Elliot Berman 2023-01-30 21:44 ` Elliot Berman 2023-01-30 21:45 ` Elliot Berman 2023-01-30 21:45 ` Elliot Berman 2023-02-07 11:36 ` Srinivas Kandagatla 2023-02-07 11:36 ` Srinivas Kandagatla 2023-02-08 21:04 ` Elliot Berman 2023-02-08 21:04 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 15/27] samples: Add sample userspace Gunyah VM Manager Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 16/27] gunyah: rsc_mgr: Add platform ops on mem_lend/mem_reclaim Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 17/27] firmware: qcom_scm: Use fixed width src vm bitmap Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-03-16 3:21 ` (subset) " Bjorn Andersson 2023-03-16 3:21 ` Bjorn Andersson 2023-03-16 3:21 ` Bjorn Andersson 2023-01-20 22:46 ` [PATCH v9 18/27] firmware: qcom_scm: Register Gunyah platform ops Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-31 15:18 ` Srivatsa Vaddagiri 2023-01-31 15:18 ` Srivatsa Vaddagiri 2023-02-07 11:52 ` Srinivas Kandagatla 2023-02-07 11:52 ` Srinivas Kandagatla 2023-02-08 1:06 ` Elliot Berman 2023-02-08 1:06 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 19/27] docs: gunyah: Document Gunyah VM Manager Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 20/27] virt: gunyah: Translate gh_rm_hyp_resource into gunyah_resource Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 21/27] gunyah: vm_mgr: Add framework to add VM Functions Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-02-03 9:37 ` Srivatsa Vaddagiri 2023-02-03 9:37 ` Srivatsa Vaddagiri 2023-02-03 17:56 ` Srivatsa Vaddagiri 2023-02-03 17:56 ` Srivatsa Vaddagiri 2023-02-07 13:15 ` Srinivas Kandagatla 2023-02-07 13:15 ` Srinivas Kandagatla 2023-02-08 19:34 ` Elliot Berman 2023-02-08 19:34 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 22/27] virt: gunyah: Add resource tickets Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-02-06 9:50 ` Srivatsa Vaddagiri 2023-02-06 9:50 ` Srivatsa Vaddagiri 2023-02-06 21:30 ` Elliot Berman 2023-02-06 21:30 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 23/27] virt: gunyah: Add IO handlers Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-02-06 10:46 ` Srivatsa Vaddagiri [this message] 2023-02-06 10:46 ` Srivatsa Vaddagiri 2023-02-07 3:59 ` Elliot Berman 2023-02-07 3:59 ` Elliot Berman 2023-02-07 12:19 ` Srivatsa Vaddagiri 2023-02-07 12:19 ` Srivatsa Vaddagiri 2023-01-20 22:46 ` [PATCH v9 24/27] virt: gunyah: Add proxy-scheduled vCPUs Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-02-07 14:43 ` Srinivas Kandagatla 2023-02-07 14:43 ` Srinivas Kandagatla 2023-02-08 18:36 ` Elliot Berman 2023-02-08 18:36 ` Elliot Berman 2023-02-09 10:39 ` Srivatsa Vaddagiri 2023-02-09 10:39 ` Srivatsa Vaddagiri 2023-02-10 6:54 ` Srivatsa Vaddagiri 2023-02-10 6:54 ` Srivatsa Vaddagiri 2023-02-10 17:09 ` Elliot Berman 2023-02-10 17:09 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 25/27] virt: gunyah: Add hypercalls for sending doorbell Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-01-20 22:46 ` [PATCH v9 26/27] virt: gunyah: Add irqfd interface Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-02-07 14:30 ` Srinivas Kandagatla 2023-02-07 14:30 ` Srinivas Kandagatla 2023-02-13 8:11 ` Srivatsa Vaddagiri 2023-02-13 8:11 ` Srivatsa Vaddagiri 2023-01-20 22:46 ` [PATCH v9 27/27] virt: gunyah: Add ioeventfd Elliot Berman 2023-01-20 22:46 ` Elliot Berman 2023-02-07 14:19 ` Srinivas Kandagatla 2023-02-07 14:19 ` Srinivas Kandagatla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230206104637.GG332@quicinc.com \ --to=quic_svaddagi@quicinc.com \ --cc=arnd@arndb.de \ --cc=bagasdotme@gmail.com \ --cc=catalin.marinas@arm.com \ --cc=corbet@lwn.net \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=elder@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=jassisinghbrar@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maz@kernel.org \ --cc=quic_bjorande@quicinc.com \ --cc=quic_cvanscha@quicinc.com \ --cc=quic_eberman@quicinc.com \ --cc=quic_mnalajal@quicinc.com \ --cc=quic_pheragu@quicinc.com \ --cc=quic_tsoni@quicinc.com \ --cc=robh+dt@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.