All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: socfpga: Add enclustra PE1 devicetree
@ 2023-02-07  9:41 ` Steffen Trumtrar
  0 siblings, 0 replies; 12+ messages in thread
From: Steffen Trumtrar @ 2023-02-07  9:41 UTC (permalink / raw)
  To: Dinh Nguyen
  Cc: Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree, kernel

The enclustra PE1 is a baseboard from enclustra GmbH for the enclustra
Mercury AA1+ SOM.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 arch/arm/boot/dts/Makefile                    |  1 +
 .../boot/dts/socfpga_arria10_mercury_pe1.dts  | 55 +++++++++++++++++++
 2 files changed, 56 insertions(+)
 create mode 100644 arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index d08a3c450ce7..2714b70f2a67 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1179,6 +1179,7 @@ dtb-$(CONFIG_ARCH_S5PV210) += \
 dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += \
 	socfpga_arria5_socdk.dtb \
 	socfpga_arria10_chameleonv3.dtb \
+	socfpga_arria10_mercury_pe1.dtb \
 	socfpga_arria10_socdk_nand.dtb \
 	socfpga_arria10_socdk_qspi.dtb \
 	socfpga_arria10_socdk_sdmmc.dtb \
diff --git a/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts b/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
new file mode 100644
index 000000000000..a236489afbc2
--- /dev/null
+++ b/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
@@ -0,0 +1,55 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2023 Steffen Trumtrar <kernel@pengutronix.de>
+ */
+/dts-v1/;
+#include "socfpga_arria10_mercury_aa1.dtsi"
+
+/ {
+	model = "enclustra,mercury-pe1";
+	compatible = "enclustra,mercury-pe1", "enclustra,mercury-aa1",
+		     "altr,socfpga-arria10", "altr,socfpga";
+
+	aliases {
+		ethernet0 = &gmac0;
+		serial0 = &uart0;
+		serial1 = &uart1;
+	};
+};
+
+&gmac0 {
+	status = "okay";
+};
+
+&gpio0 {
+	status = "okay";
+};
+
+&gpio1 {
+	status = "okay";
+};
+
+&gpio2 {
+	status = "okay";
+};
+
+&i2c1 {
+	status = "okay";
+};
+
+&mmc {
+	status = "okay";
+};
+
+&uart0 {
+	status = "okay";
+};
+
+&uart1 {
+	status = "okay";
+};
+
+&usb0 {
+	status = "okay";
+	dr_mode = "host";
+};
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 1/2] ARM: dts: socfpga: Add enclustra PE1 devicetree
@ 2023-02-07  9:41 ` Steffen Trumtrar
  0 siblings, 0 replies; 12+ messages in thread
From: Steffen Trumtrar @ 2023-02-07  9:41 UTC (permalink / raw)
  To: Dinh Nguyen
  Cc: Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree, kernel

The enclustra PE1 is a baseboard from enclustra GmbH for the enclustra
Mercury AA1+ SOM.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 arch/arm/boot/dts/Makefile                    |  1 +
 .../boot/dts/socfpga_arria10_mercury_pe1.dts  | 55 +++++++++++++++++++
 2 files changed, 56 insertions(+)
 create mode 100644 arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index d08a3c450ce7..2714b70f2a67 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1179,6 +1179,7 @@ dtb-$(CONFIG_ARCH_S5PV210) += \
 dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += \
 	socfpga_arria5_socdk.dtb \
 	socfpga_arria10_chameleonv3.dtb \
+	socfpga_arria10_mercury_pe1.dtb \
 	socfpga_arria10_socdk_nand.dtb \
 	socfpga_arria10_socdk_qspi.dtb \
 	socfpga_arria10_socdk_sdmmc.dtb \
diff --git a/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts b/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
new file mode 100644
index 000000000000..a236489afbc2
--- /dev/null
+++ b/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
@@ -0,0 +1,55 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2023 Steffen Trumtrar <kernel@pengutronix.de>
+ */
+/dts-v1/;
+#include "socfpga_arria10_mercury_aa1.dtsi"
+
+/ {
+	model = "enclustra,mercury-pe1";
+	compatible = "enclustra,mercury-pe1", "enclustra,mercury-aa1",
+		     "altr,socfpga-arria10", "altr,socfpga";
+
+	aliases {
+		ethernet0 = &gmac0;
+		serial0 = &uart0;
+		serial1 = &uart1;
+	};
+};
+
+&gmac0 {
+	status = "okay";
+};
+
+&gpio0 {
+	status = "okay";
+};
+
+&gpio1 {
+	status = "okay";
+};
+
+&gpio2 {
+	status = "okay";
+};
+
+&i2c1 {
+	status = "okay";
+};
+
+&mmc {
+	status = "okay";
+};
+
+&uart0 {
+	status = "okay";
+};
+
+&uart1 {
+	status = "okay";
+};
+
+&usb0 {
+	status = "okay";
+	dr_mode = "host";
+};
-- 
2.39.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 2/2] dt-bindings: altera: Add enclustra mercury PE1
  2023-02-07  9:41 ` Steffen Trumtrar
@ 2023-02-07  9:41   ` Steffen Trumtrar
  -1 siblings, 0 replies; 12+ messages in thread
From: Steffen Trumtrar @ 2023-02-07  9:41 UTC (permalink / raw)
  To: Dinh Nguyen
  Cc: Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree, kernel

Add binding for the enclustra PE1 baseboard from enclustra GmbH.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 Documentation/devicetree/bindings/arm/altera.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
index 3eee03aa935c..6f306f9f2f9d 100644
--- a/Documentation/devicetree/bindings/arm/altera.yaml
+++ b/Documentation/devicetree/bindings/arm/altera.yaml
@@ -32,6 +32,7 @@ properties:
         items:
           - enum:
               - google,chameleon-v3
+              - enclustra,mercury-pe1
           - const: enclustra,mercury-aa1
           - const: altr,socfpga-arria10
           - const: altr,socfpga
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 2/2] dt-bindings: altera: Add enclustra mercury PE1
@ 2023-02-07  9:41   ` Steffen Trumtrar
  0 siblings, 0 replies; 12+ messages in thread
From: Steffen Trumtrar @ 2023-02-07  9:41 UTC (permalink / raw)
  To: Dinh Nguyen
  Cc: Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree, kernel

Add binding for the enclustra PE1 baseboard from enclustra GmbH.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 Documentation/devicetree/bindings/arm/altera.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
index 3eee03aa935c..6f306f9f2f9d 100644
--- a/Documentation/devicetree/bindings/arm/altera.yaml
+++ b/Documentation/devicetree/bindings/arm/altera.yaml
@@ -32,6 +32,7 @@ properties:
         items:
           - enum:
               - google,chameleon-v3
+              - enclustra,mercury-pe1
           - const: enclustra,mercury-aa1
           - const: altr,socfpga-arria10
           - const: altr,socfpga
-- 
2.39.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: altera: Add enclustra mercury PE1
  2023-02-07  9:41   ` Steffen Trumtrar
@ 2023-02-07 10:48     ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-07 10:48 UTC (permalink / raw)
  To: Steffen Trumtrar, Dinh Nguyen
  Cc: Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree, kernel

On 07/02/2023 10:41, Steffen Trumtrar wrote:
> Add binding for the enclustra PE1 baseboard from enclustra GmbH.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/arm/altera.yaml | 1 +

Bindings are before the usage. Otherwise you have checkpatch error.

>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
> index 3eee03aa935c..6f306f9f2f9d 100644
> --- a/Documentation/devicetree/bindings/arm/altera.yaml
> +++ b/Documentation/devicetree/bindings/arm/altera.yaml
> @@ -32,6 +32,7 @@ properties:
>          items:
>            - enum:
>                - google,chameleon-v3
> +              - enclustra,mercury-pe1

Messed order, keep alphabetical order.

>            - const: enclustra,mercury-aa1
>            - const: altr,socfpga-arria10
>            - const: altr,socfpga

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: altera: Add enclustra mercury PE1
@ 2023-02-07 10:48     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-07 10:48 UTC (permalink / raw)
  To: Steffen Trumtrar, Dinh Nguyen
  Cc: Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree, kernel

On 07/02/2023 10:41, Steffen Trumtrar wrote:
> Add binding for the enclustra PE1 baseboard from enclustra GmbH.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/arm/altera.yaml | 1 +

Bindings are before the usage. Otherwise you have checkpatch error.

>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
> index 3eee03aa935c..6f306f9f2f9d 100644
> --- a/Documentation/devicetree/bindings/arm/altera.yaml
> +++ b/Documentation/devicetree/bindings/arm/altera.yaml
> @@ -32,6 +32,7 @@ properties:
>          items:
>            - enum:
>                - google,chameleon-v3
> +              - enclustra,mercury-pe1

Messed order, keep alphabetical order.

>            - const: enclustra,mercury-aa1
>            - const: altr,socfpga-arria10
>            - const: altr,socfpga

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] ARM: dts: socfpga: Add enclustra PE1 devicetree
  2023-02-07  9:41 ` Steffen Trumtrar
@ 2023-02-07 10:49   ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-07 10:49 UTC (permalink / raw)
  To: Steffen Trumtrar, Dinh Nguyen
  Cc: Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree, kernel

On 07/02/2023 10:41, Steffen Trumtrar wrote:
> The enclustra PE1 is a baseboard from enclustra GmbH for the enclustra
> Mercury AA1+ SOM.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  arch/arm/boot/dts/Makefile                    |  1 +
>  .../boot/dts/socfpga_arria10_mercury_pe1.dts  | 55 +++++++++++++++++++
>  2 files changed, 56 insertions(+)
>  create mode 100644 arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d08a3c450ce7..2714b70f2a67 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1179,6 +1179,7 @@ dtb-$(CONFIG_ARCH_S5PV210) += \
>  dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += \
>  	socfpga_arria5_socdk.dtb \
>  	socfpga_arria10_chameleonv3.dtb \
> +	socfpga_arria10_mercury_pe1.dtb \
>  	socfpga_arria10_socdk_nand.dtb \
>  	socfpga_arria10_socdk_qspi.dtb \
>  	socfpga_arria10_socdk_sdmmc.dtb \
> diff --git a/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts b/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
> new file mode 100644
> index 000000000000..a236489afbc2
> --- /dev/null
> +++ b/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
> @@ -0,0 +1,55 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright 2023 Steffen Trumtrar <kernel@pengutronix.de>
> + */
> +/dts-v1/;
> +#include "socfpga_arria10_mercury_aa1.dtsi"
> +
> +/ {
> +	model = "enclustra,mercury-pe1";

This is user-visible string, not compatible. git grep for examples.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] ARM: dts: socfpga: Add enclustra PE1 devicetree
@ 2023-02-07 10:49   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-07 10:49 UTC (permalink / raw)
  To: Steffen Trumtrar, Dinh Nguyen
  Cc: Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree, kernel

On 07/02/2023 10:41, Steffen Trumtrar wrote:
> The enclustra PE1 is a baseboard from enclustra GmbH for the enclustra
> Mercury AA1+ SOM.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  arch/arm/boot/dts/Makefile                    |  1 +
>  .../boot/dts/socfpga_arria10_mercury_pe1.dts  | 55 +++++++++++++++++++
>  2 files changed, 56 insertions(+)
>  create mode 100644 arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d08a3c450ce7..2714b70f2a67 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1179,6 +1179,7 @@ dtb-$(CONFIG_ARCH_S5PV210) += \
>  dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += \
>  	socfpga_arria5_socdk.dtb \
>  	socfpga_arria10_chameleonv3.dtb \
> +	socfpga_arria10_mercury_pe1.dtb \
>  	socfpga_arria10_socdk_nand.dtb \
>  	socfpga_arria10_socdk_qspi.dtb \
>  	socfpga_arria10_socdk_sdmmc.dtb \
> diff --git a/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts b/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
> new file mode 100644
> index 000000000000..a236489afbc2
> --- /dev/null
> +++ b/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
> @@ -0,0 +1,55 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright 2023 Steffen Trumtrar <kernel@pengutronix.de>
> + */
> +/dts-v1/;
> +#include "socfpga_arria10_mercury_aa1.dtsi"
> +
> +/ {
> +	model = "enclustra,mercury-pe1";

This is user-visible string, not compatible. git grep for examples.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] ARM: dts: socfpga: Add enclustra PE1 devicetree
  2023-02-07 10:49   ` Krzysztof Kozlowski
@ 2023-02-07 12:46     ` Steffen Trumtrar
  -1 siblings, 0 replies; 12+ messages in thread
From: Steffen Trumtrar @ 2023-02-07 12:46 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel,
	devicetree, kernel

On Tue, Feb 07, 2023 at 11:49:58AM +0100, Krzysztof Kozlowski wrote:
> On 07/02/2023 10:41, Steffen Trumtrar wrote:
> > The enclustra PE1 is a baseboard from enclustra GmbH for the enclustra
> > Mercury AA1+ SOM.
> > 
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/Makefile                    |  1 +
> >  .../boot/dts/socfpga_arria10_mercury_pe1.dts  | 55 +++++++++++++++++++
> >  2 files changed, 56 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
> > 
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index d08a3c450ce7..2714b70f2a67 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -1179,6 +1179,7 @@ dtb-$(CONFIG_ARCH_S5PV210) += \
> >  dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += \
> >  	socfpga_arria5_socdk.dtb \
> >  	socfpga_arria10_chameleonv3.dtb \
> > +	socfpga_arria10_mercury_pe1.dtb \
> >  	socfpga_arria10_socdk_nand.dtb \
> >  	socfpga_arria10_socdk_qspi.dtb \
> >  	socfpga_arria10_socdk_sdmmc.dtb \
> > diff --git a/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts b/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
> > new file mode 100644
> > index 000000000000..a236489afbc2
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
> > @@ -0,0 +1,55 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright 2023 Steffen Trumtrar <kernel@pengutronix.de>
> > + */
> > +/dts-v1/;
> > +#include "socfpga_arria10_mercury_aa1.dtsi"
> > +
> > +/ {
> > +	model = "enclustra,mercury-pe1";
> 
> This is user-visible string, not compatible. git grep for examples.

Oops, stupid me. Sorry, will fix that of course.


Thanks,
Steffen Trumtrar

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] ARM: dts: socfpga: Add enclustra PE1 devicetree
@ 2023-02-07 12:46     ` Steffen Trumtrar
  0 siblings, 0 replies; 12+ messages in thread
From: Steffen Trumtrar @ 2023-02-07 12:46 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel,
	devicetree, kernel

On Tue, Feb 07, 2023 at 11:49:58AM +0100, Krzysztof Kozlowski wrote:
> On 07/02/2023 10:41, Steffen Trumtrar wrote:
> > The enclustra PE1 is a baseboard from enclustra GmbH for the enclustra
> > Mercury AA1+ SOM.
> > 
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/Makefile                    |  1 +
> >  .../boot/dts/socfpga_arria10_mercury_pe1.dts  | 55 +++++++++++++++++++
> >  2 files changed, 56 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
> > 
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index d08a3c450ce7..2714b70f2a67 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -1179,6 +1179,7 @@ dtb-$(CONFIG_ARCH_S5PV210) += \
> >  dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += \
> >  	socfpga_arria5_socdk.dtb \
> >  	socfpga_arria10_chameleonv3.dtb \
> > +	socfpga_arria10_mercury_pe1.dtb \
> >  	socfpga_arria10_socdk_nand.dtb \
> >  	socfpga_arria10_socdk_qspi.dtb \
> >  	socfpga_arria10_socdk_sdmmc.dtb \
> > diff --git a/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts b/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
> > new file mode 100644
> > index 000000000000..a236489afbc2
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/socfpga_arria10_mercury_pe1.dts
> > @@ -0,0 +1,55 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright 2023 Steffen Trumtrar <kernel@pengutronix.de>
> > + */
> > +/dts-v1/;
> > +#include "socfpga_arria10_mercury_aa1.dtsi"
> > +
> > +/ {
> > +	model = "enclustra,mercury-pe1";
> 
> This is user-visible string, not compatible. git grep for examples.

Oops, stupid me. Sorry, will fix that of course.


Thanks,
Steffen Trumtrar

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: altera: Add enclustra mercury PE1
  2023-02-07 10:48     ` Krzysztof Kozlowski
@ 2023-02-07 12:47       ` Steffen Trumtrar
  -1 siblings, 0 replies; 12+ messages in thread
From: Steffen Trumtrar @ 2023-02-07 12:47 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel,
	devicetree, kernel

On Tue, Feb 07, 2023 at 11:48:56AM +0100, Krzysztof Kozlowski wrote:
> On 07/02/2023 10:41, Steffen Trumtrar wrote:
> > Add binding for the enclustra PE1 baseboard from enclustra GmbH.
> > 
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> >  Documentation/devicetree/bindings/arm/altera.yaml | 1 +
> 
> Bindings are before the usage. Otherwise you have checkpatch error.
> 
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
> > index 3eee03aa935c..6f306f9f2f9d 100644
> > --- a/Documentation/devicetree/bindings/arm/altera.yaml
> > +++ b/Documentation/devicetree/bindings/arm/altera.yaml
> > @@ -32,6 +32,7 @@ properties:
> >          items:
> >            - enum:
> >                - google,chameleon-v3
> > +              - enclustra,mercury-pe1
> 
> Messed order, keep alphabetical order.
> 
> >            - const: enclustra,mercury-aa1
> >            - const: altr,socfpga-arria10
> >            - const: altr,socfpga
> 

Ack.

Thanks,
Steffen Trumtrar

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: altera: Add enclustra mercury PE1
@ 2023-02-07 12:47       ` Steffen Trumtrar
  0 siblings, 0 replies; 12+ messages in thread
From: Steffen Trumtrar @ 2023-02-07 12:47 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel,
	devicetree, kernel

On Tue, Feb 07, 2023 at 11:48:56AM +0100, Krzysztof Kozlowski wrote:
> On 07/02/2023 10:41, Steffen Trumtrar wrote:
> > Add binding for the enclustra PE1 baseboard from enclustra GmbH.
> > 
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> >  Documentation/devicetree/bindings/arm/altera.yaml | 1 +
> 
> Bindings are before the usage. Otherwise you have checkpatch error.
> 
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
> > index 3eee03aa935c..6f306f9f2f9d 100644
> > --- a/Documentation/devicetree/bindings/arm/altera.yaml
> > +++ b/Documentation/devicetree/bindings/arm/altera.yaml
> > @@ -32,6 +32,7 @@ properties:
> >          items:
> >            - enum:
> >                - google,chameleon-v3
> > +              - enclustra,mercury-pe1
> 
> Messed order, keep alphabetical order.
> 
> >            - const: enclustra,mercury-aa1
> >            - const: altr,socfpga-arria10
> >            - const: altr,socfpga
> 

Ack.

Thanks,
Steffen Trumtrar

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-02-07 12:48 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-07  9:41 [PATCH 1/2] ARM: dts: socfpga: Add enclustra PE1 devicetree Steffen Trumtrar
2023-02-07  9:41 ` Steffen Trumtrar
2023-02-07  9:41 ` [PATCH 2/2] dt-bindings: altera: Add enclustra mercury PE1 Steffen Trumtrar
2023-02-07  9:41   ` Steffen Trumtrar
2023-02-07 10:48   ` Krzysztof Kozlowski
2023-02-07 10:48     ` Krzysztof Kozlowski
2023-02-07 12:47     ` Steffen Trumtrar
2023-02-07 12:47       ` Steffen Trumtrar
2023-02-07 10:49 ` [PATCH 1/2] ARM: dts: socfpga: Add enclustra PE1 devicetree Krzysztof Kozlowski
2023-02-07 10:49   ` Krzysztof Kozlowski
2023-02-07 12:46   ` Steffen Trumtrar
2023-02-07 12:46     ` Steffen Trumtrar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.