* [PATCH] dt-bindings: mt76: allow up to 4 interrupts for mt7986
@ 2023-02-07 17:15 ` Frank Wunderlich
0 siblings, 0 replies; 6+ messages in thread
From: Frank Wunderlich @ 2023-02-07 17:15 UTC (permalink / raw)
To: linux-mediatek
Cc: devicetree, Ryder Lee, netdev, Kalle Valo, Sean Wang,
linux-wireless, linux-kernel, Rob Herring, Eric Dumazet,
Paolo Abeni, Krzysztof Kozlowski, Matthias Brugger,
Jakub Kicinski, Shayne Chen, Lorenzo Bianconi, David S. Miller,
linux-arm-kernel, Felix Fietkau
From: Frank Wunderlich <frank-w@public-files.de>
Mt7986 needs 4 interrupts which are already defined in mt7986a.dtsi.
Update binding to reflect it
This fixes this error in dtbs_check (here only bpi-r3 example):
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: wifi@18000000:
interrupts: [[0, 213, 4], [0, 214, 4], [0, 215, 4], [0, 216, 4]] is too long
From schema: Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: wifi@18000000:
Unevaluated properties are not allowed ('interrupts' was unexpected)
From schema: Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
.../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index 212508672979..222b657fe4ea 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -38,7 +38,10 @@ properties:
MT7986 should contain 3 regions consys, dcm, and sku, in this order.
interrupts:
- maxItems: 1
+ minItems: 1
+ maxItems: 4
+ description:
+ MT7986 should contain 4 items.
power-domains:
maxItems: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] dt-bindings: mt76: allow up to 4 interrupts for mt7986
@ 2023-02-07 17:15 ` Frank Wunderlich
0 siblings, 0 replies; 6+ messages in thread
From: Frank Wunderlich @ 2023-02-07 17:15 UTC (permalink / raw)
To: linux-mediatek
Cc: Frank Wunderlich, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Kalle Valo, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring,
Krzysztof Kozlowski, Matthias Brugger, linux-wireless, netdev,
devicetree, linux-arm-kernel, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
Mt7986 needs 4 interrupts which are already defined in mt7986a.dtsi.
Update binding to reflect it
This fixes this error in dtbs_check (here only bpi-r3 example):
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: wifi@18000000:
interrupts: [[0, 213, 4], [0, 214, 4], [0, 215, 4], [0, 216, 4]] is too long
From schema: Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: wifi@18000000:
Unevaluated properties are not allowed ('interrupts' was unexpected)
From schema: Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
.../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index 212508672979..222b657fe4ea 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -38,7 +38,10 @@ properties:
MT7986 should contain 3 regions consys, dcm, and sku, in this order.
interrupts:
- maxItems: 1
+ minItems: 1
+ maxItems: 4
+ description:
+ MT7986 should contain 4 items.
power-domains:
maxItems: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] dt-bindings: mt76: allow up to 4 interrupts for mt7986
@ 2023-02-07 17:15 ` Frank Wunderlich
0 siblings, 0 replies; 6+ messages in thread
From: Frank Wunderlich @ 2023-02-07 17:15 UTC (permalink / raw)
To: linux-mediatek
Cc: Frank Wunderlich, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Kalle Valo, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring,
Krzysztof Kozlowski, Matthias Brugger, linux-wireless, netdev,
devicetree, linux-arm-kernel, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
Mt7986 needs 4 interrupts which are already defined in mt7986a.dtsi.
Update binding to reflect it
This fixes this error in dtbs_check (here only bpi-r3 example):
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: wifi@18000000:
interrupts: [[0, 213, 4], [0, 214, 4], [0, 215, 4], [0, 216, 4]] is too long
From schema: Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: wifi@18000000:
Unevaluated properties are not allowed ('interrupts' was unexpected)
From schema: Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
.../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index 212508672979..222b657fe4ea 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -38,7 +38,10 @@ properties:
MT7986 should contain 3 regions consys, dcm, and sku, in this order.
interrupts:
- maxItems: 1
+ minItems: 1
+ maxItems: 4
+ description:
+ MT7986 should contain 4 items.
power-domains:
maxItems: 1
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: mt76: allow up to 4 interrupts for mt7986
2023-02-07 17:15 ` Frank Wunderlich
(?)
@ 2023-02-08 23:48 ` Rob Herring
-1 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-02-08 23:48 UTC (permalink / raw)
To: Frank Wunderlich
Cc: linux-mediatek, Frank Wunderlich, Felix Fietkau,
Lorenzo Bianconi, Ryder Lee, Shayne Chen, Sean Wang, Kalle Valo,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Krzysztof Kozlowski, Matthias Brugger, linux-wireless, netdev,
devicetree, linux-arm-kernel, linux-kernel
On Tue, Feb 07, 2023 at 06:15:12PM +0100, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Mt7986 needs 4 interrupts which are already defined in mt7986a.dtsi.
> Update binding to reflect it
>
> This fixes this error in dtbs_check (here only bpi-r3 example):
>
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: wifi@18000000:
> interrupts: [[0, 213, 4], [0, 214, 4], [0, 215, 4], [0, 216, 4]] is too long
> From schema: Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: wifi@18000000:
> Unevaluated properties are not allowed ('interrupts' was unexpected)
> From schema: Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index 212508672979..222b657fe4ea 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -38,7 +38,10 @@ properties:
> MT7986 should contain 3 regions consys, dcm, and sku, in this order.
>
> interrupts:
> - maxItems: 1
> + minItems: 1
> + maxItems: 4
> + description:
> + MT7986 should contain 4 items.
The schema and the description don't match.
You need to define what each interrupt is.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: mt76: allow up to 4 interrupts for mt7986
@ 2023-02-08 23:48 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-02-08 23:48 UTC (permalink / raw)
To: Frank Wunderlich
Cc: devicetree, Ryder Lee, netdev, Kalle Valo, Sean Wang,
linux-wireless, linux-kernel, Eric Dumazet, Paolo Abeni,
linux-mediatek, Krzysztof Kozlowski, Matthias Brugger,
Jakub Kicinski, Shayne Chen, Lorenzo Bianconi, David S. Miller,
linux-arm-kernel, Felix Fietkau
On Tue, Feb 07, 2023 at 06:15:12PM +0100, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Mt7986 needs 4 interrupts which are already defined in mt7986a.dtsi.
> Update binding to reflect it
>
> This fixes this error in dtbs_check (here only bpi-r3 example):
>
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: wifi@18000000:
> interrupts: [[0, 213, 4], [0, 214, 4], [0, 215, 4], [0, 216, 4]] is too long
> From schema: Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: wifi@18000000:
> Unevaluated properties are not allowed ('interrupts' was unexpected)
> From schema: Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index 212508672979..222b657fe4ea 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -38,7 +38,10 @@ properties:
> MT7986 should contain 3 regions consys, dcm, and sku, in this order.
>
> interrupts:
> - maxItems: 1
> + minItems: 1
> + maxItems: 4
> + description:
> + MT7986 should contain 4 items.
The schema and the description don't match.
You need to define what each interrupt is.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: mt76: allow up to 4 interrupts for mt7986
@ 2023-02-08 23:48 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-02-08 23:48 UTC (permalink / raw)
To: Frank Wunderlich
Cc: linux-mediatek, Frank Wunderlich, Felix Fietkau,
Lorenzo Bianconi, Ryder Lee, Shayne Chen, Sean Wang, Kalle Valo,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Krzysztof Kozlowski, Matthias Brugger, linux-wireless, netdev,
devicetree, linux-arm-kernel, linux-kernel
On Tue, Feb 07, 2023 at 06:15:12PM +0100, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Mt7986 needs 4 interrupts which are already defined in mt7986a.dtsi.
> Update binding to reflect it
>
> This fixes this error in dtbs_check (here only bpi-r3 example):
>
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: wifi@18000000:
> interrupts: [[0, 213, 4], [0, 214, 4], [0, 215, 4], [0, 216, 4]] is too long
> From schema: Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: wifi@18000000:
> Unevaluated properties are not allowed ('interrupts' was unexpected)
> From schema: Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index 212508672979..222b657fe4ea 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -38,7 +38,10 @@ properties:
> MT7986 should contain 3 regions consys, dcm, and sku, in this order.
>
> interrupts:
> - maxItems: 1
> + minItems: 1
> + maxItems: 4
> + description:
> + MT7986 should contain 4 items.
The schema and the description don't match.
You need to define what each interrupt is.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-02-08 23:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-07 17:15 [PATCH] dt-bindings: mt76: allow up to 4 interrupts for mt7986 Frank Wunderlich
2023-02-07 17:15 ` Frank Wunderlich
2023-02-07 17:15 ` Frank Wunderlich
2023-02-08 23:48 ` Rob Herring
2023-02-08 23:48 ` Rob Herring
2023-02-08 23:48 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.