From: Pekka Paalanen <ppaalanen@gmail.com> To: Joshua Ashton <joshua@froggi.es> Cc: Sebastian Wick <sebastian.wick@redhat.com>, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Uma Shankar <uma.shankar@intel.com>, Vitaly.Prosyak@amd.com Subject: Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum Date: Wed, 8 Feb 2023 11:30:41 +0200 [thread overview] Message-ID: <20230208113041.70691449@eldfell> (raw) In-Reply-To: <20230203020744.30745-3-joshua@froggi.es> [-- Attachment #1: Type: text/plain, Size: 9084 bytes --] On Fri, 3 Feb 2023 02:07:44 +0000 Joshua Ashton <joshua@froggi.es> wrote: > Userspace has no way of controlling or knowing the pixel encoding > currently, so there is no way for it to ever get the right values here. > > When we do add pixel_encoding control from userspace,we can pick the > right value for the colorimetry packet based on the > pixel_encoding + the colorspace. > > Let's deprecate these values, and have one BT.2020 colorspace entry > that userspace can use. > > Note: _CYCC was effectively 'removed' by this change, but that was not > possible to be taken advantage of anyway, as there is currently no > pixel_encoding control so it would not be possible to output > linear YCbCr. > > Signed-off-by: Joshua Ashton <joshua@froggi.es> > > Cc: Pekka Paalanen <ppaalanen@gmail.com> > Cc: Sebastian Wick <sebastian.wick@redhat.com> > Cc: Vitaly.Prosyak@amd.com > Cc: Uma Shankar <uma.shankar@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Joshua Ashton <joshua@froggi.es> > Cc: dri-devel@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > --- > drivers/gpu/drm/display/drm_hdmi_helper.c | 9 ++++----- > drivers/gpu/drm/drm_connector.c | 12 ++++++------ > drivers/gpu/drm/i915/display/intel_dp.c | 20 +++++++++----------- > include/drm/drm_connector.h | 19 ++++++++++--------- > 4 files changed, 29 insertions(+), 31 deletions(-) > > diff --git a/drivers/gpu/drm/display/drm_hdmi_helper.c b/drivers/gpu/drm/display/drm_hdmi_helper.c > index 0264abe55278..c85860600395 100644 > --- a/drivers/gpu/drm/display/drm_hdmi_helper.c > +++ b/drivers/gpu/drm/display/drm_hdmi_helper.c > @@ -99,8 +99,7 @@ EXPORT_SYMBOL(drm_hdmi_infoframe_set_hdr_metadata); > #define HDMI_COLORIMETRY_OPYCC_601 (C(3) | EC(3) | ACE(0)) > #define HDMI_COLORIMETRY_OPRGB (C(3) | EC(4) | ACE(0)) > #define HDMI_COLORIMETRY_BT2020_CYCC (C(3) | EC(5) | ACE(0)) > -#define HDMI_COLORIMETRY_BT2020_RGB (C(3) | EC(6) | ACE(0)) > -#define HDMI_COLORIMETRY_BT2020_YCC (C(3) | EC(6) | ACE(0)) > +#define HDMI_COLORIMETRY_BT2020 (C(3) | EC(6) | ACE(0)) > #define HDMI_COLORIMETRY_DCI_P3_RGB_D65 (C(3) | EC(7) | ACE(0)) > #define HDMI_COLORIMETRY_DCI_P3_RGB_THEATER (C(3) | EC(7) | ACE(1)) > > @@ -113,9 +112,9 @@ static const u32 hdmi_colorimetry_val[] = { > [DRM_MODE_COLORIMETRY_SYCC_601] = HDMI_COLORIMETRY_SYCC_601, > [DRM_MODE_COLORIMETRY_OPYCC_601] = HDMI_COLORIMETRY_OPYCC_601, > [DRM_MODE_COLORIMETRY_OPRGB] = HDMI_COLORIMETRY_OPRGB, > - [DRM_MODE_COLORIMETRY_BT2020_CYCC] = HDMI_COLORIMETRY_BT2020_CYCC, > - [DRM_MODE_COLORIMETRY_BT2020_RGB] = HDMI_COLORIMETRY_BT2020_RGB, > - [DRM_MODE_COLORIMETRY_BT2020_YCC] = HDMI_COLORIMETRY_BT2020_YCC, > + [DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_1] = HDMI_COLORIMETRY_BT2020, > + [DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_2] = HDMI_COLORIMETRY_BT2020, > + [DRM_MODE_COLORIMETRY_BT2020] = HDMI_COLORIMETRY_BT2020, > }; > > #undef C > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index 61c29ce74b03..58699ab15a6a 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -1029,11 +1029,11 @@ static const struct drm_prop_enum_list hdmi_colorspaces[] = { > /* Colorimetry based on IEC 61966-2-5 */ > { DRM_MODE_COLORIMETRY_OPRGB, "opRGB" }, > /* Colorimetry based on ITU-R BT.2020 */ > - { DRM_MODE_COLORIMETRY_BT2020_CYCC, "BT2020_CYCC" }, > + { DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_1, "BT2020_DEPRECATED_1" }, > /* Colorimetry based on ITU-R BT.2020 */ > - { DRM_MODE_COLORIMETRY_BT2020_RGB, "BT2020_RGB" }, > + { DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_2, "BT2020_DEPRECATED_2" }, > /* Colorimetry based on ITU-R BT.2020 */ > - { DRM_MODE_COLORIMETRY_BT2020_YCC, "BT2020_YCC" }, > + { DRM_MODE_COLORIMETRY_BT2020, "BT2020" }, > /* Added as part of Additional Colorimetry Extension in 861.G */ > { DRM_MODE_COLORIMETRY_DCI_P3_RGB_D65, "DCI-P3_RGB_D65" }, > { DRM_MODE_COLORIMETRY_DCI_P3_RGB_THEATER, "DCI-P3_RGB_Theater" }, > @@ -1054,7 +1054,7 @@ static const struct drm_prop_enum_list dp_colorspaces[] = { > /* Colorimetry based on SMPTE RP 431-2 */ > { DRM_MODE_COLORIMETRY_DCI_P3_RGB_D65, "DCI-P3_RGB_D65" }, > /* Colorimetry based on ITU-R BT.2020 */ > - { DRM_MODE_COLORIMETRY_BT2020_RGB, "BT2020_RGB" }, > + { DRM_MODE_COLORIMETRY_BT2020, "BT2020" }, > { DRM_MODE_COLORIMETRY_BT601_YCC, "BT601_YCC" }, > { DRM_MODE_COLORIMETRY_BT709_YCC, "BT709_YCC" }, > /* Standard Definition Colorimetry based on IEC 61966-2-4 */ > @@ -1066,9 +1066,9 @@ static const struct drm_prop_enum_list dp_colorspaces[] = { > /* Colorimetry based on IEC 61966-2-5 [33] */ > { DRM_MODE_COLORIMETRY_OPYCC_601, "opYCC_601" }, > /* Colorimetry based on ITU-R BT.2020 */ > - { DRM_MODE_COLORIMETRY_BT2020_CYCC, "BT2020_CYCC" }, > + { DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_1, "BT2020_DEPRECATED_1" }, > /* Colorimetry based on ITU-R BT.2020 */ > - { DRM_MODE_COLORIMETRY_BT2020_YCC, "BT2020_YCC" }, > + { DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_2, "BT2020_DEPRECATED_2" }, > }; Hi, do these not rename the old uAPI strings? Shouldn't the old strings be kept? It's much easier to scream "kernel regression" when the expected string is no longer found than a subtle change in behaviour that might not even be a change. ;-) If there is not going to be a difference in behaviour, the enum could expose e.g. all of "BT2020_RGB", "BT2020_CYCC" and "BT2020_YCC" as the same integer value. If old userspace exists, it would not notice any difference. I mean, the *strings* are the uAPI, not the integers, right? Thanks, pq > > /** > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index c9be61d2348e..1aa5dedeec7b 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -1763,14 +1763,12 @@ static void intel_dp_compute_vsc_colorimetry(const struct intel_crtc_state *crtc > case DRM_MODE_COLORIMETRY_OPYCC_601: > vsc->colorimetry = DP_COLORIMETRY_OPYCC_601; > break; > - case DRM_MODE_COLORIMETRY_BT2020_CYCC: > - vsc->colorimetry = DP_COLORIMETRY_BT2020_CYCC; > - break; > - case DRM_MODE_COLORIMETRY_BT2020_RGB: > - vsc->colorimetry = DP_COLORIMETRY_BT2020_RGB; > - break; > - case DRM_MODE_COLORIMETRY_BT2020_YCC: > - vsc->colorimetry = DP_COLORIMETRY_BT2020_YCC; > + case DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_1: > + case DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_2: > + case DRM_MODE_COLORIMETRY_BT2020: > + vsc->colorimetry = vsc->pixelformat == DP_PIXELFORMAT_RGB > + ? DP_COLORIMETRY_BT2020_RGB > + : DP_COLORIMETRY_BT2020_YCC; > break; > case DRM_MODE_COLORIMETRY_DCI_P3_RGB_D65: > case DRM_MODE_COLORIMETRY_DCI_P3_RGB_THEATER: > @@ -3043,9 +3041,9 @@ intel_dp_needs_vsc_sdp(const struct intel_crtc_state *crtc_state, > switch (conn_state->colorspace) { > case DRM_MODE_COLORIMETRY_SYCC_601: > case DRM_MODE_COLORIMETRY_OPYCC_601: > - case DRM_MODE_COLORIMETRY_BT2020_YCC: > - case DRM_MODE_COLORIMETRY_BT2020_RGB: > - case DRM_MODE_COLORIMETRY_BT2020_CYCC: > + case DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_1: > + case DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_2: > + case DRM_MODE_COLORIMETRY_BT2020: > return true; > default: > break; > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index eb4cc9076e16..42a3cf43168c 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -390,12 +390,13 @@ enum drm_privacy_screen_status { > * opYCC601 colorimetry format > * @DRM_MODE_COLORIMETRY_OPRGB: > * opRGB colorimetry format > - * @DRM_MODE_COLORIMETRY_BT2020_CYCC: > - * ITU-R BT.2020 Y'c C'bc C'rc (linear) colorimetry format > - * @DRM_MODE_COLORIMETRY_BT2020_RGB: > - * ITU-R BT.2020 R' G' B' colorimetry format > - * @DRM_MODE_COLORIMETRY_BT2020_YCC: > - * ITU-R BT.2020 Y' C'b C'r colorimetry format > + * @DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_1: > + * @DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_2: > + * @DRM_MODE_COLORIMETRY_BT2020: > + * ITU-R BT.2020 [R' G' B'] or > + * ITU-R BT.2020 [Y' C'b C'r] or > + * ITU-R BT.2020 [Y'c C'bc C'rc] (linear) > + * colorimetry format > * @DRM_MODE_COLORIMETRY_DCI_P3_RGB_D65: > * DCI-P3 (SMPTE RP 431-2) colorimetry format > * @DRM_MODE_COLORIMETRY_DCI_P3_RGB_THEATER: > @@ -420,9 +421,9 @@ enum drm_colorspace { > DRM_MODE_COLORIMETRY_SYCC_601, > DRM_MODE_COLORIMETRY_OPYCC_601, > DRM_MODE_COLORIMETRY_OPRGB, > - DRM_MODE_COLORIMETRY_BT2020_CYCC, > - DRM_MODE_COLORIMETRY_BT2020_RGB, > - DRM_MODE_COLORIMETRY_BT2020_YCC, > + DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_1, > + DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_2, > + DRM_MODE_COLORIMETRY_BT2020, > /* Additional Colorimetry extension added as part of CTA 861.G */ > DRM_MODE_COLORIMETRY_DCI_P3_RGB_D65, > DRM_MODE_COLORIMETRY_DCI_P3_RGB_THEATER, [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pekka Paalanen <ppaalanen@gmail.com> To: Joshua Ashton <joshua@froggi.es> Cc: "Sebastian Wick" <sebastian.wick@redhat.com>, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, "Uma Shankar" <uma.shankar@intel.com>, Vitaly.Prosyak@amd.com, "Ville Syrjälä" <ville.syrjala@linux.intel.com> Subject: Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum Date: Wed, 8 Feb 2023 11:30:41 +0200 [thread overview] Message-ID: <20230208113041.70691449@eldfell> (raw) In-Reply-To: <20230203020744.30745-3-joshua@froggi.es> [-- Attachment #1: Type: text/plain, Size: 9084 bytes --] On Fri, 3 Feb 2023 02:07:44 +0000 Joshua Ashton <joshua@froggi.es> wrote: > Userspace has no way of controlling or knowing the pixel encoding > currently, so there is no way for it to ever get the right values here. > > When we do add pixel_encoding control from userspace,we can pick the > right value for the colorimetry packet based on the > pixel_encoding + the colorspace. > > Let's deprecate these values, and have one BT.2020 colorspace entry > that userspace can use. > > Note: _CYCC was effectively 'removed' by this change, but that was not > possible to be taken advantage of anyway, as there is currently no > pixel_encoding control so it would not be possible to output > linear YCbCr. > > Signed-off-by: Joshua Ashton <joshua@froggi.es> > > Cc: Pekka Paalanen <ppaalanen@gmail.com> > Cc: Sebastian Wick <sebastian.wick@redhat.com> > Cc: Vitaly.Prosyak@amd.com > Cc: Uma Shankar <uma.shankar@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Joshua Ashton <joshua@froggi.es> > Cc: dri-devel@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > --- > drivers/gpu/drm/display/drm_hdmi_helper.c | 9 ++++----- > drivers/gpu/drm/drm_connector.c | 12 ++++++------ > drivers/gpu/drm/i915/display/intel_dp.c | 20 +++++++++----------- > include/drm/drm_connector.h | 19 ++++++++++--------- > 4 files changed, 29 insertions(+), 31 deletions(-) > > diff --git a/drivers/gpu/drm/display/drm_hdmi_helper.c b/drivers/gpu/drm/display/drm_hdmi_helper.c > index 0264abe55278..c85860600395 100644 > --- a/drivers/gpu/drm/display/drm_hdmi_helper.c > +++ b/drivers/gpu/drm/display/drm_hdmi_helper.c > @@ -99,8 +99,7 @@ EXPORT_SYMBOL(drm_hdmi_infoframe_set_hdr_metadata); > #define HDMI_COLORIMETRY_OPYCC_601 (C(3) | EC(3) | ACE(0)) > #define HDMI_COLORIMETRY_OPRGB (C(3) | EC(4) | ACE(0)) > #define HDMI_COLORIMETRY_BT2020_CYCC (C(3) | EC(5) | ACE(0)) > -#define HDMI_COLORIMETRY_BT2020_RGB (C(3) | EC(6) | ACE(0)) > -#define HDMI_COLORIMETRY_BT2020_YCC (C(3) | EC(6) | ACE(0)) > +#define HDMI_COLORIMETRY_BT2020 (C(3) | EC(6) | ACE(0)) > #define HDMI_COLORIMETRY_DCI_P3_RGB_D65 (C(3) | EC(7) | ACE(0)) > #define HDMI_COLORIMETRY_DCI_P3_RGB_THEATER (C(3) | EC(7) | ACE(1)) > > @@ -113,9 +112,9 @@ static const u32 hdmi_colorimetry_val[] = { > [DRM_MODE_COLORIMETRY_SYCC_601] = HDMI_COLORIMETRY_SYCC_601, > [DRM_MODE_COLORIMETRY_OPYCC_601] = HDMI_COLORIMETRY_OPYCC_601, > [DRM_MODE_COLORIMETRY_OPRGB] = HDMI_COLORIMETRY_OPRGB, > - [DRM_MODE_COLORIMETRY_BT2020_CYCC] = HDMI_COLORIMETRY_BT2020_CYCC, > - [DRM_MODE_COLORIMETRY_BT2020_RGB] = HDMI_COLORIMETRY_BT2020_RGB, > - [DRM_MODE_COLORIMETRY_BT2020_YCC] = HDMI_COLORIMETRY_BT2020_YCC, > + [DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_1] = HDMI_COLORIMETRY_BT2020, > + [DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_2] = HDMI_COLORIMETRY_BT2020, > + [DRM_MODE_COLORIMETRY_BT2020] = HDMI_COLORIMETRY_BT2020, > }; > > #undef C > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index 61c29ce74b03..58699ab15a6a 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -1029,11 +1029,11 @@ static const struct drm_prop_enum_list hdmi_colorspaces[] = { > /* Colorimetry based on IEC 61966-2-5 */ > { DRM_MODE_COLORIMETRY_OPRGB, "opRGB" }, > /* Colorimetry based on ITU-R BT.2020 */ > - { DRM_MODE_COLORIMETRY_BT2020_CYCC, "BT2020_CYCC" }, > + { DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_1, "BT2020_DEPRECATED_1" }, > /* Colorimetry based on ITU-R BT.2020 */ > - { DRM_MODE_COLORIMETRY_BT2020_RGB, "BT2020_RGB" }, > + { DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_2, "BT2020_DEPRECATED_2" }, > /* Colorimetry based on ITU-R BT.2020 */ > - { DRM_MODE_COLORIMETRY_BT2020_YCC, "BT2020_YCC" }, > + { DRM_MODE_COLORIMETRY_BT2020, "BT2020" }, > /* Added as part of Additional Colorimetry Extension in 861.G */ > { DRM_MODE_COLORIMETRY_DCI_P3_RGB_D65, "DCI-P3_RGB_D65" }, > { DRM_MODE_COLORIMETRY_DCI_P3_RGB_THEATER, "DCI-P3_RGB_Theater" }, > @@ -1054,7 +1054,7 @@ static const struct drm_prop_enum_list dp_colorspaces[] = { > /* Colorimetry based on SMPTE RP 431-2 */ > { DRM_MODE_COLORIMETRY_DCI_P3_RGB_D65, "DCI-P3_RGB_D65" }, > /* Colorimetry based on ITU-R BT.2020 */ > - { DRM_MODE_COLORIMETRY_BT2020_RGB, "BT2020_RGB" }, > + { DRM_MODE_COLORIMETRY_BT2020, "BT2020" }, > { DRM_MODE_COLORIMETRY_BT601_YCC, "BT601_YCC" }, > { DRM_MODE_COLORIMETRY_BT709_YCC, "BT709_YCC" }, > /* Standard Definition Colorimetry based on IEC 61966-2-4 */ > @@ -1066,9 +1066,9 @@ static const struct drm_prop_enum_list dp_colorspaces[] = { > /* Colorimetry based on IEC 61966-2-5 [33] */ > { DRM_MODE_COLORIMETRY_OPYCC_601, "opYCC_601" }, > /* Colorimetry based on ITU-R BT.2020 */ > - { DRM_MODE_COLORIMETRY_BT2020_CYCC, "BT2020_CYCC" }, > + { DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_1, "BT2020_DEPRECATED_1" }, > /* Colorimetry based on ITU-R BT.2020 */ > - { DRM_MODE_COLORIMETRY_BT2020_YCC, "BT2020_YCC" }, > + { DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_2, "BT2020_DEPRECATED_2" }, > }; Hi, do these not rename the old uAPI strings? Shouldn't the old strings be kept? It's much easier to scream "kernel regression" when the expected string is no longer found than a subtle change in behaviour that might not even be a change. ;-) If there is not going to be a difference in behaviour, the enum could expose e.g. all of "BT2020_RGB", "BT2020_CYCC" and "BT2020_YCC" as the same integer value. If old userspace exists, it would not notice any difference. I mean, the *strings* are the uAPI, not the integers, right? Thanks, pq > > /** > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index c9be61d2348e..1aa5dedeec7b 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -1763,14 +1763,12 @@ static void intel_dp_compute_vsc_colorimetry(const struct intel_crtc_state *crtc > case DRM_MODE_COLORIMETRY_OPYCC_601: > vsc->colorimetry = DP_COLORIMETRY_OPYCC_601; > break; > - case DRM_MODE_COLORIMETRY_BT2020_CYCC: > - vsc->colorimetry = DP_COLORIMETRY_BT2020_CYCC; > - break; > - case DRM_MODE_COLORIMETRY_BT2020_RGB: > - vsc->colorimetry = DP_COLORIMETRY_BT2020_RGB; > - break; > - case DRM_MODE_COLORIMETRY_BT2020_YCC: > - vsc->colorimetry = DP_COLORIMETRY_BT2020_YCC; > + case DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_1: > + case DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_2: > + case DRM_MODE_COLORIMETRY_BT2020: > + vsc->colorimetry = vsc->pixelformat == DP_PIXELFORMAT_RGB > + ? DP_COLORIMETRY_BT2020_RGB > + : DP_COLORIMETRY_BT2020_YCC; > break; > case DRM_MODE_COLORIMETRY_DCI_P3_RGB_D65: > case DRM_MODE_COLORIMETRY_DCI_P3_RGB_THEATER: > @@ -3043,9 +3041,9 @@ intel_dp_needs_vsc_sdp(const struct intel_crtc_state *crtc_state, > switch (conn_state->colorspace) { > case DRM_MODE_COLORIMETRY_SYCC_601: > case DRM_MODE_COLORIMETRY_OPYCC_601: > - case DRM_MODE_COLORIMETRY_BT2020_YCC: > - case DRM_MODE_COLORIMETRY_BT2020_RGB: > - case DRM_MODE_COLORIMETRY_BT2020_CYCC: > + case DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_1: > + case DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_2: > + case DRM_MODE_COLORIMETRY_BT2020: > return true; > default: > break; > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index eb4cc9076e16..42a3cf43168c 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -390,12 +390,13 @@ enum drm_privacy_screen_status { > * opYCC601 colorimetry format > * @DRM_MODE_COLORIMETRY_OPRGB: > * opRGB colorimetry format > - * @DRM_MODE_COLORIMETRY_BT2020_CYCC: > - * ITU-R BT.2020 Y'c C'bc C'rc (linear) colorimetry format > - * @DRM_MODE_COLORIMETRY_BT2020_RGB: > - * ITU-R BT.2020 R' G' B' colorimetry format > - * @DRM_MODE_COLORIMETRY_BT2020_YCC: > - * ITU-R BT.2020 Y' C'b C'r colorimetry format > + * @DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_1: > + * @DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_2: > + * @DRM_MODE_COLORIMETRY_BT2020: > + * ITU-R BT.2020 [R' G' B'] or > + * ITU-R BT.2020 [Y' C'b C'r] or > + * ITU-R BT.2020 [Y'c C'bc C'rc] (linear) > + * colorimetry format > * @DRM_MODE_COLORIMETRY_DCI_P3_RGB_D65: > * DCI-P3 (SMPTE RP 431-2) colorimetry format > * @DRM_MODE_COLORIMETRY_DCI_P3_RGB_THEATER: > @@ -420,9 +421,9 @@ enum drm_colorspace { > DRM_MODE_COLORIMETRY_SYCC_601, > DRM_MODE_COLORIMETRY_OPYCC_601, > DRM_MODE_COLORIMETRY_OPRGB, > - DRM_MODE_COLORIMETRY_BT2020_CYCC, > - DRM_MODE_COLORIMETRY_BT2020_RGB, > - DRM_MODE_COLORIMETRY_BT2020_YCC, > + DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_1, > + DRM_MODE_COLORIMETRY_BT2020_DEPRECATED_2, > + DRM_MODE_COLORIMETRY_BT2020, > /* Additional Colorimetry extension added as part of CTA 861.G */ > DRM_MODE_COLORIMETRY_DCI_P3_RGB_D65, > DRM_MODE_COLORIMETRY_DCI_P3_RGB_THEATER, [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-02-08 9:30 UTC|newest] Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-03 2:07 [PATCH 1/3] drm/connector: Convert DRM_MODE_COLORIMETRY to enum Joshua Ashton 2023-02-03 2:07 ` Joshua Ashton 2023-02-03 2:07 ` [PATCH 2/3] drm/connector: Add enum documentation to drm_colorspace Joshua Ashton 2023-02-03 2:07 ` Joshua Ashton 2023-02-08 8:56 ` Pekka Paalanen 2023-02-08 8:56 ` Pekka Paalanen 2023-02-16 21:22 ` Harry Wentland 2023-02-16 21:22 ` Harry Wentland 2023-02-03 2:07 ` [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum Joshua Ashton 2023-02-03 2:07 ` Joshua Ashton 2023-02-03 10:39 ` Ville Syrjälä 2023-02-03 12:59 ` Sebastian Wick 2023-02-03 13:35 ` Ville Syrjälä 2023-02-03 13:52 ` Sebastian Wick 2023-02-03 14:02 ` Ville Syrjälä 2023-02-08 9:18 ` Pekka Paalanen 2023-02-08 14:49 ` Ville Syrjälä 2023-02-09 10:05 ` Pekka Paalanen 2023-02-09 10:05 ` Pekka Paalanen 2023-02-03 14:39 ` Harry Wentland 2023-02-03 15:19 ` Ville Syrjälä 2023-02-03 15:24 ` Harry Wentland 2023-02-03 16:00 ` Ville Syrjälä 2023-02-03 18:28 ` Harry Wentland 2023-02-03 18:56 ` Ville Syrjälä 2023-02-03 19:16 ` Harry Wentland 2023-02-03 19:25 ` Ville Syrjälä 2023-02-03 19:33 ` Harry Wentland 2023-02-08 10:03 ` Pekka Paalanen 2023-02-08 10:03 ` Pekka Paalanen 2023-02-03 19:34 ` Ville Syrjälä 2023-02-03 19:43 ` Harry Wentland 2023-02-04 6:09 ` Joshua Ashton 2023-02-06 9:47 ` Ville Syrjälä 2023-02-06 9:47 ` Ville Syrjälä 2023-02-06 17:16 ` Harry Wentland 2023-02-08 10:32 ` Pekka Paalanen 2023-02-08 10:32 ` Pekka Paalanen 2023-02-08 9:30 ` Pekka Paalanen 2023-02-08 9:30 ` Pekka Paalanen 2023-02-08 9:25 ` Pekka Paalanen 2023-02-08 9:25 ` Pekka Paalanen 2023-02-14 15:49 ` Sebastian Wick 2023-02-14 15:49 ` Sebastian Wick 2023-02-14 16:56 ` Harry Wentland 2023-02-14 19:45 ` Sebastian Wick 2023-02-14 19:45 ` Sebastian Wick 2023-02-14 20:04 ` Harry Wentland 2023-02-14 20:04 ` Harry Wentland 2023-02-15 9:40 ` Pekka Paalanen 2023-02-15 9:40 ` Pekka Paalanen 2023-02-15 20:45 ` Harry Wentland 2023-02-15 20:45 ` Harry Wentland 2023-02-14 20:10 ` Ville Syrjälä 2023-02-14 20:10 ` Ville Syrjälä 2023-02-14 21:18 ` Sebastian Wick 2023-02-14 21:18 ` Sebastian Wick 2023-02-14 21:27 ` Ville Syrjälä 2023-02-14 21:27 ` Ville Syrjälä 2023-02-15 10:01 ` Pekka Paalanen 2023-02-15 10:01 ` Pekka Paalanen 2023-02-15 10:33 ` Ville Syrjälä 2023-02-15 10:33 ` Ville Syrjälä 2023-02-15 11:46 ` Daniel Stone 2023-02-15 11:46 ` Daniel Stone 2023-02-15 20:54 ` Harry Wentland 2023-02-15 20:54 ` Harry Wentland 2023-02-15 22:07 ` Daniel Stone 2023-02-15 22:07 ` Daniel Stone 2023-02-03 14:52 ` Harry Wentland 2023-02-04 16:06 ` kernel test robot 2023-02-04 16:06 ` kernel test robot 2023-02-08 9:30 ` Pekka Paalanen [this message] 2023-02-08 9:30 ` Pekka Paalanen 2023-02-09 16:38 ` Joshua Ashton 2023-02-09 16:38 ` Joshua Ashton 2023-02-09 17:03 ` Simon Ser 2023-02-09 18:08 ` Ville Syrjälä 2023-02-10 9:37 ` Pekka Paalanen 2023-02-10 9:44 ` Simon Ser 2023-02-04 9:06 ` [PATCH 1/3] drm/connector: Convert DRM_MODE_COLORIMETRY to enum kernel test robot 2023-02-04 9:06 ` kernel test robot 2023-02-04 10:28 ` kernel test robot 2023-02-04 10:28 ` kernel test robot 2023-02-08 8:29 ` Pekka Paalanen 2023-02-08 8:29 ` Pekka Paalanen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230208113041.70691449@eldfell \ --to=ppaalanen@gmail.com \ --cc=Vitaly.Prosyak@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=joshua@froggi.es \ --cc=sebastian.wick@redhat.com \ --cc=uma.shankar@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.