Re: [Buildroot] [PATCH 1/1] board/raspberrypi4: bump kernel version to 5.15.68

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Athaariq,

On Mon, 26 Sep 2022 05:20:15 +0000 (UTC)
Athaariq Ardhiansyah <buildroot@athaariq.my.id> wrote:

> First of all, kernel support for Raspberry Pi is way too old relative to stable version. Second, we actually have several bug fixes regarding the kernel including HDMI hotplug and more problems on graphic stacks. However, I only have Raspberry Pi 4B so I cannot test the changes for other Raspberry Pi models. For anyone who has those boards, please help us to bump and test the kernel.
> 
> Signed-off-by: Athaariq Ardhiansyah <buildroot@athaariq.my.id>

Thanks for your patch. It would indeed be nice to update our
RaspberryPi defconfigs, but there are a number of questions which need
to be answered before we can apply your patch.

First of all, a small detail: your commit log must be wrapped at ~80
columns. Also, it shouldn't use 1st person sentence "I only have".

> diff --git a/board/raspberrypi/linux.fragment b/board/raspberrypi/linux.fragment
> new file mode 100644
> index 0000000000..798b2e91da
> --- /dev/null
> +++ b/board/raspberrypi/linux.fragment
> @@ -0,0 +1,7 @@
> +# Dynamic CPU Clock
> +CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE=n
> +CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
> +
> +# Fix Kernel Module won't Load
> +CONFIG_MODULE_COMPRESS_XZ=n
> +CONFIG_MODULE_COMPRESS_NONE=y

Why is this Linux kernel configuration fragment needed? There is no
explanation in your commit log. Changing the default CPU governor
should not be needed, and the second chunk about kernel module
compression is a bit strange and deserves some explanation.

> diff --git a/configs/raspberrypi4_64_defconfig b/configs/raspberrypi4_64_defconfig
> index 5942f7c4e1..6d90a8f004 100644
> --- a/configs/raspberrypi4_64_defconfig
> +++ b/configs/raspberrypi4_64_defconfig
> @@ -6,13 +6,14 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
>  
>  BR2_SYSTEM_DHCP="eth0"
>  
> -# Linux headers same as kernel, a 5.10 series
> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y
> +# Linux headers same as kernel, a 5.15 series
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
>  
>  BR2_LINUX_KERNEL=y
>  BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> -BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,0b54dbda3cca2beb51e236a25738784e90853b64)/linux-0b54dbda3cca2beb51e236a25738784e90853b64.tar.gz"
> +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,155b736f0ff883415d374ba743473f5ef146814b)/linux-155b736f0ff883415d374ba743473f5ef146814b.tar.gz"
>  BR2_LINUX_KERNEL_DEFCONFIG="bcm2711"
> +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/raspberrypi4-64/linux.fragment"
>  
>  # Build the DTB from the kernel sources
>  BR2_LINUX_KERNEL_DTS_SUPPORT=y
> @@ -23,6 +24,9 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
>  BR2_PACKAGE_RPI_FIRMWARE=y
>  BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4=y
>  BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi4-64/config_4_64bit.txt"
> +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI=y
> +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_BT=y
> +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_WIFI=y

Why is this being added?

>  # Required tools to create the SD image
>  BR2_PACKAGE_HOST_DOSFSTOOLS=y
> diff --git a/configs/raspberrypi4_defconfig b/configs/raspberrypi4_defconfig
> index 4e5580c140..f0947c329c 100644
> --- a/configs/raspberrypi4_defconfig
> +++ b/configs/raspberrypi4_defconfig
> @@ -6,13 +6,14 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
>  
>  BR2_SYSTEM_DHCP="eth0"
>  
> -# Linux headers same as kernel, a 5.10 series
> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y
> +# Linux headers same as kernel, a 5.15 series
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
>  
>  BR2_LINUX_KERNEL=y
>  BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> -BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,0b54dbda3cca2beb51e236a25738784e90853b64)/linux-0b54dbda3cca2beb51e236a25738784e90853b64.tar.gz"
> +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,155b736f0ff883415d374ba743473f5ef146814b)/linux-155b736f0ff883415d374ba743473f5ef146814b.tar.gz"
>  BR2_LINUX_KERNEL_DEFCONFIG="bcm2711"
> +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/raspberrypi4/linux.fragment"
>  
>  # Build the DTB from the kernel sources
>  BR2_LINUX_KERNEL_DTS_SUPPORT=y
> @@ -23,6 +24,10 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
>  BR2_PACKAGE_RPI_FIRMWARE=y
>  BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4=y
>  BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi4/config_4.txt"
> +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI=y
> +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_BT=y
> +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_WIFI=y
> +BR2_PACKAGE_RPI_USERLAND=y

Why is rpi-userland being added here, and not to the other defconfig above?

Also, you're updating rpi-firmware, rpi-userland and RaspberryPi
defconfigs in the same commit. Is this because they need to be updated
in sync? If that's the case, is there a potential problem if we update
rpi-firmware/rpi-userland, but not the defconfigs for RaspberryPi 1/2/3 ?

Thanks a lot for your feedback!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot