* [Buildroot] [PATCH 1/1] board/raspberrypi4: bump kernel version to 5.15.68
@ 2022-09-26 5:20 Athaariq Ardhiansyah
2023-02-08 13:46 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 5+ messages in thread
From: Athaariq Ardhiansyah @ 2022-09-26 5:20 UTC (permalink / raw)
To: buildroot; +Cc: Martin Bark, Julien Grossholtz, Mahyar Koshkouei
First of all, kernel support for Raspberry Pi is way too old relative to stable version. Second, we actually have several bug fixes regarding the kernel including HDMI hotplug and more problems on graphic stacks. However, I only have Raspberry Pi 4B so I cannot test the changes for other Raspberry Pi models. For anyone who has those boards, please help us to bump and test the kernel.
Signed-off-by: Athaariq Ardhiansyah <buildroot@athaariq.my.id>
---
board/raspberrypi/linux.fragment | 7 +++++++
configs/raspberrypi4_64_defconfig | 10 +++++++---
configs/raspberrypi4_defconfig | 11 ++++++++---
package/rpi-firmware/rpi-firmware.hash | 2 +-
package/rpi-firmware/rpi-firmware.mk | 2 +-
package/rpi-userland/rpi-userland.hash | 2 +-
package/rpi-userland/rpi-userland.mk | 2 +-
7 files changed, 26 insertions(+), 10 deletions(-)
create mode 100644 board/raspberrypi/linux.fragment
diff --git a/board/raspberrypi/linux.fragment b/board/raspberrypi/linux.fragment
new file mode 100644
index 0000000000..798b2e91da
--- /dev/null
+++ b/board/raspberrypi/linux.fragment
@@ -0,0 +1,7 @@
+# Dynamic CPU Clock
+CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE=n
+CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
+
+# Fix Kernel Module won't Load
+CONFIG_MODULE_COMPRESS_XZ=n
+CONFIG_MODULE_COMPRESS_NONE=y
diff --git a/configs/raspberrypi4_64_defconfig b/configs/raspberrypi4_64_defconfig
index 5942f7c4e1..6d90a8f004 100644
--- a/configs/raspberrypi4_64_defconfig
+++ b/configs/raspberrypi4_64_defconfig
@@ -6,13 +6,14 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_SYSTEM_DHCP="eth0"
-# Linux headers same as kernel, a 5.10 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y
+# Linux headers same as kernel, a 5.15 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
-BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,0b54dbda3cca2beb51e236a25738784e90853b64)/linux-0b54dbda3cca2beb51e236a25738784e90853b64.tar.gz"
+BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,155b736f0ff883415d374ba743473f5ef146814b)/linux-155b736f0ff883415d374ba743473f5ef146814b.tar.gz"
BR2_LINUX_KERNEL_DEFCONFIG="bcm2711"
+BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/raspberrypi4-64/linux.fragment"
# Build the DTB from the kernel sources
BR2_LINUX_KERNEL_DTS_SUPPORT=y
@@ -23,6 +24,9 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
BR2_PACKAGE_RPI_FIRMWARE=y
BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4=y
BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi4-64/config_4_64bit.txt"
+BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI=y
+BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_BT=y
+BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_WIFI=y
# Required tools to create the SD image
BR2_PACKAGE_HOST_DOSFSTOOLS=y
diff --git a/configs/raspberrypi4_defconfig b/configs/raspberrypi4_defconfig
index 4e5580c140..f0947c329c 100644
--- a/configs/raspberrypi4_defconfig
+++ b/configs/raspberrypi4_defconfig
@@ -6,13 +6,14 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_SYSTEM_DHCP="eth0"
-# Linux headers same as kernel, a 5.10 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y
+# Linux headers same as kernel, a 5.15 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
-BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,0b54dbda3cca2beb51e236a25738784e90853b64)/linux-0b54dbda3cca2beb51e236a25738784e90853b64.tar.gz"
+BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,155b736f0ff883415d374ba743473f5ef146814b)/linux-155b736f0ff883415d374ba743473f5ef146814b.tar.gz"
BR2_LINUX_KERNEL_DEFCONFIG="bcm2711"
+BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/raspberrypi4/linux.fragment"
# Build the DTB from the kernel sources
BR2_LINUX_KERNEL_DTS_SUPPORT=y
@@ -23,6 +24,10 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
BR2_PACKAGE_RPI_FIRMWARE=y
BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4=y
BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi4/config_4.txt"
+BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI=y
+BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_BT=y
+BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_WIFI=y
+BR2_PACKAGE_RPI_USERLAND=y
# Required tools to create the SD image
BR2_PACKAGE_HOST_DOSFSTOOLS=y
diff --git a/package/rpi-firmware/rpi-firmware.hash b/package/rpi-firmware/rpi-firmware.hash
index ec13115f3b..46acc06176 100644
--- a/package/rpi-firmware/rpi-firmware.hash
+++ b/package/rpi-firmware/rpi-firmware.hash
@@ -1,3 +1,3 @@
# Locally computed
-sha256 33aea2cb9c3be94c3dd6a96fbb3443eee5af1dc5fc9140e1fadc50832983064e rpi-firmware-3f20b832b27cd730deb6419b570f31a98167eef6.tar.gz
+sha256 f4da50526880b0731ef38d0d4fd3de8b80354f3b2c6bfceacd4f7861af8eafad rpi-firmware-ff5eaaa640ff1620b9eeff6650548eab619ae53a.tar.gz
sha256 c7283ff51f863d93a275c66e3b4cb08021a5dd4d8c1e7acc47d872fbe52d3d6b boot/LICENCE.broadcom
diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
index d4d1d07b3f..c1128b4228 100644
--- a/package/rpi-firmware/rpi-firmware.mk
+++ b/package/rpi-firmware/rpi-firmware.mk
@@ -4,7 +4,7 @@
#
################################################################################
-RPI_FIRMWARE_VERSION = 3f20b832b27cd730deb6419b570f31a98167eef6
+RPI_FIRMWARE_VERSION = ff5eaaa640ff1620b9eeff6650548eab619ae53a
RPI_FIRMWARE_SITE = $(call github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
RPI_FIRMWARE_LICENSE = BSD-3-Clause
RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom
diff --git a/package/rpi-userland/rpi-userland.hash b/package/rpi-userland/rpi-userland.hash
index b837cfe709..c35fbe4977 100644
--- a/package/rpi-userland/rpi-userland.hash
+++ b/package/rpi-userland/rpi-userland.hash
@@ -1,3 +1,3 @@
# Locally computed
-sha256 bb682f3c20bc5c7877531d5666c8dcc674a2f347aa792cf979dc0b07b6261e77 rpi-userland-14b90ff9d9f031391a299e6e006965d02bfd1bb1.tar.gz
+sha256 b5718b34730069b7c3748cefb528696267c5bf9ba1e12df4f668640c50849125 rpi-userland-54fd97ae4066a10b6b02089bc769ceed328737e0.tar.gz
sha256 bee6f1249175683d8610651706e1aa7dffcbfd3f9c4c05bc1e5ab34f313c2db5 LICENCE
diff --git a/package/rpi-userland/rpi-userland.mk b/package/rpi-userland/rpi-userland.mk
index 1204196e19..8552b6aa11 100644
--- a/package/rpi-userland/rpi-userland.mk
+++ b/package/rpi-userland/rpi-userland.mk
@@ -4,7 +4,7 @@
#
################################################################################
-RPI_USERLAND_VERSION = 14b90ff9d9f031391a299e6e006965d02bfd1bb1
+RPI_USERLAND_VERSION = 54fd97ae4066a10b6b02089bc769ceed328737e0
RPI_USERLAND_SITE = $(call github,raspberrypi,userland,$(RPI_USERLAND_VERSION))
RPI_USERLAND_LICENSE = BSD-3-Clause
RPI_USERLAND_LICENSE_FILES = LICENCE
--
2.37.3
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] board/raspberrypi4: bump kernel version to 5.15.68
2022-09-26 5:20 [Buildroot] [PATCH 1/1] board/raspberrypi4: bump kernel version to 5.15.68 Athaariq Ardhiansyah
@ 2023-02-08 13:46 ` Thomas Petazzoni via buildroot
2023-02-08 17:43 ` Peter Seiderer
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-02-08 13:46 UTC (permalink / raw)
To: Athaariq Ardhiansyah
Cc: Yann E. MORIN, Mahyar Koshkouei, Martin Bark, Julien Grossholtz,
buildroot
Hello Athaariq,
On Mon, 26 Sep 2022 05:20:15 +0000 (UTC)
Athaariq Ardhiansyah <buildroot@athaariq.my.id> wrote:
> First of all, kernel support for Raspberry Pi is way too old relative to stable version. Second, we actually have several bug fixes regarding the kernel including HDMI hotplug and more problems on graphic stacks. However, I only have Raspberry Pi 4B so I cannot test the changes for other Raspberry Pi models. For anyone who has those boards, please help us to bump and test the kernel.
>
> Signed-off-by: Athaariq Ardhiansyah <buildroot@athaariq.my.id>
Thanks for your patch. It would indeed be nice to update our
RaspberryPi defconfigs, but there are a number of questions which need
to be answered before we can apply your patch.
First of all, a small detail: your commit log must be wrapped at ~80
columns. Also, it shouldn't use 1st person sentence "I only have".
> diff --git a/board/raspberrypi/linux.fragment b/board/raspberrypi/linux.fragment
> new file mode 100644
> index 0000000000..798b2e91da
> --- /dev/null
> +++ b/board/raspberrypi/linux.fragment
> @@ -0,0 +1,7 @@
> +# Dynamic CPU Clock
> +CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE=n
> +CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
> +
> +# Fix Kernel Module won't Load
> +CONFIG_MODULE_COMPRESS_XZ=n
> +CONFIG_MODULE_COMPRESS_NONE=y
Why is this Linux kernel configuration fragment needed? There is no
explanation in your commit log. Changing the default CPU governor
should not be needed, and the second chunk about kernel module
compression is a bit strange and deserves some explanation.
> diff --git a/configs/raspberrypi4_64_defconfig b/configs/raspberrypi4_64_defconfig
> index 5942f7c4e1..6d90a8f004 100644
> --- a/configs/raspberrypi4_64_defconfig
> +++ b/configs/raspberrypi4_64_defconfig
> @@ -6,13 +6,14 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
>
> BR2_SYSTEM_DHCP="eth0"
>
> -# Linux headers same as kernel, a 5.10 series
> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y
> +# Linux headers same as kernel, a 5.15 series
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
>
> BR2_LINUX_KERNEL=y
> BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> -BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,0b54dbda3cca2beb51e236a25738784e90853b64)/linux-0b54dbda3cca2beb51e236a25738784e90853b64.tar.gz"
> +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,155b736f0ff883415d374ba743473f5ef146814b)/linux-155b736f0ff883415d374ba743473f5ef146814b.tar.gz"
> BR2_LINUX_KERNEL_DEFCONFIG="bcm2711"
> +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/raspberrypi4-64/linux.fragment"
>
> # Build the DTB from the kernel sources
> BR2_LINUX_KERNEL_DTS_SUPPORT=y
> @@ -23,6 +24,9 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> BR2_PACKAGE_RPI_FIRMWARE=y
> BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4=y
> BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi4-64/config_4_64bit.txt"
> +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI=y
> +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_BT=y
> +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_WIFI=y
Why is this being added?
> # Required tools to create the SD image
> BR2_PACKAGE_HOST_DOSFSTOOLS=y
> diff --git a/configs/raspberrypi4_defconfig b/configs/raspberrypi4_defconfig
> index 4e5580c140..f0947c329c 100644
> --- a/configs/raspberrypi4_defconfig
> +++ b/configs/raspberrypi4_defconfig
> @@ -6,13 +6,14 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
>
> BR2_SYSTEM_DHCP="eth0"
>
> -# Linux headers same as kernel, a 5.10 series
> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y
> +# Linux headers same as kernel, a 5.15 series
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
>
> BR2_LINUX_KERNEL=y
> BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> -BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,0b54dbda3cca2beb51e236a25738784e90853b64)/linux-0b54dbda3cca2beb51e236a25738784e90853b64.tar.gz"
> +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,155b736f0ff883415d374ba743473f5ef146814b)/linux-155b736f0ff883415d374ba743473f5ef146814b.tar.gz"
> BR2_LINUX_KERNEL_DEFCONFIG="bcm2711"
> +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/raspberrypi4/linux.fragment"
>
> # Build the DTB from the kernel sources
> BR2_LINUX_KERNEL_DTS_SUPPORT=y
> @@ -23,6 +24,10 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> BR2_PACKAGE_RPI_FIRMWARE=y
> BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4=y
> BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi4/config_4.txt"
> +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI=y
> +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_BT=y
> +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_WIFI=y
> +BR2_PACKAGE_RPI_USERLAND=y
Why is rpi-userland being added here, and not to the other defconfig above?
Also, you're updating rpi-firmware, rpi-userland and RaspberryPi
defconfigs in the same commit. Is this because they need to be updated
in sync? If that's the case, is there a potential problem if we update
rpi-firmware/rpi-userland, but not the defconfigs for RaspberryPi 1/2/3 ?
Thanks a lot for your feedback!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] board/raspberrypi4: bump kernel version to 5.15.68
2023-02-08 13:46 ` Thomas Petazzoni via buildroot
@ 2023-02-08 17:43 ` Peter Seiderer
2023-02-09 7:19 ` Peter Seiderer
0 siblings, 1 reply; 5+ messages in thread
From: Peter Seiderer @ 2023-02-08 17:43 UTC (permalink / raw)
To: Thomas Petazzoni via buildroot
Cc: Mahyar Koshkouei, Julien Grossholtz, Yann E. MORIN,
Thomas Petazzoni, Martin Bark
On Wed, 8 Feb 2023 14:46:39 +0100, Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:
> Hello Athaariq,
>
> On Mon, 26 Sep 2022 05:20:15 +0000 (UTC)
> Athaariq Ardhiansyah <buildroot@athaariq.my.id> wrote:
>
> > First of all, kernel support for Raspberry Pi is way too old relative to stable version. Second, we actually have several bug fixes regarding the kernel including HDMI hotplug and more problems on graphic stacks. However, I only have Raspberry Pi 4B so I cannot test the changes for other Raspberry Pi models. For anyone who has those boards, please help us to bump and test the kernel.
> >
> > Signed-off-by: Athaariq Ardhiansyah <buildroot@athaariq.my.id>
>
> Thanks for your patch. It would indeed be nice to update our
> RaspberryPi defconfigs, but there are a number of questions which need
> to be answered before we can apply your patch.
>
> First of all, a small detail: your commit log must be wrapped at ~80
> columns. Also, it shouldn't use 1st person sentence "I only have".
>
> > diff --git a/board/raspberrypi/linux.fragment b/board/raspberrypi/linux.fragment
> > new file mode 100644
> > index 0000000000..798b2e91da
> > --- /dev/null
> > +++ b/board/raspberrypi/linux.fragment
> > @@ -0,0 +1,7 @@
> > +# Dynamic CPU Clock
> > +CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE=n
> > +CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
> > +
> > +# Fix Kernel Module won't Load
> > +CONFIG_MODULE_COMPRESS_XZ=n
> > +CONFIG_MODULE_COMPRESS_NONE=y
>
> Why is this Linux kernel configuration fragment needed? There is no
> explanation in your commit log. Changing the default CPU governor
> should not be needed, and the second chunk about kernel module
> compression is a bit strange and deserves some explanation.
>
Upstream defconfigs changed to CONFIG_MODULE_COMPRESS_XZ (see [1] and [2]),
alternative would be to enable the following in the buildroot
raspberry*_defconfigs:
BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
BR2_PACKAGE_XZ
BR2_PACKAGE_KMOD
BR2_PACKAGE_KMOD_TOOLS
BR2_PACKAGE_HOST_KMOD_XZ
Regards,
Peter
> > diff --git a/configs/raspberrypi4_64_defconfig b/configs/raspberrypi4_64_defconfig
> > index 5942f7c4e1..6d90a8f004 100644
> > --- a/configs/raspberrypi4_64_defconfig
> > +++ b/configs/raspberrypi4_64_defconfig
> > @@ -6,13 +6,14 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
> >
> > BR2_SYSTEM_DHCP="eth0"
> >
> > -# Linux headers same as kernel, a 5.10 series
> > -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y
> > +# Linux headers same as kernel, a 5.15 series
> > +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
> >
> > BR2_LINUX_KERNEL=y
> > BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> > -BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,0b54dbda3cca2beb51e236a25738784e90853b64)/linux-0b54dbda3cca2beb51e236a25738784e90853b64.tar.gz"
> > +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,155b736f0ff883415d374ba743473f5ef146814b)/linux-155b736f0ff883415d374ba743473f5ef146814b.tar.gz"
> > BR2_LINUX_KERNEL_DEFCONFIG="bcm2711"
> > +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/raspberrypi4-64/linux.fragment"
> >
> > # Build the DTB from the kernel sources
> > BR2_LINUX_KERNEL_DTS_SUPPORT=y
> > @@ -23,6 +24,9 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> > BR2_PACKAGE_RPI_FIRMWARE=y
> > BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4=y
> > BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi4-64/config_4_64bit.txt"
> > +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI=y
> > +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_BT=y
> > +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_WIFI=y
>
> Why is this being added?
>
> > # Required tools to create the SD image
> > BR2_PACKAGE_HOST_DOSFSTOOLS=y
> > diff --git a/configs/raspberrypi4_defconfig b/configs/raspberrypi4_defconfig
> > index 4e5580c140..f0947c329c 100644
> > --- a/configs/raspberrypi4_defconfig
> > +++ b/configs/raspberrypi4_defconfig
> > @@ -6,13 +6,14 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
> >
> > BR2_SYSTEM_DHCP="eth0"
> >
> > -# Linux headers same as kernel, a 5.10 series
> > -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y
> > +# Linux headers same as kernel, a 5.15 series
> > +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
> >
> > BR2_LINUX_KERNEL=y
> > BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> > -BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,0b54dbda3cca2beb51e236a25738784e90853b64)/linux-0b54dbda3cca2beb51e236a25738784e90853b64.tar.gz"
> > +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,155b736f0ff883415d374ba743473f5ef146814b)/linux-155b736f0ff883415d374ba743473f5ef146814b.tar.gz"
> > BR2_LINUX_KERNEL_DEFCONFIG="bcm2711"
> > +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/raspberrypi4/linux.fragment"
> >
> > # Build the DTB from the kernel sources
> > BR2_LINUX_KERNEL_DTS_SUPPORT=y
> > @@ -23,6 +24,10 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> > BR2_PACKAGE_RPI_FIRMWARE=y
> > BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4=y
> > BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi4/config_4.txt"
> > +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI=y
> > +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_BT=y
> > +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_WIFI=y
> > +BR2_PACKAGE_RPI_USERLAND=y
>
> Why is rpi-userland being added here, and not to the other defconfig above?
>
> Also, you're updating rpi-firmware, rpi-userland and RaspberryPi
> defconfigs in the same commit. Is this because they need to be updated
> in sync? If that's the case, is there a potential problem if we update
> rpi-firmware/rpi-userland, but not the defconfigs for RaspberryPi 1/2/3 ?
>
> Thanks a lot for your feedback!
>
> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] board/raspberrypi4: bump kernel version to 5.15.68
2023-02-08 17:43 ` Peter Seiderer
@ 2023-02-09 7:19 ` Peter Seiderer
2023-02-09 7:51 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 5+ messages in thread
From: Peter Seiderer @ 2023-02-09 7:19 UTC (permalink / raw)
To: Thomas Petazzoni via buildroot
Cc: Thomas Petazzoni, Martin Bark, Mahyar Koshkouei,
Julien Grossholtz, Yann E. MORIN
On Wed, 8 Feb 2023 18:43:23 +0100, Peter Seiderer <ps.report@gmx.net> wrote:
> On Wed, 8 Feb 2023 14:46:39 +0100, Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:
>
> > Hello Athaariq,
> >
> > On Mon, 26 Sep 2022 05:20:15 +0000 (UTC)
> > Athaariq Ardhiansyah <buildroot@athaariq.my.id> wrote:
> >
> > > First of all, kernel support for Raspberry Pi is way too old relative to stable version. Second, we actually have several bug fixes regarding the kernel including HDMI hotplug and more problems on graphic stacks. However, I only have Raspberry Pi 4B so I cannot test the changes for other Raspberry Pi models. For anyone who has those boards, please help us to bump and test the kernel.
> > >
> > > Signed-off-by: Athaariq Ardhiansyah <buildroot@athaariq.my.id>
> >
> > Thanks for your patch. It would indeed be nice to update our
> > RaspberryPi defconfigs, but there are a number of questions which need
> > to be answered before we can apply your patch.
> >
> > First of all, a small detail: your commit log must be wrapped at ~80
> > columns. Also, it shouldn't use 1st person sentence "I only have".
> >
> > > diff --git a/board/raspberrypi/linux.fragment b/board/raspberrypi/linux.fragment
> > > new file mode 100644
> > > index 0000000000..798b2e91da
> > > --- /dev/null
> > > +++ b/board/raspberrypi/linux.fragment
> > > @@ -0,0 +1,7 @@
> > > +# Dynamic CPU Clock
> > > +CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE=n
> > > +CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
> > > +
> > > +# Fix Kernel Module won't Load
> > > +CONFIG_MODULE_COMPRESS_XZ=n
> > > +CONFIG_MODULE_COMPRESS_NONE=y
> >
> > Why is this Linux kernel configuration fragment needed? There is no
> > explanation in your commit log. Changing the default CPU governor
> > should not be needed, and the second chunk about kernel module
> > compression is a bit strange and deserves some explanation.
> >
>
> Upstream defconfigs changed to CONFIG_MODULE_COMPRESS_XZ (see [1] and [2]),
> alternative would be to enable the following in the buildroot
> raspberry*_defconfigs:
>
> BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> BR2_PACKAGE_XZ
> BR2_PACKAGE_KMOD
> BR2_PACKAGE_KMOD_TOOLS
> BR2_PACKAGE_HOST_KMOD_XZ
>
> Regards,
> Peter
...ups, and the missing links:
[1] https://github.com/raspberrypi/linux/commit/c45b4223a4e4a8cfe39edbb4949329ea478fa4e2
[2] https://github.com/raspberrypi/linux/issues/4966
Regards,
Peter
>
>
> > > diff --git a/configs/raspberrypi4_64_defconfig b/configs/raspberrypi4_64_defconfig
> > > index 5942f7c4e1..6d90a8f004 100644
> > > --- a/configs/raspberrypi4_64_defconfig
> > > +++ b/configs/raspberrypi4_64_defconfig
> > > @@ -6,13 +6,14 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
> > >
> > > BR2_SYSTEM_DHCP="eth0"
> > >
> > > -# Linux headers same as kernel, a 5.10 series
> > > -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y
> > > +# Linux headers same as kernel, a 5.15 series
> > > +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
> > >
> > > BR2_LINUX_KERNEL=y
> > > BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> > > -BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,0b54dbda3cca2beb51e236a25738784e90853b64)/linux-0b54dbda3cca2beb51e236a25738784e90853b64.tar.gz"
> > > +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,155b736f0ff883415d374ba743473f5ef146814b)/linux-155b736f0ff883415d374ba743473f5ef146814b.tar.gz"
> > > BR2_LINUX_KERNEL_DEFCONFIG="bcm2711"
> > > +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/raspberrypi4-64/linux.fragment"
> > >
> > > # Build the DTB from the kernel sources
> > > BR2_LINUX_KERNEL_DTS_SUPPORT=y
> > > @@ -23,6 +24,9 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> > > BR2_PACKAGE_RPI_FIRMWARE=y
> > > BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4=y
> > > BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi4-64/config_4_64bit.txt"
> > > +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI=y
> > > +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_BT=y
> > > +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_WIFI=y
> >
> > Why is this being added?
> >
> > > # Required tools to create the SD image
> > > BR2_PACKAGE_HOST_DOSFSTOOLS=y
> > > diff --git a/configs/raspberrypi4_defconfig b/configs/raspberrypi4_defconfig
> > > index 4e5580c140..f0947c329c 100644
> > > --- a/configs/raspberrypi4_defconfig
> > > +++ b/configs/raspberrypi4_defconfig
> > > @@ -6,13 +6,14 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
> > >
> > > BR2_SYSTEM_DHCP="eth0"
> > >
> > > -# Linux headers same as kernel, a 5.10 series
> > > -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y
> > > +# Linux headers same as kernel, a 5.15 series
> > > +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
> > >
> > > BR2_LINUX_KERNEL=y
> > > BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> > > -BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,0b54dbda3cca2beb51e236a25738784e90853b64)/linux-0b54dbda3cca2beb51e236a25738784e90853b64.tar.gz"
> > > +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,155b736f0ff883415d374ba743473f5ef146814b)/linux-155b736f0ff883415d374ba743473f5ef146814b.tar.gz"
> > > BR2_LINUX_KERNEL_DEFCONFIG="bcm2711"
> > > +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/raspberrypi4/linux.fragment"
> > >
> > > # Build the DTB from the kernel sources
> > > BR2_LINUX_KERNEL_DTS_SUPPORT=y
> > > @@ -23,6 +24,10 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> > > BR2_PACKAGE_RPI_FIRMWARE=y
> > > BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4=y
> > > BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi4/config_4.txt"
> > > +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI=y
> > > +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_BT=y
> > > +BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_WIFI=y
> > > +BR2_PACKAGE_RPI_USERLAND=y
> >
> > Why is rpi-userland being added here, and not to the other defconfig above?
> >
> > Also, you're updating rpi-firmware, rpi-userland and RaspberryPi
> > defconfigs in the same commit. Is this because they need to be updated
> > in sync? If that's the case, is there a potential problem if we update
> > rpi-firmware/rpi-userland, but not the defconfigs for RaspberryPi 1/2/3 ?
> >
> > Thanks a lot for your feedback!
> >
> > Thomas
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Buildroot] [PATCH 1/1] board/raspberrypi4: bump kernel version to 5.15.68
2023-02-09 7:19 ` Peter Seiderer
@ 2023-02-09 7:51 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-02-09 7:51 UTC (permalink / raw)
To: Peter Seiderer
Cc: Yann E. MORIN, Martin Bark, Mahyar Koshkouei, Julien Grossholtz,
Thomas Petazzoni via buildroot
On Thu, 9 Feb 2023 08:19:22 +0100
Peter Seiderer <ps.report@gmx.net> wrote:
> > Upstream defconfigs changed to CONFIG_MODULE_COMPRESS_XZ (see [1] and [2]),
> > alternative would be to enable the following in the buildroot
> > raspberry*_defconfigs:
> >
> > BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> > BR2_PACKAGE_XZ
> > BR2_PACKAGE_KMOD
> > BR2_PACKAGE_KMOD_TOOLS
> > BR2_PACKAGE_HOST_KMOD_XZ
> >
> > Regards,
> > Peter
>
> ...ups, and the missing links:
>
> [1] https://github.com/raspberrypi/linux/commit/c45b4223a4e4a8cfe39edbb4949329ea478fa4e2
> [2] https://github.com/raspberrypi/linux/issues/4966
Thanks for the extra info! Peter, in the past I believe you have been
maintaining those raspberrypi defconfigs. Any chance that you send an
update for all raspberrypi defconfigs again? :-)
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-09 7:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 5:20 [Buildroot] [PATCH 1/1] board/raspberrypi4: bump kernel version to 5.15.68 Athaariq Ardhiansyah
2023-02-08 13:46 ` Thomas Petazzoni via buildroot
2023-02-08 17:43 ` Peter Seiderer
2023-02-09 7:19 ` Peter Seiderer
2023-02-09 7:51 ` Thomas Petazzoni via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.