* [PATCH] mfd: qcom_rpm: use devm_platform_get_and_ioremap_resource()
@ 2023-02-08 9:34 ye.xingchen
2023-02-08 10:02 ` Konrad Dybcio
2023-03-03 8:22 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: ye.xingchen @ 2023-02-08 9:34 UTC (permalink / raw)
To: lee; +Cc: agross, andersson, konrad.dybcio, linux-arm-msm, linux-kernel
From: Ye Xingchen <ye.xingchen@zte.com.cn>
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
drivers/mfd/qcom_rpm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
index 8fea0e511550..086611322874 100644
--- a/drivers/mfd/qcom_rpm.c
+++ b/drivers/mfd/qcom_rpm.c
@@ -530,7 +530,6 @@ static int qcom_rpm_probe(struct platform_device *pdev)
{
const struct of_device_id *match;
struct device_node *syscon_np;
- struct resource *res;
struct qcom_rpm *rpm;
u32 fw_version[3];
int irq_wakeup;
@@ -576,8 +575,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
return -ENODEV;
rpm->data = match->data;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- rpm->status_regs = devm_ioremap_resource(&pdev->dev, res);
+ rpm->status_regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(rpm->status_regs))
return PTR_ERR(rpm->status_regs);
rpm->ctrl_regs = rpm->status_regs + 0x400;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: qcom_rpm: use devm_platform_get_and_ioremap_resource()
2023-02-08 9:34 [PATCH] mfd: qcom_rpm: use devm_platform_get_and_ioremap_resource() ye.xingchen
@ 2023-02-08 10:02 ` Konrad Dybcio
2023-03-03 8:22 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2023-02-08 10:02 UTC (permalink / raw)
To: ye.xingchen, lee; +Cc: agross, andersson, linux-arm-msm, linux-kernel
On 8.02.2023 10:34, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> drivers/mfd/qcom_rpm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 8fea0e511550..086611322874 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -530,7 +530,6 @@ static int qcom_rpm_probe(struct platform_device *pdev)
> {
> const struct of_device_id *match;
> struct device_node *syscon_np;
> - struct resource *res;
> struct qcom_rpm *rpm;
> u32 fw_version[3];
> int irq_wakeup;
> @@ -576,8 +575,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
> return -ENODEV;
> rpm->data = match->data;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - rpm->status_regs = devm_ioremap_resource(&pdev->dev, res);
> + rpm->status_regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> if (IS_ERR(rpm->status_regs))
> return PTR_ERR(rpm->status_regs);
> rpm->ctrl_regs = rpm->status_regs + 0x400;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: qcom_rpm: use devm_platform_get_and_ioremap_resource()
2023-02-08 9:34 [PATCH] mfd: qcom_rpm: use devm_platform_get_and_ioremap_resource() ye.xingchen
2023-02-08 10:02 ` Konrad Dybcio
@ 2023-03-03 8:22 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2023-03-03 8:22 UTC (permalink / raw)
To: ye.xingchen; +Cc: agross, andersson, konrad.dybcio, linux-arm-msm, linux-kernel
On Wed, 08 Feb 2023, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/mfd/qcom_rpm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-03 8:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08 9:34 [PATCH] mfd: qcom_rpm: use devm_platform_get_and_ioremap_resource() ye.xingchen
2023-02-08 10:02 ` Konrad Dybcio
2023-03-03 8:22 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.