All of lore.kernel.org
 help / color / mirror / Atom feed
* kernel/trace/trace_events.c:2657 add_str_to_module() warn: possible memory leak of 'modstr'
@ 2023-02-10  0:16 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-02-10  0:16 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Steven Rostedt (Google)" <rostedt@goodmis.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e544a07438522ab3688416e6e2e34bf0ee6d8755
commit: 795301d3c28996219d555023ac6863401b6076bc tracing: Have type enum modifications copy the strings
date:   11 months ago
:::::: branch date: 5 hours ago
:::::: commit date: 11 months ago
config: powerpc-randconfig-m041-20230208 (https://download.01.org/0day-ci/archive/20230210/202302100827.DSKdAFYJ-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202302100827.DSKdAFYJ-lkp@intel.com/

smatch warnings:
kernel/trace/trace_events.c:2657 add_str_to_module() warn: possible memory leak of 'modstr'

vim +/modstr +2657 kernel/trace/trace_events.c

0c564a538aa934 Steven Rostedt (Red Hat  2015-03-24  2643) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2644) static void add_str_to_module(struct module *module, char *str)
795301d3c28996 Steven Rostedt (Google   2022-03-18  2645) {
795301d3c28996 Steven Rostedt (Google   2022-03-18  2646) 	struct module_string *modstr;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2647) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2648) 	modstr = kmalloc(sizeof(*modstr), GFP_KERNEL);
795301d3c28996 Steven Rostedt (Google   2022-03-18  2649) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2650) 	/*
795301d3c28996 Steven Rostedt (Google   2022-03-18  2651) 	 * If we failed to allocate memory here, then we'll just
795301d3c28996 Steven Rostedt (Google   2022-03-18  2652) 	 * let the str memory leak when the module is removed.
795301d3c28996 Steven Rostedt (Google   2022-03-18  2653) 	 * If this fails to allocate, there's worse problems than
795301d3c28996 Steven Rostedt (Google   2022-03-18  2654) 	 * a leaked string on module removal.
795301d3c28996 Steven Rostedt (Google   2022-03-18  2655) 	 */
795301d3c28996 Steven Rostedt (Google   2022-03-18  2656) 	if (WARN_ON_ONCE(!modstr))
795301d3c28996 Steven Rostedt (Google   2022-03-18 @2657) 		return;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2658) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2659) 	modstr->module = module;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2660) 	modstr->str = str;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2661) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2662) 	list_add(&modstr->next, &module_strings);
795301d3c28996 Steven Rostedt (Google   2022-03-18  2663) }
795301d3c28996 Steven Rostedt (Google   2022-03-18  2664) 

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] 4+ messages in thread

* kernel/trace/trace_events.c:2657 add_str_to_module() warn: possible memory leak of 'modstr'
@ 2023-02-09  7:09 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-02-09  7:09 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Steven Rostedt (Google)" <rostedt@goodmis.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   0983f6bf2bfc0789b51ddf7315f644ff4da50acb
commit: 795301d3c28996219d555023ac6863401b6076bc tracing: Have type enum modifications copy the strings
date:   11 months ago
:::::: branch date: 33 hours ago
:::::: commit date: 11 months ago
config: powerpc-randconfig-m041-20230208 (https://download.01.org/0day-ci/archive/20230209/202302091508.C8CWaMot-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202302091508.C8CWaMot-lkp@intel.com

smatch warnings:
kernel/trace/trace_events.c:2657 add_str_to_module() warn: possible memory leak of 'modstr'

vim +/modstr +2657 kernel/trace/trace_events.c

0c564a538aa934 Steven Rostedt (Red Hat  2015-03-24  2643) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2644) static void add_str_to_module(struct module *module, char *str)
795301d3c28996 Steven Rostedt (Google   2022-03-18  2645) {
795301d3c28996 Steven Rostedt (Google   2022-03-18  2646) 	struct module_string *modstr;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2647) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2648) 	modstr = kmalloc(sizeof(*modstr), GFP_KERNEL);
795301d3c28996 Steven Rostedt (Google   2022-03-18  2649) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2650) 	/*
795301d3c28996 Steven Rostedt (Google   2022-03-18  2651) 	 * If we failed to allocate memory here, then we'll just
795301d3c28996 Steven Rostedt (Google   2022-03-18  2652) 	 * let the str memory leak when the module is removed.
795301d3c28996 Steven Rostedt (Google   2022-03-18  2653) 	 * If this fails to allocate, there's worse problems than
795301d3c28996 Steven Rostedt (Google   2022-03-18  2654) 	 * a leaked string on module removal.
795301d3c28996 Steven Rostedt (Google   2022-03-18  2655) 	 */
795301d3c28996 Steven Rostedt (Google   2022-03-18  2656) 	if (WARN_ON_ONCE(!modstr))
795301d3c28996 Steven Rostedt (Google   2022-03-18 @2657) 		return;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2658) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2659) 	modstr->module = module;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2660) 	modstr->str = str;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2661) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2662) 	list_add(&modstr->next, &module_strings);
795301d3c28996 Steven Rostedt (Google   2022-03-18  2663) }
795301d3c28996 Steven Rostedt (Google   2022-03-18  2664) 

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] 4+ messages in thread

* kernel/trace/trace_events.c:2657 add_str_to_module() warn: possible memory leak of 'modstr'
@ 2023-02-08 22:36 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-02-08 22:36 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Steven Rostedt (Google)" <rostedt@goodmis.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   0983f6bf2bfc0789b51ddf7315f644ff4da50acb
commit: 795301d3c28996219d555023ac6863401b6076bc tracing: Have type enum modifications copy the strings
date:   11 months ago
:::::: branch date: 24 hours ago
:::::: commit date: 11 months ago
config: powerpc-randconfig-m041-20230208 (https://download.01.org/0day-ci/archive/20230209/202302090643.sYPXqFRc-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>

| Link: https://lore.kernel.org/r/202302090643.sYPXqFRc-lkp@intel.com

smatch warnings:
kernel/trace/trace_events.c:2657 add_str_to_module() warn: possible memory leak of 'modstr'

vim +/modstr +2657 kernel/trace/trace_events.c

0c564a538aa934 Steven Rostedt (Red Hat  2015-03-24  2643) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2644) static void add_str_to_module(struct module *module, char *str)
795301d3c28996 Steven Rostedt (Google   2022-03-18  2645) {
795301d3c28996 Steven Rostedt (Google   2022-03-18  2646) 	struct module_string *modstr;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2647) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2648) 	modstr = kmalloc(sizeof(*modstr), GFP_KERNEL);
795301d3c28996 Steven Rostedt (Google   2022-03-18  2649) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2650) 	/*
795301d3c28996 Steven Rostedt (Google   2022-03-18  2651) 	 * If we failed to allocate memory here, then we'll just
795301d3c28996 Steven Rostedt (Google   2022-03-18  2652) 	 * let the str memory leak when the module is removed.
795301d3c28996 Steven Rostedt (Google   2022-03-18  2653) 	 * If this fails to allocate, there's worse problems than
795301d3c28996 Steven Rostedt (Google   2022-03-18  2654) 	 * a leaked string on module removal.
795301d3c28996 Steven Rostedt (Google   2022-03-18  2655) 	 */
795301d3c28996 Steven Rostedt (Google   2022-03-18  2656) 	if (WARN_ON_ONCE(!modstr))
795301d3c28996 Steven Rostedt (Google   2022-03-18 @2657) 		return;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2658) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2659) 	modstr->module = module;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2660) 	modstr->str = str;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2661) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2662) 	list_add(&modstr->next, &module_strings);
795301d3c28996 Steven Rostedt (Google   2022-03-18  2663) }
795301d3c28996 Steven Rostedt (Google   2022-03-18  2664) 

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] 4+ messages in thread

* kernel/trace/trace_events.c:2657 add_str_to_module() warn: possible memory leak of 'modstr'
@ 2023-02-08 11:35 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-02-08 11:35 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Steven Rostedt (Google)" <rostedt@goodmis.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   0983f6bf2bfc0789b51ddf7315f644ff4da50acb
commit: 795301d3c28996219d555023ac6863401b6076bc tracing: Have type enum modifications copy the strings
date:   11 months ago
:::::: branch date: 13 hours ago
:::::: commit date: 11 months ago
config: powerpc-randconfig-m041-20230208 (https://download.01.org/0day-ci/archive/20230208/202302081900.dCU8AVVm-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>

smatch warnings:
kernel/trace/trace_events.c:2657 add_str_to_module() warn: possible memory leak of 'modstr'

vim +/modstr +2657 kernel/trace/trace_events.c

0c564a538aa934 Steven Rostedt (Red Hat  2015-03-24  2643) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2644) static void add_str_to_module(struct module *module, char *str)
795301d3c28996 Steven Rostedt (Google   2022-03-18  2645) {
795301d3c28996 Steven Rostedt (Google   2022-03-18  2646) 	struct module_string *modstr;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2647) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2648) 	modstr = kmalloc(sizeof(*modstr), GFP_KERNEL);
795301d3c28996 Steven Rostedt (Google   2022-03-18  2649) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2650) 	/*
795301d3c28996 Steven Rostedt (Google   2022-03-18  2651) 	 * If we failed to allocate memory here, then we'll just
795301d3c28996 Steven Rostedt (Google   2022-03-18  2652) 	 * let the str memory leak when the module is removed.
795301d3c28996 Steven Rostedt (Google   2022-03-18  2653) 	 * If this fails to allocate, there's worse problems than
795301d3c28996 Steven Rostedt (Google   2022-03-18  2654) 	 * a leaked string on module removal.
795301d3c28996 Steven Rostedt (Google   2022-03-18  2655) 	 */
795301d3c28996 Steven Rostedt (Google   2022-03-18  2656) 	if (WARN_ON_ONCE(!modstr))
795301d3c28996 Steven Rostedt (Google   2022-03-18 @2657) 		return;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2658) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2659) 	modstr->module = module;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2660) 	modstr->str = str;
795301d3c28996 Steven Rostedt (Google   2022-03-18  2661) 
795301d3c28996 Steven Rostedt (Google   2022-03-18  2662) 	list_add(&modstr->next, &module_strings);
795301d3c28996 Steven Rostedt (Google   2022-03-18  2663) }
795301d3c28996 Steven Rostedt (Google   2022-03-18  2664) 

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-02-10  0:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-10  0:16 kernel/trace/trace_events.c:2657 add_str_to_module() warn: possible memory leak of 'modstr' kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2023-02-09  7:09 kernel test robot
2023-02-08 22:36 kernel test robot
2023-02-08 11:35 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.