All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/python-flit-core: set license path
@ 2023-02-10 10:26 Alexis Lothoré via buildroot
  2023-02-10 15:36 ` Peter Korsgaard
  0 siblings, 1 reply; 3+ messages in thread
From: Alexis Lothoré via buildroot @ 2023-02-10 10:26 UTC (permalink / raw)
  To: buildroot; +Cc: thomas.petazzoni, Asaf Kahlon

When generating legal info with a configuration enabling a package which uses
flit as setup type, we get a warning about python-flit-core license:
WARNING: python-flit-core-3.8.0: cannot save license (HOST_PYTHON_FLIT_CORE_LICENSE_FILES not defined)

Add missing variable to point to python-flit-core license file

Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
---
 package/python-flit-core/python-flit-core.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/python-flit-core/python-flit-core.mk b/package/python-flit-core/python-flit-core.mk
index 4d7bee81da..f96191ade6 100644
--- a/package/python-flit-core/python-flit-core.mk
+++ b/package/python-flit-core/python-flit-core.mk
@@ -8,6 +8,7 @@ PYTHON_FLIT_CORE_VERSION = 3.8.0
 PYTHON_FLIT_CORE_SOURCE = flit_core-$(PYTHON_FLIT_CORE_VERSION).tar.gz
 PYTHON_FLIT_CORE_SITE = https://files.pythonhosted.org/packages/10/e5/be08751d07b30889af130cec20955c987a74380a10058e6e8856e4010afc
 PYTHON_FLIT_CORE_LICENSE = BSD-3-Clause
+PYTHON_FLIT_CORE_LICENSE_FILES = LICENSE
 PYTHON_FLIT_CORE_SETUP_TYPE = flit-bootstrap
 
 # Use flit built in bootstrap_install for installing host-python-flit-core.
-- 
2.39.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/python-flit-core: set license path
  2023-02-10 10:26 [Buildroot] [PATCH 1/1] package/python-flit-core: set license path Alexis Lothoré via buildroot
@ 2023-02-10 15:36 ` Peter Korsgaard
  2023-02-10 15:47   ` Alexis Lothoré via buildroot
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2023-02-10 15:36 UTC (permalink / raw)
  To: Alexis Lothoré via buildroot
  Cc: Asaf Kahlon, Alexis Lothoré, thomas.petazzoni

>>>>> "Alexis" == Alexis Lothoré via buildroot <buildroot@buildroot.org> writes:

 > When generating legal info with a configuration enabling a package which uses
 > flit as setup type, we get a warning about python-flit-core license:
 > WARNING: python-flit-core-3.8.0: cannot save license (HOST_PYTHON_FLIT_CORE_LICENSE_FILES not defined)

 > Add missing variable to point to python-flit-core license file

 > Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
 > ---
 >  package/python-flit-core/python-flit-core.mk | 1 +
 >  1 file changed, 1 insertion(+)

 > diff --git a/package/python-flit-core/python-flit-core.mk b/package/python-flit-core/python-flit-core.mk
 > index 4d7bee81da..f96191ade6 100644
 > --- a/package/python-flit-core/python-flit-core.mk
 > +++ b/package/python-flit-core/python-flit-core.mk
 > @@ -8,6 +8,7 @@ PYTHON_FLIT_CORE_VERSION = 3.8.0
 >  PYTHON_FLIT_CORE_SOURCE = flit_core-$(PYTHON_FLIT_CORE_VERSION).tar.gz
 >  PYTHON_FLIT_CORE_SITE = https://files.pythonhosted.org/packages/10/e5/be08751d07b30889af130cec20955c987a74380a10058e6e8856e4010afc
 >  PYTHON_FLIT_CORE_LICENSE = BSD-3-Clause
 > +PYTHON_FLIT_CORE_LICENSE_FILES = LICENSE

You also need to add the sha256 of LICENSE to the .hash file:

ake host-python-flit-core-legal-info
flit_core-3.8.0.tar.gz: OK (md5: 7c41da13273f7787709a24f74e0f5a99)
flit_core-3.8.0.tar.gz: OK (sha256: b305b30c99526df5e63d6022dd2310a0a941a187bd3884f4c8ef0418df6c39f3)
>>> host-python-flit-core 3.8.0 Extracting
gzip -d -c /var/lib/downloads/python-flit-core/flit_core-3.8.0.tar.gz | tar --strip-components=1 -C /home/peko/source/buildroot/output/build/host-python-flit-core-3.8.0   -xf -
>>> host-python-flit-core 3.8.0 Patching
>>> host-python-flit-core 3.8.0 Collecting legal info
ERROR: No hash found for LICENSE

Committed with that fixed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/python-flit-core: set license path
  2023-02-10 15:36 ` Peter Korsgaard
@ 2023-02-10 15:47   ` Alexis Lothoré via buildroot
  0 siblings, 0 replies; 3+ messages in thread
From: Alexis Lothoré via buildroot @ 2023-02-10 15:47 UTC (permalink / raw)
  To: Peter Korsgaard
  Cc: Asaf Kahlon, thomas.petazzoni, Alexis Lothoré via buildroot

On 2/10/23 16:36, Peter Korsgaard wrote:
>>>>>> "Alexis" == Alexis Lothoré via buildroot <buildroot@buildroot.org> writes:
> 
>  > diff --git a/package/python-flit-core/python-flit-core.mk b/package/python-flit-core/python-flit-core.mk
>  > index 4d7bee81da..f96191ade6 100644
>  > --- a/package/python-flit-core/python-flit-core.mk
>  > +++ b/package/python-flit-core/python-flit-core.mk
>  > @@ -8,6 +8,7 @@ PYTHON_FLIT_CORE_VERSION = 3.8.0
>  >  PYTHON_FLIT_CORE_SOURCE = flit_core-$(PYTHON_FLIT_CORE_VERSION).tar.gz
>  >  PYTHON_FLIT_CORE_SITE = https://files.pythonhosted.org/packages/10/e5/be08751d07b30889af130cec20955c987a74380a10058e6e8856e4010afc
>  >  PYTHON_FLIT_CORE_LICENSE = BSD-3-Clause
>  > +PYTHON_FLIT_CORE_LICENSE_FILES = LICENSE
> 
> You also need to add the sha256 of LICENSE to the .hash file:
> 

> Committed with that fixed, thanks.

ACK for next time, sorry for omission and thanks for the fix

Kind regards,

-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-02-10 15:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-10 10:26 [Buildroot] [PATCH 1/1] package/python-flit-core: set license path Alexis Lothoré via buildroot
2023-02-10 15:36 ` Peter Korsgaard
2023-02-10 15:47   ` Alexis Lothoré via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.