All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gavin Shan <gshan@redhat.com>
To: qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com,
	peter.maydell@linaro.org, peterx@redhat.com, david@redhat.com,
	philmd@linaro.org, mst@redhat.com, cohuck@redhat.com,
	quintela@redhat.com, dgilbert@redhat.com, maz@kernel.org,
	zhenyzha@redhat.com, shan.gavin@gmail.com
Subject: [PATCH v1 6/6] kvm: Enable dirty ring for arm64
Date: Mon, 13 Feb 2023 08:39:25 +0800	[thread overview]
Message-ID: <20230213003925.40158-7-gshan@redhat.com> (raw)
In-Reply-To: <20230213003925.40158-1-gshan@redhat.com>

arm64 has different capability from x86 to enable the dirty ring, which
is KVM_CAP_DIRTY_LOG_RING_ACQ_REL. To enable it in kvm_dirty_ring_init()
when KVM_CAP_DIRTY_LOG_RING isn't supported.

Signed-off-by: Gavin Shan <gshan@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
---
 accel/kvm/kvm-all.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index e5035026c9..f6fbeae644 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -1457,6 +1457,7 @@ static int kvm_dirty_ring_init(KVMState *s)
 {
     uint32_t ring_size = s->kvm_dirty_ring_size;
     uint64_t ring_bytes = ring_size * sizeof(struct kvm_dirty_gfn);
+    unsigned int capability = KVM_CAP_DIRTY_LOG_RING;
     int ret;
 
     s->kvm_dirty_ring_size = 0;
@@ -1471,7 +1472,12 @@ static int kvm_dirty_ring_init(KVMState *s)
      * Read the max supported pages. Fall back to dirty logging mode
      * if the dirty ring isn't supported.
      */
-    ret = kvm_vm_check_extension(s, KVM_CAP_DIRTY_LOG_RING);
+    ret = kvm_vm_check_extension(s, capability);
+    if (ret <= 0) {
+        capability = KVM_CAP_DIRTY_LOG_RING_ACQ_REL;
+        ret = kvm_vm_check_extension(s, capability);
+    }
+
     if (ret <= 0) {
         warn_report("KVM dirty ring not available, using bitmap method");
         return 0;
@@ -1484,7 +1490,7 @@ static int kvm_dirty_ring_init(KVMState *s)
         return -EINVAL;
     }
 
-    ret = kvm_vm_enable_cap(s, KVM_CAP_DIRTY_LOG_RING, 0, ring_bytes);
+    ret = kvm_vm_enable_cap(s, capability, 0, ring_bytes);
     if (ret) {
         error_report("Enabling of KVM dirty ring failed: %s. "
                      "Suggested minimum value is 1024.", strerror(-ret));
-- 
2.23.0



  parent reply	other threads:[~2023-02-13  0:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13  0:39 [PATCH v1 0/6] hw/arm/virt: Support dirty ring Gavin Shan
2023-02-13  0:39 ` [PATCH v1 1/6] linux-headers: Update for " Gavin Shan
2023-02-21 16:30   ` Peter Maydell
2023-02-21 23:18     ` Gavin Shan
2023-02-22  8:49       ` Cornelia Huck
2023-02-22  9:03         ` Gavin Shan
2023-02-13  0:39 ` [PATCH v1 2/6] migration: Add last stage indicator to global dirty log synchronization Gavin Shan
2023-02-21 17:36   ` Peter Xu
2023-02-21 23:20     ` Gavin Shan
2023-02-13  0:39 ` [PATCH v1 3/6] kvm: Synchronize the backup bitmap in the last stage Gavin Shan
2023-02-21 17:46   ` Peter Xu
2023-02-21 23:44     ` Gavin Shan
2023-02-21 23:58       ` Peter Xu
2023-02-22  6:06         ` Gavin Shan
2023-02-13  0:39 ` [PATCH v1 4/6] kvm: Add helper kvm_dirty_ring_init() Gavin Shan
2023-02-21 20:12   ` Peter Xu
2023-02-13  0:39 ` [PATCH v1 5/6] hw/arm/virt: Enable backup bitmap for dirty ring Gavin Shan
2023-02-21 16:27   ` Peter Maydell
2023-02-22  4:35     ` Gavin Shan
2023-02-22 15:54       ` Peter Maydell
2023-02-23  0:52         ` Gavin Shan
2023-02-23 11:51           ` Peter Maydell
2023-02-24 10:19             ` Gavin Shan
2023-02-13  0:39 ` Gavin Shan [this message]
2023-02-17  1:59 ` [PATCH v1 0/6] hw/arm/virt: Support " Zhenyu Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230213003925.40158-7-gshan@redhat.com \
    --to=gshan@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=maz@kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=shan.gavin@gmail.com \
    --cc=zhenyzha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.