From: Peter Xu <peterx@redhat.com>
To: Gavin Shan <gshan@redhat.com>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, pbonzini@redhat.com,
peter.maydell@linaro.org, david@redhat.com, philmd@linaro.org,
mst@redhat.com, cohuck@redhat.com, quintela@redhat.com,
dgilbert@redhat.com, maz@kernel.org, zhenyzha@redhat.com,
shan.gavin@gmail.com
Subject: Re: [PATCH v1 3/6] kvm: Synchronize the backup bitmap in the last stage
Date: Tue, 21 Feb 2023 18:58:15 -0500 [thread overview]
Message-ID: <Y/Val7mrVHHE8Bsb@x1n> (raw)
In-Reply-To: <08c954d7-f4e4-4d63-28fc-50128f4bc2d7@redhat.com>
Hi, Gavin,
On Wed, Feb 22, 2023 at 10:44:07AM +1100, Gavin Shan wrote:
> Peter, could you please give some hints for me to understand the atomic
> and non-atomic update here? Ok, I will drop this part of changes in next
> revision with the assumption that we have atomic update supported for
> ARM64.
See commit f39b7d2b96. Please don't remove the change in this patch.
The comment was just something I thought about when reading, not something
I suggested to change.
If to remove it we'll need to remove the whole chunk not your changes alone
here. Still, please take it with a grain of salt before anyone can help to
confirm because I can miss something else here.
In short: before we know anything solidly, your current code is exactly
correct, AFAICT.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2023-02-21 23:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 0:39 [PATCH v1 0/6] hw/arm/virt: Support dirty ring Gavin Shan
2023-02-13 0:39 ` [PATCH v1 1/6] linux-headers: Update for " Gavin Shan
2023-02-21 16:30 ` Peter Maydell
2023-02-21 23:18 ` Gavin Shan
2023-02-22 8:49 ` Cornelia Huck
2023-02-22 9:03 ` Gavin Shan
2023-02-13 0:39 ` [PATCH v1 2/6] migration: Add last stage indicator to global dirty log synchronization Gavin Shan
2023-02-21 17:36 ` Peter Xu
2023-02-21 23:20 ` Gavin Shan
2023-02-13 0:39 ` [PATCH v1 3/6] kvm: Synchronize the backup bitmap in the last stage Gavin Shan
2023-02-21 17:46 ` Peter Xu
2023-02-21 23:44 ` Gavin Shan
2023-02-21 23:58 ` Peter Xu [this message]
2023-02-22 6:06 ` Gavin Shan
2023-02-13 0:39 ` [PATCH v1 4/6] kvm: Add helper kvm_dirty_ring_init() Gavin Shan
2023-02-21 20:12 ` Peter Xu
2023-02-13 0:39 ` [PATCH v1 5/6] hw/arm/virt: Enable backup bitmap for dirty ring Gavin Shan
2023-02-21 16:27 ` Peter Maydell
2023-02-22 4:35 ` Gavin Shan
2023-02-22 15:54 ` Peter Maydell
2023-02-23 0:52 ` Gavin Shan
2023-02-23 11:51 ` Peter Maydell
2023-02-24 10:19 ` Gavin Shan
2023-02-13 0:39 ` [PATCH v1 6/6] kvm: Enable dirty ring for arm64 Gavin Shan
2023-02-17 1:59 ` [PATCH v1 0/6] hw/arm/virt: Support dirty ring Zhenyu Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/Val7mrVHHE8Bsb@x1n \
--to=peterx@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=gshan@redhat.com \
--cc=maz@kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=shan.gavin@gmail.com \
--cc=zhenyzha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.