All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice)
@ 2023-02-14 21:29 Tony Nguyen
  2023-02-14 21:29 ` [PATCH net-next 1/5] ice: Add GPIO pin support for E823 products Tony Nguyen
                   ` (6 more replies)
  0 siblings, 7 replies; 9+ messages in thread
From: Tony Nguyen @ 2023-02-14 21:29 UTC (permalink / raw)
  To: davem, kuba, pabeni, edumazet; +Cc: Tony Nguyen, netdev

This series contains updates to ice driver only.

Karol extends support for GPIO pins to E823 devices.

Daniel Vacek stops processing of PTP packets when link is down.

Pawel adds support for BIG TCP for IPv6.

Tony changes return type of ice_vsi_realloc_stat_arrays() as it always
returns success.

Zhu Yanjun updates kdoc stating supported TLVs.

The following are changes since commit 2edd92570441dd33246210042dc167319a5cf7e3:
  devlink: don't allow to change net namespace for FW_ACTIVATE reload action
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 100GbE

Daniel Vacek (1):
  ice/ptp: fix the PTP worker retrying indefinitely if the link went
    down

Karol Kolacinski (1):
  ice: Add GPIO pin support for E823 products

Pawel Chmielewski (1):
  ice: add support BIG TCP on IPv6

Tony Nguyen (1):
  ice: Change ice_vsi_realloc_stat_arrays() to void

Zhu Yanjun (1):
  ice: Mention CEE DCBX in code comment

 drivers/net/ethernet/intel/ice/ice.h        |  2 +
 drivers/net/ethernet/intel/ice/ice_common.c | 25 +++++++
 drivers/net/ethernet/intel/ice/ice_common.h |  1 +
 drivers/net/ethernet/intel/ice/ice_dcb.c    |  4 +-
 drivers/net/ethernet/intel/ice/ice_lib.c    | 11 ++--
 drivers/net/ethernet/intel/ice/ice_main.c   |  2 +
 drivers/net/ethernet/intel/ice/ice_ptp.c    | 72 ++++++++++++++++++++-
 drivers/net/ethernet/intel/ice/ice_txrx.c   |  3 +
 8 files changed, 109 insertions(+), 11 deletions(-)

-- 
2.38.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH net-next 1/5] ice: Add GPIO pin support for E823 products
  2023-02-14 21:29 [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice) Tony Nguyen
@ 2023-02-14 21:29 ` Tony Nguyen
  2023-02-14 21:30 ` [PATCH net-next 2/5] ice/ptp: fix the PTP worker retrying indefinitely if the link went down Tony Nguyen
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Tony Nguyen @ 2023-02-14 21:29 UTC (permalink / raw)
  To: davem, kuba, pabeni, edumazet
  Cc: Karol Kolacinski, netdev, anthony.l.nguyen, richardcochran, Gurucharan G

From: Karol Kolacinski <karol.kolacinski@intel.com>

Add GPIO pin setup for E823, which is only 1PPS input and output.

Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_common.c | 25 ++++++++
 drivers/net/ethernet/intel/ice/ice_common.h |  1 +
 drivers/net/ethernet/intel/ice/ice_ptp.c    | 64 +++++++++++++++++++++
 3 files changed, 90 insertions(+)

diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c
index 1b79bb0a4fcd..c2fda4fa4188 100644
--- a/drivers/net/ethernet/intel/ice/ice_common.c
+++ b/drivers/net/ethernet/intel/ice/ice_common.c
@@ -207,6 +207,31 @@ bool ice_is_e810t(struct ice_hw *hw)
 	return false;
 }
 
+/**
+ * ice_is_e823
+ * @hw: pointer to the hardware structure
+ *
+ * returns true if the device is E823-L or E823-C based, false if not.
+ */
+bool ice_is_e823(struct ice_hw *hw)
+{
+	switch (hw->device_id) {
+	case ICE_DEV_ID_E823L_BACKPLANE:
+	case ICE_DEV_ID_E823L_SFP:
+	case ICE_DEV_ID_E823L_10G_BASE_T:
+	case ICE_DEV_ID_E823L_1GBE:
+	case ICE_DEV_ID_E823L_QSFP:
+	case ICE_DEV_ID_E823C_BACKPLANE:
+	case ICE_DEV_ID_E823C_QSFP:
+	case ICE_DEV_ID_E823C_SFP:
+	case ICE_DEV_ID_E823C_10G_BASE_T:
+	case ICE_DEV_ID_E823C_SGMII:
+		return true;
+	default:
+		return false;
+	}
+}
+
 /**
  * ice_clear_pf_cfg - Clear PF configuration
  * @hw: pointer to the hardware structure
diff --git a/drivers/net/ethernet/intel/ice/ice_common.h b/drivers/net/ethernet/intel/ice/ice_common.h
index 98aa8d124730..8ba5f935a092 100644
--- a/drivers/net/ethernet/intel/ice/ice_common.h
+++ b/drivers/net/ethernet/intel/ice/ice_common.h
@@ -199,6 +199,7 @@ void
 ice_stat_update32(struct ice_hw *hw, u32 reg, bool prev_stat_loaded,
 		  u64 *prev_stat, u64 *cur_stat);
 bool ice_is_e810t(struct ice_hw *hw);
+bool ice_is_e823(struct ice_hw *hw);
 int
 ice_sched_query_elem(struct ice_hw *hw, u32 node_teid,
 		     struct ice_aqc_txsched_elem_data *buf);
diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c b/drivers/net/ethernet/intel/ice/ice_ptp.c
index 3abc8db1d065..651dc385ff5d 100644
--- a/drivers/net/ethernet/intel/ice/ice_ptp.c
+++ b/drivers/net/ethernet/intel/ice/ice_ptp.c
@@ -1769,6 +1769,38 @@ ice_ptp_gpio_enable_e810(struct ptp_clock_info *info,
 	return err;
 }
 
+/**
+ * ice_ptp_gpio_enable_e823 - Enable/disable ancillary features of PHC
+ * @info: the driver's PTP info structure
+ * @rq: The requested feature to change
+ * @on: Enable/disable flag
+ */
+static int ice_ptp_gpio_enable_e823(struct ptp_clock_info *info,
+				    struct ptp_clock_request *rq, int on)
+{
+	struct ice_pf *pf = ptp_info_to_pf(info);
+	struct ice_perout_channel clk_cfg = {0};
+	int err;
+
+	switch (rq->type) {
+	case PTP_CLK_REQ_PPS:
+		clk_cfg.gpio_pin = PPS_PIN_INDEX;
+		clk_cfg.period = NSEC_PER_SEC;
+		clk_cfg.ena = !!on;
+
+		err = ice_ptp_cfg_clkout(pf, PPS_CLK_GEN_CHAN, &clk_cfg, true);
+		break;
+	case PTP_CLK_REQ_EXTTS:
+		err = ice_ptp_cfg_extts(pf, !!on, rq->extts.index,
+					TIME_SYNC_PIN_INDEX, rq->extts.flags);
+		break;
+	default:
+		return -EOPNOTSUPP;
+	}
+
+	return err;
+}
+
 /**
  * ice_ptp_gettimex64 - Get the time of the clock
  * @info: the driver's PTP info structure
@@ -2220,6 +2252,19 @@ ice_ptp_setup_pins_e810(struct ice_pf *pf, struct ptp_clock_info *info)
 	}
 }
 
+/**
+ * ice_ptp_setup_pins_e823 - Setup PTP pins in sysfs
+ * @pf: pointer to the PF instance
+ * @info: PTP clock capabilities
+ */
+static void
+ice_ptp_setup_pins_e823(struct ice_pf *pf, struct ptp_clock_info *info)
+{
+	info->pps = 1;
+	info->n_per_out = 0;
+	info->n_ext_ts = 1;
+}
+
 /**
  * ice_ptp_set_funcs_e822 - Set specialized functions for E822 support
  * @pf: Board private structure
@@ -2257,6 +2302,23 @@ ice_ptp_set_funcs_e810(struct ice_pf *pf, struct ptp_clock_info *info)
 	ice_ptp_setup_pins_e810(pf, info);
 }
 
+/**
+ * ice_ptp_set_funcs_e823 - Set specialized functions for E823 support
+ * @pf: Board private structure
+ * @info: PTP info to fill
+ *
+ * Assign functions to the PTP capabiltiies structure for E823 devices.
+ * Functions which operate across all device families should be set directly
+ * in ice_ptp_set_caps. Only add functions here which are distinct for e823
+ * devices.
+ */
+static void
+ice_ptp_set_funcs_e823(struct ice_pf *pf, struct ptp_clock_info *info)
+{
+	info->enable = ice_ptp_gpio_enable_e823;
+	ice_ptp_setup_pins_e823(pf, info);
+}
+
 /**
  * ice_ptp_set_caps - Set PTP capabilities
  * @pf: Board private structure
@@ -2277,6 +2339,8 @@ static void ice_ptp_set_caps(struct ice_pf *pf)
 
 	if (ice_is_e810(&pf->hw))
 		ice_ptp_set_funcs_e810(pf, info);
+	else if (ice_is_e823(&pf->hw))
+		ice_ptp_set_funcs_e823(pf, info);
 	else
 		ice_ptp_set_funcs_e822(pf, info);
 }
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH net-next 2/5] ice/ptp: fix the PTP worker retrying indefinitely if the link went down
  2023-02-14 21:29 [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice) Tony Nguyen
  2023-02-14 21:29 ` [PATCH net-next 1/5] ice: Add GPIO pin support for E823 products Tony Nguyen
@ 2023-02-14 21:30 ` Tony Nguyen
  2023-02-14 21:30 ` [PATCH net-next 3/5] ice: add support BIG TCP on IPv6 Tony Nguyen
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Tony Nguyen @ 2023-02-14 21:30 UTC (permalink / raw)
  To: davem, kuba, pabeni, edumazet
  Cc: Daniel Vacek, netdev, anthony.l.nguyen, richardcochran,
	Jacob Keller, Gurucharan G

From: Daniel Vacek <neelx@redhat.com>

When the link goes down the ice_ptp_tx_tstamp() may loop re-trying to
process the packets till the 2 seconds timeout finally drops them.
In such a case it makes sense to just drop them right away.

Signed-off-by: Daniel Vacek <neelx@redhat.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_ptp.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c b/drivers/net/ethernet/intel/ice/ice_ptp.c
index 651dc385ff5d..ac6f06f9a2ed 100644
--- a/drivers/net/ethernet/intel/ice/ice_ptp.c
+++ b/drivers/net/ethernet/intel/ice/ice_ptp.c
@@ -680,6 +680,7 @@ static bool ice_ptp_tx_tstamp(struct ice_ptp_tx *tx)
 	struct ice_pf *pf;
 	struct ice_hw *hw;
 	u64 tstamp_ready;
+	bool link_up;
 	int err;
 	u8 idx;
 
@@ -695,11 +696,14 @@ static bool ice_ptp_tx_tstamp(struct ice_ptp_tx *tx)
 	if (err)
 		return false;
 
+	/* Drop packets if the link went down */
+	link_up = ptp_port->link_up;
+
 	for_each_set_bit(idx, tx->in_use, tx->len) {
 		struct skb_shared_hwtstamps shhwtstamps = {};
 		u8 phy_idx = idx + tx->offset;
 		u64 raw_tstamp = 0, tstamp;
-		bool drop_ts = false;
+		bool drop_ts = !link_up;
 		struct sk_buff *skb;
 
 		/* Drop packets which have waited for more than 2 seconds */
@@ -728,7 +732,7 @@ static bool ice_ptp_tx_tstamp(struct ice_ptp_tx *tx)
 		ice_trace(tx_tstamp_fw_req, tx->tstamps[idx].skb, idx);
 
 		err = ice_read_phy_tstamp(hw, tx->block, phy_idx, &raw_tstamp);
-		if (err)
+		if (err && !drop_ts)
 			continue;
 
 		ice_trace(tx_tstamp_fw_done, tx->tstamps[idx].skb, idx);
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH net-next 3/5] ice: add support BIG TCP on IPv6
  2023-02-14 21:29 [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice) Tony Nguyen
  2023-02-14 21:29 ` [PATCH net-next 1/5] ice: Add GPIO pin support for E823 products Tony Nguyen
  2023-02-14 21:30 ` [PATCH net-next 2/5] ice/ptp: fix the PTP worker retrying indefinitely if the link went down Tony Nguyen
@ 2023-02-14 21:30 ` Tony Nguyen
  2023-02-14 21:30 ` [PATCH net-next 4/5] ice: Change ice_vsi_realloc_stat_arrays() to void Tony Nguyen
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Tony Nguyen @ 2023-02-14 21:30 UTC (permalink / raw)
  To: davem, kuba, pabeni, edumazet
  Cc: Pawel Chmielewski, netdev, anthony.l.nguyen, Gurucharan G

From: Pawel Chmielewski <pawel.chmielewski@intel.com>

Enable sending BIG TCP packets on IPv6 in the ice driver using generic
ipv6_hopopt_jumbo_remove helper for stripping HBH header.

Tested:
netperf -t TCP_RR -H 2001:db8:0:f101::1  -- -r80000,80000 -O MIN_LATENCY,P90_LATENCY,P99_LATENCY,TRANSACTION_RATE

Tested on two different setups. In both cases, the following settings were
applied after loading the changed driver:

ip link set dev enp175s0f1np1 gso_max_size 130000
ip link set dev enp175s0f1np1 gro_max_size 130000
ip link set dev enp175s0f1np1 mtu 9000

First setup:
Before:
Minimum      90th         99th         Transaction
Latency      Percentile   Percentile   Rate
Microseconds Latency      Latency      Tran/s
             Microseconds Microseconds
134          279          410          3961.584

After:
Minimum      90th         99th         Transaction
Latency      Percentile   Percentile   Rate
Microseconds Latency      Latency      Tran/s
             Microseconds Microseconds
135          178          216          6093.404

The other setup:
Before:
Minimum      90th         99th         Transaction
Latency      Percentile   Percentile   Rate
Microseconds Latency      Latency      Tran/s
             Microseconds Microseconds
218          414          478          2944.765

After:
Minimum      90th         99th         Transaction
Latency      Percentile   Percentile   Rate
Microseconds Latency      Latency      Tran/s
             Microseconds Microseconds
146          238          266          4700.596

Signed-off-by: Pawel Chmielewski <pawel.chmielewski@intel.com>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/ice/ice.h      | 2 ++
 drivers/net/ethernet/intel/ice/ice_main.c | 2 ++
 drivers/net/ethernet/intel/ice/ice_txrx.c | 3 +++
 3 files changed, 7 insertions(+)

diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h
index 7bd50e49312c..b0e29e342401 100644
--- a/drivers/net/ethernet/intel/ice/ice.h
+++ b/drivers/net/ethernet/intel/ice/ice.h
@@ -123,6 +123,8 @@
 
 #define ICE_MAX_MTU	(ICE_AQ_SET_MAC_FRAME_SIZE_MAX - ICE_ETH_PKT_HDR_PAD)
 
+#define ICE_MAX_TSO_SIZE 131072
+
 #define ICE_UP_TABLE_TRANSLATE(val, i) \
 		(((val) << ICE_AQ_VSI_UP_TABLE_UP##i##_S) & \
 		  ICE_AQ_VSI_UP_TABLE_UP##i##_M)
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 0712c1055aea..eb87bb08f5ec 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -3436,6 +3436,8 @@ static void ice_set_netdev_features(struct net_device *netdev)
 	 * be changed at runtime
 	 */
 	netdev->hw_features |= NETIF_F_RXFCS;
+
+	netif_set_tso_max_size(netdev, ICE_MAX_TSO_SIZE);
 }
 
 /**
diff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c
index 466113c86e6f..c036be5eb35d 100644
--- a/drivers/net/ethernet/intel/ice/ice_txrx.c
+++ b/drivers/net/ethernet/intel/ice/ice_txrx.c
@@ -2327,6 +2327,9 @@ ice_xmit_frame_ring(struct sk_buff *skb, struct ice_tx_ring *tx_ring)
 
 	ice_trace(xmit_frame_ring, tx_ring, skb);
 
+	if (unlikely(ipv6_hopopt_jumbo_remove(skb)))
+		goto out_drop;
+
 	count = ice_xmit_desc_count(skb);
 	if (ice_chk_linearize(skb, count)) {
 		if (__skb_linearize(skb))
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH net-next 4/5] ice: Change ice_vsi_realloc_stat_arrays() to void
  2023-02-14 21:29 [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice) Tony Nguyen
                   ` (2 preceding siblings ...)
  2023-02-14 21:30 ` [PATCH net-next 3/5] ice: add support BIG TCP on IPv6 Tony Nguyen
@ 2023-02-14 21:30 ` Tony Nguyen
  2023-02-14 21:30 ` [PATCH net-next 5/5] ice: Mention CEE DCBX in code comment Tony Nguyen
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Tony Nguyen @ 2023-02-14 21:30 UTC (permalink / raw)
  To: davem, kuba, pabeni, edumazet
  Cc: Tony Nguyen, netdev, kernel test robot, Gurucharan G

smatch reports:

smatch warnings:
drivers/net/ethernet/intel/ice/ice_lib.c:3612 ice_vsi_rebuild() warn: missing error code 'ret'

If an error is encountered for ice_vsi_realloc_stat_arrays(), ret is not
assigned an error value so the goto error path would return success. The
function, however, only returns 0 so an error will never be reported; due
to this, change the function to return void.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
---
 drivers/net/ethernet/intel/ice/ice_lib.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
index 37fe639712e6..8cfc30fc9840 100644
--- a/drivers/net/ethernet/intel/ice/ice_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_lib.c
@@ -3426,7 +3426,7 @@ ice_vsi_rebuild_set_coalesce(struct ice_vsi *vsi,
  * @prev_txq: Number of Tx rings before ring reallocation
  * @prev_rxq: Number of Rx rings before ring reallocation
  */
-static int
+static void
 ice_vsi_realloc_stat_arrays(struct ice_vsi *vsi, int prev_txq, int prev_rxq)
 {
 	struct ice_vsi_stats *vsi_stat;
@@ -3434,9 +3434,9 @@ ice_vsi_realloc_stat_arrays(struct ice_vsi *vsi, int prev_txq, int prev_rxq)
 	int i;
 
 	if (!prev_txq || !prev_rxq)
-		return 0;
+		return;
 	if (vsi->type == ICE_VSI_CHNL)
-		return 0;
+		return;
 
 	vsi_stat = pf->vsi_stats[vsi->idx];
 
@@ -3457,8 +3457,6 @@ ice_vsi_realloc_stat_arrays(struct ice_vsi *vsi, int prev_txq, int prev_rxq)
 			}
 		}
 	}
-
-	return 0;
 }
 
 /**
@@ -3515,8 +3513,7 @@ int ice_vsi_rebuild(struct ice_vsi *vsi, u32 vsi_flags)
 		}
 	}
 
-	if (ice_vsi_realloc_stat_arrays(vsi, prev_txq, prev_rxq))
-		goto err_vsi_cfg_tc_lan;
+	ice_vsi_realloc_stat_arrays(vsi, prev_txq, prev_rxq);
 
 	ice_vsi_rebuild_set_coalesce(vsi, coalesce, prev_num_q_vectors);
 	kfree(coalesce);
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH net-next 5/5] ice: Mention CEE DCBX in code comment
  2023-02-14 21:29 [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice) Tony Nguyen
                   ` (3 preceding siblings ...)
  2023-02-14 21:30 ` [PATCH net-next 4/5] ice: Change ice_vsi_realloc_stat_arrays() to void Tony Nguyen
@ 2023-02-14 21:30 ` Tony Nguyen
  2023-02-15  7:57 ` [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice) Jiri Pirko
  2023-02-16  6:00 ` patchwork-bot+netdevbpf
  6 siblings, 0 replies; 9+ messages in thread
From: Tony Nguyen @ 2023-02-14 21:30 UTC (permalink / raw)
  To: davem, kuba, pabeni, edumazet; +Cc: Zhu Yanjun, netdev, anthony.l.nguyen

From: Zhu Yanjun <yanjun.zhu@linux.dev>

From the function ice_parse_org_tlv, CEE DCBX TLV is also supported.
So update the comment. Or else, it is confusing.

Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_dcb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_dcb.c b/drivers/net/ethernet/intel/ice/ice_dcb.c
index 776c1ff6e265..c557dfc50aad 100644
--- a/drivers/net/ethernet/intel/ice/ice_dcb.c
+++ b/drivers/net/ethernet/intel/ice/ice_dcb.c
@@ -569,7 +569,7 @@ ice_parse_cee_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
  * @tlv: Organization specific TLV
  * @dcbcfg: Local store to update ETS REC data
  *
- * Currently only IEEE 802.1Qaz TLV is supported, all others
+ * Currently IEEE 802.1Qaz and CEE DCBX TLV are supported, others
  * will be returned
  */
 static void
@@ -588,7 +588,7 @@ ice_parse_org_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
 		ice_parse_cee_tlv(tlv, dcbcfg);
 		break;
 	default:
-		break;
+		break; /* Other OUIs not supported */
 	}
 }
 
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice)
  2023-02-14 21:29 [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice) Tony Nguyen
                   ` (4 preceding siblings ...)
  2023-02-14 21:30 ` [PATCH net-next 5/5] ice: Mention CEE DCBX in code comment Tony Nguyen
@ 2023-02-15  7:57 ` Jiri Pirko
  2023-02-15  8:03   ` Jiri Pirko
  2023-02-16  6:00 ` patchwork-bot+netdevbpf
  6 siblings, 1 reply; 9+ messages in thread
From: Jiri Pirko @ 2023-02-15  7:57 UTC (permalink / raw)
  To: Tony Nguyen; +Cc: davem, kuba, pabeni, edumazet, netdev

Tue, Feb 14, 2023 at 10:29:58PM CET, anthony.l.nguyen@intel.com wrote:
>This series contains updates to ice driver only.
>
>Karol extends support for GPIO pins to E823 devices.
>
>Daniel Vacek stops processing of PTP packets when link is down.
>
>Pawel adds support for BIG TCP for IPv6.
>
>Tony changes return type of ice_vsi_realloc_stat_arrays() as it always
>returns success.
>
>Zhu Yanjun updates kdoc stating supported TLVs.
>
>The following are changes since commit 2edd92570441dd33246210042dc167319a5cf7e3:
>  devlink: don't allow to change net namespace for FW_ACTIVATE reload action
>and are available in the git repository at:
>  git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 100GbE
>
>Daniel Vacek (1):
>  ice/ptp: fix the PTP worker retrying indefinitely if the link went
>    down
>
>Karol Kolacinski (1):
>  ice: Add GPIO pin support for E823 products
>
>Pawel Chmielewski (1):
>  ice: add support BIG TCP on IPv6
>
>Tony Nguyen (1):
>  ice: Change ice_vsi_realloc_stat_arrays() to void
>
>Zhu Yanjun (1):
>  ice: Mention CEE DCBX in code comment
>
> drivers/net/ethernet/intel/ice/ice.h        |  2 +
> drivers/net/ethernet/intel/ice/ice_common.c | 25 +++++++
> drivers/net/ethernet/intel/ice/ice_common.h |  1 +
> drivers/net/ethernet/intel/ice/ice_dcb.c    |  4 +-
> drivers/net/ethernet/intel/ice/ice_lib.c    | 11 ++--
> drivers/net/ethernet/intel/ice/ice_main.c   |  2 +
> drivers/net/ethernet/intel/ice/ice_ptp.c    | 72 ++++++++++++++++++++-
> drivers/net/ethernet/intel/ice/ice_txrx.c   |  3 +
> 8 files changed, 109 insertions(+), 11 deletions(-)

Tony, could you please send the patches alongside with the pull request,
as for example Saeed does for mlx5 pull requests?

Thanks!

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice)
  2023-02-15  7:57 ` [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice) Jiri Pirko
@ 2023-02-15  8:03   ` Jiri Pirko
  0 siblings, 0 replies; 9+ messages in thread
From: Jiri Pirko @ 2023-02-15  8:03 UTC (permalink / raw)
  To: Tony Nguyen; +Cc: davem, kuba, pabeni, edumazet, netdev

Wed, Feb 15, 2023 at 08:57:02AM CET, jiri@resnulli.us wrote:
>Tue, Feb 14, 2023 at 10:29:58PM CET, anthony.l.nguyen@intel.com wrote:
>>This series contains updates to ice driver only.
>>
>>Karol extends support for GPIO pins to E823 devices.
>>
>>Daniel Vacek stops processing of PTP packets when link is down.
>>
>>Pawel adds support for BIG TCP for IPv6.
>>
>>Tony changes return type of ice_vsi_realloc_stat_arrays() as it always
>>returns success.
>>
>>Zhu Yanjun updates kdoc stating supported TLVs.
>>
>>The following are changes since commit 2edd92570441dd33246210042dc167319a5cf7e3:
>>  devlink: don't allow to change net namespace for FW_ACTIVATE reload action
>>and are available in the git repository at:
>>  git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 100GbE
>>
>>Daniel Vacek (1):
>>  ice/ptp: fix the PTP worker retrying indefinitely if the link went
>>    down
>>
>>Karol Kolacinski (1):
>>  ice: Add GPIO pin support for E823 products
>>
>>Pawel Chmielewski (1):
>>  ice: add support BIG TCP on IPv6
>>
>>Tony Nguyen (1):
>>  ice: Change ice_vsi_realloc_stat_arrays() to void
>>
>>Zhu Yanjun (1):
>>  ice: Mention CEE DCBX in code comment
>>
>> drivers/net/ethernet/intel/ice/ice.h        |  2 +
>> drivers/net/ethernet/intel/ice/ice_common.c | 25 +++++++
>> drivers/net/ethernet/intel/ice/ice_common.h |  1 +
>> drivers/net/ethernet/intel/ice/ice_dcb.c    |  4 +-
>> drivers/net/ethernet/intel/ice/ice_lib.c    | 11 ++--
>> drivers/net/ethernet/intel/ice/ice_main.c   |  2 +
>> drivers/net/ethernet/intel/ice/ice_ptp.c    | 72 ++++++++++++++++++++-
>> drivers/net/ethernet/intel/ice/ice_txrx.c   |  3 +
>> 8 files changed, 109 insertions(+), 11 deletions(-)
>
>Tony, could you please send the patches alongside with the pull request,
>as for example Saeed does for mlx5 pull requests?

Ah, I see it now. Unlike 0/5, the rest got filtered out to another
folder in my inbox. Sorry :)

>
>Thanks!

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice)
  2023-02-14 21:29 [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice) Tony Nguyen
                   ` (5 preceding siblings ...)
  2023-02-15  7:57 ` [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice) Jiri Pirko
@ 2023-02-16  6:00 ` patchwork-bot+netdevbpf
  6 siblings, 0 replies; 9+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-02-16  6:00 UTC (permalink / raw)
  To: Tony Nguyen; +Cc: davem, kuba, pabeni, edumazet, netdev

Hello:

This series was applied to netdev/net-next.git (master)
by Tony Nguyen <anthony.l.nguyen@intel.com>:

On Tue, 14 Feb 2023 13:29:58 -0800 you wrote:
> This series contains updates to ice driver only.
> 
> Karol extends support for GPIO pins to E823 devices.
> 
> Daniel Vacek stops processing of PTP packets when link is down.
> 
> Pawel adds support for BIG TCP for IPv6.
> 
> [...]

Here is the summary with links:
  - [net-next,1/5] ice: Add GPIO pin support for E823 products
    https://git.kernel.org/netdev/net-next/c/634d841dbfa7
  - [net-next,2/5] ice/ptp: fix the PTP worker retrying indefinitely if the link went down
    https://git.kernel.org/netdev/net-next/c/fcc2cef37fed
  - [net-next,3/5] ice: add support BIG TCP on IPv6
    https://git.kernel.org/netdev/net-next/c/fce92dbc6117
  - [net-next,4/5] ice: Change ice_vsi_realloc_stat_arrays() to void
    https://git.kernel.org/netdev/net-next/c/d8a23ff6a755
  - [net-next,5/5] ice: Mention CEE DCBX in code comment
    https://git.kernel.org/netdev/net-next/c/13b599f15e1c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-02-16  6:00 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-14 21:29 [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice) Tony Nguyen
2023-02-14 21:29 ` [PATCH net-next 1/5] ice: Add GPIO pin support for E823 products Tony Nguyen
2023-02-14 21:30 ` [PATCH net-next 2/5] ice/ptp: fix the PTP worker retrying indefinitely if the link went down Tony Nguyen
2023-02-14 21:30 ` [PATCH net-next 3/5] ice: add support BIG TCP on IPv6 Tony Nguyen
2023-02-14 21:30 ` [PATCH net-next 4/5] ice: Change ice_vsi_realloc_stat_arrays() to void Tony Nguyen
2023-02-14 21:30 ` [PATCH net-next 5/5] ice: Mention CEE DCBX in code comment Tony Nguyen
2023-02-15  7:57 ` [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-02-14 (ice) Jiri Pirko
2023-02-15  8:03   ` Jiri Pirko
2023-02-16  6:00 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.