* [Intel-gfx] [PATCH 1/3] drm/i915: Use encoder->devdata more
@ 2023-02-14 23:19 Ville Syrjala
2023-02-14 23:19 ` [Intel-gfx] [PATCH 2/3] drm/i915: Sanitize child devices later Ville Syrjala
` (8 more replies)
0 siblings, 9 replies; 12+ messages in thread
From: Ville Syrjala @ 2023-02-14 23:19 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Switch a lot of the intel_bios_foo() stuff to just accept the
devdata (VBT child device info) directly, instead of taking
detours via vbt.ports[].
Also unify the function naming scheme.
TODO: is intel_bios_encoder_{dp,hdmi}_ too much? Or should we
shorten to just intel_bios_{dp,hdmi}_ ?
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 54 +++++------------------
drivers/gpu/drm/i915/display/intel_bios.h | 15 ++++---
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/display/intel_dp.c | 4 +-
drivers/gpu/drm/i915/display/intel_hdmi.c | 4 +-
5 files changed, 23 insertions(+), 56 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 229f9782e226..22bbbca171dc 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -2520,7 +2520,7 @@ static int parse_bdb_216_dp_max_link_rate(const int vbt_max_link_rate)
}
}
-static int _intel_bios_dp_max_link_rate(const struct intel_bios_encoder_data *devdata)
+int intel_bios_encoder_dp_max_link_rate(const struct intel_bios_encoder_data *devdata)
{
if (!devdata || devdata->i915->display.vbt.version < 216)
return 0;
@@ -2531,7 +2531,7 @@ static int _intel_bios_dp_max_link_rate(const struct intel_bios_encoder_data *de
return parse_bdb_216_dp_max_link_rate(devdata->child.dp_max_link_rate);
}
-static int _intel_bios_dp_max_lane_count(const struct intel_bios_encoder_data *devdata)
+int intel_bios_encoder_dp_max_lane_count(const struct intel_bios_encoder_data *devdata)
{
if (!devdata || devdata->i915->display.vbt.version < 244)
return 0;
@@ -2604,7 +2604,8 @@ intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata)
return devdata && HAS_LSPCON(devdata->i915) && devdata->child.lspcon;
}
-static int _intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data *devdata)
+/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */
+int intel_bios_encoder_hdmi_level_shift(const struct intel_bios_encoder_data *devdata)
{
if (!devdata || devdata->i915->display.vbt.version < 158)
return -1;
@@ -2612,7 +2613,7 @@ static int _intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data *de
return devdata->child.hdmi_level_shifter_value;
}
-static int _intel_bios_max_tmds_clock(const struct intel_bios_encoder_data *devdata)
+int intel_bios_encoder_hdmi_max_tmds_clock(const struct intel_bios_encoder_data *devdata)
{
if (!devdata || devdata->i915->display.vbt.version < 204)
return 0;
@@ -2674,14 +2675,14 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata,
supports_typec_usb, supports_tbt,
devdata->dsc != NULL);
- hdmi_level_shift = _intel_bios_hdmi_level_shift(devdata);
+ hdmi_level_shift = intel_bios_encoder_hdmi_level_shift(devdata);
if (hdmi_level_shift >= 0) {
drm_dbg_kms(&i915->drm,
"Port %c VBT HDMI level shift: %d\n",
port_name(port), hdmi_level_shift);
}
- max_tmds_clock = _intel_bios_max_tmds_clock(devdata);
+ max_tmds_clock = intel_bios_encoder_hdmi_max_tmds_clock(devdata);
if (max_tmds_clock)
drm_dbg_kms(&i915->drm,
"Port %c VBT HDMI max TMDS clock: %d kHz\n",
@@ -2700,7 +2701,7 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata,
"Port %c VBT HDMI boost level: %d\n",
port_name(port), hdmi_boost_level);
- dp_max_link_rate = _intel_bios_dp_max_link_rate(devdata);
+ dp_max_link_rate = intel_bios_encoder_dp_max_link_rate(devdata);
if (dp_max_link_rate)
drm_dbg_kms(&i915->drm,
"Port %c VBT DP max link rate: %d\n",
@@ -3665,22 +3666,6 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *i915,
return aux_ch;
}
-int intel_bios_max_tmds_clock(struct intel_encoder *encoder)
-{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
- const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
-
- return _intel_bios_max_tmds_clock(devdata);
-}
-
-/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */
-int intel_bios_hdmi_level_shift(struct intel_encoder *encoder)
-{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
- const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
-
- return _intel_bios_hdmi_level_shift(devdata);
-}
int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devdata)
{
@@ -3698,31 +3683,12 @@ int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *de
return translate_iboost(devdata->child.hdmi_iboost_level);
}
-int intel_bios_dp_max_link_rate(struct intel_encoder *encoder)
+int intel_bios_encoder_hdmi_ddc_pin(const struct intel_bios_encoder_data *devdata)
{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
- const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
-
- return _intel_bios_dp_max_link_rate(devdata);
-}
-
-int intel_bios_dp_max_lane_count(struct intel_encoder *encoder)
-{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
- const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
-
- return _intel_bios_dp_max_lane_count(devdata);
-}
-
-int intel_bios_alternate_ddc_pin(struct intel_encoder *encoder)
-{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
- const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
-
if (!devdata || !devdata->child.ddc_pin)
return 0;
- return map_ddc_pin(i915, devdata->child.ddc_pin);
+ return map_ddc_pin(devdata->i915, devdata->child.ddc_pin);
}
bool intel_bios_encoder_supports_typec_usb(const struct intel_bios_encoder_data *devdata)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
index 1a6ae38bd4f6..0ce7ed7f28c9 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.h
+++ b/drivers/gpu/drm/i915/display/intel_bios.h
@@ -254,11 +254,6 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *i915,
bool intel_bios_get_dsc_params(struct intel_encoder *encoder,
struct intel_crtc_state *crtc_state,
int dsc_max_bpc);
-int intel_bios_max_tmds_clock(struct intel_encoder *encoder);
-int intel_bios_hdmi_level_shift(struct intel_encoder *encoder);
-int intel_bios_dp_max_link_rate(struct intel_encoder *encoder);
-int intel_bios_dp_max_lane_count(struct intel_encoder *encoder);
-int intel_bios_alternate_ddc_pin(struct intel_encoder *encoder);
bool intel_bios_port_supports_typec_usb(struct drm_i915_private *i915, enum port port);
bool intel_bios_port_supports_tbt(struct drm_i915_private *i915, enum port port);
@@ -272,9 +267,15 @@ bool intel_bios_encoder_supports_edp(const struct intel_bios_encoder_data *devda
bool intel_bios_encoder_supports_typec_usb(const struct intel_bios_encoder_data *devdata);
bool intel_bios_encoder_supports_tbt(const struct intel_bios_encoder_data *devdata);
bool intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata);
-int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devdata);
-int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *devdata);
bool intel_bios_encoder_lane_reversal(const struct intel_bios_encoder_data *devdata);
bool intel_bios_encoder_hpd_invert(const struct intel_bios_encoder_data *devdata);
+int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devdata);
+int intel_bios_encoder_dp_max_link_rate(const struct intel_bios_encoder_data *devdata);
+int intel_bios_encoder_dp_max_lane_count(const struct intel_bios_encoder_data *devdata);
+int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *devdata);
+int intel_bios_encoder_hdmi_max_tmds_clock(const struct intel_bios_encoder_data *devdata);
+int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *devdata);
+int intel_bios_encoder_hdmi_level_shift(const struct intel_bios_encoder_data *devdata);
+int intel_bios_encoder_hdmi_ddc_pin(const struct intel_bios_encoder_data *devdata);
#endif /* _INTEL_BIOS_H_ */
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index bfd1e30a27b4..655309ff5b55 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -89,7 +89,7 @@ static int intel_ddi_hdmi_level(struct intel_encoder *encoder,
{
int level;
- level = intel_bios_hdmi_level_shift(encoder);
+ level = intel_bios_encoder_hdmi_level_shift(encoder->devdata);
if (level < 0)
level = trans->hdmi_default_entry;
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index b92e0b0f5369..7fd4c5ccf7e5 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -288,7 +288,7 @@ static int intel_dp_max_common_rate(struct intel_dp *intel_dp)
static int intel_dp_max_source_lane_count(struct intel_digital_port *dig_port)
{
- int vbt_max_lanes = intel_bios_dp_max_lane_count(&dig_port->base);
+ int vbt_max_lanes = intel_bios_encoder_dp_max_lane_count(dig_port->base.devdata);
int max_lanes = dig_port->max_lanes;
if (vbt_max_lanes)
@@ -425,7 +425,7 @@ static int vbt_max_link_rate(struct intel_dp *intel_dp)
struct intel_encoder *encoder = &dp_to_dig_port(intel_dp)->base;
int max_rate;
- max_rate = intel_bios_dp_max_link_rate(encoder);
+ max_rate = intel_bios_encoder_dp_max_link_rate(encoder->devdata);
if (intel_dp_is_edp(intel_dp)) {
struct intel_connector *connector = intel_dp->attached_connector;
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 619865b45eca..07a1495bd55f 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -1795,7 +1795,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder)
else
max_tmds_clock = 165000;
- vbt_max_tmds_clock = intel_bios_max_tmds_clock(encoder);
+ vbt_max_tmds_clock = intel_bios_encoder_hdmi_max_tmds_clock(encoder->devdata);
if (vbt_max_tmds_clock)
max_tmds_clock = min(max_tmds_clock, vbt_max_tmds_clock);
@@ -2871,7 +2871,7 @@ static u8 intel_hdmi_ddc_pin(struct intel_encoder *encoder)
enum port port = encoder->port;
u8 ddc_pin;
- ddc_pin = intel_bios_alternate_ddc_pin(encoder);
+ ddc_pin = intel_bios_encoder_hdmi_ddc_pin(encoder->devdata);
if (ddc_pin) {
drm_dbg_kms(&dev_priv->drm,
"Using DDC pin 0x%x for port %c (VBT)\n",
--
2.39.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH 2/3] drm/i915: Sanitize child devices later
2023-02-14 23:19 [Intel-gfx] [PATCH 1/3] drm/i915: Use encoder->devdata more Ville Syrjala
@ 2023-02-14 23:19 ` Ville Syrjala
2023-02-14 23:19 ` [Intel-gfx] [PATCH 3/3] drm/i915: Try to initialize DDI ports for every VBT child device Ville Syrjala
` (7 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Ville Syrjala @ 2023-02-14 23:19 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Currently we sanitize the child device aux_ch/ddc_pin while parsing
the ports from VBT. But that won't work when we have duplicate child
devices for the same port.
Instead let's sanitize just before initializing the encoder,
based on which resources were consumed by encoders that were
(successfully) initialized earlier.
I also included the intel_bios_encoder_sanitize() calls in the
g4x+ DP/HDMI code, but there we need to be careful not confuse
the split DP vs. HDMI encoders as conflicting child devices.
Checking encoder->devdata for equality should suffice.
TODO: the sanitation only affects the VBT assigned stuff, but
we could still have a conflict if one port came from VBT
with a non-default pin, and another port just used the
platform default which happens be the same pin...
TODO: Need to double check the details on commit 41e35ffb380b ("drm/i915:
Favor last VBT child device with conflicting AUX ch/DDC pin")
to make sure we're not breaking stuff with the new
sanitation scheme
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/g4x_dp.c | 3 +-
drivers/gpu/drm/i915/display/g4x_hdmi.c | 3 +-
drivers/gpu/drm/i915/display/intel_bios.c | 91 +++++++++++++----------
drivers/gpu/drm/i915/display/intel_bios.h | 4 +-
drivers/gpu/drm/i915/display/intel_ddi.c | 4 +-
5 files changed, 62 insertions(+), 43 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c b/drivers/gpu/drm/i915/display/g4x_dp.c
index 5a3e79484608..b794cd2ff7d5 100644
--- a/drivers/gpu/drm/i915/display/g4x_dp.c
+++ b/drivers/gpu/drm/i915/display/g4x_dp.c
@@ -1279,13 +1279,14 @@ static const struct drm_encoder_funcs intel_dp_enc_funcs = {
bool g4x_dp_init(struct drm_i915_private *dev_priv,
i915_reg_t output_reg, enum port port)
{
- const struct intel_bios_encoder_data *devdata;
+ struct intel_bios_encoder_data *devdata;
struct intel_digital_port *dig_port;
struct intel_encoder *intel_encoder;
struct drm_encoder *encoder;
struct intel_connector *intel_connector;
devdata = intel_bios_encoder_data_lookup(dev_priv, port);
+ intel_bios_encoder_sanitize(devdata, port);
/* FIXME bail? */
if (!devdata)
diff --git a/drivers/gpu/drm/i915/display/g4x_hdmi.c b/drivers/gpu/drm/i915/display/g4x_hdmi.c
index 3a1144865c30..d6c6726bedf8 100644
--- a/drivers/gpu/drm/i915/display/g4x_hdmi.c
+++ b/drivers/gpu/drm/i915/display/g4x_hdmi.c
@@ -548,12 +548,13 @@ intel_hdmi_hotplug(struct intel_encoder *encoder,
void g4x_hdmi_init(struct drm_i915_private *dev_priv,
i915_reg_t hdmi_reg, enum port port)
{
- const struct intel_bios_encoder_data *devdata;
+ struct intel_bios_encoder_data *devdata;
struct intel_digital_port *dig_port;
struct intel_encoder *intel_encoder;
struct intel_connector *intel_connector;
devdata = intel_bios_encoder_data_lookup(dev_priv, port);
+ intel_bios_encoder_sanitize(devdata, port);
/* FIXME bail? */
if (!devdata)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 22bbbca171dc..ac9fc07e5ccf 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -2222,31 +2222,31 @@ static u8 map_ddc_pin(struct drm_i915_private *i915, u8 vbt_pin)
return 0;
}
-static enum port get_port_by_ddc_pin(struct drm_i915_private *i915, u8 ddc_pin)
+static struct intel_encoder *
+get_encoder_by_ddc_pin(struct drm_i915_private *i915, u8 ddc_pin)
{
- enum port port;
+ struct intel_encoder *encoder;
if (!ddc_pin)
- return PORT_NONE;
+ return NULL;
- for_each_port(port) {
- const struct intel_bios_encoder_data *devdata =
- i915->display.vbt.ports[port];
+ for_each_intel_encoder(&i915->drm, encoder) {
+ const struct intel_bios_encoder_data *devdata = encoder->devdata;
if (devdata && ddc_pin == devdata->child.ddc_pin)
- return port;
+ return encoder;
}
- return PORT_NONE;
+ return NULL;
}
static void sanitize_ddc_pin(struct intel_bios_encoder_data *devdata,
enum port port)
{
struct drm_i915_private *i915 = devdata->i915;
- struct child_device_config *child;
+ struct child_device_config *child = &devdata->child;
+ struct intel_encoder *other;
u8 mapped_ddc_pin;
- enum port p;
if (!devdata->child.ddc_pin)
return;
@@ -2261,79 +2261,85 @@ static void sanitize_ddc_pin(struct intel_bios_encoder_data *devdata,
return;
}
- p = get_port_by_ddc_pin(i915, devdata->child.ddc_pin);
- if (p == PORT_NONE)
+ other = get_encoder_by_ddc_pin(i915, devdata->child.ddc_pin);
+ if (!other)
+ return;
+
+ /*
+ * Pre-HSW uses separate DP and HDMI encoders
+ * for the same port. Let them pass.
+ */
+ if (!HAS_DDI(i915) && devdata == other->devdata)
return;
drm_dbg_kms(&i915->drm,
"port %c trying to use the same DDC pin (0x%x) as port %c, "
"disabling port %c DVI/HDMI support\n",
port_name(port), mapped_ddc_pin,
- port_name(p), port_name(p));
+ port_name(other->port), port_name(port));
/*
* If we have multiple ports supposedly sharing the pin, then dvi/hdmi
* couldn't exist on the shared port. Otherwise they share the same ddc
* pin and system couldn't communicate with them separately.
*
- * Give inverse child device order the priority, last one wins. Yes,
- * there are real machines (eg. Asrock B250M-HDV) where VBT has both
- * port A and port E with the same AUX ch and we must pick port E :(
+ * First successfully initialized encoder wins.
*/
- child = &i915->display.vbt.ports[p]->child;
-
child->device_type &= ~DEVICE_TYPE_TMDS_DVI_SIGNALING;
child->device_type |= DEVICE_TYPE_NOT_HDMI_OUTPUT;
child->ddc_pin = 0;
}
-static enum port get_port_by_aux_ch(struct drm_i915_private *i915, u8 aux_ch)
+static struct intel_encoder *
+get_encoder_by_aux_ch(struct drm_i915_private *i915, u8 aux_ch)
{
- enum port port;
+ struct intel_encoder *encoder;
if (!aux_ch)
- return PORT_NONE;
+ return NULL;
- for_each_port(port) {
- const struct intel_bios_encoder_data *devdata =
- i915->display.vbt.ports[port];
+ for_each_intel_encoder(&i915->drm, encoder) {
+ const struct intel_bios_encoder_data *devdata = encoder->devdata;
if (devdata && aux_ch == devdata->child.aux_channel)
- return port;
+ return encoder;
}
- return PORT_NONE;
+ return NULL;
}
static void sanitize_aux_ch(struct intel_bios_encoder_data *devdata,
enum port port)
{
struct drm_i915_private *i915 = devdata->i915;
- struct child_device_config *child;
- enum port p;
+ struct child_device_config *child = &devdata->child;
+ struct intel_encoder *other;
- p = get_port_by_aux_ch(i915, devdata->child.aux_channel);
- if (p == PORT_NONE)
+ other = get_encoder_by_aux_ch(i915, devdata->child.aux_channel);
+ if (!other)
+ return;
+
+ /*
+ * Pre-HSW uses separate DP and HDMI encoders
+ * for the same port. Let them pass.
+ */
+ if (!HAS_DDI(i915) && devdata == other->devdata)
return;
drm_dbg_kms(&i915->drm,
"port %c trying to use the same AUX CH (0x%x) as port %c, "
"disabling port %c DP support\n",
port_name(port), devdata->child.aux_channel,
- port_name(p), port_name(p));
+ port_name(other->port), port_name(port));
/*
* If we have multiple ports supposedly sharing the aux channel, then DP
* couldn't exist on the shared port. Otherwise they share the same aux
* channel and system couldn't communicate with them separately.
*
- * Give inverse child device order the priority, last one wins. Yes,
- * there are real machines (eg. Asrock B250M-HDV) where VBT has both
- * port A and port E with the same AUX ch and we must pick port E :(
+ * First successfully initialized encoder wins.
*/
- child = &i915->display.vbt.ports[p]->child;
-
child->device_type &= ~DEVICE_TYPE_DISPLAYPORT_OUTPUT;
child->aux_channel = 0;
}
@@ -2744,13 +2750,20 @@ static void parse_ddi_port(struct intel_bios_encoder_data *devdata)
sanitize_device_type(devdata, port);
+ i915->display.vbt.ports[port] = devdata;
+}
+
+void intel_bios_encoder_sanitize(struct intel_bios_encoder_data *devdata,
+ enum port port)
+{
+ if (!devdata)
+ return;
+
if (intel_bios_encoder_supports_dvi(devdata))
sanitize_ddc_pin(devdata, port);
if (intel_bios_encoder_supports_dp(devdata))
sanitize_aux_ch(devdata, port);
-
- i915->display.vbt.ports[port] = devdata;
}
static bool has_ddi_port_info(struct drm_i915_private *i915)
@@ -3711,7 +3724,7 @@ bool intel_bios_encoder_hpd_invert(const struct intel_bios_encoder_data *devdata
return devdata && devdata->child.hpd_invert;
}
-const struct intel_bios_encoder_data *
+struct intel_bios_encoder_data *
intel_bios_encoder_data_lookup(struct drm_i915_private *i915, enum port port)
{
return i915->display.vbt.ports[port];
diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
index 0ce7ed7f28c9..7f72e35eec3d 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.h
+++ b/drivers/gpu/drm/i915/display/intel_bios.h
@@ -256,8 +256,10 @@ bool intel_bios_get_dsc_params(struct intel_encoder *encoder,
int dsc_max_bpc);
bool intel_bios_port_supports_typec_usb(struct drm_i915_private *i915, enum port port);
bool intel_bios_port_supports_tbt(struct drm_i915_private *i915, enum port port);
+void intel_bios_encoder_sanitize(struct intel_bios_encoder_data *devdata,
+ enum port port);
-const struct intel_bios_encoder_data *
+struct intel_bios_encoder_data *
intel_bios_encoder_data_lookup(struct drm_i915_private *i915, enum port port);
bool intel_bios_encoder_supports_dvi(const struct intel_bios_encoder_data *devdata);
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 655309ff5b55..2864592fe6b9 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -35,6 +35,7 @@
#include "intel_audio.h"
#include "intel_audio_regs.h"
#include "intel_backlight.h"
+#include "intel_bios.h"
#include "intel_combo_phy.h"
#include "intel_combo_phy_regs.h"
#include "intel_connector.h"
@@ -4277,7 +4278,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
{
struct intel_digital_port *dig_port;
struct intel_encoder *encoder;
- const struct intel_bios_encoder_data *devdata;
+ struct intel_bios_encoder_data *devdata;
bool init_hdmi, init_dp;
enum phy phy = intel_port_to_phy(dev_priv, port);
@@ -4300,6 +4301,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
port_name(port));
return;
}
+ intel_bios_encoder_sanitize(devdata, port);
init_hdmi = intel_bios_encoder_supports_dvi(devdata) ||
intel_bios_encoder_supports_hdmi(devdata);
--
2.39.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH 3/3] drm/i915: Try to initialize DDI ports for every VBT child device
2023-02-14 23:19 [Intel-gfx] [PATCH 1/3] drm/i915: Use encoder->devdata more Ville Syrjala
2023-02-14 23:19 ` [Intel-gfx] [PATCH 2/3] drm/i915: Sanitize child devices later Ville Syrjala
@ 2023-02-14 23:19 ` Ville Syrjala
2023-02-14 23:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Use encoder->devdata more Patchwork
` (6 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Ville Syrjala @ 2023-02-14 23:19 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Try to deal with duplicate child devices for the same DDI port
by attempting to initialize each in turn. The first on to succeed
will be the one we use.
TODO: Still very rough. Should probably just initialize DDIs
strictly in child device order, and just filter out the
ones that are bogus (eg. via device_info->port_mask etc.)?
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 67 ++++++++++++++-----
drivers/gpu/drm/i915/display/intel_bios.h | 6 ++
drivers/gpu/drm/i915/display/intel_ddi.c | 29 ++++----
.../gpu/drm/i915/display/intel_display_core.h | 2 -
4 files changed, 72 insertions(+), 32 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index ac9fc07e5ccf..73b1f18bc8c9 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -2610,6 +2610,31 @@ intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata)
return devdata && HAS_LSPCON(devdata->i915) && devdata->child.lspcon;
}
+bool
+intel_bios_for_each_child(struct drm_i915_private *i915,
+ enum port port,
+ bool (*func)(struct drm_i915_private *i915,
+ struct intel_bios_encoder_data *devdata,
+ enum port port))
+{
+ struct intel_bios_encoder_data *devdata;
+ bool found = false;
+
+ list_for_each_entry(devdata, &i915->display.vbt.display_devices, node) {
+ const struct child_device_config *child = &devdata->child;
+
+ if (dvo_port_to_port(i915, child->dvo_port) != port)
+ continue;
+
+ found = true;
+
+ if (func(i915, devdata, port))
+ break;
+ }
+
+ return found;
+}
+
/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */
int intel_bios_encoder_hdmi_level_shift(const struct intel_bios_encoder_data *devdata)
{
@@ -2656,13 +2681,19 @@ static bool is_port_valid(struct drm_i915_private *i915, enum port port)
return true;
}
-static void print_ddi_port(const struct intel_bios_encoder_data *devdata,
- enum port port)
+static void print_ddi_port(const struct intel_bios_encoder_data *devdata)
{
struct drm_i915_private *i915 = devdata->i915;
const struct child_device_config *child = &devdata->child;
bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, supports_tbt;
int dp_boost_level, dp_max_link_rate, hdmi_boost_level, hdmi_level_shift, max_tmds_clock;
+ enum port port;
+
+ port = dvo_port_to_port(i915, child->dvo_port);
+ if (port == PORT_NONE && DISPLAY_VER(i915) >= 11)
+ port = dsi_dvo_port_to_port(i915, child->dvo_port);
+ if (port == PORT_NONE)
+ return;
is_dvi = intel_bios_encoder_supports_dvi(devdata);
is_dp = intel_bios_encoder_supports_dp(devdata);
@@ -2741,16 +2772,7 @@ static void parse_ddi_port(struct intel_bios_encoder_data *devdata)
return;
}
- if (i915->display.vbt.ports[port]) {
- drm_dbg_kms(&i915->drm,
- "More than one child device for port %c in VBT, using the first.\n",
- port_name(port));
- return;
- }
-
sanitize_device_type(devdata, port);
-
- i915->display.vbt.ports[port] = devdata;
}
void intel_bios_encoder_sanitize(struct intel_bios_encoder_data *devdata,
@@ -2774,7 +2796,6 @@ static bool has_ddi_port_info(struct drm_i915_private *i915)
static void parse_ddi_ports(struct drm_i915_private *i915)
{
struct intel_bios_encoder_data *devdata;
- enum port port;
if (!has_ddi_port_info(i915))
return;
@@ -2782,10 +2803,8 @@ static void parse_ddi_ports(struct drm_i915_private *i915)
list_for_each_entry(devdata, &i915->display.vbt.display_devices, node)
parse_ddi_port(devdata);
- for_each_port(port) {
- if (i915->display.vbt.ports[port])
- print_ddi_port(i915->display.vbt.ports[port], port);
- }
+ list_for_each_entry(devdata, &i915->display.vbt.display_devices, node)
+ print_ddi_port(devdata);
}
static void
@@ -3727,5 +3746,19 @@ bool intel_bios_encoder_hpd_invert(const struct intel_bios_encoder_data *devdata
struct intel_bios_encoder_data *
intel_bios_encoder_data_lookup(struct drm_i915_private *i915, enum port port)
{
- return i915->display.vbt.ports[port];
+ struct intel_bios_encoder_data *devdata;
+
+ list_for_each_entry(devdata, &i915->display.vbt.display_devices, node) {
+ const struct child_device_config *child = &devdata->child;
+ enum port p;
+
+ p = dvo_port_to_port(i915, child->dvo_port);
+ if (p == PORT_NONE && DISPLAY_VER(i915) >= 11)
+ p = dsi_dvo_port_to_port(i915, child->dvo_port);
+
+ if (p == port)
+ return devdata;
+ }
+
+ return NULL;
}
diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
index 7f72e35eec3d..c3b79793ec18 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.h
+++ b/drivers/gpu/drm/i915/display/intel_bios.h
@@ -280,4 +280,10 @@ int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *de
int intel_bios_encoder_hdmi_level_shift(const struct intel_bios_encoder_data *devdata);
int intel_bios_encoder_hdmi_ddc_pin(const struct intel_bios_encoder_data *devdata);
+bool
+intel_bios_for_each_child(struct drm_i915_private *i915,
+ enum port port,
+ bool (*func)(struct drm_i915_private *i915,
+ struct intel_bios_encoder_data *devdata, enum port port));
+
#endif /* _INTEL_BIOS_H_ */
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 2864592fe6b9..b05eca899ace 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -4274,11 +4274,12 @@ static void intel_ddi_encoder_shutdown(struct intel_encoder *encoder)
#define port_tc_name(port) ((port) - PORT_TC1 + '1')
#define tc_port_name(tc_port) ((tc_port) - TC_PORT_1 + '1')
-void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
+static bool _intel_ddi_init(struct drm_i915_private *dev_priv,
+ struct intel_bios_encoder_data *devdata,
+ enum port port)
{
struct intel_digital_port *dig_port;
struct intel_encoder *encoder;
- struct intel_bios_encoder_data *devdata;
bool init_hdmi, init_dp;
enum phy phy = intel_port_to_phy(dev_priv, port);
@@ -4291,16 +4292,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
if (intel_hti_uses_phy(dev_priv, phy)) {
drm_dbg_kms(&dev_priv->drm, "PORT %c / PHY %c reserved by HTI\n",
port_name(port), phy_name(phy));
- return;
+ return false;
}
- devdata = intel_bios_encoder_data_lookup(dev_priv, port);
- if (!devdata) {
- drm_dbg_kms(&dev_priv->drm,
- "VBT says port %c is not present\n",
- port_name(port));
- return;
- }
intel_bios_encoder_sanitize(devdata, port);
init_hdmi = intel_bios_encoder_supports_dvi(devdata) ||
@@ -4323,7 +4317,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
drm_dbg_kms(&dev_priv->drm,
"VBT says port %c is not DVI/HDMI/DP compatible, respect it\n",
port_name(port));
- return;
+ return false;
}
if (intel_phy_is_snps(dev_priv, phy) &&
@@ -4335,7 +4329,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
dig_port = kzalloc(sizeof(*dig_port), GFP_KERNEL);
if (!dig_port)
- return;
+ return false;
encoder = &dig_port->base;
encoder->devdata = devdata;
@@ -4560,9 +4554,18 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
intel_infoframe_init(dig_port);
- return;
+ return true;
err:
drm_encoder_cleanup(&encoder->base);
kfree(dig_port);
+ return false;
+}
+
+void intel_ddi_init(struct drm_i915_private *i915, enum port port)
+{
+ if (!intel_bios_for_each_child(i915, port, _intel_ddi_init))
+ drm_dbg_kms(&i915->drm,
+ "VBT says port %c is not present\n",
+ port_name(port));
}
diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h b/drivers/gpu/drm/i915/display/intel_display_core.h
index 25d778fb7d15..b63c5db76a97 100644
--- a/drivers/gpu/drm/i915/display/intel_display_core.h
+++ b/drivers/gpu/drm/i915/display/intel_display_core.h
@@ -34,7 +34,6 @@ struct i915_audio_component;
struct i915_hdcp_comp_master;
struct intel_atomic_state;
struct intel_audio_funcs;
-struct intel_bios_encoder_data;
struct intel_cdclk_funcs;
struct intel_cdclk_vals;
struct intel_color_funcs;
@@ -206,7 +205,6 @@ struct intel_vbt_data {
struct list_head display_devices;
struct list_head bdb_blocks;
- struct intel_bios_encoder_data *ports[I915_MAX_PORTS]; /* Non-NULL if port present. */
struct sdvo_device_mapping {
u8 initialized;
u8 dvo_port;
--
2.39.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Use encoder->devdata more
2023-02-14 23:19 [Intel-gfx] [PATCH 1/3] drm/i915: Use encoder->devdata more Ville Syrjala
2023-02-14 23:19 ` [Intel-gfx] [PATCH 2/3] drm/i915: Sanitize child devices later Ville Syrjala
2023-02-14 23:19 ` [Intel-gfx] [PATCH 3/3] drm/i915: Try to initialize DDI ports for every VBT child device Ville Syrjala
@ 2023-02-14 23:56 ` Patchwork
2023-02-15 10:02 ` [Intel-gfx] [PATCH 1/3] " Jani Nikula
` (5 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-02-14 23:56 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3475 bytes --]
== Series Details ==
Series: series starting with [1/3] drm/i915: Use encoder->devdata more
URL : https://patchwork.freedesktop.org/series/114029/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12739 -> Patchwork_114029v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/index.html
Participating hosts (39 -> 37)
------------------------------
Missing (2): fi-kbl-soraka fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_114029v1:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_suspend@basic-s2idle-without-i915:
- {bat-rpls-1}: NOTRUN -> [ABORT][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/bat-rpls-1/igt@i915_suspend@basic-s2idle-without-i915.html
Known issues
------------
Here are the changes found in Patchwork_114029v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-n3050: [PASS][2] -> [FAIL][3] ([i915#6298])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
#### Possible fixes ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [FAIL][4] ([i915#7229]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
* igt@i915_selftest@live@reset:
- {bat-rpls-1}: [ABORT][6] ([i915#4983]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/bat-rpls-1/igt@i915_selftest@live@reset.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/bat-rpls-1/igt@i915_selftest@live@reset.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
Build changes
-------------
* Linux: CI_DRM_12739 -> Patchwork_114029v1
CI-20190529: 20190529
CI_DRM_12739: 5fc904286af94038fbf2c7cda50ed871b70cf4e8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7160: 45da871dd2684227e93a2fc002b87dfc58bd5fd9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114029v1: 5fc904286af94038fbf2c7cda50ed871b70cf4e8 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
7df05f4bf1da drm/i915: Try to initialize DDI ports for every VBT child device
c71fdcbe502e drm/i915: Sanitize child devices later
4e89250129c9 drm/i915: Use encoder->devdata more
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/index.html
[-- Attachment #2: Type: text/html, Size: 4124 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use encoder->devdata more
2023-02-14 23:19 [Intel-gfx] [PATCH 1/3] drm/i915: Use encoder->devdata more Ville Syrjala
` (2 preceding siblings ...)
2023-02-14 23:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Use encoder->devdata more Patchwork
@ 2023-02-15 10:02 ` Jani Nikula
2023-02-15 10:35 ` Ville Syrjälä
2023-02-15 11:04 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork
` (4 subsequent siblings)
8 siblings, 1 reply; 12+ messages in thread
From: Jani Nikula @ 2023-02-15 10:02 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On Wed, 15 Feb 2023, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Switch a lot of the intel_bios_foo() stuff to just accept the
> devdata (VBT child device info) directly, instead of taking
> detours via vbt.ports[].
>
> Also unify the function naming scheme.
>
> TODO: is intel_bios_encoder_{dp,hdmi}_ too much? Or should we
> shorten to just intel_bios_{dp,hdmi}_ ?
I think I added encoder in the name to distinguish from the old stuff,
but if everything's going to be based on encoder->devdata, I don't see
what the point is. Could just shorten it I guess?
BR,
Jani.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 54 +++++------------------
> drivers/gpu/drm/i915/display/intel_bios.h | 15 ++++---
> drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
> drivers/gpu/drm/i915/display/intel_dp.c | 4 +-
> drivers/gpu/drm/i915/display/intel_hdmi.c | 4 +-
> 5 files changed, 23 insertions(+), 56 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 229f9782e226..22bbbca171dc 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -2520,7 +2520,7 @@ static int parse_bdb_216_dp_max_link_rate(const int vbt_max_link_rate)
> }
> }
>
> -static int _intel_bios_dp_max_link_rate(const struct intel_bios_encoder_data *devdata)
> +int intel_bios_encoder_dp_max_link_rate(const struct intel_bios_encoder_data *devdata)
> {
> if (!devdata || devdata->i915->display.vbt.version < 216)
> return 0;
> @@ -2531,7 +2531,7 @@ static int _intel_bios_dp_max_link_rate(const struct intel_bios_encoder_data *de
> return parse_bdb_216_dp_max_link_rate(devdata->child.dp_max_link_rate);
> }
>
> -static int _intel_bios_dp_max_lane_count(const struct intel_bios_encoder_data *devdata)
> +int intel_bios_encoder_dp_max_lane_count(const struct intel_bios_encoder_data *devdata)
> {
> if (!devdata || devdata->i915->display.vbt.version < 244)
> return 0;
> @@ -2604,7 +2604,8 @@ intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata)
> return devdata && HAS_LSPCON(devdata->i915) && devdata->child.lspcon;
> }
>
> -static int _intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data *devdata)
> +/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */
> +int intel_bios_encoder_hdmi_level_shift(const struct intel_bios_encoder_data *devdata)
> {
> if (!devdata || devdata->i915->display.vbt.version < 158)
> return -1;
> @@ -2612,7 +2613,7 @@ static int _intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data *de
> return devdata->child.hdmi_level_shifter_value;
> }
>
> -static int _intel_bios_max_tmds_clock(const struct intel_bios_encoder_data *devdata)
> +int intel_bios_encoder_hdmi_max_tmds_clock(const struct intel_bios_encoder_data *devdata)
> {
> if (!devdata || devdata->i915->display.vbt.version < 204)
> return 0;
> @@ -2674,14 +2675,14 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata,
> supports_typec_usb, supports_tbt,
> devdata->dsc != NULL);
>
> - hdmi_level_shift = _intel_bios_hdmi_level_shift(devdata);
> + hdmi_level_shift = intel_bios_encoder_hdmi_level_shift(devdata);
> if (hdmi_level_shift >= 0) {
> drm_dbg_kms(&i915->drm,
> "Port %c VBT HDMI level shift: %d\n",
> port_name(port), hdmi_level_shift);
> }
>
> - max_tmds_clock = _intel_bios_max_tmds_clock(devdata);
> + max_tmds_clock = intel_bios_encoder_hdmi_max_tmds_clock(devdata);
> if (max_tmds_clock)
> drm_dbg_kms(&i915->drm,
> "Port %c VBT HDMI max TMDS clock: %d kHz\n",
> @@ -2700,7 +2701,7 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata,
> "Port %c VBT HDMI boost level: %d\n",
> port_name(port), hdmi_boost_level);
>
> - dp_max_link_rate = _intel_bios_dp_max_link_rate(devdata);
> + dp_max_link_rate = intel_bios_encoder_dp_max_link_rate(devdata);
> if (dp_max_link_rate)
> drm_dbg_kms(&i915->drm,
> "Port %c VBT DP max link rate: %d\n",
> @@ -3665,22 +3666,6 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *i915,
> return aux_ch;
> }
>
> -int intel_bios_max_tmds_clock(struct intel_encoder *encoder)
> -{
> - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> - const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
> -
> - return _intel_bios_max_tmds_clock(devdata);
> -}
> -
> -/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */
> -int intel_bios_hdmi_level_shift(struct intel_encoder *encoder)
> -{
> - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> - const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
> -
> - return _intel_bios_hdmi_level_shift(devdata);
> -}
>
> int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devdata)
> {
> @@ -3698,31 +3683,12 @@ int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *de
> return translate_iboost(devdata->child.hdmi_iboost_level);
> }
>
> -int intel_bios_dp_max_link_rate(struct intel_encoder *encoder)
> +int intel_bios_encoder_hdmi_ddc_pin(const struct intel_bios_encoder_data *devdata)
> {
> - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> - const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
> -
> - return _intel_bios_dp_max_link_rate(devdata);
> -}
> -
> -int intel_bios_dp_max_lane_count(struct intel_encoder *encoder)
> -{
> - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> - const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
> -
> - return _intel_bios_dp_max_lane_count(devdata);
> -}
> -
> -int intel_bios_alternate_ddc_pin(struct intel_encoder *encoder)
> -{
> - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> - const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
> -
> if (!devdata || !devdata->child.ddc_pin)
> return 0;
>
> - return map_ddc_pin(i915, devdata->child.ddc_pin);
> + return map_ddc_pin(devdata->i915, devdata->child.ddc_pin);
> }
>
> bool intel_bios_encoder_supports_typec_usb(const struct intel_bios_encoder_data *devdata)
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
> index 1a6ae38bd4f6..0ce7ed7f28c9 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.h
> +++ b/drivers/gpu/drm/i915/display/intel_bios.h
> @@ -254,11 +254,6 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *i915,
> bool intel_bios_get_dsc_params(struct intel_encoder *encoder,
> struct intel_crtc_state *crtc_state,
> int dsc_max_bpc);
> -int intel_bios_max_tmds_clock(struct intel_encoder *encoder);
> -int intel_bios_hdmi_level_shift(struct intel_encoder *encoder);
> -int intel_bios_dp_max_link_rate(struct intel_encoder *encoder);
> -int intel_bios_dp_max_lane_count(struct intel_encoder *encoder);
> -int intel_bios_alternate_ddc_pin(struct intel_encoder *encoder);
> bool intel_bios_port_supports_typec_usb(struct drm_i915_private *i915, enum port port);
> bool intel_bios_port_supports_tbt(struct drm_i915_private *i915, enum port port);
>
> @@ -272,9 +267,15 @@ bool intel_bios_encoder_supports_edp(const struct intel_bios_encoder_data *devda
> bool intel_bios_encoder_supports_typec_usb(const struct intel_bios_encoder_data *devdata);
> bool intel_bios_encoder_supports_tbt(const struct intel_bios_encoder_data *devdata);
> bool intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata);
> -int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devdata);
> -int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *devdata);
> bool intel_bios_encoder_lane_reversal(const struct intel_bios_encoder_data *devdata);
> bool intel_bios_encoder_hpd_invert(const struct intel_bios_encoder_data *devdata);
> +int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devdata);
> +int intel_bios_encoder_dp_max_link_rate(const struct intel_bios_encoder_data *devdata);
> +int intel_bios_encoder_dp_max_lane_count(const struct intel_bios_encoder_data *devdata);
> +int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *devdata);
> +int intel_bios_encoder_hdmi_max_tmds_clock(const struct intel_bios_encoder_data *devdata);
> +int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *devdata);
> +int intel_bios_encoder_hdmi_level_shift(const struct intel_bios_encoder_data *devdata);
> +int intel_bios_encoder_hdmi_ddc_pin(const struct intel_bios_encoder_data *devdata);
>
> #endif /* _INTEL_BIOS_H_ */
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index bfd1e30a27b4..655309ff5b55 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -89,7 +89,7 @@ static int intel_ddi_hdmi_level(struct intel_encoder *encoder,
> {
> int level;
>
> - level = intel_bios_hdmi_level_shift(encoder);
> + level = intel_bios_encoder_hdmi_level_shift(encoder->devdata);
> if (level < 0)
> level = trans->hdmi_default_entry;
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index b92e0b0f5369..7fd4c5ccf7e5 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -288,7 +288,7 @@ static int intel_dp_max_common_rate(struct intel_dp *intel_dp)
>
> static int intel_dp_max_source_lane_count(struct intel_digital_port *dig_port)
> {
> - int vbt_max_lanes = intel_bios_dp_max_lane_count(&dig_port->base);
> + int vbt_max_lanes = intel_bios_encoder_dp_max_lane_count(dig_port->base.devdata);
> int max_lanes = dig_port->max_lanes;
>
> if (vbt_max_lanes)
> @@ -425,7 +425,7 @@ static int vbt_max_link_rate(struct intel_dp *intel_dp)
> struct intel_encoder *encoder = &dp_to_dig_port(intel_dp)->base;
> int max_rate;
>
> - max_rate = intel_bios_dp_max_link_rate(encoder);
> + max_rate = intel_bios_encoder_dp_max_link_rate(encoder->devdata);
>
> if (intel_dp_is_edp(intel_dp)) {
> struct intel_connector *connector = intel_dp->attached_connector;
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 619865b45eca..07a1495bd55f 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1795,7 +1795,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder)
> else
> max_tmds_clock = 165000;
>
> - vbt_max_tmds_clock = intel_bios_max_tmds_clock(encoder);
> + vbt_max_tmds_clock = intel_bios_encoder_hdmi_max_tmds_clock(encoder->devdata);
> if (vbt_max_tmds_clock)
> max_tmds_clock = min(max_tmds_clock, vbt_max_tmds_clock);
>
> @@ -2871,7 +2871,7 @@ static u8 intel_hdmi_ddc_pin(struct intel_encoder *encoder)
> enum port port = encoder->port;
> u8 ddc_pin;
>
> - ddc_pin = intel_bios_alternate_ddc_pin(encoder);
> + ddc_pin = intel_bios_encoder_hdmi_ddc_pin(encoder->devdata);
> if (ddc_pin) {
> drm_dbg_kms(&dev_priv->drm,
> "Using DDC pin 0x%x for port %c (VBT)\n",
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use encoder->devdata more
2023-02-15 10:02 ` [Intel-gfx] [PATCH 1/3] " Jani Nikula
@ 2023-02-15 10:35 ` Ville Syrjälä
0 siblings, 0 replies; 12+ messages in thread
From: Ville Syrjälä @ 2023-02-15 10:35 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Feb 15, 2023 at 12:02:41PM +0200, Jani Nikula wrote:
> On Wed, 15 Feb 2023, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Switch a lot of the intel_bios_foo() stuff to just accept the
> > devdata (VBT child device info) directly, instead of taking
> > detours via vbt.ports[].
> >
> > Also unify the function naming scheme.
> >
> > TODO: is intel_bios_encoder_{dp,hdmi}_ too much? Or should we
> > shorten to just intel_bios_{dp,hdmi}_ ?
>
> I think I added encoder in the name to distinguish from the old stuff,
> but if everything's going to be based on encoder->devdata, I don't see
> what the point is. Could just shorten it I guess?
Agreed. I'll drop the extra junk in v2.
>
> BR,
> Jani.
>
>
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_bios.c | 54 +++++------------------
> > drivers/gpu/drm/i915/display/intel_bios.h | 15 ++++---
> > drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_dp.c | 4 +-
> > drivers/gpu/drm/i915/display/intel_hdmi.c | 4 +-
> > 5 files changed, 23 insertions(+), 56 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> > index 229f9782e226..22bbbca171dc 100644
> > --- a/drivers/gpu/drm/i915/display/intel_bios.c
> > +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> > @@ -2520,7 +2520,7 @@ static int parse_bdb_216_dp_max_link_rate(const int vbt_max_link_rate)
> > }
> > }
> >
> > -static int _intel_bios_dp_max_link_rate(const struct intel_bios_encoder_data *devdata)
> > +int intel_bios_encoder_dp_max_link_rate(const struct intel_bios_encoder_data *devdata)
> > {
> > if (!devdata || devdata->i915->display.vbt.version < 216)
> > return 0;
> > @@ -2531,7 +2531,7 @@ static int _intel_bios_dp_max_link_rate(const struct intel_bios_encoder_data *de
> > return parse_bdb_216_dp_max_link_rate(devdata->child.dp_max_link_rate);
> > }
> >
> > -static int _intel_bios_dp_max_lane_count(const struct intel_bios_encoder_data *devdata)
> > +int intel_bios_encoder_dp_max_lane_count(const struct intel_bios_encoder_data *devdata)
> > {
> > if (!devdata || devdata->i915->display.vbt.version < 244)
> > return 0;
> > @@ -2604,7 +2604,8 @@ intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata)
> > return devdata && HAS_LSPCON(devdata->i915) && devdata->child.lspcon;
> > }
> >
> > -static int _intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data *devdata)
> > +/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */
> > +int intel_bios_encoder_hdmi_level_shift(const struct intel_bios_encoder_data *devdata)
> > {
> > if (!devdata || devdata->i915->display.vbt.version < 158)
> > return -1;
> > @@ -2612,7 +2613,7 @@ static int _intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data *de
> > return devdata->child.hdmi_level_shifter_value;
> > }
> >
> > -static int _intel_bios_max_tmds_clock(const struct intel_bios_encoder_data *devdata)
> > +int intel_bios_encoder_hdmi_max_tmds_clock(const struct intel_bios_encoder_data *devdata)
> > {
> > if (!devdata || devdata->i915->display.vbt.version < 204)
> > return 0;
> > @@ -2674,14 +2675,14 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata,
> > supports_typec_usb, supports_tbt,
> > devdata->dsc != NULL);
> >
> > - hdmi_level_shift = _intel_bios_hdmi_level_shift(devdata);
> > + hdmi_level_shift = intel_bios_encoder_hdmi_level_shift(devdata);
> > if (hdmi_level_shift >= 0) {
> > drm_dbg_kms(&i915->drm,
> > "Port %c VBT HDMI level shift: %d\n",
> > port_name(port), hdmi_level_shift);
> > }
> >
> > - max_tmds_clock = _intel_bios_max_tmds_clock(devdata);
> > + max_tmds_clock = intel_bios_encoder_hdmi_max_tmds_clock(devdata);
> > if (max_tmds_clock)
> > drm_dbg_kms(&i915->drm,
> > "Port %c VBT HDMI max TMDS clock: %d kHz\n",
> > @@ -2700,7 +2701,7 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata,
> > "Port %c VBT HDMI boost level: %d\n",
> > port_name(port), hdmi_boost_level);
> >
> > - dp_max_link_rate = _intel_bios_dp_max_link_rate(devdata);
> > + dp_max_link_rate = intel_bios_encoder_dp_max_link_rate(devdata);
> > if (dp_max_link_rate)
> > drm_dbg_kms(&i915->drm,
> > "Port %c VBT DP max link rate: %d\n",
> > @@ -3665,22 +3666,6 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *i915,
> > return aux_ch;
> > }
> >
> > -int intel_bios_max_tmds_clock(struct intel_encoder *encoder)
> > -{
> > - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> > - const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
> > -
> > - return _intel_bios_max_tmds_clock(devdata);
> > -}
> > -
> > -/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */
> > -int intel_bios_hdmi_level_shift(struct intel_encoder *encoder)
> > -{
> > - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> > - const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
> > -
> > - return _intel_bios_hdmi_level_shift(devdata);
> > -}
> >
> > int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devdata)
> > {
> > @@ -3698,31 +3683,12 @@ int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *de
> > return translate_iboost(devdata->child.hdmi_iboost_level);
> > }
> >
> > -int intel_bios_dp_max_link_rate(struct intel_encoder *encoder)
> > +int intel_bios_encoder_hdmi_ddc_pin(const struct intel_bios_encoder_data *devdata)
> > {
> > - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> > - const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
> > -
> > - return _intel_bios_dp_max_link_rate(devdata);
> > -}
> > -
> > -int intel_bios_dp_max_lane_count(struct intel_encoder *encoder)
> > -{
> > - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> > - const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
> > -
> > - return _intel_bios_dp_max_lane_count(devdata);
> > -}
> > -
> > -int intel_bios_alternate_ddc_pin(struct intel_encoder *encoder)
> > -{
> > - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> > - const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
> > -
> > if (!devdata || !devdata->child.ddc_pin)
> > return 0;
> >
> > - return map_ddc_pin(i915, devdata->child.ddc_pin);
> > + return map_ddc_pin(devdata->i915, devdata->child.ddc_pin);
> > }
> >
> > bool intel_bios_encoder_supports_typec_usb(const struct intel_bios_encoder_data *devdata)
> > diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
> > index 1a6ae38bd4f6..0ce7ed7f28c9 100644
> > --- a/drivers/gpu/drm/i915/display/intel_bios.h
> > +++ b/drivers/gpu/drm/i915/display/intel_bios.h
> > @@ -254,11 +254,6 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *i915,
> > bool intel_bios_get_dsc_params(struct intel_encoder *encoder,
> > struct intel_crtc_state *crtc_state,
> > int dsc_max_bpc);
> > -int intel_bios_max_tmds_clock(struct intel_encoder *encoder);
> > -int intel_bios_hdmi_level_shift(struct intel_encoder *encoder);
> > -int intel_bios_dp_max_link_rate(struct intel_encoder *encoder);
> > -int intel_bios_dp_max_lane_count(struct intel_encoder *encoder);
> > -int intel_bios_alternate_ddc_pin(struct intel_encoder *encoder);
> > bool intel_bios_port_supports_typec_usb(struct drm_i915_private *i915, enum port port);
> > bool intel_bios_port_supports_tbt(struct drm_i915_private *i915, enum port port);
> >
> > @@ -272,9 +267,15 @@ bool intel_bios_encoder_supports_edp(const struct intel_bios_encoder_data *devda
> > bool intel_bios_encoder_supports_typec_usb(const struct intel_bios_encoder_data *devdata);
> > bool intel_bios_encoder_supports_tbt(const struct intel_bios_encoder_data *devdata);
> > bool intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata);
> > -int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devdata);
> > -int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *devdata);
> > bool intel_bios_encoder_lane_reversal(const struct intel_bios_encoder_data *devdata);
> > bool intel_bios_encoder_hpd_invert(const struct intel_bios_encoder_data *devdata);
> > +int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devdata);
> > +int intel_bios_encoder_dp_max_link_rate(const struct intel_bios_encoder_data *devdata);
> > +int intel_bios_encoder_dp_max_lane_count(const struct intel_bios_encoder_data *devdata);
> > +int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *devdata);
> > +int intel_bios_encoder_hdmi_max_tmds_clock(const struct intel_bios_encoder_data *devdata);
> > +int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *devdata);
> > +int intel_bios_encoder_hdmi_level_shift(const struct intel_bios_encoder_data *devdata);
> > +int intel_bios_encoder_hdmi_ddc_pin(const struct intel_bios_encoder_data *devdata);
> >
> > #endif /* _INTEL_BIOS_H_ */
> > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> > index bfd1e30a27b4..655309ff5b55 100644
> > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > @@ -89,7 +89,7 @@ static int intel_ddi_hdmi_level(struct intel_encoder *encoder,
> > {
> > int level;
> >
> > - level = intel_bios_hdmi_level_shift(encoder);
> > + level = intel_bios_encoder_hdmi_level_shift(encoder->devdata);
> > if (level < 0)
> > level = trans->hdmi_default_entry;
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > index b92e0b0f5369..7fd4c5ccf7e5 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -288,7 +288,7 @@ static int intel_dp_max_common_rate(struct intel_dp *intel_dp)
> >
> > static int intel_dp_max_source_lane_count(struct intel_digital_port *dig_port)
> > {
> > - int vbt_max_lanes = intel_bios_dp_max_lane_count(&dig_port->base);
> > + int vbt_max_lanes = intel_bios_encoder_dp_max_lane_count(dig_port->base.devdata);
> > int max_lanes = dig_port->max_lanes;
> >
> > if (vbt_max_lanes)
> > @@ -425,7 +425,7 @@ static int vbt_max_link_rate(struct intel_dp *intel_dp)
> > struct intel_encoder *encoder = &dp_to_dig_port(intel_dp)->base;
> > int max_rate;
> >
> > - max_rate = intel_bios_dp_max_link_rate(encoder);
> > + max_rate = intel_bios_encoder_dp_max_link_rate(encoder->devdata);
> >
> > if (intel_dp_is_edp(intel_dp)) {
> > struct intel_connector *connector = intel_dp->attached_connector;
> > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> > index 619865b45eca..07a1495bd55f 100644
> > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> > @@ -1795,7 +1795,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder)
> > else
> > max_tmds_clock = 165000;
> >
> > - vbt_max_tmds_clock = intel_bios_max_tmds_clock(encoder);
> > + vbt_max_tmds_clock = intel_bios_encoder_hdmi_max_tmds_clock(encoder->devdata);
> > if (vbt_max_tmds_clock)
> > max_tmds_clock = min(max_tmds_clock, vbt_max_tmds_clock);
> >
> > @@ -2871,7 +2871,7 @@ static u8 intel_hdmi_ddc_pin(struct intel_encoder *encoder)
> > enum port port = encoder->port;
> > u8 ddc_pin;
> >
> > - ddc_pin = intel_bios_alternate_ddc_pin(encoder);
> > + ddc_pin = intel_bios_encoder_hdmi_ddc_pin(encoder->devdata);
> > if (ddc_pin) {
> > drm_dbg_kms(&dev_priv->drm,
> > "Using DDC pin 0x%x for port %c (VBT)\n",
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Use encoder->devdata more
2023-02-14 23:19 [Intel-gfx] [PATCH 1/3] drm/i915: Use encoder->devdata more Ville Syrjala
` (3 preceding siblings ...)
2023-02-15 10:02 ` [Intel-gfx] [PATCH 1/3] " Jani Nikula
@ 2023-02-15 11:04 ` Patchwork
2023-02-16 0:04 ` [Intel-gfx] [PATCH v2 1/3] " Ville Syrjala
` (3 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-02-15 11:04 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 50493 bytes --]
== Series Details ==
Series: series starting with [1/3] drm/i915: Use encoder->devdata more
URL : https://patchwork.freedesktop.org/series/114029/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12739_full -> Patchwork_114029v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/index.html
Participating hosts (11 -> 10)
------------------------------
Missing (1): shard-rkl0
New tests
---------
New tests have been introduced between CI_DRM_12739_full and Patchwork_114029v1_full:
### New IGT tests (255) ###
* igt@core_setmaster@master-drop-set-root:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@core_setmaster@master-drop-set-shared-fd:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@core_setmaster@master-drop-set-user:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@all-busy-check-all:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@all-busy-idle-check-all:
- Statuses : 3 pass(s) 2 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@basics:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-check-all:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-check-all@bcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-check-all@rcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-check-all@vcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-check-all@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-check-all@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-hang:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-hang@bcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-hang@rcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-hang@vcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-hang@vecs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-idle:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-idle-check-all:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-idle-check-all@bcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-idle-check-all@rcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-idle-check-all@vcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-idle-check-all@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-idle-check-all@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-idle@bcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-idle@rcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-idle@vcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-idle@vecs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy@bcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy@rcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy@vcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@idle:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@idle@bcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@idle@rcs0:
- Statuses : 1 fail(s) 3 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@idle@vcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@idle@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@idle@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@isolation@bcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@isolation@rcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@isolation@vcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@isolation@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@isolation@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@most-busy-check-all:
- Statuses : 2 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@most-busy-check-all@bcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@most-busy-check-all@vcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@most-busy-check-all@vecs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@most-busy-idle-check-all:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@most-busy-idle-check-all@bcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@most-busy-idle-check-all@vcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@most-busy-idle-check-all@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@most-busy-idle-check-all@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ccs@block-copy-inplace:
- Statuses : 4 skip(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@clean:
- Statuses :
- Exec time: [None] s
* igt@gem_ctx_isolation@clean@bcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@clean@rcs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@clean@vcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@clean@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@clean@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@dirty-create:
- Statuses :
- Exec time: [None] s
* igt@gem_ctx_isolation@dirty-create@bcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@dirty-create@rcs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@dirty-create@vcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@dirty-create@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@dirty-create@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@dirty-switch:
- Statuses :
- Exec time: [None] s
* igt@gem_ctx_isolation@dirty-switch@bcs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@dirty-switch@rcs0:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@dirty-switch@vcs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@dirty-switch@vcs1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@dirty-switch@vecs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@nonpriv:
- Statuses :
- Exec time: [None] s
* igt@gem_ctx_isolation@nonpriv-switch:
- Statuses :
- Exec time: [None] s
* igt@gem_ctx_isolation@nonpriv-switch@bcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@nonpriv-switch@rcs0:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@nonpriv-switch@vcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@nonpriv-switch@vecs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@nonpriv@bcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@nonpriv@rcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@nonpriv@vcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@nonpriv@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@nonpriv@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@preservation:
- Statuses :
- Exec time: [None] s
* igt@gem_ctx_isolation@preservation-reset:
- Statuses :
- Exec time: [None] s
* igt@gem_ctx_isolation@preservation-reset@bcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@preservation-reset@rcs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@preservation-reset@vcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@preservation-reset@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@preservation-reset@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@preservation-s3:
- Statuses :
- Exec time: [None] s
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@preservation-s3@vcs1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@preservation-s3@vecs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@preservation@bcs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@preservation@rcs0:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@preservation@vcs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@preservation@vcs1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_isolation@preservation@vecs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@exec-shared-gtt:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@exec-shared-gtt@bcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@exec-shared-gtt@rcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@exec-shared-gtt@vcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@exec-shared-gtt@vecs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@exec-single-timeline:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@exec-single-timeline@bcs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@exec-single-timeline@rcs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@exec-single-timeline@vcs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@exec-single-timeline@vcs1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@exec-single-timeline@vecs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-in-order:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-in-order@bcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-in-order@rcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-in-order@vcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-in-order@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-in-order@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-independent:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-independent@bcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-independent@rcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-independent@vcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-independent@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-independent@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-out-order:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-out-order@bcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-out-order@rcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-out-order@vcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-out-order@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-out-order@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-promotion:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-promotion@bcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-promotion@rcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-promotion@vcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-promotion@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-promotion@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-smoketest:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-smoketest@bcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-smoketest@rcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-smoketest@vcs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@gem_ctx_shared@q-smoketest@vecs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@gem_exec_big@single:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@gem_exec_schedule@semaphore-power:
- Statuses : 2 pass(s) 3 skip(s)
- Exec time: [0.0] s
* igt@gem_mmap@bad-offset:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@gem_mmap@bad-size:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@gem_mmap@pf-nonblock:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_mmap_gtt@bad-object:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@gem_mmap_gtt@pf-nonblock:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_mmap_offset@oob-read:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@gem_mmap_wc@bad-object:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_mmap_wc@bad-offset:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@gem_mmap_wc@bad-size:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@gem_mmap_wc@pf-nonblock:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@gem_render_copy@y-tiled-ccs-to-yf-tiled:
- Statuses :
- Exec time: [None] s
* igt@gem_render_copy@yf-tiled:
- Statuses :
- Exec time: [None] s
* igt@gem_render_copy@yf-tiled-ccs-to-linear:
- Statuses :
- Exec time: [None] s
* igt@gem_render_copy@yf-tiled-ccs-to-x-tiled:
- Statuses :
- Exec time: [None] s
* igt@gem_render_copy@yf-tiled-ccs-to-y-tiled:
- Statuses :
- Exec time: [None] s
* igt@gem_render_copy@yf-tiled-ccs-to-yf-tiled:
- Statuses :
- Exec time: [None] s
* igt@gem_watchdog@default-physical:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@gem_watchdog@default-virtual:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@i915_pm_dc@dc9-dpms:
- Statuses : 1 pass(s) 4 skip(s)
- Exec time: [0.0] s
* igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack-mmap-gtt:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@kms_frontbuffer_tracking@fbc-2p-indfb-fliptrack-mmap-gtt:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0] s
* igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0] s
* igt@kms_frontbuffer_tracking@fbc-farfromfence-mmap-gtt:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack-mmap-gtt:
- Statuses : 4 skip(s)
- Exec time: [0.0] s
* igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack-mmap-gtt:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@kms_frontbuffer_tracking@fbcpsr-2p-indfb-fliptrack-mmap-gtt:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_frontbuffer_tracking@fbcpsr-2p-shrfb-fliptrack-mmap-gtt:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@kms_frontbuffer_tracking@fbcpsr-farfromfence-mmap-gtt:
- Statuses : 4 skip(s)
- Exec time: [0.0] s
* igt@kms_frontbuffer_tracking@fbcpsr-tiling-4:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_frontbuffer_tracking@psr-farfromfence-mmap-gtt:
- Statuses : 4 skip(s)
- Exec time: [0.0] s
* igt@kms_lease@atomic_implicit_crtc:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_lease@cursor_implicit_plane:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_lease@page_flip_implicit_plane:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_lease@setcrtc_implicit_plane:
- Statuses : 2 skip(s)
- Exec time: [0.0] s
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@perf@blocking-parameterized:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@perf@gen12-oa-tlb-invalidate:
- Statuses : 2 pass(s) 3 skip(s)
- Exec time: [0.0] s
* igt@perf@global-sseu-config:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@perf@global-sseu-config-invalid:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@perf@polling-parameterized:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@idempotent:
- Statuses :
- Exec time: [None] s
* igt@sysfs_heartbeat_interval@idempotent@bcs0:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@idempotent@rcs0:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@idempotent@vcs0:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@idempotent@vcs1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@idempotent@vecs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@invalid:
- Statuses :
- Exec time: [None] s
* igt@sysfs_heartbeat_interval@invalid@bcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@invalid@rcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@invalid@vcs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@invalid@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@invalid@vecs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@mixed:
- Statuses :
- Exec time: [None] s
* igt@sysfs_heartbeat_interval@mixed@bcs0:
- Statuses : 2 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@mixed@rcs0:
- Statuses : 2 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@mixed@vcs0:
- Statuses : 2 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@mixed@vecs0:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@nopreempt:
- Statuses :
- Exec time: [None] s
* igt@sysfs_heartbeat_interval@nopreempt@bcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@nopreempt@rcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@nopreempt@vcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@nopreempt@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@nopreempt@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@precise:
- Statuses :
- Exec time: [None] s
* igt@sysfs_heartbeat_interval@precise@bcs0:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@precise@rcs0:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@precise@vcs0:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_heartbeat_interval@precise@vecs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@sysfs_preempt_timeout@idempotent:
- Statuses :
- Exec time: [None] s
* igt@sysfs_preempt_timeout@idempotent@bcs0:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_preempt_timeout@idempotent@rcs0:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_preempt_timeout@idempotent@vcs0:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_preempt_timeout@idempotent@vcs1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@sysfs_preempt_timeout@idempotent@vecs0:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@sysfs_preempt_timeout@invalid:
- Statuses :
- Exec time: [None] s
* igt@sysfs_preempt_timeout@invalid@bcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_preempt_timeout@invalid@rcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_preempt_timeout@invalid@vcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_preempt_timeout@invalid@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@sysfs_preempt_timeout@invalid@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@sysfs_preempt_timeout@timeout:
- Statuses :
- Exec time: [None] s
* igt@sysfs_preempt_timeout@timeout@bcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_preempt_timeout@timeout@rcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_preempt_timeout@timeout@vcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_preempt_timeout@timeout@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@sysfs_preempt_timeout@timeout@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@duration:
- Statuses :
- Exec time: [None] s
* igt@sysfs_timeslice_duration@duration@bcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@duration@rcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@duration@vcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@duration@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@duration@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@idempotent:
- Statuses :
- Exec time: [None] s
* igt@sysfs_timeslice_duration@idempotent@bcs0:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@idempotent@rcs0:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@idempotent@vcs0:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@idempotent@vecs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@invalid:
- Statuses :
- Exec time: [None] s
* igt@sysfs_timeslice_duration@invalid@bcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@invalid@rcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@invalid@vcs0:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@invalid@vcs1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@invalid@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@timeout:
- Statuses :
- Exec time: [None] s
* igt@sysfs_timeslice_duration@timeout@bcs0:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@timeout@rcs0:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@timeout@vcs0:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@sysfs_timeslice_duration@timeout@vecs0:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_114029v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_fdinfo@idle@rcs0 (NEW):
- {shard-rkl}: [PASS][1] -> [FAIL][2] ([i915#7742])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-6/igt@drm_fdinfo@idle@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-4/igt@drm_fdinfo@idle@rcs0.html
* igt@drm_fdinfo@most-busy-check-all (NEW):
- {shard-dg1}: NOTRUN -> [SKIP][3] ([i915#5563])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-dg1-16/igt@drm_fdinfo@most-busy-check-all.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [PASS][4] -> [FAIL][5] ([i915#2842])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-glk5/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-glk7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_mmap_gtt@bad-object (NEW):
- {shard-dg1}: NOTRUN -> [SKIP][6] ([i915#4077])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-dg1-18/igt@gem_mmap_gtt@bad-object.html
* igt@i915_pm_dc@dc9-dpms (NEW):
- {shard-tglu}: NOTRUN -> [SKIP][7] ([i915#4281])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-tglu-3/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rps@engine-order:
- shard-apl: [PASS][8] -> [FAIL][9] ([i915#6537])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-apl2/igt@i915_pm_rps@engine-order.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-apl3/igt@i915_pm_rps@engine-order.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#2346])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-apl: [PASS][12] -> [FAIL][13] ([i915#2346])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [PASS][14] -> [FAIL][15] ([i915#79]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
* igt@kms_frontbuffer_tracking@fbc-2p-indfb-fliptrack-mmap-gtt (NEW):
- {shard-tglu}: [SKIP][16] ([i915#1849]) -> [SKIP][17] ([fdo#109280])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-2p-indfb-fliptrack-mmap-gtt.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-tglu-4/igt@kms_frontbuffer_tracking@fbc-2p-indfb-fliptrack-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt (NEW):
- {shard-rkl}: [SKIP][18] ([fdo#111825]) -> [SKIP][19] ([i915#1849] / [i915#4098])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-4/igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt.html
- {shard-tglu-9}: NOTRUN -> [SKIP][20] ([i915#1849]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-tglu-9/igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack-mmap-gtt (NEW):
- {shard-tglu-10}: NOTRUN -> [SKIP][21] ([fdo#110189])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-tglu-10/igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-indfb-fliptrack-mmap-gtt (NEW):
- {shard-tglu}: NOTRUN -> [SKIP][22] ([fdo#109280]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-tglu-2/igt@kms_frontbuffer_tracking@fbcpsr-2p-indfb-fliptrack-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt:
- shard-glk: NOTRUN -> [SKIP][23] ([fdo#109271]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-glk1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-tiling-4 (NEW):
- {shard-rkl}: [SKIP][24] ([i915#5439]) -> [SKIP][25] ([i915#1849] / [i915#4098])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-tiling-4.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-5/igt@kms_frontbuffer_tracking@fbcpsr-tiling-4.html
* igt@kms_lease@setcrtc_implicit_plane (NEW):
- {shard-tglu}: NOTRUN -> [SKIP][26] ([i915#1845] / [i915#7651])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-tglu-6/igt@kms_lease@setcrtc_implicit_plane.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][27] ([fdo#109271]) +16 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-snb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-hdmi-a-1.html
* igt@kms_setmode@basic@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [FAIL][28] ([i915#5465]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-snb1/igt@kms_setmode@basic@pipe-a-hdmi-a-1.html
#### Possible fixes ####
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}: [FAIL][29] ([i915#7742]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-3/igt@drm_fdinfo@virtual-idle.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-5/igt@drm_fdinfo@virtual-idle.html
* igt@drm_read@short-buffer-block:
- {shard-rkl}: [SKIP][31] ([i915#4098]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-2/igt@drm_read@short-buffer-block.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-6/igt@drm_read@short-buffer-block.html
* igt@fbdev@info:
- {shard-rkl}: [SKIP][33] ([i915#2582]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-1/igt@fbdev@info.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-6/igt@fbdev@info.html
* igt@gem_ctx_persistence@hang:
- {shard-rkl}: [SKIP][35] ([i915#6252]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-5/igt@gem_ctx_persistence@hang.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-4/igt@gem_ctx_persistence@hang.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][37] ([i915#2842]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][39] ([i915#2842]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- {shard-rkl}: [FAIL][41] ([i915#2842]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-6/igt@gem_exec_fair@basic-throttle@rcs0.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-5/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_reloc@basic-write-read-noreloc:
- {shard-rkl}: [SKIP][43] ([i915#3281]) -> [PASS][44] +13 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-3/igt@gem_exec_reloc@basic-write-read-noreloc.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-5/igt@gem_exec_reloc@basic-write-read-noreloc.html
* igt@gem_partial_pwrite_pread@writes-after-reads:
- {shard-rkl}: [SKIP][45] ([i915#3282]) -> [PASS][46] +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-3/igt@gem_partial_pwrite_pread@writes-after-reads.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads.html
* igt@gen9_exec_parse@bb-start-param:
- {shard-rkl}: [SKIP][47] ([i915#2527]) -> [PASS][48] +3 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-3/igt@gen9_exec_parse@bb-start-param.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-5/igt@gen9_exec_parse@bb-start-param.html
* igt@i915_pm_dc@dc6-dpms:
- {shard-tglu}: [FAIL][49] ([i915#3989] / [i915#454]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-tglu-6/igt@i915_pm_dc@dc6-dpms.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-tglu-4/igt@i915_pm_dc@dc6-dpms.html
* {igt@i915_power@sanity}:
- {shard-rkl}: [SKIP][51] ([i915#7984]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-3/igt@i915_power@sanity.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-5/igt@i915_power@sanity.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [SKIP][53] ([i915#1845] / [i915#4098]) -> [PASS][54] +19 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-2/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-6/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-apl: [FAIL][55] ([i915#2346]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][57] ([i915#79]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
* igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack-mmap-gtt (NEW):
- {shard-tglu}: [SKIP][59] ([i915#1849]) -> [PASS][60] +5 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack-mmap-gtt.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-tglu-4/igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary:
- {shard-rkl}: [SKIP][61] ([i915#1849] / [i915#4098]) -> [PASS][62] +10 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-1/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html
* igt@kms_plane@pixel-format@pipe-b-planes:
- {shard-tglu}: [SKIP][63] ([i915#1849] / [i915#3558]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-tglu-6/igt@kms_plane@pixel-format@pipe-b-planes.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-tglu-4/igt@kms_plane@pixel-format@pipe-b-planes.html
* igt@kms_plane@plane-position-covered@pipe-a-planes:
- {shard-rkl}: [SKIP][65] ([i915#1849]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-1/igt@kms_plane@plane-position-covered@pipe-a-planes.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-6/igt@kms_plane@plane-position-covered@pipe-a-planes.html
* igt@kms_psr@sprite_plane_move:
- {shard-rkl}: [SKIP][67] ([i915#1072]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-2/igt@kms_psr@sprite_plane_move.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-6/igt@kms_psr@sprite_plane_move.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- {shard-rkl}: [SKIP][69] ([i915#5461]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-1/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-6/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
* igt@kms_vblank@pipe-a-query-forked:
- {shard-tglu}: [SKIP][71] ([i915#1845] / [i915#7651]) -> [PASS][72] +26 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-tglu-6/igt@kms_vblank@pipe-a-query-forked.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-tglu-4/igt@kms_vblank@pipe-a-query-forked.html
* igt@perf_pmu@idle@rcs0:
- {shard-rkl}: [FAIL][73] ([i915#4349]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-2/igt@perf_pmu@idle@rcs0.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-6/igt@perf_pmu@idle@rcs0.html
* igt@prime_vgem@basic-read:
- {shard-rkl}: [SKIP][75] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12739/shard-rkl-3/igt@prime_vgem@basic-read.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/shard-rkl-5/igt@prime_vgem@basic-read.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
[i915#7984]: https://gitlab.freedesktop.org/drm/intel/issues/7984
[i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
Build changes
-------------
* Linux: CI_DRM_12739 -> Patchwork_114029v1
CI-20190529: 20190529
CI_DRM_12739: 5fc904286af94038fbf2c7cda50ed871b70cf4e8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7160: 45da871dd2684227e93a2fc002b87dfc58bd5fd9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114029v1: 5fc904286af94038fbf2c7cda50ed871b70cf4e8 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v1/index.html
[-- Attachment #2: Type: text/html, Size: 54565 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH v2 1/3] drm/i915: Use encoder->devdata more
2023-02-14 23:19 [Intel-gfx] [PATCH 1/3] drm/i915: Use encoder->devdata more Ville Syrjala
` (4 preceding siblings ...)
2023-02-15 11:04 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork
@ 2023-02-16 0:04 ` Ville Syrjala
2023-02-16 14:53 ` Jani Nikula
2023-02-16 0:34 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/i915: Use encoder->devdata more (rev2) Patchwork
` (2 subsequent siblings)
8 siblings, 1 reply; 12+ messages in thread
From: Ville Syrjala @ 2023-02-16 0:04 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Switch a lot of the intel_bios_foo() stuff to just accept the
devdata (VBT child device info) directly, instead of taking
detours via vbt.ports[].
Also unify the function naming scheme.
v2: Drop the redundant "encoder" from the dp/hdmi specific functions
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 62 +++++------------------
drivers/gpu/drm/i915/display/intel_bios.h | 15 +++---
drivers/gpu/drm/i915/display/intel_ddi.c | 10 ++--
drivers/gpu/drm/i915/display/intel_dp.c | 4 +-
drivers/gpu/drm/i915/display/intel_hdmi.c | 4 +-
5 files changed, 31 insertions(+), 64 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 229f9782e226..8cf2392a5670 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -2520,7 +2520,7 @@ static int parse_bdb_216_dp_max_link_rate(const int vbt_max_link_rate)
}
}
-static int _intel_bios_dp_max_link_rate(const struct intel_bios_encoder_data *devdata)
+int intel_bios_dp_max_link_rate(const struct intel_bios_encoder_data *devdata)
{
if (!devdata || devdata->i915->display.vbt.version < 216)
return 0;
@@ -2531,7 +2531,7 @@ static int _intel_bios_dp_max_link_rate(const struct intel_bios_encoder_data *de
return parse_bdb_216_dp_max_link_rate(devdata->child.dp_max_link_rate);
}
-static int _intel_bios_dp_max_lane_count(const struct intel_bios_encoder_data *devdata)
+int intel_bios_dp_max_lane_count(const struct intel_bios_encoder_data *devdata)
{
if (!devdata || devdata->i915->display.vbt.version < 244)
return 0;
@@ -2604,7 +2604,8 @@ intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata)
return devdata && HAS_LSPCON(devdata->i915) && devdata->child.lspcon;
}
-static int _intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data *devdata)
+/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */
+int intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data *devdata)
{
if (!devdata || devdata->i915->display.vbt.version < 158)
return -1;
@@ -2612,7 +2613,7 @@ static int _intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data *de
return devdata->child.hdmi_level_shifter_value;
}
-static int _intel_bios_max_tmds_clock(const struct intel_bios_encoder_data *devdata)
+int intel_bios_hdmi_max_tmds_clock(const struct intel_bios_encoder_data *devdata)
{
if (!devdata || devdata->i915->display.vbt.version < 204)
return 0;
@@ -2674,33 +2675,33 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata,
supports_typec_usb, supports_tbt,
devdata->dsc != NULL);
- hdmi_level_shift = _intel_bios_hdmi_level_shift(devdata);
+ hdmi_level_shift = intel_bios_hdmi_level_shift(devdata);
if (hdmi_level_shift >= 0) {
drm_dbg_kms(&i915->drm,
"Port %c VBT HDMI level shift: %d\n",
port_name(port), hdmi_level_shift);
}
- max_tmds_clock = _intel_bios_max_tmds_clock(devdata);
+ max_tmds_clock = intel_bios_hdmi_max_tmds_clock(devdata);
if (max_tmds_clock)
drm_dbg_kms(&i915->drm,
"Port %c VBT HDMI max TMDS clock: %d kHz\n",
port_name(port), max_tmds_clock);
/* I_boost config for SKL and above */
- dp_boost_level = intel_bios_encoder_dp_boost_level(devdata);
+ dp_boost_level = intel_bios_dp_boost_level(devdata);
if (dp_boost_level)
drm_dbg_kms(&i915->drm,
"Port %c VBT (e)DP boost level: %d\n",
port_name(port), dp_boost_level);
- hdmi_boost_level = intel_bios_encoder_hdmi_boost_level(devdata);
+ hdmi_boost_level = intel_bios_hdmi_boost_level(devdata);
if (hdmi_boost_level)
drm_dbg_kms(&i915->drm,
"Port %c VBT HDMI boost level: %d\n",
port_name(port), hdmi_boost_level);
- dp_max_link_rate = _intel_bios_dp_max_link_rate(devdata);
+ dp_max_link_rate = intel_bios_dp_max_link_rate(devdata);
if (dp_max_link_rate)
drm_dbg_kms(&i915->drm,
"Port %c VBT DP max link rate: %d\n",
@@ -3665,24 +3666,8 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *i915,
return aux_ch;
}
-int intel_bios_max_tmds_clock(struct intel_encoder *encoder)
-{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
- const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
- return _intel_bios_max_tmds_clock(devdata);
-}
-
-/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */
-int intel_bios_hdmi_level_shift(struct intel_encoder *encoder)
-{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
- const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
-
- return _intel_bios_hdmi_level_shift(devdata);
-}
-
-int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devdata)
+int intel_bios_dp_boost_level(const struct intel_bios_encoder_data *devdata)
{
if (!devdata || devdata->i915->display.vbt.version < 196 || !devdata->child.iboost)
return 0;
@@ -3690,7 +3675,7 @@ int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devd
return translate_iboost(devdata->child.dp_iboost_level);
}
-int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *devdata)
+int intel_bios_hdmi_boost_level(const struct intel_bios_encoder_data *devdata)
{
if (!devdata || devdata->i915->display.vbt.version < 196 || !devdata->child.iboost)
return 0;
@@ -3698,31 +3683,12 @@ int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *de
return translate_iboost(devdata->child.hdmi_iboost_level);
}
-int intel_bios_dp_max_link_rate(struct intel_encoder *encoder)
+int intel_bios_hdmi_ddc_pin(const struct intel_bios_encoder_data *devdata)
{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
- const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
-
- return _intel_bios_dp_max_link_rate(devdata);
-}
-
-int intel_bios_dp_max_lane_count(struct intel_encoder *encoder)
-{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
- const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
-
- return _intel_bios_dp_max_lane_count(devdata);
-}
-
-int intel_bios_alternate_ddc_pin(struct intel_encoder *encoder)
-{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
- const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
-
if (!devdata || !devdata->child.ddc_pin)
return 0;
- return map_ddc_pin(i915, devdata->child.ddc_pin);
+ return map_ddc_pin(devdata->i915, devdata->child.ddc_pin);
}
bool intel_bios_encoder_supports_typec_usb(const struct intel_bios_encoder_data *devdata)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
index 1a6ae38bd4f6..53123468331a 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.h
+++ b/drivers/gpu/drm/i915/display/intel_bios.h
@@ -254,11 +254,6 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *i915,
bool intel_bios_get_dsc_params(struct intel_encoder *encoder,
struct intel_crtc_state *crtc_state,
int dsc_max_bpc);
-int intel_bios_max_tmds_clock(struct intel_encoder *encoder);
-int intel_bios_hdmi_level_shift(struct intel_encoder *encoder);
-int intel_bios_dp_max_link_rate(struct intel_encoder *encoder);
-int intel_bios_dp_max_lane_count(struct intel_encoder *encoder);
-int intel_bios_alternate_ddc_pin(struct intel_encoder *encoder);
bool intel_bios_port_supports_typec_usb(struct drm_i915_private *i915, enum port port);
bool intel_bios_port_supports_tbt(struct drm_i915_private *i915, enum port port);
@@ -272,9 +267,15 @@ bool intel_bios_encoder_supports_edp(const struct intel_bios_encoder_data *devda
bool intel_bios_encoder_supports_typec_usb(const struct intel_bios_encoder_data *devdata);
bool intel_bios_encoder_supports_tbt(const struct intel_bios_encoder_data *devdata);
bool intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata);
-int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devdata);
-int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *devdata);
bool intel_bios_encoder_lane_reversal(const struct intel_bios_encoder_data *devdata);
bool intel_bios_encoder_hpd_invert(const struct intel_bios_encoder_data *devdata);
+int intel_bios_dp_boost_level(const struct intel_bios_encoder_data *devdata);
+int intel_bios_dp_max_link_rate(const struct intel_bios_encoder_data *devdata);
+int intel_bios_dp_max_lane_count(const struct intel_bios_encoder_data *devdata);
+int intel_bios_hdmi_boost_level(const struct intel_bios_encoder_data *devdata);
+int intel_bios_hdmi_max_tmds_clock(const struct intel_bios_encoder_data *devdata);
+int intel_bios_hdmi_boost_level(const struct intel_bios_encoder_data *devdata);
+int intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data *devdata);
+int intel_bios_hdmi_ddc_pin(const struct intel_bios_encoder_data *devdata);
#endif /* _INTEL_BIOS_H_ */
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index bfd1e30a27b4..6010ba977adb 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -89,7 +89,7 @@ static int intel_ddi_hdmi_level(struct intel_encoder *encoder,
{
int level;
- level = intel_bios_hdmi_level_shift(encoder);
+ level = intel_bios_hdmi_level_shift(encoder->devdata);
if (level < 0)
level = trans->hdmi_default_entry;
@@ -126,7 +126,7 @@ void hsw_prepare_dp_ddi_buffers(struct intel_encoder *encoder,
/* If we're boosting the current, set bit 31 of trans1 */
if (has_iboost(dev_priv) &&
- intel_bios_encoder_dp_boost_level(encoder->devdata))
+ intel_bios_dp_boost_level(encoder->devdata))
iboost_bit = DDI_BUF_BALANCE_LEG_ENABLE;
for (i = 0; i < n_entries; i++) {
@@ -158,7 +158,7 @@ static void hsw_prepare_hdmi_ddi_buffers(struct intel_encoder *encoder,
/* If we're boosting the current, set bit 31 of trans1 */
if (has_iboost(dev_priv) &&
- intel_bios_encoder_hdmi_boost_level(encoder->devdata))
+ intel_bios_hdmi_boost_level(encoder->devdata))
iboost_bit = DDI_BUF_BALANCE_LEG_ENABLE;
/* Entry 9 is for HDMI: */
@@ -1009,9 +1009,9 @@ static void skl_ddi_set_iboost(struct intel_encoder *encoder,
u8 iboost;
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
- iboost = intel_bios_encoder_hdmi_boost_level(encoder->devdata);
+ iboost = intel_bios_hdmi_boost_level(encoder->devdata);
else
- iboost = intel_bios_encoder_dp_boost_level(encoder->devdata);
+ iboost = intel_bios_dp_boost_level(encoder->devdata);
if (iboost == 0) {
const struct intel_ddi_buf_trans *trans;
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index b92e0b0f5369..86fdf9d74b93 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -288,7 +288,7 @@ static int intel_dp_max_common_rate(struct intel_dp *intel_dp)
static int intel_dp_max_source_lane_count(struct intel_digital_port *dig_port)
{
- int vbt_max_lanes = intel_bios_dp_max_lane_count(&dig_port->base);
+ int vbt_max_lanes = intel_bios_dp_max_lane_count(dig_port->base.devdata);
int max_lanes = dig_port->max_lanes;
if (vbt_max_lanes)
@@ -425,7 +425,7 @@ static int vbt_max_link_rate(struct intel_dp *intel_dp)
struct intel_encoder *encoder = &dp_to_dig_port(intel_dp)->base;
int max_rate;
- max_rate = intel_bios_dp_max_link_rate(encoder);
+ max_rate = intel_bios_dp_max_link_rate(encoder->devdata);
if (intel_dp_is_edp(intel_dp)) {
struct intel_connector *connector = intel_dp->attached_connector;
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 619865b45eca..74e2bc0ef8ba 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -1795,7 +1795,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder)
else
max_tmds_clock = 165000;
- vbt_max_tmds_clock = intel_bios_max_tmds_clock(encoder);
+ vbt_max_tmds_clock = intel_bios_hdmi_max_tmds_clock(encoder->devdata);
if (vbt_max_tmds_clock)
max_tmds_clock = min(max_tmds_clock, vbt_max_tmds_clock);
@@ -2871,7 +2871,7 @@ static u8 intel_hdmi_ddc_pin(struct intel_encoder *encoder)
enum port port = encoder->port;
u8 ddc_pin;
- ddc_pin = intel_bios_alternate_ddc_pin(encoder);
+ ddc_pin = intel_bios_hdmi_ddc_pin(encoder->devdata);
if (ddc_pin) {
drm_dbg_kms(&dev_priv->drm,
"Using DDC pin 0x%x for port %c (VBT)\n",
--
2.39.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/i915: Use encoder->devdata more (rev2)
2023-02-14 23:19 [Intel-gfx] [PATCH 1/3] drm/i915: Use encoder->devdata more Ville Syrjala
` (5 preceding siblings ...)
2023-02-16 0:04 ` [Intel-gfx] [PATCH v2 1/3] " Ville Syrjala
@ 2023-02-16 0:34 ` Patchwork
2023-02-16 1:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-02-16 19:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
8 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-02-16 0:34 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v2,1/3] drm/i915: Use encoder->devdata more (rev2)
URL : https://patchwork.freedesktop.org/series/114029/
State : warning
== Summary ==
Error: dim checkpatch failed
6d862c28ab08 drm/i915: Use encoder->devdata more
c197ab2941f5 drm/i915: Sanitize child devices later
f80b5f236011 drm/i915: Try to initialize DDI ports for every VBT child device
-:29: ERROR:OPEN_BRACE: that open brace { should be on the previous line
#29: FILE: drivers/gpu/drm/i915/display/intel_bios.c:2614:
+intel_bios_for_each_child(struct drm_i915_private *i915,
+ enum port port,
+ bool (*func)(struct drm_i915_private *i915,
+ struct intel_bios_encoder_data *devdata,
+ enum port port))
+{
total: 1 errors, 0 warnings, 0 checks, 197 lines checked
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915: Use encoder->devdata more (rev2)
2023-02-14 23:19 [Intel-gfx] [PATCH 1/3] drm/i915: Use encoder->devdata more Ville Syrjala
` (6 preceding siblings ...)
2023-02-16 0:34 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/i915: Use encoder->devdata more (rev2) Patchwork
@ 2023-02-16 1:05 ` Patchwork
2023-02-16 19:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
8 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-02-16 1:05 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5584 bytes --]
== Series Details ==
Series: series starting with [v2,1/3] drm/i915: Use encoder->devdata more (rev2)
URL : https://patchwork.freedesktop.org/series/114029/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12746 -> Patchwork_114029v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/index.html
Participating hosts (38 -> 38)
------------------------------
Additional (1): fi-kbl-soraka
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_114029v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@execlists:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][3] ([i915#7156] / [i915#7913])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][4] ([i915#1886])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- fi-skl-guc: [PASS][5] -> [DMESG-WARN][6] ([i915#8073])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/fi-skl-guc/igt@i915_selftest@live@hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/fi-skl-guc/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271]) +15 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-blb-e6850: NOTRUN -> [SKIP][8] ([fdo#109271])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/fi-blb-e6850/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- {bat-dg2-11}: [ABORT][9] ([i915#7913] / [i915#7979]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@migrate:
- {bat-adlp-6}: [DMESG-FAIL][11] ([i915#7699]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/bat-adlp-6/igt@i915_selftest@live@migrate.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/bat-adlp-6/igt@i915_selftest@live@migrate.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-blb-e6850: [ABORT][13] -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/fi-blb-e6850/igt@i915_suspend@basic-s2idle-without-i915.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/fi-blb-e6850/igt@i915_suspend@basic-s2idle-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7156]: https://gitlab.freedesktop.org/drm/intel/issues/7156
[i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7979]: https://gitlab.freedesktop.org/drm/intel/issues/7979
[i915#8073]: https://gitlab.freedesktop.org/drm/intel/issues/8073
Build changes
-------------
* Linux: CI_DRM_12746 -> Patchwork_114029v2
CI-20190529: 20190529
CI_DRM_12746: 6ce36b596fa77ffb513126191268bc3637c96413 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7160: 45da871dd2684227e93a2fc002b87dfc58bd5fd9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114029v2: 6ce36b596fa77ffb513126191268bc3637c96413 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
626754c94477 drm/i915: Try to initialize DDI ports for every VBT child device
27a67aa2b994 drm/i915: Sanitize child devices later
c34603060a4c drm/i915: Use encoder->devdata more
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/index.html
[-- Attachment #2: Type: text/html, Size: 6188 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Use encoder->devdata more
2023-02-16 0:04 ` [Intel-gfx] [PATCH v2 1/3] " Ville Syrjala
@ 2023-02-16 14:53 ` Jani Nikula
0 siblings, 0 replies; 12+ messages in thread
From: Jani Nikula @ 2023-02-16 14:53 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On Thu, 16 Feb 2023, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Switch a lot of the intel_bios_foo() stuff to just accept the
> devdata (VBT child device info) directly, instead of taking
> detours via vbt.ports[].
>
> Also unify the function naming scheme.
>
> v2: Drop the redundant "encoder" from the dp/hdmi specific functions
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 62 +++++------------------
> drivers/gpu/drm/i915/display/intel_bios.h | 15 +++---
> drivers/gpu/drm/i915/display/intel_ddi.c | 10 ++--
> drivers/gpu/drm/i915/display/intel_dp.c | 4 +-
> drivers/gpu/drm/i915/display/intel_hdmi.c | 4 +-
> 5 files changed, 31 insertions(+), 64 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 229f9782e226..8cf2392a5670 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -2520,7 +2520,7 @@ static int parse_bdb_216_dp_max_link_rate(const int vbt_max_link_rate)
> }
> }
>
> -static int _intel_bios_dp_max_link_rate(const struct intel_bios_encoder_data *devdata)
> +int intel_bios_dp_max_link_rate(const struct intel_bios_encoder_data *devdata)
> {
> if (!devdata || devdata->i915->display.vbt.version < 216)
> return 0;
> @@ -2531,7 +2531,7 @@ static int _intel_bios_dp_max_link_rate(const struct intel_bios_encoder_data *de
> return parse_bdb_216_dp_max_link_rate(devdata->child.dp_max_link_rate);
> }
>
> -static int _intel_bios_dp_max_lane_count(const struct intel_bios_encoder_data *devdata)
> +int intel_bios_dp_max_lane_count(const struct intel_bios_encoder_data *devdata)
> {
> if (!devdata || devdata->i915->display.vbt.version < 244)
> return 0;
> @@ -2604,7 +2604,8 @@ intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata)
> return devdata && HAS_LSPCON(devdata->i915) && devdata->child.lspcon;
> }
>
> -static int _intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data *devdata)
> +/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */
> +int intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data *devdata)
> {
> if (!devdata || devdata->i915->display.vbt.version < 158)
> return -1;
> @@ -2612,7 +2613,7 @@ static int _intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data *de
> return devdata->child.hdmi_level_shifter_value;
> }
>
> -static int _intel_bios_max_tmds_clock(const struct intel_bios_encoder_data *devdata)
> +int intel_bios_hdmi_max_tmds_clock(const struct intel_bios_encoder_data *devdata)
> {
> if (!devdata || devdata->i915->display.vbt.version < 204)
> return 0;
> @@ -2674,33 +2675,33 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata,
> supports_typec_usb, supports_tbt,
> devdata->dsc != NULL);
>
> - hdmi_level_shift = _intel_bios_hdmi_level_shift(devdata);
> + hdmi_level_shift = intel_bios_hdmi_level_shift(devdata);
> if (hdmi_level_shift >= 0) {
> drm_dbg_kms(&i915->drm,
> "Port %c VBT HDMI level shift: %d\n",
> port_name(port), hdmi_level_shift);
> }
>
> - max_tmds_clock = _intel_bios_max_tmds_clock(devdata);
> + max_tmds_clock = intel_bios_hdmi_max_tmds_clock(devdata);
> if (max_tmds_clock)
> drm_dbg_kms(&i915->drm,
> "Port %c VBT HDMI max TMDS clock: %d kHz\n",
> port_name(port), max_tmds_clock);
>
> /* I_boost config for SKL and above */
> - dp_boost_level = intel_bios_encoder_dp_boost_level(devdata);
> + dp_boost_level = intel_bios_dp_boost_level(devdata);
> if (dp_boost_level)
> drm_dbg_kms(&i915->drm,
> "Port %c VBT (e)DP boost level: %d\n",
> port_name(port), dp_boost_level);
>
> - hdmi_boost_level = intel_bios_encoder_hdmi_boost_level(devdata);
> + hdmi_boost_level = intel_bios_hdmi_boost_level(devdata);
> if (hdmi_boost_level)
> drm_dbg_kms(&i915->drm,
> "Port %c VBT HDMI boost level: %d\n",
> port_name(port), hdmi_boost_level);
>
> - dp_max_link_rate = _intel_bios_dp_max_link_rate(devdata);
> + dp_max_link_rate = intel_bios_dp_max_link_rate(devdata);
> if (dp_max_link_rate)
> drm_dbg_kms(&i915->drm,
> "Port %c VBT DP max link rate: %d\n",
> @@ -3665,24 +3666,8 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *i915,
> return aux_ch;
> }
>
> -int intel_bios_max_tmds_clock(struct intel_encoder *encoder)
> -{
> - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> - const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
>
> - return _intel_bios_max_tmds_clock(devdata);
> -}
> -
> -/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */
> -int intel_bios_hdmi_level_shift(struct intel_encoder *encoder)
> -{
> - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> - const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
> -
> - return _intel_bios_hdmi_level_shift(devdata);
> -}
> -
> -int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devdata)
> +int intel_bios_dp_boost_level(const struct intel_bios_encoder_data *devdata)
> {
> if (!devdata || devdata->i915->display.vbt.version < 196 || !devdata->child.iboost)
> return 0;
> @@ -3690,7 +3675,7 @@ int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devd
> return translate_iboost(devdata->child.dp_iboost_level);
> }
>
> -int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *devdata)
> +int intel_bios_hdmi_boost_level(const struct intel_bios_encoder_data *devdata)
> {
> if (!devdata || devdata->i915->display.vbt.version < 196 || !devdata->child.iboost)
> return 0;
> @@ -3698,31 +3683,12 @@ int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *de
> return translate_iboost(devdata->child.hdmi_iboost_level);
> }
>
> -int intel_bios_dp_max_link_rate(struct intel_encoder *encoder)
> +int intel_bios_hdmi_ddc_pin(const struct intel_bios_encoder_data *devdata)
> {
> - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> - const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
> -
> - return _intel_bios_dp_max_link_rate(devdata);
> -}
> -
> -int intel_bios_dp_max_lane_count(struct intel_encoder *encoder)
> -{
> - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> - const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
> -
> - return _intel_bios_dp_max_lane_count(devdata);
> -}
> -
> -int intel_bios_alternate_ddc_pin(struct intel_encoder *encoder)
> -{
> - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> - const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];
> -
> if (!devdata || !devdata->child.ddc_pin)
> return 0;
>
> - return map_ddc_pin(i915, devdata->child.ddc_pin);
> + return map_ddc_pin(devdata->i915, devdata->child.ddc_pin);
> }
>
> bool intel_bios_encoder_supports_typec_usb(const struct intel_bios_encoder_data *devdata)
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
> index 1a6ae38bd4f6..53123468331a 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.h
> +++ b/drivers/gpu/drm/i915/display/intel_bios.h
> @@ -254,11 +254,6 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *i915,
> bool intel_bios_get_dsc_params(struct intel_encoder *encoder,
> struct intel_crtc_state *crtc_state,
> int dsc_max_bpc);
> -int intel_bios_max_tmds_clock(struct intel_encoder *encoder);
> -int intel_bios_hdmi_level_shift(struct intel_encoder *encoder);
> -int intel_bios_dp_max_link_rate(struct intel_encoder *encoder);
> -int intel_bios_dp_max_lane_count(struct intel_encoder *encoder);
> -int intel_bios_alternate_ddc_pin(struct intel_encoder *encoder);
> bool intel_bios_port_supports_typec_usb(struct drm_i915_private *i915, enum port port);
> bool intel_bios_port_supports_tbt(struct drm_i915_private *i915, enum port port);
>
> @@ -272,9 +267,15 @@ bool intel_bios_encoder_supports_edp(const struct intel_bios_encoder_data *devda
> bool intel_bios_encoder_supports_typec_usb(const struct intel_bios_encoder_data *devdata);
> bool intel_bios_encoder_supports_tbt(const struct intel_bios_encoder_data *devdata);
> bool intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata);
> -int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devdata);
> -int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *devdata);
> bool intel_bios_encoder_lane_reversal(const struct intel_bios_encoder_data *devdata);
> bool intel_bios_encoder_hpd_invert(const struct intel_bios_encoder_data *devdata);
> +int intel_bios_dp_boost_level(const struct intel_bios_encoder_data *devdata);
> +int intel_bios_dp_max_link_rate(const struct intel_bios_encoder_data *devdata);
> +int intel_bios_dp_max_lane_count(const struct intel_bios_encoder_data *devdata);
> +int intel_bios_hdmi_boost_level(const struct intel_bios_encoder_data *devdata);
> +int intel_bios_hdmi_max_tmds_clock(const struct intel_bios_encoder_data *devdata);
> +int intel_bios_hdmi_boost_level(const struct intel_bios_encoder_data *devdata);
Dupe declaration of intel_bios_hdmi_boost_level(), with that dropped,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> +int intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data *devdata);
> +int intel_bios_hdmi_ddc_pin(const struct intel_bios_encoder_data *devdata);
>
> #endif /* _INTEL_BIOS_H_ */
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index bfd1e30a27b4..6010ba977adb 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -89,7 +89,7 @@ static int intel_ddi_hdmi_level(struct intel_encoder *encoder,
> {
> int level;
>
> - level = intel_bios_hdmi_level_shift(encoder);
> + level = intel_bios_hdmi_level_shift(encoder->devdata);
> if (level < 0)
> level = trans->hdmi_default_entry;
>
> @@ -126,7 +126,7 @@ void hsw_prepare_dp_ddi_buffers(struct intel_encoder *encoder,
>
> /* If we're boosting the current, set bit 31 of trans1 */
> if (has_iboost(dev_priv) &&
> - intel_bios_encoder_dp_boost_level(encoder->devdata))
> + intel_bios_dp_boost_level(encoder->devdata))
> iboost_bit = DDI_BUF_BALANCE_LEG_ENABLE;
>
> for (i = 0; i < n_entries; i++) {
> @@ -158,7 +158,7 @@ static void hsw_prepare_hdmi_ddi_buffers(struct intel_encoder *encoder,
>
> /* If we're boosting the current, set bit 31 of trans1 */
> if (has_iboost(dev_priv) &&
> - intel_bios_encoder_hdmi_boost_level(encoder->devdata))
> + intel_bios_hdmi_boost_level(encoder->devdata))
> iboost_bit = DDI_BUF_BALANCE_LEG_ENABLE;
>
> /* Entry 9 is for HDMI: */
> @@ -1009,9 +1009,9 @@ static void skl_ddi_set_iboost(struct intel_encoder *encoder,
> u8 iboost;
>
> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
> - iboost = intel_bios_encoder_hdmi_boost_level(encoder->devdata);
> + iboost = intel_bios_hdmi_boost_level(encoder->devdata);
> else
> - iboost = intel_bios_encoder_dp_boost_level(encoder->devdata);
> + iboost = intel_bios_dp_boost_level(encoder->devdata);
>
> if (iboost == 0) {
> const struct intel_ddi_buf_trans *trans;
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index b92e0b0f5369..86fdf9d74b93 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -288,7 +288,7 @@ static int intel_dp_max_common_rate(struct intel_dp *intel_dp)
>
> static int intel_dp_max_source_lane_count(struct intel_digital_port *dig_port)
> {
> - int vbt_max_lanes = intel_bios_dp_max_lane_count(&dig_port->base);
> + int vbt_max_lanes = intel_bios_dp_max_lane_count(dig_port->base.devdata);
> int max_lanes = dig_port->max_lanes;
>
> if (vbt_max_lanes)
> @@ -425,7 +425,7 @@ static int vbt_max_link_rate(struct intel_dp *intel_dp)
> struct intel_encoder *encoder = &dp_to_dig_port(intel_dp)->base;
> int max_rate;
>
> - max_rate = intel_bios_dp_max_link_rate(encoder);
> + max_rate = intel_bios_dp_max_link_rate(encoder->devdata);
>
> if (intel_dp_is_edp(intel_dp)) {
> struct intel_connector *connector = intel_dp->attached_connector;
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 619865b45eca..74e2bc0ef8ba 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1795,7 +1795,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder)
> else
> max_tmds_clock = 165000;
>
> - vbt_max_tmds_clock = intel_bios_max_tmds_clock(encoder);
> + vbt_max_tmds_clock = intel_bios_hdmi_max_tmds_clock(encoder->devdata);
> if (vbt_max_tmds_clock)
> max_tmds_clock = min(max_tmds_clock, vbt_max_tmds_clock);
>
> @@ -2871,7 +2871,7 @@ static u8 intel_hdmi_ddc_pin(struct intel_encoder *encoder)
> enum port port = encoder->port;
> u8 ddc_pin;
>
> - ddc_pin = intel_bios_alternate_ddc_pin(encoder);
> + ddc_pin = intel_bios_hdmi_ddc_pin(encoder->devdata);
> if (ddc_pin) {
> drm_dbg_kms(&dev_priv->drm,
> "Using DDC pin 0x%x for port %c (VBT)\n",
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/3] drm/i915: Use encoder->devdata more (rev2)
2023-02-14 23:19 [Intel-gfx] [PATCH 1/3] drm/i915: Use encoder->devdata more Ville Syrjala
` (7 preceding siblings ...)
2023-02-16 1:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-02-16 19:10 ` Patchwork
8 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-02-16 19:10 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 23595 bytes --]
== Series Details ==
Series: series starting with [v2,1/3] drm/i915: Use encoder->devdata more (rev2)
URL : https://patchwork.freedesktop.org/series/114029/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12746_full -> Patchwork_114029v2_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_114029v2_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_114029v2_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/index.html
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_114029v2_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_plane_cursor@viewport:
- shard-glk: NOTRUN -> [TIMEOUT][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-glk2/igt@kms_plane_cursor@viewport.html
#### Warnings ####
* igt@kms_frontbuffer_tracking@fbcpsr-tiling-4:
- shard-glk: [SKIP][2] ([fdo#109271]) -> [TIMEOUT][3] +2 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-glk3/igt@kms_frontbuffer_tracking@fbcpsr-tiling-4.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-glk2/igt@kms_frontbuffer_tracking@fbcpsr-tiling-4.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_eio@in-flight-immediate:
- {shard-rkl}: [PASS][4] -> [ABORT][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-rkl-2/igt@gem_eio@in-flight-immediate.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-rkl-1/igt@gem_eio@in-flight-immediate.html
* {igt@kms_plane_scaling@invalid-parameters}:
- {shard-tglu-9}: NOTRUN -> [SKIP][6]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-tglu-9/igt@kms_plane_scaling@invalid-parameters.html
Known issues
------------
Here are the changes found in Patchwork_114029v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-apl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-apl: [PASS][9] -> [FAIL][10] ([i915#2346]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_flip@plain-flip-ts-check@c-hdmi-a2:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#2122])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-glk4/igt@kms_flip@plain-flip-ts-check@c-hdmi-a2.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-glk6/igt@kms_flip@plain-flip-ts-check@c-hdmi-a2.html
* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][13] ([fdo#109271]) +24 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-snb4/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-b-vga-1.html
* igt@perf@non-zero-reason:
- shard-glk: [PASS][14] -> [TIMEOUT][15] ([i915#6943])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-glk3/igt@perf@non-zero-reason.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-glk2/igt@perf@non-zero-reason.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- {shard-rkl}: [FAIL][16] ([i915#7742]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-rkl-2/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-rkl-1/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* igt@fbdev@info:
- {shard-rkl}: [SKIP][18] ([i915#2582]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-rkl-4/igt@fbdev@info.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-rkl-6/igt@fbdev@info.html
* igt@feature_discovery@psr2:
- {shard-rkl}: [SKIP][20] ([i915#658]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-rkl-2/igt@feature_discovery@psr2.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-rkl-6/igt@feature_discovery@psr2.html
* igt@gem_ctx_persistence@hang:
- {shard-rkl}: [SKIP][22] ([i915#6252]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-rkl-5/igt@gem_ctx_persistence@hang.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-rkl-4/igt@gem_ctx_persistence@hang.html
* igt@gem_eio@in-flight-suspend:
- {shard-rkl}: [FAIL][24] ([i915#5115] / [i915#7052]) -> [PASS][25] +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-rkl-4/igt@gem_eio@in-flight-suspend.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-rkl-6/igt@gem_eio@in-flight-suspend.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [FAIL][26] ([i915#2842]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-glk3/igt@gem_exec_fair@basic-none-share@rcs0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-glk9/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][28] ([i915#2842]) -> [PASS][29] +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-rkl-4/igt@gem_exec_fair@basic-pace@rcs0.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-rkl-5/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_reloc@basic-write-read:
- {shard-rkl}: [SKIP][30] ([i915#3281]) -> [PASS][31] +6 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-rkl-1/igt@gem_exec_reloc@basic-write-read.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-rkl-5/igt@gem_exec_reloc@basic-write-read.html
* igt@gem_set_tiling_vs_pwrite:
- {shard-rkl}: [SKIP][32] ([i915#3282]) -> [PASS][33] +6 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-rkl-1/igt@gem_set_tiling_vs_pwrite.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-rkl-5/igt@gem_set_tiling_vs_pwrite.html
* igt@gen9_exec_parse@allowed-all:
- {shard-rkl}: [SKIP][34] ([i915#2527]) -> [PASS][35] +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-rkl-4/igt@gen9_exec_parse@allowed-all.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-rkl-5/igt@gen9_exec_parse@allowed-all.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-glk: [DMESG-FAIL][36] ([i915#5334]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-glk6/igt@i915_selftest@live@gt_heartbeat.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-glk5/igt@i915_selftest@live@gt_heartbeat.html
- shard-apl: [DMESG-FAIL][38] ([i915#5334]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-apl6/igt@i915_selftest@live@gt_heartbeat.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-apl4/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_addfb_basic@no-handle:
- {shard-dg1}: [DMESG-WARN][40] -> [PASS][41] +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-dg1-12/igt@kms_addfb_basic@no-handle.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-dg1-12/igt@kms_addfb_basic@no-handle.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [SKIP][42] ([i915#1845] / [i915#4098]) -> [PASS][43] +17 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-rkl-2/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-rkl-6/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- {shard-tglu}: [SKIP][44] ([i915#1845] / [i915#7651]) -> [PASS][45] +10 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-tglu-6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-tglu-4/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- {shard-tglu}: [SKIP][46] ([i915#1849]) -> [PASS][47] +4 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-tglu-4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary:
- {shard-rkl}: [SKIP][48] ([i915#1849] / [i915#4098]) -> [PASS][49] +18 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-rkl-4/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html
* igt@kms_plane@plane-position-hole@pipe-b-planes:
- {shard-rkl}: [SKIP][50] ([i915#1849]) -> [PASS][51] +3 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-rkl-2/igt@kms_plane@plane-position-hole@pipe-b-planes.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-rkl-6/igt@kms_plane@plane-position-hole@pipe-b-planes.html
* igt@kms_psr@no_drrs:
- {shard-rkl}: [SKIP][52] ([i915#1072]) -> [PASS][53] +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-rkl-2/igt@kms_psr@no_drrs.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-rkl-6/igt@kms_psr@no_drrs.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- {shard-rkl}: [SKIP][54] ([i915#5461]) -> [PASS][55] +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-rkl-5/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-rkl-6/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
* igt@kms_pwrite_crc:
- {shard-tglu}: [SKIP][56] ([fdo#109274] / [i915#1845]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-tglu-6/igt@kms_pwrite_crc.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-tglu-4/igt@kms_pwrite_crc.html
* igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-c:
- {shard-tglu}: [SKIP][58] ([fdo#109274]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-tglu-6/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-c.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-tglu-4/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-c.html
* igt@syncobj_wait@wait-all-delayed-signal:
- {shard-dg1}: [DMESG-WARN][60] ([i915#1982]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/shard-dg1-15/igt@syncobj_wait@wait-all-delayed-signal.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/shard-dg1-14/igt@syncobj_wait@wait-all-delayed-signal.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5115]: https://gitlab.freedesktop.org/drm/intel/issues/5115
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6943]: https://gitlab.freedesktop.org/drm/intel/issues/6943
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8018]: https://gitlab.freedesktop.org/drm/intel/issues/8018
[i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
Build changes
-------------
* Linux: CI_DRM_12746 -> Patchwork_114029v2
CI-20190529: 20190529
CI_DRM_12746: 6ce36b596fa77ffb513126191268bc3637c96413 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7160: 45da871dd2684227e93a2fc002b87dfc58bd5fd9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114029v2: 6ce36b596fa77ffb513126191268bc3637c96413 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114029v2/index.html
[-- Attachment #2: Type: text/html, Size: 17137 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-02-16 19:10 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-14 23:19 [Intel-gfx] [PATCH 1/3] drm/i915: Use encoder->devdata more Ville Syrjala
2023-02-14 23:19 ` [Intel-gfx] [PATCH 2/3] drm/i915: Sanitize child devices later Ville Syrjala
2023-02-14 23:19 ` [Intel-gfx] [PATCH 3/3] drm/i915: Try to initialize DDI ports for every VBT child device Ville Syrjala
2023-02-14 23:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Use encoder->devdata more Patchwork
2023-02-15 10:02 ` [Intel-gfx] [PATCH 1/3] " Jani Nikula
2023-02-15 10:35 ` Ville Syrjälä
2023-02-15 11:04 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork
2023-02-16 0:04 ` [Intel-gfx] [PATCH v2 1/3] " Ville Syrjala
2023-02-16 14:53 ` Jani Nikula
2023-02-16 0:34 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/i915: Use encoder->devdata more (rev2) Patchwork
2023-02-16 1:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-02-16 19:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.