From: Conor Dooley <conor.dooley@microchip.com> To: Conor Dooley <conor@kernel.org>, <soc@kernel.org> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Emil Renner Berthing <emil.renner.berthing@canonical.com>, Hal Feng <hal.feng@starfivetech.com>, <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>, Conor Dooley <conor.dooley@microchip.com> Subject: [PATCH v1] dt-bindings: riscv: correct starfive visionfive 2 compatibles Date: Thu, 16 Feb 2023 13:15:12 +0000 [thread overview] Message-ID: <20230216131511.3327943-1-conor.dooley@microchip.com> (raw) Using "va" and "vb" doesn't match what's written on the board, or the communications from StarFive. Switching to using the silkscreened version number will ease confusion & the risk of another spin of the board containing a "conflicting" version identifier. As the binding has not made it into mainline yet, take the opportunity to "correct" things. Suggested-by: Emil Renner Berthing <emil.renner.berthing@canonical.com> Link: https://lore.kernel.org/linux-riscv/Y+4AxDSDLyL1WAqh@wendy/ Fixes: 97b7ed072784 ("dt-bindings: riscv: Add StarFive JH7110 SoC and VisionFive 2 board") Signed-off-by: Conor Dooley <conor.dooley@microchip.com> --- Arnd, If this is okay with the dt folk, could you please send this to Linus in the merge window? The dts for this binding hasn't landed yet so this is a standalone "fix" on top of my earlier dt for v6.3 PR. Thanks, Conor. --- Documentation/devicetree/bindings/riscv/starfive.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml index 60c7c03fcdce..cc4d92f0a1bf 100644 --- a/Documentation/devicetree/bindings/riscv/starfive.yaml +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml @@ -26,8 +26,8 @@ properties: - items: - enum: - - starfive,visionfive-2-va - - starfive,visionfive-2-vb + - starfive,visionfive-2-v1.2a + - starfive,visionfive-2-v1.3b - const: starfive,jh7110 additionalProperties: true -- 2.39.0
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor.dooley@microchip.com> To: Conor Dooley <conor@kernel.org>, <soc@kernel.org> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Emil Renner Berthing <emil.renner.berthing@canonical.com>, Hal Feng <hal.feng@starfivetech.com>, <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>, Conor Dooley <conor.dooley@microchip.com> Subject: [PATCH v1] dt-bindings: riscv: correct starfive visionfive 2 compatibles Date: Thu, 16 Feb 2023 13:15:12 +0000 [thread overview] Message-ID: <20230216131511.3327943-1-conor.dooley@microchip.com> (raw) Using "va" and "vb" doesn't match what's written on the board, or the communications from StarFive. Switching to using the silkscreened version number will ease confusion & the risk of another spin of the board containing a "conflicting" version identifier. As the binding has not made it into mainline yet, take the opportunity to "correct" things. Suggested-by: Emil Renner Berthing <emil.renner.berthing@canonical.com> Link: https://lore.kernel.org/linux-riscv/Y+4AxDSDLyL1WAqh@wendy/ Fixes: 97b7ed072784 ("dt-bindings: riscv: Add StarFive JH7110 SoC and VisionFive 2 board") Signed-off-by: Conor Dooley <conor.dooley@microchip.com> --- Arnd, If this is okay with the dt folk, could you please send this to Linus in the merge window? The dts for this binding hasn't landed yet so this is a standalone "fix" on top of my earlier dt for v6.3 PR. Thanks, Conor. --- Documentation/devicetree/bindings/riscv/starfive.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml index 60c7c03fcdce..cc4d92f0a1bf 100644 --- a/Documentation/devicetree/bindings/riscv/starfive.yaml +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml @@ -26,8 +26,8 @@ properties: - items: - enum: - - starfive,visionfive-2-va - - starfive,visionfive-2-vb + - starfive,visionfive-2-v1.2a + - starfive,visionfive-2-v1.3b - const: starfive,jh7110 additionalProperties: true -- 2.39.0 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2023-02-16 13:16 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-16 13:15 Conor Dooley [this message] 2023-02-16 13:15 ` [PATCH v1] dt-bindings: riscv: correct starfive visionfive 2 compatibles Conor Dooley 2023-02-16 15:16 ` Krzysztof Kozlowski 2023-02-16 15:16 ` Krzysztof Kozlowski 2023-02-16 22:30 ` patchwork-bot+linux-soc
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230216131511.3327943-1-conor.dooley@microchip.com \ --to=conor.dooley@microchip.com \ --cc=conor@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=emil.renner.berthing@canonical.com \ --cc=hal.feng@starfivetech.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-riscv@lists.infradead.org \ --cc=robh+dt@kernel.org \ --cc=soc@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.