All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: defconfig: Fix unintentional disablement of PCI on i.MX
@ 2023-02-20 19:09 ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2023-02-20 19:09 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon, soc, Richard Zhu,
	Lorenzo Pieralisi, Richard Zhu, Lucas Stach
  Cc: Michael Walle, Krzysztof Wilczyński, Kishon Vijay Abraham I,
	linux-pci, linux-arm-kernel, Manivannan Sadhasivam,
	kernelci.org bot, Mark Brown

A recent update to support PCI endpoint mode on i.MX platforms
unintentionally disabled PCI host support for i.MX in defconfig.  The
existing PCI_IMX6 was made a hidden option, selected by new options
PCI_IMX6_HOST (for the existing support) and PCI_IMX6_EP (for the
endpoint mode), but there has been no corresponding update to defconfig
so the PCI_IMX6 ends up getting disabled.  Switch defconfig to
PCI_IMX6_HOST to preserve the existing functionality.

Fixes: 75c2f26da03f ("PCI: imx6: Add i.MX PCIe EP mode support")
Reported-by: "kernelci.org bot" <bot@kernelci.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/configs/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index b452d8d7a32c..36f5c9ecc871 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -219,7 +219,7 @@ CONFIG_PCI_HOST_THUNDER_ECAM=y
 CONFIG_PCIE_ROCKCHIP_HOST=m
 CONFIG_PCIE_MEDIATEK_GEN3=m
 CONFIG_PCIE_BRCMSTB=m
-CONFIG_PCI_IMX6=y
+CONFIG_PCI_IMX6_HOST=y
 CONFIG_PCI_LAYERSCAPE=y
 CONFIG_PCI_HISI=y
 CONFIG_PCIE_QCOM=y

---
base-commit: d2af0fa4bfa4ec29d03b449ccd43fee39501112d
change-id: 20230220-imx-pci-defconfig-8a3a283b798a

Best regards,
-- 
Mark Brown <broonie@kernel.org>


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] arm64: defconfig: Fix unintentional disablement of PCI on i.MX
@ 2023-02-20 19:09 ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2023-02-20 19:09 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon, soc, Richard Zhu,
	Lorenzo Pieralisi, Richard Zhu, Lucas Stach
  Cc: Michael Walle, Krzysztof Wilczyński, Kishon Vijay Abraham I,
	linux-pci, linux-arm-kernel, Manivannan Sadhasivam,
	kernelci.org bot, Mark Brown

A recent update to support PCI endpoint mode on i.MX platforms
unintentionally disabled PCI host support for i.MX in defconfig.  The
existing PCI_IMX6 was made a hidden option, selected by new options
PCI_IMX6_HOST (for the existing support) and PCI_IMX6_EP (for the
endpoint mode), but there has been no corresponding update to defconfig
so the PCI_IMX6 ends up getting disabled.  Switch defconfig to
PCI_IMX6_HOST to preserve the existing functionality.

Fixes: 75c2f26da03f ("PCI: imx6: Add i.MX PCIe EP mode support")
Reported-by: "kernelci.org bot" <bot@kernelci.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/configs/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index b452d8d7a32c..36f5c9ecc871 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -219,7 +219,7 @@ CONFIG_PCI_HOST_THUNDER_ECAM=y
 CONFIG_PCIE_ROCKCHIP_HOST=m
 CONFIG_PCIE_MEDIATEK_GEN3=m
 CONFIG_PCIE_BRCMSTB=m
-CONFIG_PCI_IMX6=y
+CONFIG_PCI_IMX6_HOST=y
 CONFIG_PCI_LAYERSCAPE=y
 CONFIG_PCI_HISI=y
 CONFIG_PCIE_QCOM=y

---
base-commit: d2af0fa4bfa4ec29d03b449ccd43fee39501112d
change-id: 20230220-imx-pci-defconfig-8a3a283b798a

Best regards,
-- 
Mark Brown <broonie@kernel.org>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* RE: [PATCH] arm64: defconfig: Fix unintentional disablement of PCI on i.MX
  2023-02-20 19:09 ` Mark Brown
@ 2023-02-21  2:57   ` Hongxing Zhu
  -1 siblings, 0 replies; 5+ messages in thread
From: Hongxing Zhu @ 2023-02-21  2:57 UTC (permalink / raw)
  To: Mark Brown, Catalin Marinas, Will Deacon, soc, Lorenzo Pieralisi,
	Lucas Stach
  Cc: Michael Walle, Krzysztof Wilczyński, Kishon Vijay Abraham I,
	linux-pci, linux-arm-kernel, Manivannan Sadhasivam,
	kernelci.org bot

> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: 2023年2月21日 3:10
> To: Catalin Marinas <catalin.marinas@arm.com>; Will Deacon
> <will@kernel.org>; soc@kernel.org; Hongxing Zhu <hongxing.zhu@nxp.com>;
> Lorenzo Pieralisi <lpieralisi@kernel.org>; Hongxing Zhu
> <hongxing.zhu@nxp.com>; Lucas Stach <l.stach@pengutronix.de>
> Cc: Michael Walle <michael@walle.cc>; Krzysztof Wilczyński
> <kw@linux.com>; Kishon Vijay Abraham I <kishon@kernel.org>;
> linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Manivannan
> Sadhasivam <mani@kernel.org>; kernelci.org bot <bot@kernelci.org>; Mark
> Brown <broonie@kernel.org>
> Subject: [PATCH] arm64: defconfig: Fix unintentional disablement of PCI on
> i.MX
> 
> A recent update to support PCI endpoint mode on i.MX platforms
> unintentionally disabled PCI host support for i.MX in defconfig.  The existing
> PCI_IMX6 was made a hidden option, selected by new options
> PCI_IMX6_HOST (for the existing support) and PCI_IMX6_EP (for the endpoint
> mode), but there has been no corresponding update to defconfig so the
> PCI_IMX6 ends up getting disabled.  Switch defconfig to PCI_IMX6_HOST to
> preserve the existing functionality.
> 
> Fixes: 75c2f26da03f ("PCI: imx6: Add i.MX PCIe EP mode support")
> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
Thanks a lot for your fix.
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>

Best Regards
Richard Zhu

>  arch/arm64/configs/defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index b452d8d7a32c..36f5c9ecc871 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -219,7 +219,7 @@ CONFIG_PCI_HOST_THUNDER_ECAM=y
> CONFIG_PCIE_ROCKCHIP_HOST=m  CONFIG_PCIE_MEDIATEK_GEN3=m
> CONFIG_PCIE_BRCMSTB=m -CONFIG_PCI_IMX6=y
> +CONFIG_PCI_IMX6_HOST=y
>  CONFIG_PCI_LAYERSCAPE=y
>  CONFIG_PCI_HISI=y
>  CONFIG_PCIE_QCOM=y
> 
> ---
> base-commit: d2af0fa4bfa4ec29d03b449ccd43fee39501112d
> change-id: 20230220-imx-pci-defconfig-8a3a283b798a
> 
> Best regards,
> --
> Mark Brown <broonie@kernel.org>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] arm64: defconfig: Fix unintentional disablement of PCI on i.MX
@ 2023-02-21  2:57   ` Hongxing Zhu
  0 siblings, 0 replies; 5+ messages in thread
From: Hongxing Zhu @ 2023-02-21  2:57 UTC (permalink / raw)
  To: Mark Brown, Catalin Marinas, Will Deacon, soc, Lorenzo Pieralisi,
	Lucas Stach
  Cc: Michael Walle, Krzysztof Wilczyński, Kishon Vijay Abraham I,
	linux-pci, linux-arm-kernel, Manivannan Sadhasivam,
	kernelci.org bot

> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: 2023年2月21日 3:10
> To: Catalin Marinas <catalin.marinas@arm.com>; Will Deacon
> <will@kernel.org>; soc@kernel.org; Hongxing Zhu <hongxing.zhu@nxp.com>;
> Lorenzo Pieralisi <lpieralisi@kernel.org>; Hongxing Zhu
> <hongxing.zhu@nxp.com>; Lucas Stach <l.stach@pengutronix.de>
> Cc: Michael Walle <michael@walle.cc>; Krzysztof Wilczyński
> <kw@linux.com>; Kishon Vijay Abraham I <kishon@kernel.org>;
> linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Manivannan
> Sadhasivam <mani@kernel.org>; kernelci.org bot <bot@kernelci.org>; Mark
> Brown <broonie@kernel.org>
> Subject: [PATCH] arm64: defconfig: Fix unintentional disablement of PCI on
> i.MX
> 
> A recent update to support PCI endpoint mode on i.MX platforms
> unintentionally disabled PCI host support for i.MX in defconfig.  The existing
> PCI_IMX6 was made a hidden option, selected by new options
> PCI_IMX6_HOST (for the existing support) and PCI_IMX6_EP (for the endpoint
> mode), but there has been no corresponding update to defconfig so the
> PCI_IMX6 ends up getting disabled.  Switch defconfig to PCI_IMX6_HOST to
> preserve the existing functionality.
> 
> Fixes: 75c2f26da03f ("PCI: imx6: Add i.MX PCIe EP mode support")
> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
Thanks a lot for your fix.
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>

Best Regards
Richard Zhu

>  arch/arm64/configs/defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index b452d8d7a32c..36f5c9ecc871 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -219,7 +219,7 @@ CONFIG_PCI_HOST_THUNDER_ECAM=y
> CONFIG_PCIE_ROCKCHIP_HOST=m  CONFIG_PCIE_MEDIATEK_GEN3=m
> CONFIG_PCIE_BRCMSTB=m -CONFIG_PCI_IMX6=y
> +CONFIG_PCI_IMX6_HOST=y
>  CONFIG_PCI_LAYERSCAPE=y
>  CONFIG_PCI_HISI=y
>  CONFIG_PCIE_QCOM=y
> 
> ---
> base-commit: d2af0fa4bfa4ec29d03b449ccd43fee39501112d
> change-id: 20230220-imx-pci-defconfig-8a3a283b798a
> 
> Best regards,
> --
> Mark Brown <broonie@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: defconfig: Fix unintentional disablement of PCI on i.MX
  2023-02-20 19:09 ` Mark Brown
  (?)
  (?)
@ 2023-02-27 13:50 ` patchwork-bot+linux-soc
  -1 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+linux-soc @ 2023-02-27 13:50 UTC (permalink / raw)
  To: Mark Brown; +Cc: soc

Hello:

This patch was applied to soc/soc.git (arm/fixes)
by Arnd Bergmann <arnd@arndb.de>:

On Mon, 20 Feb 2023 19:09:45 +0000 you wrote:
> A recent update to support PCI endpoint mode on i.MX platforms
> unintentionally disabled PCI host support for i.MX in defconfig.  The
> existing PCI_IMX6 was made a hidden option, selected by new options
> PCI_IMX6_HOST (for the existing support) and PCI_IMX6_EP (for the
> endpoint mode), but there has been no corresponding update to defconfig
> so the PCI_IMX6 ends up getting disabled.  Switch defconfig to
> PCI_IMX6_HOST to preserve the existing functionality.
> 
> [...]

Here is the summary with links:
  - arm64: defconfig: Fix unintentional disablement of PCI on i.MX
    https://git.kernel.org/soc/soc/c/0cd5780eb625

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-02-27 13:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-20 19:09 [PATCH] arm64: defconfig: Fix unintentional disablement of PCI on i.MX Mark Brown
2023-02-20 19:09 ` Mark Brown
2023-02-21  2:57 ` Hongxing Zhu
2023-02-21  2:57   ` Hongxing Zhu
2023-02-27 13:50 ` patchwork-bot+linux-soc

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.