All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Alcock <nick.alcock@oracle.com>
To: mcgrof@kernel.org
Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
	Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org
Subject: [PATCH 20/27] kbuild, dmaengine: remove MODULE_LICENSE in non-modules
Date: Wed, 22 Feb 2023 12:14:46 +0000	[thread overview]
Message-ID: <20230222121453.91915-21-nick.alcock@oracle.com> (raw)
In-Reply-To: <20230222121453.91915-1-nick.alcock@oracle.com>

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org
---
 drivers/dma/ep93xx_dma.c    | 1 -
 drivers/dma/ipu/ipu_idmac.c | 1 -
 drivers/dma/mv_xor_v2.c     | 1 -
 drivers/dma/sh/shdma-base.c | 1 -
 4 files changed, 4 deletions(-)

diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
index d19ea885c63e..5338a94f1a69 100644
--- a/drivers/dma/ep93xx_dma.c
+++ b/drivers/dma/ep93xx_dma.c
@@ -1431,4 +1431,3 @@ subsys_initcall(ep93xx_dma_module_init);
 
 MODULE_AUTHOR("Mika Westerberg <mika.westerberg@iki.fi>");
 MODULE_DESCRIPTION("EP93xx DMA driver");
-MODULE_LICENSE("GPL");
diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
index baab1ca9f621..d799b99c18bd 100644
--- a/drivers/dma/ipu/ipu_idmac.c
+++ b/drivers/dma/ipu/ipu_idmac.c
@@ -1797,6 +1797,5 @@ static int __init ipu_init(void)
 subsys_initcall(ipu_init);
 
 MODULE_DESCRIPTION("IPU core driver");
-MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Guennadi Liakhovetski <lg@denx.de>");
 MODULE_ALIAS("platform:ipu-core");
diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
index 113834e1167b..22f485465951 100644
--- a/drivers/dma/mv_xor_v2.c
+++ b/drivers/dma/mv_xor_v2.c
@@ -920,4 +920,3 @@ static struct platform_driver mv_xor_v2_driver = {
 module_platform_driver(mv_xor_v2_driver);
 
 MODULE_DESCRIPTION("DMA engine driver for Marvell's Version 2 of XOR engine");
-MODULE_LICENSE("GPL");
diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c
index 158e5e7defae..588c5f409a80 100644
--- a/drivers/dma/sh/shdma-base.c
+++ b/drivers/dma/sh/shdma-base.c
@@ -1047,6 +1047,5 @@ static void __exit shdma_exit(void)
 }
 module_exit(shdma_exit);
 
-MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("SH-DMA driver base library");
 MODULE_AUTHOR("Guennadi Liakhovetski <g.liakhovetski@gmx.de>");
-- 
2.39.1.268.g9de2f9a303


  parent reply	other threads:[~2023-02-22 12:19 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230222121453.91915-1-nick.alcock@oracle.com>
2023-02-22 12:14 ` [PATCH 01/27] kbuild, power: reset: keystone-reset: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-22 12:14 ` [PATCH 02/27] kbuild, video: fbdev: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 03/27] kbuild, KEYS: " Nick Alcock
2023-02-22 12:14 ` [PATCH 04/27] kbuild, soc: bcm: raspberrypi-power: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-24 21:26   ` Florian Fainelli
2023-02-24 21:26     ` Florian Fainelli
2023-02-22 12:14 ` [PATCH 05/27] kbuild, soc: bcm: bcm2835-power: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-24 21:26   ` Florian Fainelli
2023-02-24 21:26     ` Florian Fainelli
2023-02-22 12:14 ` [PATCH 06/27] kbuild, pinctrl: bcm: ns: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 07/27] kbuild, MIPS: BCM47XX: " Nick Alcock
2023-02-26 22:14   ` Philippe Mathieu-Daudé
2023-02-22 12:14 ` [PATCH 08/27] kbuild, clocksource: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 09/27] kbuild, clocksource/drivers/timer-tegra186: " Nick Alcock
2023-02-22 12:14 ` [PATCH 10/27] kbuild, clocksource: " Nick Alcock
2023-02-22 12:14 ` [PATCH 11/27] kbuild, clk: bcm2835: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 23:43   ` Stephen Boyd
2023-02-22 23:43     ` Stephen Boyd
2023-02-23  1:36     ` Luis Chamberlain
2023-02-23  1:36       ` Luis Chamberlain
2023-03-06 19:29   ` Stephen Boyd
2023-03-06 19:29     ` Stephen Boyd
2023-02-22 12:14 ` [PATCH 12/27] kbuild, clk: " Nick Alcock
2023-02-22 12:41   ` Conor Dooley
2023-02-22 23:43   ` Stephen Boyd
2023-03-06 19:29   ` [PATCH 12/27] kbuild, clk: remove MODULE_LICENSE in non-modules Stephen Boyd
2023-02-22 12:14 ` [PATCH 13/27] kbuild, vgacon: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 14/27] kbuild, cpufreq: tegra124: " Nick Alcock
2023-02-23  4:20   ` Viresh Kumar
2023-02-22 12:14 ` [PATCH 15/27] kbuild, cpufreq: " Nick Alcock
2023-02-23  4:20   ` Viresh Kumar
2023-02-22 12:14 ` [PATCH 16/27] kbuild, crypto: " Nick Alcock
2023-02-23 10:18   ` Herbert Xu
2023-02-22 12:14 ` [PATCH 17/27] " Nick Alcock
2023-02-23 10:21   ` Herbert Xu
2023-02-22 12:14 ` [PATCH 18/27] kbuild, mfd: " Nick Alcock
2023-02-22 22:38   ` DLG Adam Ward
2023-02-23 13:48     ` Lee Jones
2023-02-23 19:24       ` Nick Alcock
2023-02-24 15:03         ` DLG Adam Ward
2023-02-27 13:15           ` Nick Alcock
2023-03-01  9:04             ` Lee Jones
2023-02-22 12:14 ` [PATCH 19/27] kbuild, dmaengine: stm32-mdma: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` Nick Alcock [this message]
2023-02-22 12:14 ` [PATCH 21/27] kbuild, dma-mapping: benchmark: " Nick Alcock
2023-02-22 14:48   ` Christoph Hellwig
2023-02-22 22:52     ` Luis Chamberlain
2023-02-23 15:31       ` Nick Alcock
2023-02-23 20:51         ` Luis Chamberlain
2023-02-24 14:20           ` Nick Alcock
2023-02-24 17:18             ` Luis Chamberlain
2023-02-22 12:14 ` [PATCH 22/27] kbuild, dma-buf: heaps: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 23/27] kbuild, drm/dsi: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 24/27] kbuild, binfmt_elf: " Nick Alcock
2023-02-22 12:14 ` [PATCH 25/27] kbuild, video: fbdev: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 26/27] kbuild, phy: intel: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 27/27] kbuild, gpio: gpio-aspeed-sgpio: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-03-06  9:59   ` Bartosz Golaszewski
2023-03-06  9:59     ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230222121453.91915-21-nick.alcock@oracle.com \
    --to=nick.alcock@oracle.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=hasegawa-hitomi@fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.