All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Alcock <nick.alcock@oracle.com>
To: Lee Jones <lee@kernel.org>
Cc: DLG Adam Ward <DLG-Adam.Ward.opensource@dm.renesas.com>,
	"mcgrof@kernel.org" <mcgrof@kernel.org>,
	"linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
	Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH 18/27] kbuild, mfd: remove MODULE_LICENSE in non-modules
Date: Thu, 23 Feb 2023 19:24:33 +0000	[thread overview]
Message-ID: <87ttzcmbgu.fsf@esperi.org.uk> (raw)
In-Reply-To: <Y/duxo1aKFibuZtF@google.com> (Lee Jones's message of "Thu, 23 Feb 2023 13:48:54 +0000")

On 23 Feb 2023, Lee Jones stated:

> On Wed, 22 Feb 2023, DLG Adam Ward wrote:
>
>> On 22/02/2023 12:15, Nick Alcock wrote:
>> >Since commit 8b41fc4454e ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations are used to identify modules. As a consequence, uses of the macro in non-modules will cause modprobe to misidentify their containing object file as a module when it is not (false positives), and modprobe might succeed rather than failing with a suitable error message.
>> >
>> >So remove it in the files in this commit, none of which can be built as modules.
>> 
>> Makes sense - but if you need to do a V2, would you mind removing the erroneous claim on DA9055 at the same time?

I don't know what this means. There are two references to DA9055 in this
patch, both in context (not in modified lines), one in
drivers/mfd/da9055-core.c, the other in rivers/mfd/da9055-i2c.c. To me
these both seem likely to be DA9055-related. Are you saying that one of
them isn't?

> Could you do this anyway please.  While you're at it, please remove the
> 'kbuild' reference from the subject line, thanks.

I was going to say that it seems to be in active use, but I just checked
and a total of zero files touched by this series have ever used 'kbuild'
in their log prefixes anywhere. So... dropped, series-wide. (By the
overdesigned approach of using a kbuild: prefix if and only if at least
one file in the files touched in that commit has used that prefix
somewhere in its history.)

-- 
NULL && (void)

  reply	other threads:[~2023-02-23 19:24 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230222121453.91915-1-nick.alcock@oracle.com>
2023-02-22 12:14 ` [PATCH 01/27] kbuild, power: reset: keystone-reset: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-22 12:14 ` [PATCH 02/27] kbuild, video: fbdev: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 03/27] kbuild, KEYS: " Nick Alcock
2023-02-22 12:14 ` [PATCH 04/27] kbuild, soc: bcm: raspberrypi-power: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-24 21:26   ` Florian Fainelli
2023-02-24 21:26     ` Florian Fainelli
2023-02-22 12:14 ` [PATCH 05/27] kbuild, soc: bcm: bcm2835-power: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-24 21:26   ` Florian Fainelli
2023-02-24 21:26     ` Florian Fainelli
2023-02-22 12:14 ` [PATCH 06/27] kbuild, pinctrl: bcm: ns: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 07/27] kbuild, MIPS: BCM47XX: " Nick Alcock
2023-02-26 22:14   ` Philippe Mathieu-Daudé
2023-02-22 12:14 ` [PATCH 08/27] kbuild, clocksource: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 09/27] kbuild, clocksource/drivers/timer-tegra186: " Nick Alcock
2023-02-22 12:14 ` [PATCH 10/27] kbuild, clocksource: " Nick Alcock
2023-02-22 12:14 ` [PATCH 11/27] kbuild, clk: bcm2835: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 23:43   ` Stephen Boyd
2023-02-22 23:43     ` Stephen Boyd
2023-02-23  1:36     ` Luis Chamberlain
2023-02-23  1:36       ` Luis Chamberlain
2023-03-06 19:29   ` Stephen Boyd
2023-03-06 19:29     ` Stephen Boyd
2023-02-22 12:14 ` [PATCH 12/27] kbuild, clk: " Nick Alcock
2023-02-22 12:41   ` Conor Dooley
2023-02-22 23:43   ` Stephen Boyd
2023-03-06 19:29   ` [PATCH 12/27] kbuild, clk: remove MODULE_LICENSE in non-modules Stephen Boyd
2023-02-22 12:14 ` [PATCH 13/27] kbuild, vgacon: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 14/27] kbuild, cpufreq: tegra124: " Nick Alcock
2023-02-23  4:20   ` Viresh Kumar
2023-02-22 12:14 ` [PATCH 15/27] kbuild, cpufreq: " Nick Alcock
2023-02-23  4:20   ` Viresh Kumar
2023-02-22 12:14 ` [PATCH 16/27] kbuild, crypto: " Nick Alcock
2023-02-23 10:18   ` Herbert Xu
2023-02-22 12:14 ` [PATCH 17/27] " Nick Alcock
2023-02-23 10:21   ` Herbert Xu
2023-02-22 12:14 ` [PATCH 18/27] kbuild, mfd: " Nick Alcock
2023-02-22 22:38   ` DLG Adam Ward
2023-02-23 13:48     ` Lee Jones
2023-02-23 19:24       ` Nick Alcock [this message]
2023-02-24 15:03         ` DLG Adam Ward
2023-02-27 13:15           ` Nick Alcock
2023-03-01  9:04             ` Lee Jones
2023-02-22 12:14 ` [PATCH 19/27] kbuild, dmaengine: stm32-mdma: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 20/27] kbuild, dmaengine: " Nick Alcock
2023-02-22 12:14 ` [PATCH 21/27] kbuild, dma-mapping: benchmark: " Nick Alcock
2023-02-22 14:48   ` Christoph Hellwig
2023-02-22 22:52     ` Luis Chamberlain
2023-02-23 15:31       ` Nick Alcock
2023-02-23 20:51         ` Luis Chamberlain
2023-02-24 14:20           ` Nick Alcock
2023-02-24 17:18             ` Luis Chamberlain
2023-02-22 12:14 ` [PATCH 22/27] kbuild, dma-buf: heaps: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 23/27] kbuild, drm/dsi: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 24/27] kbuild, binfmt_elf: " Nick Alcock
2023-02-22 12:14 ` [PATCH 25/27] kbuild, video: fbdev: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 26/27] kbuild, phy: intel: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-02-22 12:14 ` [PATCH 27/27] kbuild, gpio: gpio-aspeed-sgpio: " Nick Alcock
2023-02-22 12:14   ` Nick Alcock
2023-03-06  9:59   ` Bartosz Golaszewski
2023-03-06  9:59     ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttzcmbgu.fsf@esperi.org.uk \
    --to=nick.alcock@oracle.com \
    --cc=DLG-Adam.Ward.opensource@dm.renesas.com \
    --cc=hasegawa-hitomi@fujitsu.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=support.opensource@diasemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.