* [PATCH v2] macintosh: via-pmu-led: requires ATA to be set
@ 2023-02-23 1:42 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-02-23 1:42 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Benjamin Herrenschmidt, Paul Mackerras,
Elimar Riesebieter, Michael Ellerman, linuxppc-dev
LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK
when ATA is not set/enabled causes a Kconfig warning:
WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK
Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n]
Selected by [y]:
- ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y]
Fix this by making ADB_PMU_LED_DISK depend on ATA.
Seen on both PPC32 and PPC64.
Fixes: 0e865a80c135 ("macintosh: Remove dependency on IDE_GD_ATA if ADB_PMU_LED_DISK is selected")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Elimar Riesebieter <riesebie@lxtec.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
---
v2: add a complete Subject:
drivers/macintosh/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
--- a/drivers/macintosh/Kconfig
+++ b/drivers/macintosh/Kconfig
@@ -86,6 +86,7 @@ config ADB_PMU_LED
config ADB_PMU_LED_DISK
bool "Use front LED as DISK LED by default"
+ depends on ATA
depends on ADB_PMU_LED
depends on LEDS_CLASS
select LEDS_TRIGGERS
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] macintosh: via-pmu-led: requires ATA to be set
@ 2023-02-23 1:42 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-02-23 1:42 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Paul Mackerras, linuxppc-dev, Elimar Riesebieter
LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK
when ATA is not set/enabled causes a Kconfig warning:
WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK
Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n]
Selected by [y]:
- ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y]
Fix this by making ADB_PMU_LED_DISK depend on ATA.
Seen on both PPC32 and PPC64.
Fixes: 0e865a80c135 ("macintosh: Remove dependency on IDE_GD_ATA if ADB_PMU_LED_DISK is selected")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Elimar Riesebieter <riesebie@lxtec.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
---
v2: add a complete Subject:
drivers/macintosh/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
--- a/drivers/macintosh/Kconfig
+++ b/drivers/macintosh/Kconfig
@@ -86,6 +86,7 @@ config ADB_PMU_LED
config ADB_PMU_LED_DISK
bool "Use front LED as DISK LED by default"
+ depends on ATA
depends on ADB_PMU_LED
depends on LEDS_CLASS
select LEDS_TRIGGERS
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] macintosh: via-pmu-led: requires ATA to be set
2023-02-23 1:42 ` Randy Dunlap
@ 2023-04-06 1:09 ` Michael Ellerman
-1 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2023-04-06 1:09 UTC (permalink / raw)
To: linux-kernel, Randy Dunlap
Cc: Benjamin Herrenschmidt, Paul Mackerras, Elimar Riesebieter,
Michael Ellerman, linuxppc-dev
On Wed, 22 Feb 2023 17:42:41 -0800, Randy Dunlap wrote:
> LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK
> when ATA is not set/enabled causes a Kconfig warning:
>
> WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK
> Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n]
> Selected by [y]:
> - ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y]
>
> [...]
Applied to powerpc/next.
[1/1] macintosh: via-pmu-led: requires ATA to be set
https://git.kernel.org/powerpc/c/05dce4ba125336875cd3eed3c1503fa81cd2f691
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] macintosh: via-pmu-led: requires ATA to be set
@ 2023-04-06 1:09 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2023-04-06 1:09 UTC (permalink / raw)
To: linux-kernel, Randy Dunlap
Cc: Paul Mackerras, linuxppc-dev, Elimar Riesebieter
On Wed, 22 Feb 2023 17:42:41 -0800, Randy Dunlap wrote:
> LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK
> when ATA is not set/enabled causes a Kconfig warning:
>
> WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK
> Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n]
> Selected by [y]:
> - ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y]
>
> [...]
Applied to powerpc/next.
[1/1] macintosh: via-pmu-led: requires ATA to be set
https://git.kernel.org/powerpc/c/05dce4ba125336875cd3eed3c1503fa81cd2f691
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-06 1:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-23 1:42 [PATCH v2] macintosh: via-pmu-led: requires ATA to be set Randy Dunlap
2023-02-23 1:42 ` Randy Dunlap
2023-04-06 1:09 ` Michael Ellerman
2023-04-06 1:09 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.