* [RESEND] gpio: ws16c48: Fix off-by-one error in WS16C48 resource region extent
@ 2023-02-28 8:17 William Breathitt Gray
2023-03-06 9:23 ` Bartosz Golaszewski
0 siblings, 1 reply; 6+ messages in thread
From: William Breathitt Gray @ 2023-02-28 8:17 UTC (permalink / raw)
To: linus.walleij, brgl
Cc: linux-gpio, linux-kernel, techsupport, stable,
William Breathitt Gray, Paul Demetrotion
The WinSystems WS16C48 I/O address region spans offsets 0x0 through 0xA,
which is a total of 11 bytes. Fix the WS16C48_EXTENT define to the
correct value of 11 so that access to necessary device registers is
properly requested in the ws16c48_probe() callback by the
devm_request_region() function call.
Fixes: 2c05a0f29f41 ("gpio: ws16c48: Implement and utilize register structures")
Cc: stable@vger.kernel.org
Cc: Paul Demetrotion <pdemetrotion@winsystems.com>
Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
---
drivers/gpio/gpio-ws16c48.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-ws16c48.c b/drivers/gpio/gpio-ws16c48.c
index e73885a4dc32..afb42a8e916f 100644
--- a/drivers/gpio/gpio-ws16c48.c
+++ b/drivers/gpio/gpio-ws16c48.c
@@ -18,7 +18,7 @@
#include <linux/spinlock.h>
#include <linux/types.h>
-#define WS16C48_EXTENT 10
+#define WS16C48_EXTENT 11
#define MAX_NUM_WS16C48 max_num_isa_dev(WS16C48_EXTENT)
static unsigned int base[MAX_NUM_WS16C48];
base-commit: 4827aae061337251bb91801b316157a78b845ec7
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RESEND] gpio: ws16c48: Fix off-by-one error in WS16C48 resource region extent
2023-02-28 8:17 [RESEND] gpio: ws16c48: Fix off-by-one error in WS16C48 resource region extent William Breathitt Gray
@ 2023-03-06 9:23 ` Bartosz Golaszewski
2023-03-06 12:41 ` William Breathitt Gray
0 siblings, 1 reply; 6+ messages in thread
From: Bartosz Golaszewski @ 2023-03-06 9:23 UTC (permalink / raw)
To: William Breathitt Gray
Cc: linus.walleij, linux-gpio, linux-kernel, techsupport, stable,
Paul Demetrotion
On Thu, Mar 2, 2023 at 11:30 PM William Breathitt Gray
<william.gray@linaro.org> wrote:
>
> The WinSystems WS16C48 I/O address region spans offsets 0x0 through 0xA,
> which is a total of 11 bytes. Fix the WS16C48_EXTENT define to the
> correct value of 11 so that access to necessary device registers is
> properly requested in the ws16c48_probe() callback by the
> devm_request_region() function call.
>
> Fixes: 2c05a0f29f41 ("gpio: ws16c48: Implement and utilize register structures")
> Cc: stable@vger.kernel.org
> Cc: Paul Demetrotion <pdemetrotion@winsystems.com>
> Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
> ---
Why did you need to resend this? Anything changed?
Bart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND] gpio: ws16c48: Fix off-by-one error in WS16C48 resource region extent
2023-03-06 9:23 ` Bartosz Golaszewski
@ 2023-03-06 12:41 ` William Breathitt Gray
2023-04-05 14:47 ` William Breathitt Gray
0 siblings, 1 reply; 6+ messages in thread
From: William Breathitt Gray @ 2023-03-06 12:41 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: linus.walleij, linux-gpio, linux-kernel, techsupport, stable,
Paul Demetrotion
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
On Mon, Mar 06, 2023 at 10:23:30AM +0100, Bartosz Golaszewski wrote:
> On Thu, Mar 2, 2023 at 11:30 PM William Breathitt Gray
> <william.gray@linaro.org> wrote:
> >
> > The WinSystems WS16C48 I/O address region spans offsets 0x0 through 0xA,
> > which is a total of 11 bytes. Fix the WS16C48_EXTENT define to the
> > correct value of 11 so that access to necessary device registers is
> > properly requested in the ws16c48_probe() callback by the
> > devm_request_region() function call.
> >
> > Fixes: 2c05a0f29f41 ("gpio: ws16c48: Implement and utilize register structures")
> > Cc: stable@vger.kernel.org
> > Cc: Paul Demetrotion <pdemetrotion@winsystems.com>
> > Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
> > ---
>
> Why did you need to resend this? Anything changed?
>
> Bart
No changes in code, just added the stable@ver.kernel.org Cc tag.
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND] gpio: ws16c48: Fix off-by-one error in WS16C48 resource region extent
2023-03-06 12:41 ` William Breathitt Gray
@ 2023-04-05 14:47 ` William Breathitt Gray
2023-06-05 13:44 ` William Breathitt Gray
0 siblings, 1 reply; 6+ messages in thread
From: William Breathitt Gray @ 2023-04-05 14:47 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: linus.walleij, linux-gpio, linux-kernel, techsupport, stable,
Paul Demetrotion
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
On Mon, Mar 06, 2023 at 07:41:09AM -0500, William Breathitt Gray wrote:
> On Mon, Mar 06, 2023 at 10:23:30AM +0100, Bartosz Golaszewski wrote:
> > On Thu, Mar 2, 2023 at 11:30 PM William Breathitt Gray
> > <william.gray@linaro.org> wrote:
> > >
> > > The WinSystems WS16C48 I/O address region spans offsets 0x0 through 0xA,
> > > which is a total of 11 bytes. Fix the WS16C48_EXTENT define to the
> > > correct value of 11 so that access to necessary device registers is
> > > properly requested in the ws16c48_probe() callback by the
> > > devm_request_region() function call.
> > >
> > > Fixes: 2c05a0f29f41 ("gpio: ws16c48: Implement and utilize register structures")
> > > Cc: stable@vger.kernel.org
> > > Cc: Paul Demetrotion <pdemetrotion@winsystems.com>
> > > Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
> > > ---
> >
> > Why did you need to resend this? Anything changed?
> >
> > Bart
>
> No changes in code, just added the stable@ver.kernel.org Cc tag.
>
> William Breathitt Gray
Hi Bart,
Would you take this fix through the gpio tree?
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND] gpio: ws16c48: Fix off-by-one error in WS16C48 resource region extent
2023-04-05 14:47 ` William Breathitt Gray
@ 2023-06-05 13:44 ` William Breathitt Gray
2023-07-11 20:58 ` William Breathitt Gray
0 siblings, 1 reply; 6+ messages in thread
From: William Breathitt Gray @ 2023-06-05 13:44 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: linus.walleij, linux-gpio, linux-kernel, techsupport, stable,
Paul Demetrotion
[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]
On Wed, Apr 05, 2023 at 10:47:18AM -0400, William Breathitt Gray wrote:
> On Mon, Mar 06, 2023 at 07:41:09AM -0500, William Breathitt Gray wrote:
> > On Mon, Mar 06, 2023 at 10:23:30AM +0100, Bartosz Golaszewski wrote:
> > > On Thu, Mar 2, 2023 at 11:30 PM William Breathitt Gray
> > > <william.gray@linaro.org> wrote:
> > > >
> > > > The WinSystems WS16C48 I/O address region spans offsets 0x0 through 0xA,
> > > > which is a total of 11 bytes. Fix the WS16C48_EXTENT define to the
> > > > correct value of 11 so that access to necessary device registers is
> > > > properly requested in the ws16c48_probe() callback by the
> > > > devm_request_region() function call.
> > > >
> > > > Fixes: 2c05a0f29f41 ("gpio: ws16c48: Implement and utilize register structures")
> > > > Cc: stable@vger.kernel.org
> > > > Cc: Paul Demetrotion <pdemetrotion@winsystems.com>
> > > > Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
> > > > ---
> > >
> > > Why did you need to resend this? Anything changed?
> > >
> > > Bart
> >
> > No changes in code, just added the stable@ver.kernel.org Cc tag.
> >
> > William Breathitt Gray
>
> Hi Bart,
>
> Would you take this fix through the gpio tree?
>
> William Breathitt Gray
It looks like this patch was missed. Is there anything further needed or
can it be queued as it is now?
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND] gpio: ws16c48: Fix off-by-one error in WS16C48 resource region extent
2023-06-05 13:44 ` William Breathitt Gray
@ 2023-07-11 20:58 ` William Breathitt Gray
0 siblings, 0 replies; 6+ messages in thread
From: William Breathitt Gray @ 2023-07-11 20:58 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: linus.walleij, linux-gpio, linux-kernel, techsupport, stable,
Paul Demetrotion
[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]
On Mon, Jun 05, 2023 at 09:44:38AM -0400, William Breathitt Gray wrote:
> On Wed, Apr 05, 2023 at 10:47:18AM -0400, William Breathitt Gray wrote:
> > On Mon, Mar 06, 2023 at 07:41:09AM -0500, William Breathitt Gray wrote:
> > > On Mon, Mar 06, 2023 at 10:23:30AM +0100, Bartosz Golaszewski wrote:
> > > > On Thu, Mar 2, 2023 at 11:30 PM William Breathitt Gray
> > > > <william.gray@linaro.org> wrote:
> > > > >
> > > > > The WinSystems WS16C48 I/O address region spans offsets 0x0 through 0xA,
> > > > > which is a total of 11 bytes. Fix the WS16C48_EXTENT define to the
> > > > > correct value of 11 so that access to necessary device registers is
> > > > > properly requested in the ws16c48_probe() callback by the
> > > > > devm_request_region() function call.
> > > > >
> > > > > Fixes: 2c05a0f29f41 ("gpio: ws16c48: Implement and utilize register structures")
> > > > > Cc: stable@vger.kernel.org
> > > > > Cc: Paul Demetrotion <pdemetrotion@winsystems.com>
> > > > > Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
> > > > > ---
> > > >
> > > > Why did you need to resend this? Anything changed?
> > > >
> > > > Bart
> > >
> > > No changes in code, just added the stable@ver.kernel.org Cc tag.
> > >
> > > William Breathitt Gray
> >
> > Hi Bart,
> >
> > Would you take this fix through the gpio tree?
> >
> > William Breathitt Gray
>
> It looks like this patch was missed. Is there anything further needed or
> can it be queued as it is now?
>
> William Breathitt Gray
The fix was missed again this past cycle. Are there any particular
issues with merging this patch that I should address? WS16C48 interrupt
handling is still broken so that's the motivation for getting this fix
into the GPIO tree.
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-11 20:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-28 8:17 [RESEND] gpio: ws16c48: Fix off-by-one error in WS16C48 resource region extent William Breathitt Gray
2023-03-06 9:23 ` Bartosz Golaszewski
2023-03-06 12:41 ` William Breathitt Gray
2023-04-05 14:47 ` William Breathitt Gray
2023-06-05 13:44 ` William Breathitt Gray
2023-07-11 20:58 ` William Breathitt Gray
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.