* [PATCH] ASoC: mediatek: add missing initialization
@ 2023-03-01 4:08 ` Trevor Wu
0 siblings, 0 replies; 7+ messages in thread
From: Trevor Wu @ 2023-03-01 4:08 UTC (permalink / raw)
To: broonie, lgirdwood, tiwai, perex, matthias.bgg
Cc: trevor.wu, angelogioacchino.delregno, alsa-devel, linux-mediatek,
linux-arm-kernel, linux-kernel
In etdm dai driver, dai_etdm_parse_of() function is used to parse dts
properties to get parameters. There are two for-loops which are
sepearately for all etdm and etdm input only cases. In etdm in only
loop, dai_id is not initialized, so it keeps the value intiliazed in
another loop.
In the patch, add the missing initialization to fix the unexpected
parsing problem.
Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
---
sound/soc/mediatek/mt8188/mt8188-dai-etdm.c | 3 +++
sound/soc/mediatek/mt8195/mt8195-dai-etdm.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c b/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c
index 1c53d4cb19bb..7a37752d4244 100644
--- a/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c
+++ b/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c
@@ -2498,6 +2498,9 @@ static void mt8188_dai_etdm_parse_of(struct mtk_base_afe *afe)
/* etdm in only */
for (i = 0; i < 2; i++) {
+ dai_id = ETDM_TO_DAI_ID(i);
+ etdm_data = afe_priv->dai_priv[dai_id];
+
snprintf(prop, sizeof(prop), "mediatek,%s-chn-disabled",
of_afe_etdms[i].name);
diff --git a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c
index c2e268054773..f2c9a1fdbe0d 100644
--- a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c
+++ b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c
@@ -2567,6 +2567,9 @@ static void mt8195_dai_etdm_parse_of(struct mtk_base_afe *afe)
/* etdm in only */
for (i = 0; i < 2; i++) {
+ dai_id = ETDM_TO_DAI_ID(i);
+ etdm_data = afe_priv->dai_priv[dai_id];
+
ret = snprintf(prop, sizeof(prop),
"mediatek,%s-chn-disabled",
of_afe_etdms[i].name);
--
2.18.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] ASoC: mediatek: add missing initialization
@ 2023-03-01 4:08 ` Trevor Wu
0 siblings, 0 replies; 7+ messages in thread
From: Trevor Wu @ 2023-03-01 4:08 UTC (permalink / raw)
To: broonie, lgirdwood, tiwai, perex, matthias.bgg
Cc: trevor.wu, angelogioacchino.delregno, alsa-devel, linux-mediatek,
linux-arm-kernel, linux-kernel
In etdm dai driver, dai_etdm_parse_of() function is used to parse dts
properties to get parameters. There are two for-loops which are
sepearately for all etdm and etdm input only cases. In etdm in only
loop, dai_id is not initialized, so it keeps the value intiliazed in
another loop.
In the patch, add the missing initialization to fix the unexpected
parsing problem.
Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
---
sound/soc/mediatek/mt8188/mt8188-dai-etdm.c | 3 +++
sound/soc/mediatek/mt8195/mt8195-dai-etdm.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c b/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c
index 1c53d4cb19bb..7a37752d4244 100644
--- a/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c
+++ b/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c
@@ -2498,6 +2498,9 @@ static void mt8188_dai_etdm_parse_of(struct mtk_base_afe *afe)
/* etdm in only */
for (i = 0; i < 2; i++) {
+ dai_id = ETDM_TO_DAI_ID(i);
+ etdm_data = afe_priv->dai_priv[dai_id];
+
snprintf(prop, sizeof(prop), "mediatek,%s-chn-disabled",
of_afe_etdms[i].name);
diff --git a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c
index c2e268054773..f2c9a1fdbe0d 100644
--- a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c
+++ b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c
@@ -2567,6 +2567,9 @@ static void mt8195_dai_etdm_parse_of(struct mtk_base_afe *afe)
/* etdm in only */
for (i = 0; i < 2; i++) {
+ dai_id = ETDM_TO_DAI_ID(i);
+ etdm_data = afe_priv->dai_priv[dai_id];
+
ret = snprintf(prop, sizeof(prop),
"mediatek,%s-chn-disabled",
of_afe_etdms[i].name);
--
2.18.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] ASoC: mediatek: add missing initialization
@ 2023-03-01 4:08 ` Trevor Wu
0 siblings, 0 replies; 7+ messages in thread
From: Trevor Wu @ 2023-03-01 4:08 UTC (permalink / raw)
To: broonie, lgirdwood, tiwai, perex, matthias.bgg
Cc: trevor.wu, angelogioacchino.delregno, alsa-devel, linux-mediatek,
linux-arm-kernel, linux-kernel
In etdm dai driver, dai_etdm_parse_of() function is used to parse dts
properties to get parameters. There are two for-loops which are
sepearately for all etdm and etdm input only cases. In etdm in only
loop, dai_id is not initialized, so it keeps the value intiliazed in
another loop.
In the patch, add the missing initialization to fix the unexpected
parsing problem.
Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
---
sound/soc/mediatek/mt8188/mt8188-dai-etdm.c | 3 +++
sound/soc/mediatek/mt8195/mt8195-dai-etdm.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c b/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c
index 1c53d4cb19bb..7a37752d4244 100644
--- a/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c
+++ b/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c
@@ -2498,6 +2498,9 @@ static void mt8188_dai_etdm_parse_of(struct mtk_base_afe *afe)
/* etdm in only */
for (i = 0; i < 2; i++) {
+ dai_id = ETDM_TO_DAI_ID(i);
+ etdm_data = afe_priv->dai_priv[dai_id];
+
snprintf(prop, sizeof(prop), "mediatek,%s-chn-disabled",
of_afe_etdms[i].name);
diff --git a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c
index c2e268054773..f2c9a1fdbe0d 100644
--- a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c
+++ b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c
@@ -2567,6 +2567,9 @@ static void mt8195_dai_etdm_parse_of(struct mtk_base_afe *afe)
/* etdm in only */
for (i = 0; i < 2; i++) {
+ dai_id = ETDM_TO_DAI_ID(i);
+ etdm_data = afe_priv->dai_priv[dai_id];
+
ret = snprintf(prop, sizeof(prop),
"mediatek,%s-chn-disabled",
of_afe_etdms[i].name);
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: mediatek: add missing initialization
2023-03-01 4:08 ` Trevor Wu
@ 2023-03-01 10:00 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 7+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-01 10:00 UTC (permalink / raw)
To: Trevor Wu, broonie, lgirdwood, tiwai, perex, matthias.bgg
Cc: alsa-devel, linux-mediatek, linux-arm-kernel, linux-kernel
Il 01/03/23 05:08, Trevor Wu ha scritto:
> In etdm dai driver, dai_etdm_parse_of() function is used to parse dts
> properties to get parameters. There are two for-loops which are
> sepearately for all etdm and etdm input only cases. In etdm in only
> loop, dai_id is not initialized, so it keeps the value intiliazed in
> another loop.
>
> In the patch, add the missing initialization to fix the unexpected
> parsing problem.
>
> Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
I agree about this fix, but this commit is not fine as it is:
Please split it in two commits and add the appropriate Fixes tag to each
for backports.
Regards,
Angelo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: mediatek: add missing initialization
@ 2023-03-01 10:00 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 7+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-01 10:00 UTC (permalink / raw)
To: Trevor Wu, broonie, lgirdwood, tiwai, perex, matthias.bgg
Cc: alsa-devel, linux-mediatek, linux-arm-kernel, linux-kernel
Il 01/03/23 05:08, Trevor Wu ha scritto:
> In etdm dai driver, dai_etdm_parse_of() function is used to parse dts
> properties to get parameters. There are two for-loops which are
> sepearately for all etdm and etdm input only cases. In etdm in only
> loop, dai_id is not initialized, so it keeps the value intiliazed in
> another loop.
>
> In the patch, add the missing initialization to fix the unexpected
> parsing problem.
>
> Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
I agree about this fix, but this commit is not fine as it is:
Please split it in two commits and add the appropriate Fixes tag to each
for backports.
Regards,
Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: mediatek: add missing initialization
2023-03-01 10:00 ` AngeloGioacchino Del Regno
@ 2023-03-01 10:37 ` Trevor Wu (吳文良)
-1 siblings, 0 replies; 7+ messages in thread
From: Trevor Wu (吳文良) @ 2023-03-01 10:37 UTC (permalink / raw)
To: lgirdwood, matthias.bgg, angelogioacchino.delregno, broonie,
tiwai, perex
Cc: linux-arm-kernel, linux-kernel, linux-mediatek, alsa-devel
On Wed, 2023-03-01 at 11:00 +0100, AngeloGioacchino Del Regno wrote:
> Il 01/03/23 05:08, Trevor Wu ha scritto:
> > In etdm dai driver, dai_etdm_parse_of() function is used to parse
> > dts
> > properties to get parameters. There are two for-loops which are
> > sepearately for all etdm and etdm input only cases. In etdm in only
> > loop, dai_id is not initialized, so it keeps the value intiliazed
> > in
> > another loop.
> >
> > In the patch, add the missing initialization to fix the unexpected
> > parsing problem.
> >
> > Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
>
> I agree about this fix, but this commit is not fine as it is:
> Please split it in two commits and add the appropriate Fixes tag to
> each
> for backports.
>
> Regards,
> Angelo
>
Got it.
I will split it into two commits in V2.
Thanks,
Trevor
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: mediatek: add missing initialization
@ 2023-03-01 10:37 ` Trevor Wu (吳文良)
0 siblings, 0 replies; 7+ messages in thread
From: Trevor Wu (吳文良) @ 2023-03-01 10:37 UTC (permalink / raw)
To: lgirdwood, matthias.bgg, angelogioacchino.delregno, broonie,
tiwai, perex
Cc: linux-arm-kernel, linux-kernel, linux-mediatek, alsa-devel
On Wed, 2023-03-01 at 11:00 +0100, AngeloGioacchino Del Regno wrote:
> Il 01/03/23 05:08, Trevor Wu ha scritto:
> > In etdm dai driver, dai_etdm_parse_of() function is used to parse
> > dts
> > properties to get parameters. There are two for-loops which are
> > sepearately for all etdm and etdm input only cases. In etdm in only
> > loop, dai_id is not initialized, so it keeps the value intiliazed
> > in
> > another loop.
> >
> > In the patch, add the missing initialization to fix the unexpected
> > parsing problem.
> >
> > Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
>
> I agree about this fix, but this commit is not fine as it is:
> Please split it in two commits and add the appropriate Fixes tag to
> each
> for backports.
>
> Regards,
> Angelo
>
Got it.
I will split it into two commits in V2.
Thanks,
Trevor
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-03-01 11:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-01 4:08 [PATCH] ASoC: mediatek: add missing initialization Trevor Wu
2023-03-01 4:08 ` Trevor Wu
2023-03-01 4:08 ` Trevor Wu
2023-03-01 10:00 ` AngeloGioacchino Del Regno
2023-03-01 10:00 ` AngeloGioacchino Del Regno
2023-03-01 10:37 ` Trevor Wu (吳文良)
2023-03-01 10:37 ` Trevor Wu (吳文良)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.