From: Marijn Suijten <marijn.suijten@somainline.org>
To: Jessica Zhang <quic_jesszhan@quicinc.com>
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, robdclark@gmail.com,
seanpaul@chromium.org, swboyd@chromium.org,
dmitry.baryshkov@linaro.org, quic_abhinavk@quicinc.com
Subject: Re: [PATCH v4 2/4] drm/msm: Check for NULL before calling prepare_commit()
Date: Wed, 1 Mar 2023 11:03:56 +0100 [thread overview]
Message-ID: <20230301100356.5udfoy3gyxs4gbi7@SoMainline.org> (raw)
In-Reply-To: <20230221184256.1436-3-quic_jesszhan@quicinc.com>
On 2023-02-21 10:42:54, Jessica Zhang wrote:
> Add a NULL check before calling prepare_commit() in
> msm_atomic_commit_tail()
>
> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> drivers/gpu/drm/msm/msm_atomic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/msm/msm_atomic.c
> index 1686fbb611fd..c8a0a5cc5ca5 100644
> --- a/drivers/gpu/drm/msm/msm_atomic.c
> +++ b/drivers/gpu/drm/msm/msm_atomic.c
> @@ -206,7 +206,8 @@ void msm_atomic_commit_tail(struct drm_atomic_state *state)
> * Now that there is no in-progress flush, prepare the
> * current update:
> */
> - kms->funcs->prepare_commit(kms, state);
> + if (kms->funcs->prepare_commit)
> + kms->funcs->prepare_commit(kms, state);
>
> /*
> * Push atomic updates down to hardware:
> --
> 2.39.2
>
WARNING: multiple messages have this Message-ID (diff)
From: Marijn Suijten <marijn.suijten@somainline.org>
To: Jessica Zhang <quic_jesszhan@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, quic_abhinavk@quicinc.com,
dri-devel@lists.freedesktop.org, swboyd@chromium.org,
seanpaul@chromium.org, dmitry.baryshkov@linaro.org,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH v4 2/4] drm/msm: Check for NULL before calling prepare_commit()
Date: Wed, 1 Mar 2023 11:03:56 +0100 [thread overview]
Message-ID: <20230301100356.5udfoy3gyxs4gbi7@SoMainline.org> (raw)
In-Reply-To: <20230221184256.1436-3-quic_jesszhan@quicinc.com>
On 2023-02-21 10:42:54, Jessica Zhang wrote:
> Add a NULL check before calling prepare_commit() in
> msm_atomic_commit_tail()
>
> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> drivers/gpu/drm/msm/msm_atomic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/msm/msm_atomic.c
> index 1686fbb611fd..c8a0a5cc5ca5 100644
> --- a/drivers/gpu/drm/msm/msm_atomic.c
> +++ b/drivers/gpu/drm/msm/msm_atomic.c
> @@ -206,7 +206,8 @@ void msm_atomic_commit_tail(struct drm_atomic_state *state)
> * Now that there is no in-progress flush, prepare the
> * current update:
> */
> - kms->funcs->prepare_commit(kms, state);
> + if (kms->funcs->prepare_commit)
> + kms->funcs->prepare_commit(kms, state);
>
> /*
> * Push atomic updates down to hardware:
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-03-01 10:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 18:42 [PATCH v4 0/4] Move TE setup to prepare_for_kickoff() Jessica Zhang
2023-02-21 18:42 ` Jessica Zhang
2023-02-21 18:42 ` [PATCH v4 1/4] drm/msm/dpu: " Jessica Zhang
2023-02-21 18:42 ` Jessica Zhang
2023-03-01 3:21 ` Dmitry Baryshkov
2023-03-01 3:21 ` Dmitry Baryshkov
2023-03-01 10:03 ` Marijn Suijten
2023-03-01 10:03 ` Marijn Suijten
2023-03-01 16:23 ` Abhinav Kumar
2023-03-01 16:23 ` Abhinav Kumar
2023-03-01 17:08 ` Marijn Suijten
2023-03-01 17:08 ` Marijn Suijten
2023-03-01 21:42 ` Abhinav Kumar
2023-03-01 21:42 ` Abhinav Kumar
2023-03-04 10:29 ` Marijn Suijten
2023-03-04 10:29 ` Marijn Suijten
2023-03-01 21:46 ` Dmitry Baryshkov
2023-03-01 21:46 ` Dmitry Baryshkov
2023-02-21 18:42 ` [PATCH v4 2/4] drm/msm: Check for NULL before calling prepare_commit() Jessica Zhang
2023-02-21 18:42 ` Jessica Zhang
2023-03-01 10:03 ` Marijn Suijten [this message]
2023-03-01 10:03 ` Marijn Suijten
2023-02-21 18:42 ` [PATCH v4 3/4] drm/msm/dpu: Remove empty prepare_commit() function Jessica Zhang
2023-02-21 18:42 ` Jessica Zhang
2023-03-01 3:22 ` Dmitry Baryshkov
2023-03-01 3:22 ` Dmitry Baryshkov
2023-03-01 10:08 ` Marijn Suijten
2023-03-01 10:08 ` Marijn Suijten
2023-03-01 10:13 ` Marijn Suijten
2023-03-01 10:13 ` Marijn Suijten
2023-03-02 21:25 ` Jessica Zhang
2023-03-02 21:25 ` Jessica Zhang
2023-02-21 18:42 ` [PATCH v4 4/4] drm/msm/mdp4: " Jessica Zhang
2023-02-21 18:42 ` Jessica Zhang
2023-03-01 10:06 ` Marijn Suijten
2023-03-01 10:06 ` Marijn Suijten
2023-03-28 22:37 ` [PATCH v4 0/4] Move TE setup to prepare_for_kickoff() Dmitry Baryshkov
2023-03-28 22:37 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301100356.5udfoy3gyxs4gbi7@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.