From: Henning Schild <henning.schild@siemens.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 1/3] leds: simatic-ipc-leds-gpio: move two extra gpio pins into another table
Date: Thu, 2 Mar 2023 09:33:17 +0100 [thread overview]
Message-ID: <20230302093317.574c87a1@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <Y/+JsTpONdhk/nwG@smile.fi.intel.com>
Am Wed, 1 Mar 2023 19:21:53 +0200
schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> On Wed, Mar 01, 2023 at 06:02:13PM +0100, Henning Schild wrote:
> > There are two special pins needed to init the LEDs. We used to have
> > them at the end of the gpiod_lookup table to give to "leds-gpio". A
> > cleaner way is to have a dedicated table for the special pins.
>
> ...
>
> > + .dev_id = NULL,
>
> Technically speaking this is redundant. Maybe you wanted to be more
> explicit with a comment like
>
> .dev_id = NULL, /* Filled during
> initialization */
>
> ...
>
> > + .dev_id = NULL,
>
> Ditto.
Sorry you already pointed that out earlier, it slipped back in with
the rewrite.
Henning
next prev parent reply other threads:[~2023-03-02 8:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 17:02 [PATCH v2 0/3] leds: simatic-ipc-leds-gpio: split up Henning Schild
2023-03-01 17:02 ` [PATCH v2 1/3] leds: simatic-ipc-leds-gpio: move two extra gpio pins into another table Henning Schild
2023-03-01 17:21 ` Andy Shevchenko
2023-03-02 8:33 ` Henning Schild [this message]
2023-03-01 17:02 ` [PATCH v2 2/3] leds: simatic-ipc-leds-gpio: split up into multiple drivers Henning Schild
2023-03-01 17:28 ` Andy Shevchenko
2023-03-02 8:40 ` Henning Schild
2023-03-02 15:46 ` Andy Shevchenko
2023-03-02 15:58 ` Henning Schild
2023-03-02 16:21 ` Andy Shevchenko
2023-03-02 17:06 ` Henning Schild
2023-05-15 11:14 ` Henning Schild
2023-03-01 17:02 ` [PATCH v2 3/3] leds: simatic-ipc-leds-gpio: introduce more Kconfig switches Henning Schild
2023-03-01 17:29 ` Andy Shevchenko
2023-03-02 8:31 ` Henning Schild
2023-03-01 18:04 ` Hans de Goede
2023-03-02 8:47 ` Henning Schild
2023-03-02 9:02 ` Hans de Goede
2023-03-02 10:14 ` Henning Schild
2023-05-15 10:41 ` Henning Schild
2023-05-15 11:24 ` Hans de Goede
2023-03-01 17:30 ` [PATCH v2 0/3] leds: simatic-ipc-leds-gpio: split up Andy Shevchenko
2023-03-02 10:19 ` Henning Schild
2023-05-13 10:08 ` Henning Schild
2023-05-15 9:50 ` Lee Jones
2023-05-15 10:01 ` Henning Schild
2023-05-15 12:12 ` Lee Jones
2023-05-15 15:06 ` Henning Schild
2023-05-15 15:40 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302093317.574c87a1@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.