[PATCH 0/2] add support for hs bootflows on am62 devices

[PATCH 0/2] add support for hs bootflows on am62 devices

[Kamlesh.Gurudasani.kamlesh]

From: Kamlesh Gurudasani <kamlesh@ti.com>

Add support for high security bootflow on am62 devices.

On HS devices, ROM and TIFS will protect the RAM regions with
firewalls. This means the wakeup domain's SPL will need to move the
stack and heap to HSM RAM to ensure it stays within its allotted
memory regions.

Kamlesh Gurudasani (2):
  arm: mach-k3: am62: move scratch board area to HSM RAM
  configs: am62: move stack and heap to HSM RAM

 arch/arm/mach-k3/include/mach/am62_hardware.h |  3 +--
 configs/am62x_evm_r5_defconfig                | 16 +++++++++++-----
 2 files changed, 12 insertions(+), 7 deletions(-)

-- 
2.34.1

Re: [PATCH 0/2] add support for hs bootflows on am62 devices

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]

On Thu, Mar 16, 2023 at 04:05:06PM +0530, Kamlesh Gurudasani wrote:
> Bryan Brattlof <bb@ti.com> writes:
> 
> > Hi Kamlesh!
> >
> > On March  2, 2023 thus sayeth kamlesh@ti.com:
> >> From: Kamlesh Gurudasani <kamlesh@ti.com>
> >> 
> >> Add support for high security bootflow on am62 devices.
> >> 
> >> On HS devices, ROM and TIFS will protect the RAM regions with
> >> firewalls. This means the wakeup domain's SPL will need to move the
> >> stack and heap to HSM RAM to ensure it stays within its allotted
> >> memory regions.
> >> 
> >> Kamlesh Gurudasani (2):
> >>   arm: mach-k3: am62: move scratch board area to HSM RAM
> >>   configs: am62: move stack and heap to HSM RAM
> >> 
> >>  arch/arm/mach-k3/include/mach/am62_hardware.h |  3 +--
> >>  configs/am62x_evm_r5_defconfig                | 16 +++++++++++-----
> >>  2 files changed, 12 insertions(+), 7 deletions(-)
> >
> > Thanks for getting this fixed! Does TIFS drop the On Chip SRAM firewall 
> > completely once it's started? or only for the r5?
> >
> > Reviewed-by: Bryan Brattlof <bb@ti.com>
> >
> > ~Bryan
> Hi Tom,
> 
> Could you please review and merge this patches as these are bug fixes to
> get HS devices working.

Is this a regression fix vs v2023.01 or new feature support? Thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH 0/2] add support for hs bootflows on am62 devices

[Kamlesh Gurudasani]

Bryan Brattlof <bb@ti.com> writes:

> Hi Kamlesh!
>
> On March  2, 2023 thus sayeth kamlesh@ti.com:
>> From: Kamlesh Gurudasani <kamlesh@ti.com>
>> 
>> Add support for high security bootflow on am62 devices.
>> 
>> On HS devices, ROM and TIFS will protect the RAM regions with
>> firewalls. This means the wakeup domain's SPL will need to move the
>> stack and heap to HSM RAM to ensure it stays within its allotted
>> memory regions.
>> 
>> Kamlesh Gurudasani (2):
>>   arm: mach-k3: am62: move scratch board area to HSM RAM
>>   configs: am62: move stack and heap to HSM RAM
>> 
>>  arch/arm/mach-k3/include/mach/am62_hardware.h |  3 +--
>>  configs/am62x_evm_r5_defconfig                | 16 +++++++++++-----
>>  2 files changed, 12 insertions(+), 7 deletions(-)
>
> Thanks for getting this fixed! Does TIFS drop the On Chip SRAM firewall 
> completely once it's started? or only for the r5?
>
> Reviewed-by: Bryan Brattlof <bb@ti.com>
>
> ~Bryan
Hi Tom,

Could you please review and merge this patches as these are bug fixes to
get HS devices working.

Thanks.

~Kamlesh

Re: [PATCH 0/2] add support for hs bootflows on am62 devices

[Kamlesh Gurudasani]

Bryan Brattlof <bb@ti.com> writes:

> Hi Kamlesh!
>
> On March  2, 2023 thus sayeth kamlesh@ti.com:
>> From: Kamlesh Gurudasani <kamlesh@ti.com>
>> 
>> Add support for high security bootflow on am62 devices.
>> 
>> On HS devices, ROM and TIFS will protect the RAM regions with
>> firewalls. This means the wakeup domain's SPL will need to move the
>> stack and heap to HSM RAM to ensure it stays within its allotted
>> memory regions.
...

>
> Thanks for getting this fixed! Does TIFS drop the On Chip SRAM firewall 
> completely once it's started? or only for the r5?
It is open completely after TIFS drops it.

It is generic RAM, should be available for use to
all cores. Ideally, it should have been opened up by ROM only, then we
wouldn't have run in to this issue. (r5 accessing it before TIFS opens
it up)

Thanks for the review.

> Reviewed-by: Bryan Brattlof <bb@ti.com>
>
> ~Bryan

Re: [PATCH 0/2] add support for hs bootflows on am62 devices

[Bryan Brattlof]

Hi Kamlesh!

On March  2, 2023 thus sayeth kamlesh@ti.com:
> From: Kamlesh Gurudasani <kamlesh@ti.com>
> 
> Add support for high security bootflow on am62 devices.
> 
> On HS devices, ROM and TIFS will protect the RAM regions with
> firewalls. This means the wakeup domain's SPL will need to move the
> stack and heap to HSM RAM to ensure it stays within its allotted
> memory regions.
> 
> Kamlesh Gurudasani (2):
>   arm: mach-k3: am62: move scratch board area to HSM RAM
>   configs: am62: move stack and heap to HSM RAM
> 
>  arch/arm/mach-k3/include/mach/am62_hardware.h |  3 +--
>  configs/am62x_evm_r5_defconfig                | 16 +++++++++++-----
>  2 files changed, 12 insertions(+), 7 deletions(-)

Thanks for getting this fixed! Does TIFS drop the On Chip SRAM firewall 
completely once it's started? or only for the r5?

Reviewed-by: Bryan Brattlof <bb@ti.com>

~Bryan

[PATCH 0/2] add support for hs bootflows on am62 devices

[kamlesh]

From: Kamlesh Gurudasani <kamlesh@ti.com>

Add support for high security bootflow on am62 devices.

On HS devices, ROM and TIFS will protect the RAM regions with
firewalls. This means the wakeup domain's SPL will need to move the
stack and heap to HSM RAM to ensure it stays within its allotted
memory regions.

Kamlesh Gurudasani (2):
  arm: mach-k3: am62: move scratch board area to HSM RAM
  configs: am62: move stack and heap to HSM RAM

 arch/arm/mach-k3/include/mach/am62_hardware.h |  3 +--
 configs/am62x_evm_r5_defconfig                | 16 +++++++++++-----
 2 files changed, 12 insertions(+), 7 deletions(-)

-- 
2.34.1

Re: [PATCH 0/2] add support for hs bootflows on am62 devices

[Kamlesh Gurudasani]

Kamlesh Gurudasani <kamlesh@ti.com> writes:

Please ignore this series on personal id, bouncing back on u-boot@lists.denx.de

Will debug and post on u-boot@lists.denx.de directly.


> Add support for high security bootflow on am62 devices.
>
> On HS devices, ROM and TIFS will protect the RAM regions with
> firewalls. This means the wakeup domain's SPL will need to move the
> stack and heap to HSM RAM to ensure it stays within its allotted
> memory regions.
>
> Kamlesh Gurudasani (2):
>   arm: mach-k3: am62: move scratch board area to HSM RAM
>   configs: am62: move stack and heap to HSM RAM
>
>  arch/arm/mach-k3/include/mach/am62_hardware.h |  3 +--
>  configs/am62x_evm_r5_defconfig                | 16 +++++++++++-----
>  2 files changed, 12 insertions(+), 7 deletions(-)
>
> -- 
> 2.34.1