From: Jonathan Cameron <Jonathan.Cameron@huawei.com> To: <qemu-devel@nongnu.org>, Michael Tsirkin <mst@redhat.com>, Fan Ni <fan.ni@samsung.com> Cc: linux-cxl@vger.kernel.org, linuxarm@huawei.com, "Ira Weiny" <ira.weiny@intel.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Dave Jiang" <dave.jiang@intel.com> Subject: Re: [PATCH v3 5/7] hw/cxl/events: Add injection of General Media Events Date: Thu, 2 Mar 2023 17:42:40 +0000 [thread overview] Message-ID: <20230302174240.00003ed7@huawei.com> (raw) In-Reply-To: <20230227173416.7740-6-Jonathan.Cameron@huawei.com> On Mon, 27 Feb 2023 17:34:14 +0000 Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote: > From: Ira Weiny <ira.weiny@intel.com> > > To facilitate testing provide a QMP command to inject a general media > event. The event can be added to the log specified. > > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > Link: https://lore.kernel.org/r/20221221-ira-cxl-events-2022-11-17-v2-8-2ce2ecc06219@intel.com > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Took another look at this after some review feedback on remaining endian issues. There are some of those + the timestamp in the header is not in device time. I'll fix up for v4. > +static void cxl_assign_event_header(CXLEventRecordHdr *hdr, > + const QemuUUID *uuid, uint8_t flags, > + uint8_t length) > +{ > + hdr->flags[0] = flags; Should be st24_le_p() really and a type big enough to hold a 24 bit > + hdr->length = length; > + memcpy(&hdr->id, uuid, sizeof(hdr->id)); > + hdr->timestamp = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); This isn't the right timestamp and it should be little endian. > +} > + > +/* Component ID is device specific. Define this as a string. */ > +void qmp_cxl_inject_gen_media_event(const char *path, CxlEventLog log, > + uint8_t flags, uint64_t physaddr, > + uint8_t descriptor, uint8_t type, > + uint8_t transaction_type, > + bool has_channel, uint8_t channel, > + bool has_rank, uint8_t rank, > + bool has_device, uint32_t device, > + const char *component_id, > + Error **errp) > +{ > + Object *obj = object_resolve_path(path, NULL); > + CXLEventGenMedia gem; > + CXLEventRecordHdr *hdr = &gem.hdr; > + CXLDeviceState *cxlds; > + CXLType3Dev *ct3d; > + uint16_t valid_flags = 0; > + uint8_t enc_log; > + int rc; > + > + if (!obj) { > + error_setg(errp, "Unable to resolve path"); > + return; > + } > + if (!object_dynamic_cast(obj, TYPE_CXL_TYPE3)) { > + error_setg(errp, "Path does not point to a CXL type 3 device"); > + return; > + } > + ct3d = CXL_TYPE3(obj); > + cxlds = &ct3d->cxl_dstate; > + > + rc = ct3d_qmp_cxl_event_log_enc(log); > + if (rc < 0) { > + error_setg(errp, "Unhandled error log type"); > + return; > + } > + enc_log = rc; > + > + memset(&gem, 0, sizeof(gem)); > + cxl_assign_event_header(hdr, &gen_media_uuid, flags, sizeof(gem)); > + > + gem.phys_addr = physaddr; This was the one that was pointed out off list. Thanks! > + gem.descriptor = descriptor; > + gem.type = type; > + gem.transaction_type = transaction_type;
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron via <qemu-devel@nongnu.org> To: <qemu-devel@nongnu.org>, Michael Tsirkin <mst@redhat.com>, Fan Ni <fan.ni@samsung.com> Cc: linux-cxl@vger.kernel.org, linuxarm@huawei.com, "Ira Weiny" <ira.weiny@intel.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Dave Jiang" <dave.jiang@intel.com> Subject: Re: [PATCH v3 5/7] hw/cxl/events: Add injection of General Media Events Date: Thu, 2 Mar 2023 17:42:40 +0000 [thread overview] Message-ID: <20230302174240.00003ed7@huawei.com> (raw) In-Reply-To: <20230227173416.7740-6-Jonathan.Cameron@huawei.com> On Mon, 27 Feb 2023 17:34:14 +0000 Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote: > From: Ira Weiny <ira.weiny@intel.com> > > To facilitate testing provide a QMP command to inject a general media > event. The event can be added to the log specified. > > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > Link: https://lore.kernel.org/r/20221221-ira-cxl-events-2022-11-17-v2-8-2ce2ecc06219@intel.com > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Took another look at this after some review feedback on remaining endian issues. There are some of those + the timestamp in the header is not in device time. I'll fix up for v4. > +static void cxl_assign_event_header(CXLEventRecordHdr *hdr, > + const QemuUUID *uuid, uint8_t flags, > + uint8_t length) > +{ > + hdr->flags[0] = flags; Should be st24_le_p() really and a type big enough to hold a 24 bit > + hdr->length = length; > + memcpy(&hdr->id, uuid, sizeof(hdr->id)); > + hdr->timestamp = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); This isn't the right timestamp and it should be little endian. > +} > + > +/* Component ID is device specific. Define this as a string. */ > +void qmp_cxl_inject_gen_media_event(const char *path, CxlEventLog log, > + uint8_t flags, uint64_t physaddr, > + uint8_t descriptor, uint8_t type, > + uint8_t transaction_type, > + bool has_channel, uint8_t channel, > + bool has_rank, uint8_t rank, > + bool has_device, uint32_t device, > + const char *component_id, > + Error **errp) > +{ > + Object *obj = object_resolve_path(path, NULL); > + CXLEventGenMedia gem; > + CXLEventRecordHdr *hdr = &gem.hdr; > + CXLDeviceState *cxlds; > + CXLType3Dev *ct3d; > + uint16_t valid_flags = 0; > + uint8_t enc_log; > + int rc; > + > + if (!obj) { > + error_setg(errp, "Unable to resolve path"); > + return; > + } > + if (!object_dynamic_cast(obj, TYPE_CXL_TYPE3)) { > + error_setg(errp, "Path does not point to a CXL type 3 device"); > + return; > + } > + ct3d = CXL_TYPE3(obj); > + cxlds = &ct3d->cxl_dstate; > + > + rc = ct3d_qmp_cxl_event_log_enc(log); > + if (rc < 0) { > + error_setg(errp, "Unhandled error log type"); > + return; > + } > + enc_log = rc; > + > + memset(&gem, 0, sizeof(gem)); > + cxl_assign_event_header(hdr, &gen_media_uuid, flags, sizeof(gem)); > + > + gem.phys_addr = physaddr; This was the one that was pointed out off list. Thanks! > + gem.descriptor = descriptor; > + gem.type = type; > + gem.transaction_type = transaction_type;
next prev parent reply other threads:[~2023-03-02 17:42 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-27 17:34 [PATCH v3 0/7] QEMU CXL Provide mock CXL events and irq support Jonathan Cameron 2023-02-27 17:34 ` Jonathan Cameron via 2023-02-27 17:34 ` [PATCH v3 1/7] hw/cxl/events: Add event status register Jonathan Cameron 2023-02-27 17:34 ` Jonathan Cameron via 2023-02-27 17:34 ` [PATCH v3 2/7] hw/cxl: Move CXLRetCode definition to cxl_device.h Jonathan Cameron 2023-02-27 17:34 ` Jonathan Cameron via 2023-02-27 17:34 ` [PATCH v3 3/7] hw/cxl/events: Wire up get/clear event mailbox commands Jonathan Cameron 2023-02-27 17:34 ` Jonathan Cameron via 2023-02-27 17:34 ` [PATCH v3 4/7] hw/cxl/events: Add event interrupt support Jonathan Cameron 2023-02-27 17:34 ` Jonathan Cameron via 2023-02-27 17:34 ` [PATCH v3 5/7] hw/cxl/events: Add injection of General Media Events Jonathan Cameron 2023-02-27 17:34 ` Jonathan Cameron via 2023-03-02 17:42 ` Jonathan Cameron [this message] 2023-03-02 17:42 ` Jonathan Cameron via 2023-02-27 17:34 ` [PATCH v3 6/7] hw/cxl/events: Add injection of DRAM events Jonathan Cameron via 2023-02-27 17:34 ` Jonathan Cameron 2023-03-02 6:38 ` Ira Weiny 2023-03-03 11:46 ` Jonathan Cameron 2023-03-03 11:46 ` Jonathan Cameron via 2023-02-27 17:34 ` [PATCH v3 7/7] hw/cxl/events: Add injection of Memory Module Events Jonathan Cameron via 2023-02-27 17:34 ` Jonathan Cameron 2023-03-02 6:44 ` Ira Weiny
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230302174240.00003ed7@huawei.com \ --to=jonathan.cameron@huawei.com \ --cc=dave.jiang@intel.com \ --cc=fan.ni@samsung.com \ --cc=ira.weiny@intel.com \ --cc=linux-cxl@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=mst@redhat.com \ --cc=philmd@linaro.org \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.