All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <ajones@ventanamicro.com>
To: JeeHeng Sia <jeeheng.sia@starfivetech.com>
Cc: "paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
	"palmer@dabbelt.com" <palmer@dabbelt.com>,
	"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Leyfoon Tan <leyfoon.tan@starfivetech.com>,
	Mason Huo <mason.huo@starfivetech.com>
Subject: Re: [PATCH v4 4/4] RISC-V: Add arch functions to support hibernation/suspend-to-disk
Date: Fri, 3 Mar 2023 09:09:10 +0100	[thread overview]
Message-ID: <20230303080910.hfipcsrgyvppa6ex@orel> (raw)
In-Reply-To: <94325d78a0b74d8289b77ec743840941@EXMBX066.cuchost.com>

On Fri, Mar 03, 2023 at 01:53:19AM +0000, JeeHeng Sia wrote:
> Hi Andrew,
> 
> 
> > -----Original Message-----
> > From: Andrew Jones <ajones@ventanamicro.com>
...
> > I'm not sure why you don't just write a paragraph or two here in this
> > email thread explaining what "the answer" is. Anyway, feel free to
> > invite me to a call if you think it'd be easier to hash out that way.
> Thank you very much to free up time to join the call. It was very nice to talk to you over the conference call and I did learn a lot from you.
> Below is the summary of the experiment that benefit everyone:
> To avoid inspecting a huge log, the experiment was carried out on the Qemu with 512MB of memory (128000 pages). 
> During hibernation, there are 22770 pages (out of 128000 pages) were identified need to be stored to the disk. Those pages consists of the kernel text code, rodata, page table, stack/heap/kmalloc/vmalloc memory, user space app, rootfs.....etc. The number of pages need to be stored to the disk are depends on the "workload" on the system.
> When resume, only 21651 pages were assigned to the restore_pblist. The rest of the pages consists of meta_data pages and forbidden pages which were handled by the "resume kernel". Arch code will handle the pages assigned to the restore_pblist.
> From the experiment, we also know that the game that is activated before hibernation is still "alive" after resume from hibernation and can continue to play without problem.
>

Thank you, Jee Heng. Indeed it looks like the majority of the pages that
are selected for the suspend image end up on the PBE list. While we don't
have definitive "this page must be on the PBE list" type of result, I
agree that we shouldn't need to worry about the PBE list ever being empty.

Thanks,
drew

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <ajones@ventanamicro.com>
To: JeeHeng Sia <jeeheng.sia@starfivetech.com>
Cc: "paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
	"palmer@dabbelt.com" <palmer@dabbelt.com>,
	"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Leyfoon Tan <leyfoon.tan@starfivetech.com>,
	Mason Huo <mason.huo@starfivetech.com>
Subject: Re: [PATCH v4 4/4] RISC-V: Add arch functions to support hibernation/suspend-to-disk
Date: Fri, 3 Mar 2023 09:09:10 +0100	[thread overview]
Message-ID: <20230303080910.hfipcsrgyvppa6ex@orel> (raw)
In-Reply-To: <94325d78a0b74d8289b77ec743840941@EXMBX066.cuchost.com>

On Fri, Mar 03, 2023 at 01:53:19AM +0000, JeeHeng Sia wrote:
> Hi Andrew,
> 
> 
> > -----Original Message-----
> > From: Andrew Jones <ajones@ventanamicro.com>
...
> > I'm not sure why you don't just write a paragraph or two here in this
> > email thread explaining what "the answer" is. Anyway, feel free to
> > invite me to a call if you think it'd be easier to hash out that way.
> Thank you very much to free up time to join the call. It was very nice to talk to you over the conference call and I did learn a lot from you.
> Below is the summary of the experiment that benefit everyone:
> To avoid inspecting a huge log, the experiment was carried out on the Qemu with 512MB of memory (128000 pages). 
> During hibernation, there are 22770 pages (out of 128000 pages) were identified need to be stored to the disk. Those pages consists of the kernel text code, rodata, page table, stack/heap/kmalloc/vmalloc memory, user space app, rootfs.....etc. The number of pages need to be stored to the disk are depends on the "workload" on the system.
> When resume, only 21651 pages were assigned to the restore_pblist. The rest of the pages consists of meta_data pages and forbidden pages which were handled by the "resume kernel". Arch code will handle the pages assigned to the restore_pblist.
> From the experiment, we also know that the game that is activated before hibernation is still "alive" after resume from hibernation and can continue to play without problem.
>

Thank you, Jee Heng. Indeed it looks like the majority of the pages that
are selected for the suspend image end up on the PBE list. While we don't
have definitive "this page must be on the PBE list" type of result, I
agree that we shouldn't need to worry about the PBE list ever being empty.

Thanks,
drew

  reply	other threads:[~2023-03-03  8:09 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21  2:35 [PATCH v4 0/4] RISC-V Hibernation Support Sia Jee Heng
2023-02-21  2:35 ` Sia Jee Heng
2023-02-21  2:35 ` [PATCH v4 1/4] RISC-V: Change suspend_save_csrs and suspend_restore_csrs to public function Sia Jee Heng
2023-02-21  2:35   ` Sia Jee Heng
2023-02-23  6:39   ` Andrew Jones
2023-02-23  6:39     ` Andrew Jones
2023-02-24  1:33     ` JeeHeng Sia
2023-02-24  1:33       ` JeeHeng Sia
2023-02-21  2:35 ` [PATCH v4 2/4] RISC-V: Factor out common code of __cpu_resume_enter() Sia Jee Heng
2023-02-21  2:35   ` Sia Jee Heng
2023-02-23  6:51   ` Andrew Jones
2023-02-23  6:51     ` Andrew Jones
2023-02-24  1:33     ` JeeHeng Sia
2023-02-24  1:33       ` JeeHeng Sia
2023-02-24 10:19   ` Alexandre Ghiti
2023-02-24 10:19     ` Alexandre Ghiti
2023-02-27  2:21     ` JeeHeng Sia
2023-02-27  2:21       ` JeeHeng Sia
2023-02-21  2:35 ` [PATCH v4 3/4] RISC-V: mm: Enable huge page support to kernel_page_present() function Sia Jee Heng
2023-02-21  2:35   ` Sia Jee Heng
2023-02-23  6:57   ` Andrew Jones
2023-02-23  6:57     ` Andrew Jones
2023-02-24  1:33     ` JeeHeng Sia
2023-02-24  1:33       ` JeeHeng Sia
2023-02-24 10:21   ` Alexandre Ghiti
2023-02-24 10:21     ` Alexandre Ghiti
2023-02-21  2:35 ` [PATCH v4 4/4] RISC-V: Add arch functions to support hibernation/suspend-to-disk Sia Jee Heng
2023-02-21  2:35   ` Sia Jee Heng
2023-02-23 18:07   ` Andrew Jones
2023-02-23 18:07     ` Andrew Jones
2023-02-24  2:05     ` JeeHeng Sia
2023-02-24  2:05       ` JeeHeng Sia
2023-02-24  9:00       ` Andrew Jones
2023-02-24  9:00         ` Andrew Jones
2023-02-24  9:33         ` JeeHeng Sia
2023-02-24  9:33           ` JeeHeng Sia
2023-02-24  9:55           ` Andrew Jones
2023-02-24  9:55             ` Andrew Jones
2023-02-24 10:30             ` JeeHeng Sia
2023-02-24 10:30               ` JeeHeng Sia
2023-02-24 12:07               ` Andrew Jones
2023-02-24 12:07                 ` Andrew Jones
2023-02-27  2:14                 ` JeeHeng Sia
2023-02-27  2:14                   ` JeeHeng Sia
2023-02-27  7:59                   ` Andrew Jones
2023-02-27  7:59                     ` Andrew Jones
2023-02-27 10:52                     ` JeeHeng Sia
2023-02-27 10:52                       ` JeeHeng Sia
2023-02-27 11:44                       ` Andrew Jones
2023-02-27 11:44                         ` Andrew Jones
2023-02-28  1:32                         ` JeeHeng Sia
2023-02-28  1:32                           ` JeeHeng Sia
2023-02-28  5:04                           ` Andrew Jones
2023-02-28  5:04                             ` Andrew Jones
2023-02-28  5:33                             ` JeeHeng Sia
2023-02-28  5:33                               ` JeeHeng Sia
2023-02-28  7:18                               ` Andrew Jones
2023-02-28  7:18                                 ` Andrew Jones
2023-02-28  7:29                                 ` JeeHeng Sia
2023-02-28  7:29                                   ` JeeHeng Sia
2023-02-28  7:37                                   ` Andrew Jones
2023-02-28  7:37                                     ` Andrew Jones
2023-03-03  1:53                                     ` JeeHeng Sia
2023-03-03  1:53                                       ` JeeHeng Sia
2023-03-03  8:09                                       ` Andrew Jones [this message]
2023-03-03  8:09                                         ` Andrew Jones
2023-02-28  6:33                             ` JeeHeng Sia
2023-02-28  6:33                               ` JeeHeng Sia
2023-02-28  7:29                               ` Andrew Jones
2023-02-28  7:29                                 ` Andrew Jones
2023-02-28  7:34                                 ` JeeHeng Sia
2023-02-28  7:34                                   ` JeeHeng Sia
2023-02-24  2:12   ` JeeHeng Sia
2023-02-24  2:12     ` JeeHeng Sia
2023-02-24 12:29   ` Alexandre Ghiti
2023-02-24 12:29     ` Alexandre Ghiti
2023-02-27  3:11     ` JeeHeng Sia
2023-02-27  3:11       ` JeeHeng Sia
2023-02-27 20:31       ` Alexandre Ghiti
2023-02-27 20:31         ` Alexandre Ghiti
2023-02-28  1:20         ` JeeHeng Sia
2023-02-28  1:20           ` JeeHeng Sia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230303080910.hfipcsrgyvppa6ex@orel \
    --to=ajones@ventanamicro.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=jeeheng.sia@starfivetech.com \
    --cc=leyfoon.tan@starfivetech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mason.huo@starfivetech.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.