All of lore.kernel.org
 help / color / mirror / Atom feed
* [jfern:staging 8/8] kernel/rcu/update.c:266 rcu_end_inkernel_boot() warn: inconsistent returns '&rcu_boot_end_lock'.
@ 2023-03-04 22:56 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-03-04 22:56 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: "Joel Fernandes (Google)" <joel@joelfernandes.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git staging
head:   e6d2024fa329f41ffba24f06090ea57e3b0041ed
commit: e6d2024fa329f41ffba24f06090ea57e3b0041ed [8/8] rcu: Add a minimum time for marking boot as completed
:::::: branch date: 25 hours ago
:::::: commit date: 25 hours ago
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20230305/202303050636.Qhxwao0u-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202303050636.Qhxwao0u-lkp@intel.com/

smatch warnings:
kernel/rcu/update.c:266 rcu_end_inkernel_boot() warn: inconsistent returns '&rcu_boot_end_lock'.

vim +266 kernel/rcu/update.c

e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  241) 
ee42571f4381f1 Paul E. McKenney        2015-02-19  242  void rcu_end_inkernel_boot(void)
ee42571f4381f1 Paul E. McKenney        2015-02-19  243  {
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  244) 	mutex_lock(&rcu_boot_end_lock);
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  245) 	rcu_boot_end_called = true;
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  246) 
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  247) 	if (rcu_boot_ended)
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  248) 		return;
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  249) 
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  250) 	if (rcu_boot_end_delay) {
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  251) 		u64 boot_ms = div_u64(ktime_get_boot_fast_ns(), 1000000UL);
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  252) 
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  253) 		if (boot_ms < rcu_boot_end_delay) {
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  254) 			schedule_delayed_work(&rcu_boot_end_work,
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  255) 					rcu_boot_end_delay - boot_ms);
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  256) 			mutex_unlock(&rcu_boot_end_lock);
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  257) 			return;
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  258) 		}
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  259) 	}
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  260) 
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  261) 	cancel_delayed_work(&rcu_boot_end_work);
ee42571f4381f1 Paul E. McKenney        2015-02-19  262  	rcu_unexpedite_gp();
3e42ec1aa716f1 Paul E. McKenney        2015-11-25  263  	if (rcu_normal_after_boot)
3e42ec1aa716f1 Paul E. McKenney        2015-11-25  264  		WRITE_ONCE(rcu_normal, 1);
e40bb921119814 Jules Irenge            2020-06-01  265  	rcu_boot_ended = true;
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25 @266) 	mutex_unlock(&rcu_boot_end_lock);
ee42571f4381f1 Paul E. McKenney        2015-02-19  267  }
0d39482c3db13a Paul E. McKenney        2015-02-18  268  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [jfern:staging 8/8] kernel/rcu/update.c:266 rcu_end_inkernel_boot() warn: inconsistent returns '&rcu_boot_end_lock'.
@ 2023-03-05  8:04 Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2023-03-05  8:04 UTC (permalink / raw)
  To: oe-kbuild, Joel Fernandes (Google); +Cc: lkp, oe-kbuild-all

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git staging
head:   e6d2024fa329f41ffba24f06090ea57e3b0041ed
commit: e6d2024fa329f41ffba24f06090ea57e3b0041ed [8/8] rcu: Add a minimum time for marking boot as completed
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20230305/202303050636.Qhxwao0u-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202303050636.Qhxwao0u-lkp@intel.com/

smatch warnings:
kernel/rcu/update.c:266 rcu_end_inkernel_boot() warn: inconsistent returns '&rcu_boot_end_lock'.

vim +266 kernel/rcu/update.c

ee42571f4381f1 Paul E. McKenney        2015-02-19  242  void rcu_end_inkernel_boot(void)
ee42571f4381f1 Paul E. McKenney        2015-02-19  243  {
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  244) 	mutex_lock(&rcu_boot_end_lock);
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  245) 	rcu_boot_end_called = true;
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  246) 
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  247) 	if (rcu_boot_ended)
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  248) 		return;

mutex_unlock(&rcu_boot_end_lock);?

e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  249) 
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  250) 	if (rcu_boot_end_delay) {
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  251) 		u64 boot_ms = div_u64(ktime_get_boot_fast_ns(), 1000000UL);
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  252) 
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  253) 		if (boot_ms < rcu_boot_end_delay) {
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  254) 			schedule_delayed_work(&rcu_boot_end_work,
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  255) 					rcu_boot_end_delay - boot_ms);
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  256) 			mutex_unlock(&rcu_boot_end_lock);
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  257) 			return;
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  258) 		}
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  259) 	}
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  260) 
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25  261) 	cancel_delayed_work(&rcu_boot_end_work);
ee42571f4381f1 Paul E. McKenney        2015-02-19  262  	rcu_unexpedite_gp();
3e42ec1aa716f1 Paul E. McKenney        2015-11-25  263  	if (rcu_normal_after_boot)
3e42ec1aa716f1 Paul E. McKenney        2015-11-25  264  		WRITE_ONCE(rcu_normal, 1);
e40bb921119814 Jules Irenge            2020-06-01  265  	rcu_boot_ended = true;
e6d2024fa329f4 Joel Fernandes (Google  2023-02-25 @266) 	mutex_unlock(&rcu_boot_end_lock);
ee42571f4381f1 Paul E. McKenney        2015-02-19  267  }

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-06  8:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-04 22:56 [jfern:staging 8/8] kernel/rcu/update.c:266 rcu_end_inkernel_boot() warn: inconsistent returns '&rcu_boot_end_lock' kernel test robot
2023-03-05  8:04 Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.