From: Christoph Hellwig <hch@lst.de> To: Andrew Morton <akpm@linux-foundation.org>, Matthew Wilcox <willy@infradead.org>, Hugh Dickins <hughd@google.com> Cc: linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: [PATCH 3/7] mm: use filemap_get_entry in filemap_get_incore_folio Date: Tue, 7 Mar 2023 15:34:06 +0100 [thread overview] Message-ID: <20230307143410.28031-4-hch@lst.de> (raw) In-Reply-To: <20230307143410.28031-1-hch@lst.de> filemap_get_incore_folio wants to look at the details of xa_is_value entries, but doesn't need any of the other logic in filemap_get_folio. Switch it to use the lower-level filemap_get_entry interface. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- mm/swap_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/swap_state.c b/mm/swap_state.c index 7a003d8abb37bc..92234f4b51d29a 100644 --- a/mm/swap_state.c +++ b/mm/swap_state.c @@ -386,7 +386,7 @@ struct folio *filemap_get_incore_folio(struct address_space *mapping, { swp_entry_t swp; struct swap_info_struct *si; - struct folio *folio = __filemap_get_folio(mapping, index, FGP_ENTRY, 0); + struct folio *folio = filemap_get_entry(mapping, index); if (!xa_is_value(folio)) goto out; -- 2.39.1
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: cluster-devel.redhat.com Subject: [Cluster-devel] [PATCH 3/7] mm: use filemap_get_entry in filemap_get_incore_folio Date: Tue, 7 Mar 2023 15:34:06 +0100 [thread overview] Message-ID: <20230307143410.28031-4-hch@lst.de> (raw) In-Reply-To: <20230307143410.28031-1-hch@lst.de> filemap_get_incore_folio wants to look at the details of xa_is_value entries, but doesn't need any of the other logic in filemap_get_folio. Switch it to use the lower-level filemap_get_entry interface. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- mm/swap_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/swap_state.c b/mm/swap_state.c index 7a003d8abb37bc..92234f4b51d29a 100644 --- a/mm/swap_state.c +++ b/mm/swap_state.c @@ -386,7 +386,7 @@ struct folio *filemap_get_incore_folio(struct address_space *mapping, { swp_entry_t swp; struct swap_info_struct *si; - struct folio *folio = __filemap_get_folio(mapping, index, FGP_ENTRY, 0); + struct folio *folio = filemap_get_entry(mapping, index); if (!xa_is_value(folio)) goto out; -- 2.39.1
next prev parent reply other threads:[~2023-03-07 14:39 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-07 14:34 return an ERR_PTR from __filemap_get_folio v3 Christoph Hellwig 2023-03-07 14:34 ` Christoph Hellwig 2023-03-07 14:34 ` [Cluster-devel] " Christoph Hellwig 2023-03-07 14:34 ` [PATCH 1/7] mm: don't look at xarray value entries in split_huge_pages_in_file Christoph Hellwig 2023-03-07 14:34 ` Christoph Hellwig 2023-03-07 14:34 ` [Cluster-devel] " Christoph Hellwig 2023-03-07 14:34 ` [PATCH 2/7] mm: make mapping_get_entry available outside of filemap.c Christoph Hellwig 2023-03-07 14:34 ` Christoph Hellwig 2023-03-07 14:34 ` [Cluster-devel] " Christoph Hellwig 2023-03-07 14:34 ` Christoph Hellwig [this message] 2023-03-07 14:34 ` [Cluster-devel] [PATCH 3/7] mm: use filemap_get_entry in filemap_get_incore_folio Christoph Hellwig 2023-03-07 14:34 ` [PATCH 4/7] shmem: remove shmem_get_partial_folio Christoph Hellwig 2023-03-07 14:34 ` [Cluster-devel] " Christoph Hellwig 2023-03-20 5:19 ` Hugh Dickins 2023-03-20 5:19 ` [Cluster-devel] " Hugh Dickins 2023-03-20 13:58 ` Christoph Hellwig 2023-03-20 13:58 ` Christoph Hellwig 2023-03-20 13:58 ` [Cluster-devel] " Christoph Hellwig 2023-03-07 14:34 ` [PATCH 5/7] shmem: open code the page cache lookup in shmem_get_folio_gfp Christoph Hellwig 2023-03-07 14:34 ` [Cluster-devel] " Christoph Hellwig 2023-03-20 5:23 ` Hugh Dickins 2023-03-20 5:23 ` Hugh Dickins 2023-03-20 5:23 ` [Cluster-devel] " Hugh Dickins 2023-03-07 14:34 ` [PATCH 6/7] mm: remove FGP_ENTRY Christoph Hellwig 2023-03-07 14:34 ` Christoph Hellwig 2023-03-07 14:34 ` [Cluster-devel] " Christoph Hellwig 2023-03-07 14:34 ` [PATCH 7/7] mm: return an ERR_PTR from __filemap_get_folio Christoph Hellwig 2023-03-07 14:34 ` [Cluster-devel] " Christoph Hellwig 2023-03-07 15:23 ` [Cluster-devel] return an ERR_PTR from __filemap_get_folio v3 Andreas Gruenbacher 2023-03-07 15:23 ` Andreas Gruenbacher 2023-03-07 15:23 ` [Cluster-devel] " Andreas Gruenbacher -- strict thread matches above, loose matches on Subject: below -- 2023-01-21 6:57 return an ERR_PTR from __filemap_get_folio v2 Christoph Hellwig 2023-01-21 6:57 ` [PATCH 3/7] mm: use filemap_get_entry in filemap_get_incore_folio Christoph Hellwig 2023-01-21 6:57 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230307143410.28031-4-hch@lst.de \ --to=hch@lst.de \ --cc=akpm@linux-foundation.org \ --cc=cluster-devel@redhat.com \ --cc=hughd@google.com \ --cc=linux-afs@lists.infradead.org \ --cc=linux-btrfs@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-nilfs@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.