All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v6 5/6] ksm: add zero_pages_sharing documentation
@ 2023-02-10  1:20 yang.yang29
  2023-03-07 18:51 ` Claudio Imbrenda
  0 siblings, 1 reply; 2+ messages in thread
From: yang.yang29 @ 2023-02-10  1:20 UTC (permalink / raw)
  To: akpm
  Cc: david, imbrenda, jiang.xuexin, linux-kernel, linux-mm,
	ran.xiaokai, xu.xin.sc, xu.xin16, yang.yang29

From: xu xin <xu.xin16@zte.com.cn>

When enabling use_zero_pages, pages_sharing cannot represent how
much memory saved indeed. zero_pages_sharing + pages_sharing does.
add the description of zero_pages_sharing.

Cc: Xiaokai Ran <ran.xiaokai@zte.com.cn>
Cc: Yang Yang <yang.yang29@zte.com.cn>
Cc: Jiang Xuexin <jiang.xuexin@zte.com.cn>
Cc: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: David Hildenbrand <david@redhat.com>
Signed-off-by: xu xin <xu.xin16@zte.com.cn>
---
 Documentation/admin-guide/mm/ksm.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst
index fb6ba2002a4b..f160f9487a90 100644
--- a/Documentation/admin-guide/mm/ksm.rst
+++ b/Documentation/admin-guide/mm/ksm.rst
@@ -173,6 +173,13 @@ stable_node_chains
         the number of KSM pages that hit the ``max_page_sharing`` limit
 stable_node_dups
         number of duplicated KSM pages
+zero_pages_sharing
+        how many empty pages are sharing kernel zero page(s) instead of
+        with each other as it would happen normally. Only effective when
+        enabling ``use_zero_pages`` knob.
+
+When enabling ``use_zero_pages``, the sum of ``pages_sharing`` +
+``zero_pages_sharing`` represents how much really saved by KSM.

 A high ratio of ``pages_sharing`` to ``pages_shared`` indicates good
 sharing, but a high ratio of ``pages_unshared`` to ``pages_sharing``
-- 
2.15.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v6 5/6] ksm: add zero_pages_sharing documentation
  2023-02-10  1:20 [PATCH v6 5/6] ksm: add zero_pages_sharing documentation yang.yang29
@ 2023-03-07 18:51 ` Claudio Imbrenda
  0 siblings, 0 replies; 2+ messages in thread
From: Claudio Imbrenda @ 2023-03-07 18:51 UTC (permalink / raw)
  To: yang.yang29
  Cc: akpm, david, jiang.xuexin, linux-kernel, linux-mm, ran.xiaokai,
	xu.xin.sc, xu.xin16

On Fri, 10 Feb 2023 09:20:42 +0800 (CST)
<yang.yang29@zte.com.cn> wrote:

> From: xu xin <xu.xin16@zte.com.cn>
> 
> When enabling use_zero_pages, pages_sharing cannot represent how
> much memory saved indeed. zero_pages_sharing + pages_sharing does.
> add the description of zero_pages_sharing.
> 
> Cc: Xiaokai Ran <ran.xiaokai@zte.com.cn>
> Cc: Yang Yang <yang.yang29@zte.com.cn>
> Cc: Jiang Xuexin <jiang.xuexin@zte.com.cn>
> Cc: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Cc: David Hildenbrand <david@redhat.com>
> Signed-off-by: xu xin <xu.xin16@zte.com.cn>
> ---
>  Documentation/admin-guide/mm/ksm.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst
> index fb6ba2002a4b..f160f9487a90 100644
> --- a/Documentation/admin-guide/mm/ksm.rst
> +++ b/Documentation/admin-guide/mm/ksm.rst
> @@ -173,6 +173,13 @@ stable_node_chains
>          the number of KSM pages that hit the ``max_page_sharing`` limit
>  stable_node_dups
>          number of duplicated KSM pages
> +zero_pages_sharing
> +        how many empty pages are sharing kernel zero page(s) instead of

how many empty pages are sharing the kernel zero page(s) instead of
other user pages as it would happen normally. Only meaningful when
``use_zero_pages`` is enabled.

> +        with each other as it would happen normally. Only effective when
> +        enabling ``use_zero_pages`` knob.
> +
> +When enabling ``use_zero_pages``, the sum of ``pages_sharing`` +

When ``use_zero_pages`` is enabled, the sum of ``pages_sharing`` +

> +``zero_pages_sharing`` represents how much really saved by KSM.

``zero_pages_sharing`` represents the actual number of pages saved
by KSM.

> 
>  A high ratio of ``pages_sharing`` to ``pages_shared`` indicates good
>  sharing, but a high ratio of ``pages_unshared`` to ``pages_sharing``


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-07 19:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-10  1:20 [PATCH v6 5/6] ksm: add zero_pages_sharing documentation yang.yang29
2023-03-07 18:51 ` Claudio Imbrenda

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.