All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] landlock.7: ffix
@ 2023-03-08  8:56 Tom Schwindl
  2023-03-08 19:48 ` Alejandro Colomar
  0 siblings, 1 reply; 2+ messages in thread
From: Tom Schwindl @ 2023-03-08  8:56 UTC (permalink / raw)
  To: alx; +Cc: linux-man

Signed-off-by: Tom Schwindl <schwindl@posteo.de>
---
 man7/landlock.7 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/man7/landlock.7 b/man7/landlock.7
index b2bc9e10b0c0..bbe00d4c2793 100644
--- a/man7/landlock.7
+++ b/man7/landlock.7
@@ -245,7 +245,7 @@ attr.handled_access_fs =
         LANDLOCK_ACCESS_FS_MAKE_SYM;
 
 ruleset_fd = landlock_create_ruleset(&attr, sizeof(attr), 0);
-if (ruleset_fd == -1) {
+if (ruleset_fd == \-1) {
     perror("Failed to create a ruleset");
     exit(EXIT_FAILURE);
 }
@@ -276,7 +276,7 @@ path_beneath.allowed_access =
         LANDLOCK_ACCESS_FS_READ_DIR;
 
 path_beneath.parent_fd = open("/usr", O_PATH | O_CLOEXEC);
-if (path_beneath.parent_fd == -1) {
+if (path_beneath.parent_fd == \-1) {
     perror("Failed to open file");
     close(ruleset_fd);
     exit(EXIT_FAILURE);
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] landlock.7: ffix
  2023-03-08  8:56 [PATCH] landlock.7: ffix Tom Schwindl
@ 2023-03-08 19:48 ` Alejandro Colomar
  0 siblings, 0 replies; 2+ messages in thread
From: Alejandro Colomar @ 2023-03-08 19:48 UTC (permalink / raw)
  To: Tom Schwindl, alx; +Cc: linux-man


[-- Attachment #1.1: Type: text/plain, Size: 1641 bytes --]

Hi Tom,

On 3/8/23 09:56, Tom Schwindl wrote:
> Signed-off-by: Tom Schwindl <schwindl@posteo.de>
> ---
>  man7/landlock.7 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/man7/landlock.7 b/man7/landlock.7
> index b2bc9e10b0c0..bbe00d4c2793 100644
> --- a/man7/landlock.7
> +++ b/man7/landlock.7
> @@ -245,7 +245,7 @@ attr.handled_access_fs =
>          LANDLOCK_ACCESS_FS_MAKE_SYM;
>  
>  ruleset_fd = landlock_create_ruleset(&attr, sizeof(attr), 0);
> -if (ruleset_fd == -1) {
> +if (ruleset_fd == \-1) {
>      perror("Failed to create a ruleset");
>      exit(EXIT_FAILURE);
>  }
> @@ -276,7 +276,7 @@ path_beneath.allowed_access =
>          LANDLOCK_ACCESS_FS_READ_DIR;
>  
>  path_beneath.parent_fd = open("/usr", O_PATH | O_CLOEXEC);
> -if (path_beneath.parent_fd == -1) {
> +if (path_beneath.parent_fd == \-1) {
>      perror("Failed to open file");
>      close(ruleset_fd);
>      exit(EXIT_FAILURE);

Thanks for the patch!  Now that you're at it, would you mind fixing
a few other cases in printf.h.3head in the same patch?  I see the
following:

$ grep -rn '^[^.].* -1' man*
man3head/printf.h.3head:291:    if (register_printf_specifier(\[aq]b\[aq], b_printf, b_arginf_sz) == -1)
man3head/printf.h.3head:293:    if (register_printf_specifier(\[aq]B\[aq], b_printf, b_arginf_sz) == -1)
man3head/printf.h.3head:413:        return -1;
man7/landlock.7:248:if (ruleset_fd == -1) {
man7/landlock.7:279:if (path_beneath.parent_fd == -1) {


Cheers,

Alex

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-08 19:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-08  8:56 [PATCH] landlock.7: ffix Tom Schwindl
2023-03-08 19:48 ` Alejandro Colomar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.