From: Yi Liu <yi.l.liu@intel.com> To: alex.williamson@redhat.com, jgg@nvidia.com, kevin.tian@intel.com Cc: linux-s390@vger.kernel.org, yi.l.liu@intel.com, yi.y.sun@linux.intel.com, mjrosato@linux.ibm.com, kvm@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, joro@8bytes.org, cohuck@redhat.com, xudong.hao@intel.com, peterx@redhat.com, yan.y.zhao@intel.com, eric.auger@redhat.com, terrence.xu@intel.com, nicolinc@nvidia.com, shameerali.kolothum.thodi@huawei.com, suravee.suthikulpanit@amd.com, intel-gfx@lists.freedesktop.org, chao.p.peng@linux.intel.com, lulu@redhat.com, robin.murphy@arm.com, jasowang@redhat.com Subject: [Intel-gfx] [PATCH v6 08/24] vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset() Date: Wed, 8 Mar 2023 05:28:47 -0800 [thread overview] Message-ID: <20230308132903.465159-9-yi.l.liu@intel.com> (raw) In-Reply-To: <20230308132903.465159-1-yi.l.liu@intel.com> this suits more on what the code does. Signed-off-by: Yi Liu <yi.l.liu@intel.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> --- drivers/vfio/pci/vfio_pci_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c index a5ab416cf476..65bbef562268 100644 --- a/drivers/vfio/pci/vfio_pci_core.c +++ b/drivers/vfio/pci/vfio_pci_core.c @@ -1308,9 +1308,8 @@ static int vfio_pci_ioctl_pci_hot_reset(struct vfio_pci_core_device *vdev, } /* - * For each group_fd, get the group through the vfio external user - * interface and store the group and iommu ID. This ensures the group - * is held across the reset. + * Get the group file for each fd to ensure the group held across + * the reset */ for (file_idx = 0; file_idx < hdr.count; file_idx++) { struct file *file = fget(group_fds[file_idx]); -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Yi Liu <yi.l.liu@intel.com> To: alex.williamson@redhat.com, jgg@nvidia.com, kevin.tian@intel.com Cc: joro@8bytes.org, robin.murphy@arm.com, cohuck@redhat.com, eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org, mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com, yi.l.liu@intel.com, yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com, shameerali.kolothum.thodi@huawei.com, lulu@redhat.com, suravee.suthikulpanit@amd.com, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-s390@vger.kernel.org, xudong.hao@intel.com, yan.y.zhao@intel.com, terrence.xu@intel.com Subject: [PATCH v6 08/24] vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset() Date: Wed, 8 Mar 2023 05:28:47 -0800 [thread overview] Message-ID: <20230308132903.465159-9-yi.l.liu@intel.com> (raw) In-Reply-To: <20230308132903.465159-1-yi.l.liu@intel.com> this suits more on what the code does. Signed-off-by: Yi Liu <yi.l.liu@intel.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> --- drivers/vfio/pci/vfio_pci_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c index a5ab416cf476..65bbef562268 100644 --- a/drivers/vfio/pci/vfio_pci_core.c +++ b/drivers/vfio/pci/vfio_pci_core.c @@ -1308,9 +1308,8 @@ static int vfio_pci_ioctl_pci_hot_reset(struct vfio_pci_core_device *vdev, } /* - * For each group_fd, get the group through the vfio external user - * interface and store the group and iommu ID. This ensures the group - * is held across the reset. + * Get the group file for each fd to ensure the group held across + * the reset */ for (file_idx = 0; file_idx < hdr.count; file_idx++) { struct file *file = fget(group_fds[file_idx]); -- 2.34.1
next prev parent reply other threads:[~2023-03-08 13:29 UTC|newest] Thread overview: 204+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-08 13:28 [Intel-gfx] [PATCH v6 00/24] cover-letter: Add vfio_device cdev for iommufd support Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 01/24] vfio: Allocate per device file structure Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 02/24] vfio: Refine vfio file kAPIs for KVM Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 03/24] vfio: Accept vfio device file in the KVM facing kAPI Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 04/24] kvm/vfio: Rename kvm_vfio_group to prepare for accepting vfio device fd Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 05/24] kvm/vfio: Accept vfio device file from userspace Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-22 14:10 ` [Intel-gfx] " Xu Yilun 2023-03-22 14:10 ` Xu Yilun 2023-03-28 3:48 ` Liu, Yi L 2023-03-28 3:48 ` [Intel-gfx] " Liu, Yi L 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 06/24] vfio: Pass struct vfio_device_file * to vfio_device_open/close() Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 07/24] vfio: Block device access via device fd until device is opened Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-10 4:50 ` Tian, Kevin 2023-03-10 4:50 ` [Intel-gfx] " Tian, Kevin 2023-03-08 13:28 ` Yi Liu [this message] 2023-03-08 13:28 ` [PATCH v6 08/24] vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset() Yi Liu 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 09/24] vfio/pci: Only need to check opened devices in the dev_set for hot reset Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-10 5:00 ` Tian, Kevin 2023-03-10 5:00 ` [Intel-gfx] " Tian, Kevin 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 10/24] vfio/pci: Rename the helpers and data in hot reset path to accept device fd Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-10 5:01 ` Tian, Kevin 2023-03-10 5:01 ` [Intel-gfx] " Tian, Kevin 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 11/24] vfio/pci: Accept device fd in VFIO_DEVICE_PCI_HOT_RESET ioctl Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-10 5:08 ` [Intel-gfx] " Tian, Kevin 2023-03-10 5:08 ` Tian, Kevin 2023-03-10 5:38 ` Liu, Yi L 2023-03-10 5:38 ` [Intel-gfx] " Liu, Yi L 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-10 5:31 ` Tian, Kevin 2023-03-10 5:31 ` [Intel-gfx] " Tian, Kevin 2023-03-10 6:04 ` Liu, Yi L 2023-03-10 6:04 ` [Intel-gfx] " Liu, Yi L 2023-03-10 9:08 ` Tian, Kevin 2023-03-10 9:08 ` Tian, Kevin 2023-03-10 17:42 ` [Intel-gfx] " Jason Gunthorpe 2023-03-10 17:42 ` Jason Gunthorpe 2023-03-15 22:53 ` [Intel-gfx] " Alex Williamson 2023-03-15 22:53 ` Alex Williamson 2023-03-15 23:31 ` Tian, Kevin 2023-03-15 23:31 ` [Intel-gfx] " Tian, Kevin 2023-03-16 3:54 ` [offlist] " Liu, Yi L 2023-03-16 3:54 ` [Intel-gfx] " Liu, Yi L 2023-03-16 6:09 ` Tian, Kevin 2023-03-16 6:09 ` [Intel-gfx] " Tian, Kevin 2023-03-16 6:28 ` Liu, Yi L 2023-03-16 6:28 ` [Intel-gfx] " Liu, Yi L 2023-03-16 6:49 ` Nicolin Chen 2023-03-16 6:49 ` [Intel-gfx] " Nicolin Chen 2023-03-16 13:22 ` Liu, Yi L 2023-03-16 13:22 ` [Intel-gfx] " Liu, Yi L 2023-03-16 21:27 ` Nicolin Chen 2023-03-16 21:27 ` [Intel-gfx] " Nicolin Chen 2023-03-16 18:45 ` Alex Williamson 2023-03-16 18:45 ` Alex Williamson 2023-03-16 23:29 ` Tian, Kevin 2023-03-16 23:29 ` [Intel-gfx] " Tian, Kevin 2023-03-17 0:22 ` Alex Williamson 2023-03-17 0:22 ` Alex Williamson 2023-03-17 0:57 ` Tian, Kevin 2023-03-17 0:57 ` [Intel-gfx] " Tian, Kevin 2023-03-17 15:15 ` Alex Williamson 2023-03-17 15:15 ` Alex Williamson 2023-03-20 17:14 ` [Intel-gfx] " Jason Gunthorpe 2023-03-20 17:14 ` Jason Gunthorpe 2023-03-20 22:52 ` [Intel-gfx] " Alex Williamson 2023-03-20 22:52 ` Alex Williamson 2023-03-20 23:39 ` [Intel-gfx] " Jason Gunthorpe 2023-03-20 23:39 ` Jason Gunthorpe 2023-03-21 20:31 ` [Intel-gfx] " Alex Williamson 2023-03-21 20:31 ` Alex Williamson 2023-03-21 20:50 ` Jason Gunthorpe 2023-03-21 20:50 ` [Intel-gfx] " Jason Gunthorpe 2023-03-21 21:01 ` Alex Williamson 2023-03-21 21:01 ` [Intel-gfx] " Alex Williamson 2023-03-21 22:20 ` Jason Gunthorpe 2023-03-21 22:20 ` [Intel-gfx] " Jason Gunthorpe 2023-03-21 22:47 ` Alex Williamson 2023-03-21 22:47 ` [Intel-gfx] " Alex Williamson 2023-03-22 4:42 ` Liu, Yi L 2023-03-22 4:42 ` [Intel-gfx] " Liu, Yi L 2023-03-22 12:23 ` Alex Williamson 2023-03-22 12:23 ` Alex Williamson 2023-03-22 12:27 ` Jason Gunthorpe 2023-03-22 12:27 ` [Intel-gfx] " Jason Gunthorpe 2023-03-22 12:36 ` Alex Williamson 2023-03-22 12:36 ` Alex Williamson 2023-03-22 12:47 ` Jason Gunthorpe 2023-03-22 12:47 ` [Intel-gfx] " Jason Gunthorpe 2023-03-24 9:09 ` Tian, Kevin 2023-03-24 9:09 ` [Intel-gfx] " Tian, Kevin 2023-03-24 13:14 ` Jason Gunthorpe 2023-03-24 13:14 ` [Intel-gfx] " Jason Gunthorpe 2023-03-22 8:17 ` Liu, Yi L 2023-03-22 8:17 ` [Intel-gfx] " Liu, Yi L 2023-03-22 12:17 ` Jason Gunthorpe 2023-03-22 12:17 ` [Intel-gfx] " Jason Gunthorpe 2023-03-22 13:33 ` Liu, Yi L 2023-03-22 13:33 ` [Intel-gfx] " Liu, Yi L 2023-03-22 13:43 ` Jason Gunthorpe 2023-03-22 13:43 ` [Intel-gfx] " Jason Gunthorpe 2023-03-23 3:15 ` Liu, Yi L 2023-03-23 3:15 ` [Intel-gfx] " Liu, Yi L 2023-03-23 12:02 ` Jason Gunthorpe 2023-03-23 12:02 ` Jason Gunthorpe 2023-03-24 9:25 ` Liu, Yi L 2023-03-24 9:25 ` [Intel-gfx] " Liu, Yi L 2023-03-27 11:57 ` Liu, Yi L 2023-03-27 11:57 ` [Intel-gfx] " Liu, Yi L 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 13/24] vfio/iommufd: Split the compat_ioas attach out from vfio_iommufd_bind() Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-10 8:08 ` [Intel-gfx] " Tian, Kevin 2023-03-10 8:08 ` Tian, Kevin 2023-03-10 8:22 ` Liu, Yi L 2023-03-10 8:22 ` [Intel-gfx] " Liu, Yi L 2023-03-10 9:10 ` Tian, Kevin 2023-03-10 9:10 ` Tian, Kevin 2023-03-11 10:24 ` Liu, Yi L 2023-03-11 10:24 ` [Intel-gfx] " Liu, Yi L 2023-03-13 2:06 ` Tian, Kevin 2023-03-13 2:06 ` [Intel-gfx] " Tian, Kevin 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 14/24] vfio: Add cdev_device_open_cnt to vfio_group Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 15/24] vfio: Make vfio_device_open() single open for device cdev path Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 16/24] vfio: Make vfio_device_first_open() to cover the noiommu mode in " Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-10 8:30 ` Tian, Kevin 2023-03-10 8:30 ` [Intel-gfx] " Tian, Kevin 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 17/24] vfio-iommufd: Make vfio_iommufd_bind() selectively return devid Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-10 8:31 ` Tian, Kevin 2023-03-10 8:31 ` [Intel-gfx] " Tian, Kevin 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 18/24] vfio-iommufd: Add detach_ioas support for physical VFIO devices Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 19/24] vfio-iommufd: Add detach_ioas support for emulated " Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-10 23:42 ` Nicolin Chen 2023-03-10 23:42 ` [Intel-gfx] " Nicolin Chen 2023-03-15 6:15 ` Liu, Yi L 2023-03-15 6:15 ` [Intel-gfx] " Liu, Yi L 2023-03-15 6:25 ` Nicolin Chen 2023-03-15 6:25 ` [Intel-gfx] " Nicolin Chen 2023-03-08 13:28 ` [Intel-gfx] [PATCH v6 20/24] vfio: Add cdev for vfio_device Yi Liu 2023-03-08 13:28 ` Yi Liu 2023-03-10 8:48 ` [Intel-gfx] " Tian, Kevin 2023-03-10 8:48 ` Tian, Kevin 2023-03-10 9:59 ` [Intel-gfx] " Liu, Yi L 2023-03-10 9:59 ` Liu, Yi L 2023-03-08 13:29 ` [Intel-gfx] [PATCH v6 21/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD Yi Liu 2023-03-08 13:29 ` Yi Liu 2023-03-10 9:01 ` [Intel-gfx] " Tian, Kevin 2023-03-10 9:01 ` Tian, Kevin 2023-03-10 9:58 ` Liu, Yi L 2023-03-10 9:58 ` [Intel-gfx] " Liu, Yi L 2023-03-10 10:06 ` Tian, Kevin 2023-03-10 10:06 ` [Intel-gfx] " Tian, Kevin 2023-03-15 4:40 ` Liu, Yi L 2023-03-15 4:40 ` [Intel-gfx] " Liu, Yi L 2023-03-15 6:57 ` Tian, Kevin 2023-03-15 6:57 ` [Intel-gfx] " Tian, Kevin 2023-03-20 14:09 ` Jason Gunthorpe 2023-03-20 14:09 ` [Intel-gfx] " Jason Gunthorpe 2023-03-20 14:31 ` Yi Liu 2023-03-20 14:31 ` [Intel-gfx] " Yi Liu 2023-03-20 17:16 ` Jason Gunthorpe 2023-03-20 17:16 ` Jason Gunthorpe 2023-03-21 1:30 ` Tian, Kevin 2023-03-21 1:30 ` [Intel-gfx] " Tian, Kevin 2023-03-21 12:00 ` Jason Gunthorpe 2023-03-21 12:00 ` [Intel-gfx] " Jason Gunthorpe 2023-03-21 14:37 ` Liu, Yi L 2023-03-21 14:37 ` [Intel-gfx] " Liu, Yi L 2023-03-21 14:41 ` Jason Gunthorpe 2023-03-21 14:41 ` [Intel-gfx] " Jason Gunthorpe 2023-03-21 14:51 ` Liu, Yi L 2023-03-21 14:51 ` [Intel-gfx] " Liu, Yi L 2023-03-21 14:58 ` Jason Gunthorpe 2023-03-21 14:58 ` [Intel-gfx] " Jason Gunthorpe 2023-03-21 15:10 ` Liu, Yi L 2023-03-21 15:10 ` [Intel-gfx] " Liu, Yi L 2023-03-21 16:54 ` Jason Gunthorpe 2023-03-21 16:54 ` [Intel-gfx] " Jason Gunthorpe 2023-03-08 13:29 ` [Intel-gfx] [PATCH v6 22/24] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT Yi Liu 2023-03-08 13:29 ` Yi Liu 2023-03-08 13:29 ` [Intel-gfx] [PATCH v6 23/24] vfio: Compile group optionally Yi Liu 2023-03-08 13:29 ` Yi Liu 2023-03-10 9:03 ` [Intel-gfx] " Tian, Kevin 2023-03-10 9:03 ` Tian, Kevin 2023-03-08 13:29 ` [Intel-gfx] [PATCH v6 24/24] docs: vfio: Add vfio device cdev description Yi Liu 2023-03-08 13:29 ` Yi Liu 2023-03-14 11:02 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for cover-letter: Add vfio_device cdev for iommufd support Patchwork 2023-03-24 10:39 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for cover-letter: Add vfio_device cdev for iommufd support (rev2) Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230308132903.465159-9-yi.l.liu@intel.com \ --to=yi.l.liu@intel.com \ --cc=alex.williamson@redhat.com \ --cc=chao.p.peng@linux.intel.com \ --cc=cohuck@redhat.com \ --cc=eric.auger@redhat.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=intel-gvt-dev@lists.freedesktop.org \ --cc=jasowang@redhat.com \ --cc=jgg@nvidia.com \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=lulu@redhat.com \ --cc=mjrosato@linux.ibm.com \ --cc=nicolinc@nvidia.com \ --cc=peterx@redhat.com \ --cc=robin.murphy@arm.com \ --cc=shameerali.kolothum.thodi@huawei.com \ --cc=suravee.suthikulpanit@amd.com \ --cc=terrence.xu@intel.com \ --cc=xudong.hao@intel.com \ --cc=yan.y.zhao@intel.com \ --cc=yi.y.sun@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.