[PATCH V2 0/3] rework mailbox compatibles for Qualcomm IPQ SoCs

[PATCH V2 0/3] rework mailbox compatibles for Qualcomm IPQ SoCs

[Kathiravan T]

As suggested by Krzysztof[1], we can use the fallback compatible to
avoid duplicating the same device data.

Krzysztof already submitted a series[2] for this by reworking entire
binding and driver and it is conflicting with the Dmitry's series as
mentioned by Krzysztof[3].

So this series addresses IPQ SoCs alone, as I see no dependency with it.

[1]
https://lore.kernel.org/linux-arm-msm/1b75ab1a-44c9-c4a8-7fa4-d601fc710d2a@linaro.org/
[2]
https://lore.kernel.org/linux-arm-msm/20230202161856.385825-1-krzysztof.kozlowski@linaro.org/
[3]
https://lore.kernel.org/linux-arm-msm/fa6dc60c-3799-d384-da24-f282b7cbd3ef@linaro.org/

Kathiravan T (2):
  dt-bindings: mailbox: qcom: use fallback for IPQ8074 SoC
  mailbox: qcom-apcs-ipc: drop the IPQ8074 and IPQ5332 compatible

Krzysztof Kozlowski (1):
  arm64: dts: qcom: ipq8074: add compatible fallback to mailbox

 .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml    | 4 +---
 arch/arm64/boot/dts/qcom/ipq8074.dtsi                         | 3 ++-
 drivers/mailbox/qcom-apcs-ipc-mailbox.c                       | 2 --
 3 files changed, 3 insertions(+), 6 deletions(-)

-- 
2.17.1

[PATCH V2 1/3] dt-bindings: mailbox: qcom: use fallback for IPQ8074 SoC

[Kathiravan T]

Since the IPQ8074 mailbox is compatible with the IPQ6018, lets create
the fallback to ipq6018 compatible, so that we don't bloat the of_device_id
table in the driver.

Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V2:
	- Fixed the dtbs_check warning for IPQ6018

 .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml    | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
index d888ead09282..9598471d537f 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
@@ -19,11 +19,11 @@ properties:
       - items:
           - enum:
               - qcom,ipq5332-apcs-apps-global
+              - qcom,ipq8074-apcs-apps-global
           - const: qcom,ipq6018-apcs-apps-global
       - items:
           - enum:
               - qcom,ipq6018-apcs-apps-global
-              - qcom,ipq8074-apcs-apps-global
               - qcom,msm8996-apcs-hmss-global
               - qcom,msm8998-apcs-hmss-global
               - qcom,qcm2290-apcs-hmss-global
@@ -111,7 +111,6 @@ allOf:
           contains:
             enum:
               - qcom,ipq6018-apcs-apps-global
-              - qcom,ipq8074-apcs-apps-global
     then:
       properties:
         clocks:
@@ -152,7 +151,6 @@ allOf:
           contains:
             enum:
               - qcom,ipq6018-apcs-apps-global
-              - qcom,ipq8074-apcs-apps-global
     then:
       properties:
         '#clock-cells':
-- 
2.17.1

Re: [PATCH V2 1/3] dt-bindings: mailbox: qcom: use fallback for IPQ8074 SoC

[Krzysztof Kozlowski]

On 14/03/2023 06:00, Kathiravan T wrote:
> Since the IPQ8074 mailbox is compatible with the IPQ6018, lets create
> the fallback to ipq6018 compatible, so that we don't bloat the of_device_id
> table in the driver.
> 
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
> Changes in V2:
> 	- Fixed the dtbs_check warning for IPQ6018
> 

I responded to v1, so for formality: NAK.

Best regards,
Krzysztof

Re: [PATCH V2 1/3] dt-bindings: mailbox: qcom: use fallback for IPQ8074 SoC

[Kathiravan T]

On 3/14/2023 1:44 PM, Krzysztof Kozlowski wrote:
> On 14/03/2023 06:00, Kathiravan T wrote:
>> Since the IPQ8074 mailbox is compatible with the IPQ6018, lets create
>> the fallback to ipq6018 compatible, so that we don't bloat the of_device_id
>> table in the driver.
>>
>> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>> ---
>> Changes in V2:
>> 	- Fixed the dtbs_check warning for IPQ6018
>>
> I responded to v1, so for formality: NAK.

Thanks, I should have waited for some more time.. I see the V2 of your 
series. I'll drop this series.

Thanks, Kathiravan T.

[PATCH V2 2/3] mailbox: qcom-apcs-ipc: drop the IPQ8074 and IPQ5332 compatible

[Kathiravan T]

Since the IPQ8074 and IPQ5332 mailbox are compatible with IPQ6018, we can
use the compatible fallback to IPQ6018. With that, we can drop the
IPQ8074 and IPQ5332 compatible references, as well we don't bloat the
of_device_id table.

Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V2:
	- No changes

 drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
index 6bbf87c6d60b..3906bd655991 100644
--- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
+++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
@@ -141,9 +141,7 @@ static int qcom_apcs_ipc_remove(struct platform_device *pdev)
 
 /* .data is the offset of the ipc register within the global block */
 static const struct of_device_id qcom_apcs_ipc_of_match[] = {
-	{ .compatible = "qcom,ipq5332-apcs-apps-global", .data = &ipq6018_apcs_data },
 	{ .compatible = "qcom,ipq6018-apcs-apps-global", .data = &ipq6018_apcs_data },
-	{ .compatible = "qcom,ipq8074-apcs-apps-global", .data = &ipq6018_apcs_data },
 	{ .compatible = "qcom,msm8916-apcs-kpss-global", .data = &msm8916_apcs_data },
 	{ .compatible = "qcom,msm8939-apcs-kpss-global", .data = &msm8916_apcs_data },
 	{ .compatible = "qcom,msm8953-apcs-kpss-global", .data = &msm8994_apcs_data },
-- 
2.17.1

Re: [PATCH V2 2/3] mailbox: qcom-apcs-ipc: drop the IPQ8074 and IPQ5332 compatible

[Krzysztof Kozlowski]

On 14/03/2023 06:00, Kathiravan T wrote:
> Since the IPQ8074 and IPQ5332 mailbox are compatible with IPQ6018, we can
> use the compatible fallback to IPQ6018. With that, we can drop the
> IPQ8074 and IPQ5332 compatible references, as well we don't bloat the
> of_device_id table.
> 
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

I never suggested anything like this, so: NAK
(also responded to v1)

Best regards,
Krzysztof

[PATCH V2 3/3] arm64: dts: qcom: ipq8074: add compatible fallback to mailbox

[Kathiravan T]

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

IPQ8074 mailbox is compatible with IPQ6018.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V2:
	- No changes

 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
index 62d05d740646..3fa7a63db74e 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
@@ -687,7 +687,8 @@
 		};
 
 		apcs_glb: mailbox@b111000 {
-			compatible = "qcom,ipq8074-apcs-apps-global";
+			compatible = "qcom,ipq8074-apcs-apps-global",
+				     "qcom,ipq6018-apcs-apps-global";
 			reg = <0x0b111000 0x1000>;
 			clocks = <&a53pll>, <&xo>;
 			clock-names = "pll", "xo";
-- 
2.17.1

Re: [PATCH V2 3/3] arm64: dts: qcom: ipq8074: add compatible fallback to mailbox

[Krzysztof Kozlowski]

On 14/03/2023 06:00, Kathiravan T wrote:
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> IPQ8074 mailbox is compatible with IPQ6018.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
> Changes in V2:
> 	- No changes
> 

Why do you send my patches?

Best regards,
Krzysztof