All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3 V5] Bluetooth: Add support for RTL8821CS
@ 2023-03-15 17:36 ` Chris Morgan
  0 siblings, 0 replies; 17+ messages in thread
From: Chris Morgan @ 2023-03-15 17:36 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: linux-rockchip, devicetree, alistair, anarsoul, luiz.dentz,
	johan.hedberg, marcel, heiko, krzysztof.kozlowski+dt, robh+dt,
	Chris Morgan

From: Chris Morgan <macromorgan@hotmail.com>

This patch series is to add support for the RTL8821CS Bluetooth
controller found on the RTL8821CS WiFi/Bluetooth combo chip.

This has been tested with firmware version 0x75b8f098 which has been
submitted by Realtek for inclusion in linux-firmware.

https://lore.kernel.org/linux-firmware/20230223062453.181239-1-max.chou@realtek.com/

Changes from V4:
 - After extensive testing it was found that there are problems with
   using the bluetooth that were not caught with the initial testing.
   This can be mitigated by setting the "H5_INFO_WAKEUP_DISABLE" flag.
   The easiest way to accomplish that is to change the fallback
   compatible string to "realtek,rtl8723bs-bt". Updated the binding
   documentation and binding to reflect this. No change to the driver
   from V4 was necessary. Removed "reviewed-by" from documentation due
   to this change.

Changes from V3:
 - Corrected bindings so that all but the 8821 use enum, and 8821 uses
   items.

Changes from V2:
 - Corrected devicetree documentation to change compatible from const
   back to enum.
 - Removed "reviewed-by" from Alistair Francis as binding documentation
   updated with changes.

Changes from V1:
 - Switched to use a fallback string for the rtl8822cs so as to not add
   an extra entry to the of_device_id table. The driver is capable of
   selecting the correct firmware blob to load.
 - Updated the messages to note a new version of the firmware was
   tested and that Realtek has submitted this firmware upstream.
 - Updated the devicetree node on the Anbernic RGxx3 series to use the
   fallback string of realtek,rtl8822cs-bt.

Chris Morgan (3):
  dt-bindings: net: realtek-bluetooth: Add RTL8821CS
  Bluetooth: hci_h5: btrtl: Add support for RTL8821CS
  arm64: dts: rockchip: Update compatible for bluetooth

 .../bindings/net/realtek-bluetooth.yaml       | 24 ++++++++++++-------
 .../dts/rockchip/rk3566-anbernic-rgxx3.dtsi   |  2 +-
 drivers/bluetooth/btrtl.c                     |  8 +++++++
 3 files changed, 24 insertions(+), 10 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH 0/3 V5] Bluetooth: Add support for RTL8821CS
@ 2023-03-15 17:36 ` Chris Morgan
  0 siblings, 0 replies; 17+ messages in thread
From: Chris Morgan @ 2023-03-15 17:36 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: linux-rockchip, devicetree, alistair, anarsoul, luiz.dentz,
	johan.hedberg, marcel, heiko, krzysztof.kozlowski+dt, robh+dt,
	Chris Morgan

From: Chris Morgan <macromorgan@hotmail.com>

This patch series is to add support for the RTL8821CS Bluetooth
controller found on the RTL8821CS WiFi/Bluetooth combo chip.

This has been tested with firmware version 0x75b8f098 which has been
submitted by Realtek for inclusion in linux-firmware.

https://lore.kernel.org/linux-firmware/20230223062453.181239-1-max.chou@realtek.com/

Changes from V4:
 - After extensive testing it was found that there are problems with
   using the bluetooth that were not caught with the initial testing.
   This can be mitigated by setting the "H5_INFO_WAKEUP_DISABLE" flag.
   The easiest way to accomplish that is to change the fallback
   compatible string to "realtek,rtl8723bs-bt". Updated the binding
   documentation and binding to reflect this. No change to the driver
   from V4 was necessary. Removed "reviewed-by" from documentation due
   to this change.

Changes from V3:
 - Corrected bindings so that all but the 8821 use enum, and 8821 uses
   items.

Changes from V2:
 - Corrected devicetree documentation to change compatible from const
   back to enum.
 - Removed "reviewed-by" from Alistair Francis as binding documentation
   updated with changes.

Changes from V1:
 - Switched to use a fallback string for the rtl8822cs so as to not add
   an extra entry to the of_device_id table. The driver is capable of
   selecting the correct firmware blob to load.
 - Updated the messages to note a new version of the firmware was
   tested and that Realtek has submitted this firmware upstream.
 - Updated the devicetree node on the Anbernic RGxx3 series to use the
   fallback string of realtek,rtl8822cs-bt.

Chris Morgan (3):
  dt-bindings: net: realtek-bluetooth: Add RTL8821CS
  Bluetooth: hci_h5: btrtl: Add support for RTL8821CS
  arm64: dts: rockchip: Update compatible for bluetooth

 .../bindings/net/realtek-bluetooth.yaml       | 24 ++++++++++++-------
 .../dts/rockchip/rk3566-anbernic-rgxx3.dtsi   |  2 +-
 drivers/bluetooth/btrtl.c                     |  8 +++++++
 3 files changed, 24 insertions(+), 10 deletions(-)

-- 
2.34.1


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH 1/3 V5] dt-bindings: net: realtek-bluetooth: Add RTL8821CS
  2023-03-15 17:36 ` Chris Morgan
@ 2023-03-15 17:36   ` Chris Morgan
  -1 siblings, 0 replies; 17+ messages in thread
From: Chris Morgan @ 2023-03-15 17:36 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: linux-rockchip, devicetree, alistair, anarsoul, luiz.dentz,
	johan.hedberg, marcel, heiko, krzysztof.kozlowski+dt, robh+dt,
	Chris Morgan

From: Chris Morgan <macromorgan@hotmail.com>

Add compatible string for RTL8821CS for existing Realtek Bluetooth
driver.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 .../bindings/net/realtek-bluetooth.yaml       | 24 ++++++++++++-------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
index 143b5667abad..506ea9b17668 100644
--- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
@@ -4,24 +4,30 @@
 $id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: RTL8723BS/RTL8723CS/RTL8822CS Bluetooth
+title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822CS Bluetooth
 
 maintainers:
   - Vasily Khoruzhick <anarsoul@gmail.com>
   - Alistair Francis <alistair@alistair23.me>
 
 description:
-  RTL8723CS/RTL8723CS/RTL8822CS is WiFi + BT chip. WiFi part is connected over
-  SDIO, while BT is connected over serial. It speaks H5 protocol with few
-  extra commands to upload firmware and change module speed.
+  RTL8723CS/RTL8723CS/RTL8821CS/RTL8822CS is a WiFi + BT chip. WiFi part
+  is connected over SDIO, while BT is connected over serial. It speaks
+  H5 protocol with few extra commands to upload firmware and change
+  module speed.
 
 properties:
   compatible:
-    enum:
-      - realtek,rtl8723bs-bt
-      - realtek,rtl8723cs-bt
-      - realtek,rtl8723ds-bt
-      - realtek,rtl8822cs-bt
+    oneOf:
+      - enum:
+          - realtek,rtl8723bs-bt
+          - realtek,rtl8723cs-bt
+          - realtek,rtl8723ds-bt
+          - realtek,rtl8822cs-bt
+      - items:
+          - enum:
+              - realtek,rtl8821cs-bt
+          - const: realtek,rtl8723bs-bt
 
   device-wake-gpios:
     maxItems: 1
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 1/3 V5] dt-bindings: net: realtek-bluetooth: Add RTL8821CS
@ 2023-03-15 17:36   ` Chris Morgan
  0 siblings, 0 replies; 17+ messages in thread
From: Chris Morgan @ 2023-03-15 17:36 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: linux-rockchip, devicetree, alistair, anarsoul, luiz.dentz,
	johan.hedberg, marcel, heiko, krzysztof.kozlowski+dt, robh+dt,
	Chris Morgan

From: Chris Morgan <macromorgan@hotmail.com>

Add compatible string for RTL8821CS for existing Realtek Bluetooth
driver.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 .../bindings/net/realtek-bluetooth.yaml       | 24 ++++++++++++-------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
index 143b5667abad..506ea9b17668 100644
--- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
@@ -4,24 +4,30 @@
 $id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: RTL8723BS/RTL8723CS/RTL8822CS Bluetooth
+title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822CS Bluetooth
 
 maintainers:
   - Vasily Khoruzhick <anarsoul@gmail.com>
   - Alistair Francis <alistair@alistair23.me>
 
 description:
-  RTL8723CS/RTL8723CS/RTL8822CS is WiFi + BT chip. WiFi part is connected over
-  SDIO, while BT is connected over serial. It speaks H5 protocol with few
-  extra commands to upload firmware and change module speed.
+  RTL8723CS/RTL8723CS/RTL8821CS/RTL8822CS is a WiFi + BT chip. WiFi part
+  is connected over SDIO, while BT is connected over serial. It speaks
+  H5 protocol with few extra commands to upload firmware and change
+  module speed.
 
 properties:
   compatible:
-    enum:
-      - realtek,rtl8723bs-bt
-      - realtek,rtl8723cs-bt
-      - realtek,rtl8723ds-bt
-      - realtek,rtl8822cs-bt
+    oneOf:
+      - enum:
+          - realtek,rtl8723bs-bt
+          - realtek,rtl8723cs-bt
+          - realtek,rtl8723ds-bt
+          - realtek,rtl8822cs-bt
+      - items:
+          - enum:
+              - realtek,rtl8821cs-bt
+          - const: realtek,rtl8723bs-bt
 
   device-wake-gpios:
     maxItems: 1
-- 
2.34.1


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 2/3 V5] Bluetooth: hci_h5: btrtl: Add support for RTL8821CS
  2023-03-15 17:36 ` Chris Morgan
@ 2023-03-15 17:36   ` Chris Morgan
  -1 siblings, 0 replies; 17+ messages in thread
From: Chris Morgan @ 2023-03-15 17:36 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: linux-rockchip, devicetree, alistair, anarsoul, luiz.dentz,
	johan.hedberg, marcel, heiko, krzysztof.kozlowski+dt, robh+dt,
	Chris Morgan

From: Chris Morgan <macromorgan@hotmail.com>

RTL8821CS is a WiFi + Bluetooth combo chip from Realtek that provides
WiFi A/B/G/N/AC over an SDIO interface and Bluetooth 4.2 over a UART
interface.

Note that the firmware this was tested with was firmware version
0x75b8f098.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 drivers/bluetooth/btrtl.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 69c3fe649ca7..72947d319fa6 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -128,6 +128,14 @@ static const struct id_table ic_id_table[] = {
 	  .fw_name  = "rtl_bt/rtl8821c_fw.bin",
 	  .cfg_name = "rtl_bt/rtl8821c_config" },
 
+	/* 8821CS */
+	{ IC_INFO(RTL_ROM_LMP_8821A, 0xc, 0x8, HCI_UART),
+	  .config_needed = true,
+	  .has_rom_version = true,
+	  .has_msft_ext = true,
+	  .fw_name  = "rtl_bt/rtl8821cs_fw.bin",
+	  .cfg_name = "rtl_bt/rtl8821cs_config" },
+
 	/* 8761A */
 	{ IC_INFO(RTL_ROM_LMP_8761A, 0xa, 0x6, HCI_USB),
 	  .config_needed = false,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 2/3 V5] Bluetooth: hci_h5: btrtl: Add support for RTL8821CS
@ 2023-03-15 17:36   ` Chris Morgan
  0 siblings, 0 replies; 17+ messages in thread
From: Chris Morgan @ 2023-03-15 17:36 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: linux-rockchip, devicetree, alistair, anarsoul, luiz.dentz,
	johan.hedberg, marcel, heiko, krzysztof.kozlowski+dt, robh+dt,
	Chris Morgan

From: Chris Morgan <macromorgan@hotmail.com>

RTL8821CS is a WiFi + Bluetooth combo chip from Realtek that provides
WiFi A/B/G/N/AC over an SDIO interface and Bluetooth 4.2 over a UART
interface.

Note that the firmware this was tested with was firmware version
0x75b8f098.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 drivers/bluetooth/btrtl.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 69c3fe649ca7..72947d319fa6 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -128,6 +128,14 @@ static const struct id_table ic_id_table[] = {
 	  .fw_name  = "rtl_bt/rtl8821c_fw.bin",
 	  .cfg_name = "rtl_bt/rtl8821c_config" },
 
+	/* 8821CS */
+	{ IC_INFO(RTL_ROM_LMP_8821A, 0xc, 0x8, HCI_UART),
+	  .config_needed = true,
+	  .has_rom_version = true,
+	  .has_msft_ext = true,
+	  .fw_name  = "rtl_bt/rtl8821cs_fw.bin",
+	  .cfg_name = "rtl_bt/rtl8821cs_config" },
+
 	/* 8761A */
 	{ IC_INFO(RTL_ROM_LMP_8761A, 0xa, 0x6, HCI_USB),
 	  .config_needed = false,
-- 
2.34.1


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 3/3 V5] arm64: dts: rockchip: Update compatible for bluetooth
  2023-03-15 17:36 ` Chris Morgan
@ 2023-03-15 17:36   ` Chris Morgan
  -1 siblings, 0 replies; 17+ messages in thread
From: Chris Morgan @ 2023-03-15 17:36 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: linux-rockchip, devicetree, alistair, anarsoul, luiz.dentz,
	johan.hedberg, marcel, heiko, krzysztof.kozlowski+dt, robh+dt,
	Chris Morgan

From: Chris Morgan <macromorgan@hotmail.com>

Update the compatible for the Realtek RTL8821CS bluetooth node.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi
index 41262a69d33e..ad43fa199ca5 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi
@@ -716,7 +716,7 @@ &uart1 {
 	status = "okay";
 
 	bluetooth {
-		compatible = "realtek,rtl8821cs-bt";
+		compatible = "realtek,rtl8821cs-bt", "realtek,rtl8723bs-bt";
 		device-wake-gpios = <&gpio4 4 GPIO_ACTIVE_HIGH>;
 		enable-gpios = <&gpio4 3 GPIO_ACTIVE_HIGH>;
 		host-wake-gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 3/3 V5] arm64: dts: rockchip: Update compatible for bluetooth
@ 2023-03-15 17:36   ` Chris Morgan
  0 siblings, 0 replies; 17+ messages in thread
From: Chris Morgan @ 2023-03-15 17:36 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: linux-rockchip, devicetree, alistair, anarsoul, luiz.dentz,
	johan.hedberg, marcel, heiko, krzysztof.kozlowski+dt, robh+dt,
	Chris Morgan

From: Chris Morgan <macromorgan@hotmail.com>

Update the compatible for the Realtek RTL8821CS bluetooth node.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi
index 41262a69d33e..ad43fa199ca5 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi
@@ -716,7 +716,7 @@ &uart1 {
 	status = "okay";
 
 	bluetooth {
-		compatible = "realtek,rtl8821cs-bt";
+		compatible = "realtek,rtl8821cs-bt", "realtek,rtl8723bs-bt";
 		device-wake-gpios = <&gpio4 4 GPIO_ACTIVE_HIGH>;
 		enable-gpios = <&gpio4 3 GPIO_ACTIVE_HIGH>;
 		host-wake-gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>;
-- 
2.34.1


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* RE: Bluetooth: Add support for RTL8821CS
  2023-03-15 17:36   ` Chris Morgan
  (?)
@ 2023-03-15 17:39   ` bluez.test.bot
  -1 siblings, 0 replies; 17+ messages in thread
From: bluez.test.bot @ 2023-03-15 17:39 UTC (permalink / raw)
  To: linux-bluetooth, macroalpha82

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----

error: patch failed: Documentation/devicetree/bindings/net/realtek-bluetooth.yaml:4
error: Documentation/devicetree/bindings/net/realtek-bluetooth.yaml: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch

Please resolve the issue and submit the patches again.


---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/3 V5] dt-bindings: net: realtek-bluetooth: Add RTL8821CS
  2023-03-15 17:36   ` Chris Morgan
@ 2023-03-16  7:55     ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-16  7:55 UTC (permalink / raw)
  To: Chris Morgan, linux-bluetooth
  Cc: linux-rockchip, devicetree, alistair, anarsoul, luiz.dentz,
	johan.hedberg, marcel, heiko, krzysztof.kozlowski+dt, robh+dt,
	Chris Morgan

On 15/03/2023 18:36, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Add compatible string for RTL8821CS for existing Realtek Bluetooth
> driver.
> 
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  .../bindings/net/realtek-bluetooth.yaml       | 24 ++++++++++++-------
>  1 file changed, 15 insertions(+), 9 deletions(-)
> 

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions. However, there's no need to repost patches *only* to add the
tags. The upstream maintainer will do that for acks received on the
version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/3 V5] dt-bindings: net: realtek-bluetooth: Add RTL8821CS
@ 2023-03-16  7:55     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-16  7:55 UTC (permalink / raw)
  To: Chris Morgan, linux-bluetooth
  Cc: linux-rockchip, devicetree, alistair, anarsoul, luiz.dentz,
	johan.hedberg, marcel, heiko, krzysztof.kozlowski+dt, robh+dt,
	Chris Morgan

On 15/03/2023 18:36, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Add compatible string for RTL8821CS for existing Realtek Bluetooth
> driver.
> 
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  .../bindings/net/realtek-bluetooth.yaml       | 24 ++++++++++++-------
>  1 file changed, 15 insertions(+), 9 deletions(-)
> 

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions. However, there's no need to repost patches *only* to add the
tags. The upstream maintainer will do that for acks received on the
version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.


Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/3 V5] dt-bindings: net: realtek-bluetooth: Add RTL8821CS
  2023-03-16  7:55     ` Krzysztof Kozlowski
@ 2023-03-16 19:36       ` Chris Morgan
  -1 siblings, 0 replies; 17+ messages in thread
From: Chris Morgan @ 2023-03-16 19:36 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Chris Morgan, linux-bluetooth, linux-rockchip, devicetree,
	alistair, anarsoul, luiz.dentz, johan.hedberg, marcel, heiko,
	krzysztof.kozlowski+dt, robh+dt

On Thu, Mar 16, 2023 at 08:55:13AM +0100, Krzysztof Kozlowski wrote:
> On 15/03/2023 18:36, Chris Morgan wrote:
> > From: Chris Morgan <macromorgan@hotmail.com>
> > 
> > Add compatible string for RTL8821CS for existing Realtek Bluetooth
> > driver.
> > 
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > ---
> >  .../bindings/net/realtek-bluetooth.yaml       | 24 ++++++++++++-------
> >  1 file changed, 15 insertions(+), 9 deletions(-)
> > 
> 
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.

I removed it on purpose and noted it in the cover letter because I
changed the bindings. I apologize if that's not correct.

I changed the fallback from "realtek,rtl8822cs-bt" to
"realtek,rtl8723bs-bt". From the driver perspective that causes it to
disable runtime power management, but otherwise it's identical to V4.

Thank you.

> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions. However, there's no need to repost patches *only* to add the
> tags. The upstream maintainer will do that for acks received on the
> version they apply.
> 
> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
> 
> If a tag was not added on purpose, please state why and what changed.
> 
> 
> Best regards,
> Krzysztof
> 

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/3 V5] dt-bindings: net: realtek-bluetooth: Add RTL8821CS
@ 2023-03-16 19:36       ` Chris Morgan
  0 siblings, 0 replies; 17+ messages in thread
From: Chris Morgan @ 2023-03-16 19:36 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Chris Morgan, linux-bluetooth, linux-rockchip, devicetree,
	alistair, anarsoul, luiz.dentz, johan.hedberg, marcel, heiko,
	krzysztof.kozlowski+dt, robh+dt

On Thu, Mar 16, 2023 at 08:55:13AM +0100, Krzysztof Kozlowski wrote:
> On 15/03/2023 18:36, Chris Morgan wrote:
> > From: Chris Morgan <macromorgan@hotmail.com>
> > 
> > Add compatible string for RTL8821CS for existing Realtek Bluetooth
> > driver.
> > 
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > ---
> >  .../bindings/net/realtek-bluetooth.yaml       | 24 ++++++++++++-------
> >  1 file changed, 15 insertions(+), 9 deletions(-)
> > 
> 
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.

I removed it on purpose and noted it in the cover letter because I
changed the bindings. I apologize if that's not correct.

I changed the fallback from "realtek,rtl8822cs-bt" to
"realtek,rtl8723bs-bt". From the driver perspective that causes it to
disable runtime power management, but otherwise it's identical to V4.

Thank you.

> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions. However, there's no need to repost patches *only* to add the
> tags. The upstream maintainer will do that for acks received on the
> version they apply.
> 
> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
> 
> If a tag was not added on purpose, please state why and what changed.
> 
> 
> Best regards,
> Krzysztof
> 

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/3 V5] dt-bindings: net: realtek-bluetooth: Add RTL8821CS
  2023-03-15 17:36   ` Chris Morgan
@ 2023-03-17  8:26     ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-17  8:26 UTC (permalink / raw)
  To: Chris Morgan, linux-bluetooth
  Cc: linux-rockchip, devicetree, alistair, anarsoul, luiz.dentz,
	johan.hedberg, marcel, heiko, krzysztof.kozlowski+dt, robh+dt,
	Chris Morgan

On 15/03/2023 18:36, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Add compatible string for RTL8821CS for existing Realtek Bluetooth
> driver.
> 
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  .../bindings/net/realtek-bluetooth.yaml       | 24 ++++++++++++-------
>  1 file changed, 15 insertions(+), 9 deletions(-)


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/3 V5] dt-bindings: net: realtek-bluetooth: Add RTL8821CS
@ 2023-03-17  8:26     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-17  8:26 UTC (permalink / raw)
  To: Chris Morgan, linux-bluetooth
  Cc: linux-rockchip, devicetree, alistair, anarsoul, luiz.dentz,
	johan.hedberg, marcel, heiko, krzysztof.kozlowski+dt, robh+dt,
	Chris Morgan

On 15/03/2023 18:36, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Add compatible string for RTL8821CS for existing Realtek Bluetooth
> driver.
> 
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  .../bindings/net/realtek-bluetooth.yaml       | 24 ++++++++++++-------
>  1 file changed, 15 insertions(+), 9 deletions(-)


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 0/3 V5] Bluetooth: Add support for RTL8821CS
  2023-03-15 17:36 ` Chris Morgan
@ 2023-03-22 23:44   ` patchwork-bot+bluetooth
  -1 siblings, 0 replies; 17+ messages in thread
From: patchwork-bot+bluetooth @ 2023-03-22 23:44 UTC (permalink / raw)
  To: Chris Morgan
  Cc: linux-bluetooth, linux-rockchip, devicetree, alistair, anarsoul,
	luiz.dentz, johan.hedberg, marcel, heiko, krzysztof.kozlowski+dt,
	robh+dt, macromorgan

Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 15 Mar 2023 12:36:54 -0500 you wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> This patch series is to add support for the RTL8821CS Bluetooth
> controller found on the RTL8821CS WiFi/Bluetooth combo chip.
> 
> This has been tested with firmware version 0x75b8f098 which has been
> submitted by Realtek for inclusion in linux-firmware.
> 
> [...]

Here is the summary with links:
  - [1/3,V5] dt-bindings: net: realtek-bluetooth: Add RTL8821CS
    (no matching commit)
  - [2/3,V5] Bluetooth: hci_h5: btrtl: Add support for RTL8821CS
    https://git.kernel.org/bluetooth/bluetooth-next/c/60f8c67d065a
  - [3/3,V5] arm64: dts: rockchip: Update compatible for bluetooth
    (no matching commit)

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 0/3 V5] Bluetooth: Add support for RTL8821CS
@ 2023-03-22 23:44   ` patchwork-bot+bluetooth
  0 siblings, 0 replies; 17+ messages in thread
From: patchwork-bot+bluetooth @ 2023-03-22 23:44 UTC (permalink / raw)
  To: Chris Morgan
  Cc: linux-bluetooth, linux-rockchip, devicetree, alistair, anarsoul,
	luiz.dentz, johan.hedberg, marcel, heiko, krzysztof.kozlowski+dt,
	robh+dt, macromorgan

Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 15 Mar 2023 12:36:54 -0500 you wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> This patch series is to add support for the RTL8821CS Bluetooth
> controller found on the RTL8821CS WiFi/Bluetooth combo chip.
> 
> This has been tested with firmware version 0x75b8f098 which has been
> submitted by Realtek for inclusion in linux-firmware.
> 
> [...]

Here is the summary with links:
  - [1/3,V5] dt-bindings: net: realtek-bluetooth: Add RTL8821CS
    (no matching commit)
  - [2/3,V5] Bluetooth: hci_h5: btrtl: Add support for RTL8821CS
    https://git.kernel.org/bluetooth/bluetooth-next/c/60f8c67d065a
  - [3/3,V5] arm64: dts: rockchip: Update compatible for bluetooth
    (no matching commit)

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2023-03-22 23:45 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-15 17:36 [PATCH 0/3 V5] Bluetooth: Add support for RTL8821CS Chris Morgan
2023-03-15 17:36 ` Chris Morgan
2023-03-15 17:36 ` [PATCH 1/3 V5] dt-bindings: net: realtek-bluetooth: Add RTL8821CS Chris Morgan
2023-03-15 17:36   ` Chris Morgan
2023-03-15 17:39   ` Bluetooth: Add support for RTL8821CS bluez.test.bot
2023-03-16  7:55   ` [PATCH 1/3 V5] dt-bindings: net: realtek-bluetooth: Add RTL8821CS Krzysztof Kozlowski
2023-03-16  7:55     ` Krzysztof Kozlowski
2023-03-16 19:36     ` Chris Morgan
2023-03-16 19:36       ` Chris Morgan
2023-03-17  8:26   ` Krzysztof Kozlowski
2023-03-17  8:26     ` Krzysztof Kozlowski
2023-03-15 17:36 ` [PATCH 2/3 V5] Bluetooth: hci_h5: btrtl: Add support for RTL8821CS Chris Morgan
2023-03-15 17:36   ` Chris Morgan
2023-03-15 17:36 ` [PATCH 3/3 V5] arm64: dts: rockchip: Update compatible for bluetooth Chris Morgan
2023-03-15 17:36   ` Chris Morgan
2023-03-22 23:44 ` [PATCH 0/3 V5] Bluetooth: Add support for RTL8821CS patchwork-bot+bluetooth
2023-03-22 23:44   ` patchwork-bot+bluetooth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.