From: Bjorn Helgaas <helgaas@kernel.org> To: Karol Herbst <kherbst@redhat.com> Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>, Lukas Wunner <lukas@wunner.de>, linux-pci@vger.kernel.org, nouveau@lists.freedesktop.org Subject: Re: [PATCH] PCI: stop spamming info in quirk_nvidia_hda Date: Thu, 16 Mar 2023 14:50:37 -0500 [thread overview] Message-ID: <20230316195037.GA1849341@bhelgaas> (raw) In-Reply-To: <20230316143122.2377354-1-kherbst@redhat.com> On Thu, Mar 16, 2023 at 03:31:22PM +0100, Karol Herbst wrote: > Users kept complaining about those messages and it's a little spammy on > prime systems so turn it into a debug print. What is a "prime system"? I'm a little surprised that users would really care about the message. But I do see comments like these: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1836308/comments/15 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2002206 that suggest the message happens frequently, maybe if we're resuming the controller after runtime suspend? Maybe this should be a pci_info_once() sort of thing? I think there's some value in knowing that we're changing the BIOS configuration outside the purview of a driver, since I assume BIOS had some reason for hiding the HDA controller. > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Lukas Wunner <lukas@wunner.de> > Cc: linux-pci@vger.kernel.org > Cc: nouveau@lists.freedesktop.org > Fixes: b516ea586d71 ("PCI: Enable NVIDIA HDA controllers") > Signed-off-by: Karol Herbst <kherbst@redhat.com> > --- > drivers/pci/quirks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 44cab813bf951..b10c77bbe4716 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -5549,7 +5549,7 @@ static void quirk_nvidia_hda(struct pci_dev *gpu) > if (val & BIT(25)) > return; > > - pci_info(gpu, "Enabling HDA controller\n"); > + pci_dbg(gpu, "Enabling HDA controller\n"); > pci_write_config_dword(gpu, 0x488, val | BIT(25)); > > /* The GPU becomes a multi-function device when the HDA is enabled */ > -- > 2.39.2 >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org> To: Karol Herbst <kherbst@redhat.com> Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org Subject: Re: [Nouveau] [PATCH] PCI: stop spamming info in quirk_nvidia_hda Date: Thu, 16 Mar 2023 14:50:37 -0500 [thread overview] Message-ID: <20230316195037.GA1849341@bhelgaas> (raw) In-Reply-To: <20230316143122.2377354-1-kherbst@redhat.com> On Thu, Mar 16, 2023 at 03:31:22PM +0100, Karol Herbst wrote: > Users kept complaining about those messages and it's a little spammy on > prime systems so turn it into a debug print. What is a "prime system"? I'm a little surprised that users would really care about the message. But I do see comments like these: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1836308/comments/15 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2002206 that suggest the message happens frequently, maybe if we're resuming the controller after runtime suspend? Maybe this should be a pci_info_once() sort of thing? I think there's some value in knowing that we're changing the BIOS configuration outside the purview of a driver, since I assume BIOS had some reason for hiding the HDA controller. > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Lukas Wunner <lukas@wunner.de> > Cc: linux-pci@vger.kernel.org > Cc: nouveau@lists.freedesktop.org > Fixes: b516ea586d71 ("PCI: Enable NVIDIA HDA controllers") > Signed-off-by: Karol Herbst <kherbst@redhat.com> > --- > drivers/pci/quirks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 44cab813bf951..b10c77bbe4716 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -5549,7 +5549,7 @@ static void quirk_nvidia_hda(struct pci_dev *gpu) > if (val & BIT(25)) > return; > > - pci_info(gpu, "Enabling HDA controller\n"); > + pci_dbg(gpu, "Enabling HDA controller\n"); > pci_write_config_dword(gpu, 0x488, val | BIT(25)); > > /* The GPU becomes a multi-function device when the HDA is enabled */ > -- > 2.39.2 >
next prev parent reply other threads:[~2023-03-16 19:50 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-16 14:31 [Nouveau] [PATCH] PCI: stop spamming info in quirk_nvidia_hda Karol Herbst 2023-03-16 14:31 ` Karol Herbst 2023-03-16 16:41 ` Lukas Wunner 2023-03-16 16:41 ` [Nouveau] " Lukas Wunner 2023-03-16 19:50 ` Bjorn Helgaas [this message] 2023-03-16 19:50 ` Bjorn Helgaas 2023-03-16 20:04 ` Karol Herbst 2023-03-16 20:04 ` Karol Herbst
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230316195037.GA1849341@bhelgaas \ --to=helgaas@kernel.org \ --cc=bhelgaas@google.com \ --cc=kherbst@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lukas@wunner.de \ --cc=nouveau@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.