* [PATCH v4] Staging: octeon: Fix line ending with '('
@ 2023-03-17 5:24 Sumitra Sharma
2023-03-17 6:03 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Sumitra Sharma @ 2023-03-17 5:24 UTC (permalink / raw)
To: drv, gregkh, linux-kernel, linux-staging, outreachy
Since the coding style limited the code to 80 columns per line which caused
splitting the function header into two lines resulted in the first line
ending with a '('. This caused the checkpatch error.
Place the function parameters immediately after '(' in a single
line to align the function header.
Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
---
v2: Change patch subject and description
v3: Change patch description, noted by Deepak R Varma
<drv@mailo.com>
v4: Correct grammartical mistakes, noted by Julia Lawall
<julia.lawall@inria.fr>
drivers/staging/octeon/octeon-stubs.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index 7a02e59e283f..3e7b92cd2e35 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -1372,9 +1372,7 @@ static inline void cvmx_fau_async_fetch_and_add32(uint64_t scraddr,
int32_t value)
{ }
-static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
- int interface,
- int port)
+static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(int interface, int port)
{
union cvmx_gmxx_rxx_rx_inbnd r;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v4] Staging: octeon: Fix line ending with '('
2023-03-17 5:24 [PATCH v4] Staging: octeon: Fix line ending with '(' Sumitra Sharma
@ 2023-03-17 6:03 ` Julia Lawall
2023-03-17 7:13 ` Sumitra Sharma
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2023-03-17 6:03 UTC (permalink / raw)
To: Sumitra Sharma; +Cc: drv, gregkh, linux-kernel, linux-staging, outreachy
On Thu, 16 Mar 2023, Sumitra Sharma wrote:
> Since the coding style limited the code to 80 columns per line which caused
> splitting the function header into two lines resulted in the first line
> ending with a '('. This caused the checkpatch error.
The first sentence is still not really grammatical. Something like:
The coding style used to limit lines to 80 characters, which led to
splitting this function header into multiple lines, and ending thie first
line with a (.
For checkpatch, is it an error or a warning?
julia
>
> Place the function parameters immediately after '(' in a single
> line to align the function header.
>
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> ---
> v2: Change patch subject and description
>
> v3: Change patch description, noted by Deepak R Varma
> <drv@mailo.com>
>
> v4: Correct grammartical mistakes, noted by Julia Lawall
> <julia.lawall@inria.fr>
>
>
>
> drivers/staging/octeon/octeon-stubs.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> index 7a02e59e283f..3e7b92cd2e35 100644
> --- a/drivers/staging/octeon/octeon-stubs.h
> +++ b/drivers/staging/octeon/octeon-stubs.h
> @@ -1372,9 +1372,7 @@ static inline void cvmx_fau_async_fetch_and_add32(uint64_t scraddr,
> int32_t value)
> { }
>
> -static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
> - int interface,
> - int port)
> +static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(int interface, int port)
> {
> union cvmx_gmxx_rxx_rx_inbnd r;
>
> --
> 2.25.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] Staging: octeon: Fix line ending with '('
2023-03-17 6:03 ` Julia Lawall
@ 2023-03-17 7:13 ` Sumitra Sharma
2023-03-17 7:37 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Sumitra Sharma @ 2023-03-17 7:13 UTC (permalink / raw)
To: Julia Lawall; +Cc: drv, gregkh, linux-kernel, linux-staging, outreachy
On Fri, Mar 17, 2023 at 07:03:08AM +0100, Julia Lawall wrote:
>
>
> On Thu, 16 Mar 2023, Sumitra Sharma wrote:
>
> > Since the coding style limited the code to 80 columns per line which caused
> > splitting the function header into two lines resulted in the first line
> > ending with a '('. This caused the checkpatch error.
>
> The first sentence is still not really grammatical. Something like:
>
> The coding style used to limit lines to 80 characters, which led to
> splitting this function header into multiple lines, and ending thie first
> line with a (.
>
> For checkpatch, is it an error or a warning?
>
HI julia,
Yes, you are correct, I did the mistake its not the error but a check.
How about this...
###
The coding style used to limit lines to 80 characters, which led to splitting
this function header into multiple lines and ending the first line with a '('.
This split causes a check reported by the checkpatch.
Place the function parameters immediately after '(' in a single line to
align the function header.
###
Thank you for your reviews.
Regards,
Sumitra
> julia
>
> >
> > Place the function parameters immediately after '(' in a single
> > line to align the function header.
> >
> > Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> > ---
> > v2: Change patch subject and description
> >
> > v3: Change patch description, noted by Deepak R Varma
> > <drv@mailo.com>
> >
> > v4: Correct grammartical mistakes, noted by Julia Lawall
> > <julia.lawall@inria.fr>
> >
> >
> >
> > drivers/staging/octeon/octeon-stubs.h | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> > index 7a02e59e283f..3e7b92cd2e35 100644
> > --- a/drivers/staging/octeon/octeon-stubs.h
> > +++ b/drivers/staging/octeon/octeon-stubs.h
> > @@ -1372,9 +1372,7 @@ static inline void cvmx_fau_async_fetch_and_add32(uint64_t scraddr,
> > int32_t value)
> > { }
> >
> > -static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
> > - int interface,
> > - int port)
> > +static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(int interface, int port)
> > {
> > union cvmx_gmxx_rxx_rx_inbnd r;
> >
> > --
> > 2.25.1
> >
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] Staging: octeon: Fix line ending with '('
2023-03-17 7:13 ` Sumitra Sharma
@ 2023-03-17 7:37 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2023-03-17 7:37 UTC (permalink / raw)
To: Sumitra Sharma; +Cc: drv, gregkh, linux-kernel, linux-staging, outreachy
On Fri, 17 Mar 2023, Sumitra Sharma wrote:
> On Fri, Mar 17, 2023 at 07:03:08AM +0100, Julia Lawall wrote:
> >
> >
> > On Thu, 16 Mar 2023, Sumitra Sharma wrote:
> >
> > > Since the coding style limited the code to 80 columns per line which caused
> > > splitting the function header into two lines resulted in the first line
> > > ending with a '('. This caused the checkpatch error.
> >
> > The first sentence is still not really grammatical. Something like:
> >
> > The coding style used to limit lines to 80 characters, which led to
> > splitting this function header into multiple lines, and ending thie first
> > line with a (.
> >
> > For checkpatch, is it an error or a warning?
> >
>
> HI julia,
>
> Yes, you are correct, I did the mistake its not the error but a check.
>
> How about this...
>
> ###
> The coding style used to limit lines to 80 characters, which led to splitting
> this function header into multiple lines and ending the first line with a '('.
> This split causes a check reported by the checkpatch.
>
> Place the function parameters immediately after '(' in a single line to
> align the function header.
> ###
Looks better.
thanks,
julia
>
>
> Thank you for your reviews.
>
> Regards,
> Sumitra
>
> > julia
> >
> > >
> > > Place the function parameters immediately after '(' in a single
> > > line to align the function header.
> > >
> > > Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> > > ---
> > > v2: Change patch subject and description
> > >
> > > v3: Change patch description, noted by Deepak R Varma
> > > <drv@mailo.com>
> > >
> > > v4: Correct grammartical mistakes, noted by Julia Lawall
> > > <julia.lawall@inria.fr>
> > >
> > >
> > >
> > > drivers/staging/octeon/octeon-stubs.h | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> > > index 7a02e59e283f..3e7b92cd2e35 100644
> > > --- a/drivers/staging/octeon/octeon-stubs.h
> > > +++ b/drivers/staging/octeon/octeon-stubs.h
> > > @@ -1372,9 +1372,7 @@ static inline void cvmx_fau_async_fetch_and_add32(uint64_t scraddr,
> > > int32_t value)
> > > { }
> > >
> > > -static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
> > > - int interface,
> > > - int port)
> > > +static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(int interface, int port)
> > > {
> > > union cvmx_gmxx_rxx_rx_inbnd r;
> > >
> > > --
> > > 2.25.1
> > >
> > >
> > >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-17 7:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-17 5:24 [PATCH v4] Staging: octeon: Fix line ending with '(' Sumitra Sharma
2023-03-17 6:03 ` Julia Lawall
2023-03-17 7:13 ` Sumitra Sharma
2023-03-17 7:37 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.