From: Grant Grundler <grundler@chromium.org> To: Mahesh J Salgaonkar <mahesh@linux.ibm.com>, "Oliver O \ 'Halloran" <oohall@gmail.com>, Bjorn Helgaas <bhelgaas@google.com> Cc: Rajat Khandelwal <rajat.khandelwal@linux.intel.com>, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Rajat Jain <rajatja@chromium.org>, Grant Grundler <grundler@chromium.org> Subject: [PATCHv2 pci-next 1/2] PCI/AER: correctable error message as KERN_INFO Date: Fri, 17 Mar 2023 10:51:08 -0700 [thread overview] Message-ID: <20230317175109.3859943-1-grundler@chromium.org> (raw) Since correctable errors have been corrected (and counted), the dmesg output should not be reported as a warning, but rather as "informational". Otherwise, using a certain well known vendor's PCIe parts in a USB4 docking station, the dmesg buffer can be spammed with correctable errors, 717 bytes per instance, potentially many MB per day. Given the "WARN" priority, these messages have already confused the typical user that stumbles across them, support staff (triaging feedback reports), and more than a few linux kernel devs. Changing to INFO will hide these messages from most audiences. Signed-off-by: Grant Grundler <grundler@chromium.org> --- drivers/pci/pcie/aer.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index f6c24ded134c..cb6b96233967 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -687,23 +687,29 @@ static void __aer_print_error(struct pci_dev *dev, { const char **strings; unsigned long status = info->status & ~info->mask; - const char *level, *errmsg; int i; if (info->severity == AER_CORRECTABLE) { strings = aer_correctable_error_string; - level = KERN_WARNING; + pci_info(dev, "aer_status: 0x%08x, aer_mask: 0x%08x\n", + info->status, info->mask); } else { strings = aer_uncorrectable_error_string; - level = KERN_ERR; + pci_err(dev, "aer_status: 0x%08x, aer_mask: 0x%08x\n", + info->status, info->mask); } for_each_set_bit(i, &status, 32) { - errmsg = strings[i]; + const char *errmsg = strings[i]; + if (!errmsg) errmsg = "Unknown Error Bit"; - pci_printk(level, dev, " [%2d] %-22s%s\n", i, errmsg, + if (info->severity == AER_CORRECTABLE) + pci_info(dev, " [%2d] %-22s%s\n", i, errmsg, + info->first_error == i ? " (First)" : ""); + else + pci_err(dev, " [%2d] %-22s%s\n", i, errmsg, info->first_error == i ? " (First)" : ""); } pci_dev_aer_stats_incr(dev, info); @@ -724,7 +730,7 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info) layer = AER_GET_LAYER_ERROR(info->severity, info->status); agent = AER_GET_AGENT(info->severity, info->status); - level = (info->severity == AER_CORRECTABLE) ? KERN_WARNING : KERN_ERR; + level = (info->severity == AER_CORRECTABLE) ? KERN_INFO : KERN_ERR; pci_printk(level, dev, "PCIe Bus Error: severity=%s, type=%s, (%s)\n", aer_error_severity_string[info->severity], @@ -797,14 +803,17 @@ void cper_print_aer(struct pci_dev *dev, int aer_severity, info.mask = mask; info.first_error = PCI_ERR_CAP_FEP(aer->cap_control); - pci_err(dev, "aer_status: 0x%08x, aer_mask: 0x%08x\n", status, mask); __aer_print_error(dev, &info); - pci_err(dev, "aer_layer=%s, aer_agent=%s\n", - aer_error_layer[layer], aer_agent_string[agent]); - if (aer_severity != AER_CORRECTABLE) + if (aer_severity == AER_CORRECTABLE) { + pci_info(dev, "aer_layer=%s, aer_agent=%s\n", + aer_error_layer[layer], aer_agent_string[agent]); + } else { + pci_err(dev, "aer_layer=%s, aer_agent=%s\n", + aer_error_layer[layer], aer_agent_string[agent]); pci_err(dev, "aer_uncor_severity: 0x%08x\n", aer->uncor_severity); + } if (tlp_header_valid) __print_tlp_header(dev, &aer->header_log); -- 2.40.0.rc1.284.g88254d51c5-goog
WARNING: multiple messages have this Message-ID (diff)
From: Grant Grundler <grundler@chromium.org> To: Mahesh J Salgaonkar <mahesh@linux.ibm.com>, "Oliver O \ 'Halloran" <oohall@gmail.com>, Bjorn Helgaas <bhelgaas@google.com> Cc: Rajat Jain <rajatja@chromium.org>, Rajat Khandelwal <rajat.khandelwal@linux.intel.com>, Grant Grundler <grundler@chromium.org>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCHv2 pci-next 1/2] PCI/AER: correctable error message as KERN_INFO Date: Fri, 17 Mar 2023 10:51:08 -0700 [thread overview] Message-ID: <20230317175109.3859943-1-grundler@chromium.org> (raw) Since correctable errors have been corrected (and counted), the dmesg output should not be reported as a warning, but rather as "informational". Otherwise, using a certain well known vendor's PCIe parts in a USB4 docking station, the dmesg buffer can be spammed with correctable errors, 717 bytes per instance, potentially many MB per day. Given the "WARN" priority, these messages have already confused the typical user that stumbles across them, support staff (triaging feedback reports), and more than a few linux kernel devs. Changing to INFO will hide these messages from most audiences. Signed-off-by: Grant Grundler <grundler@chromium.org> --- drivers/pci/pcie/aer.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index f6c24ded134c..cb6b96233967 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -687,23 +687,29 @@ static void __aer_print_error(struct pci_dev *dev, { const char **strings; unsigned long status = info->status & ~info->mask; - const char *level, *errmsg; int i; if (info->severity == AER_CORRECTABLE) { strings = aer_correctable_error_string; - level = KERN_WARNING; + pci_info(dev, "aer_status: 0x%08x, aer_mask: 0x%08x\n", + info->status, info->mask); } else { strings = aer_uncorrectable_error_string; - level = KERN_ERR; + pci_err(dev, "aer_status: 0x%08x, aer_mask: 0x%08x\n", + info->status, info->mask); } for_each_set_bit(i, &status, 32) { - errmsg = strings[i]; + const char *errmsg = strings[i]; + if (!errmsg) errmsg = "Unknown Error Bit"; - pci_printk(level, dev, " [%2d] %-22s%s\n", i, errmsg, + if (info->severity == AER_CORRECTABLE) + pci_info(dev, " [%2d] %-22s%s\n", i, errmsg, + info->first_error == i ? " (First)" : ""); + else + pci_err(dev, " [%2d] %-22s%s\n", i, errmsg, info->first_error == i ? " (First)" : ""); } pci_dev_aer_stats_incr(dev, info); @@ -724,7 +730,7 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info) layer = AER_GET_LAYER_ERROR(info->severity, info->status); agent = AER_GET_AGENT(info->severity, info->status); - level = (info->severity == AER_CORRECTABLE) ? KERN_WARNING : KERN_ERR; + level = (info->severity == AER_CORRECTABLE) ? KERN_INFO : KERN_ERR; pci_printk(level, dev, "PCIe Bus Error: severity=%s, type=%s, (%s)\n", aer_error_severity_string[info->severity], @@ -797,14 +803,17 @@ void cper_print_aer(struct pci_dev *dev, int aer_severity, info.mask = mask; info.first_error = PCI_ERR_CAP_FEP(aer->cap_control); - pci_err(dev, "aer_status: 0x%08x, aer_mask: 0x%08x\n", status, mask); __aer_print_error(dev, &info); - pci_err(dev, "aer_layer=%s, aer_agent=%s\n", - aer_error_layer[layer], aer_agent_string[agent]); - if (aer_severity != AER_CORRECTABLE) + if (aer_severity == AER_CORRECTABLE) { + pci_info(dev, "aer_layer=%s, aer_agent=%s\n", + aer_error_layer[layer], aer_agent_string[agent]); + } else { + pci_err(dev, "aer_layer=%s, aer_agent=%s\n", + aer_error_layer[layer], aer_agent_string[agent]); pci_err(dev, "aer_uncor_severity: 0x%08x\n", aer->uncor_severity); + } if (tlp_header_valid) __print_tlp_header(dev, &aer->header_log); -- 2.40.0.rc1.284.g88254d51c5-goog
next reply other threads:[~2023-03-17 17:51 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-17 17:51 Grant Grundler [this message] 2023-03-17 17:51 ` [PATCHv2 pci-next 1/2] PCI/AER: correctable error message as KERN_INFO Grant Grundler 2023-03-17 17:51 ` [PATCHv2 pci-next 2/2] PCI/AER: Rate limit the reporting of the correctable errors Grant Grundler 2023-03-17 17:51 ` Grant Grundler 2023-04-06 19:50 ` Bjorn Helgaas 2023-04-06 19:50 ` Bjorn Helgaas 2023-04-07 18:53 ` Grant Grundler 2023-04-07 18:53 ` Grant Grundler 2023-04-07 19:46 ` Bjorn Helgaas 2023-04-07 19:46 ` Bjorn Helgaas 2023-04-07 23:46 ` Grant Grundler 2023-05-17 16:02 ` Bjorn Helgaas 2023-05-17 21:02 ` Grant Grundler 2023-05-17 21:02 ` Grant Grundler 2023-05-18 5:58 ` Grant Grundler 2023-05-18 5:58 ` Grant Grundler 2023-04-07 23:47 ` Grant Grundler 2023-04-07 23:47 ` Grant Grundler 2023-04-07 23:49 ` Grant Grundler 2023-04-07 23:49 ` Grant Grundler 2023-05-18 6:11 ` Grant Grundler 2023-05-18 6:11 ` Grant Grundler 2023-06-06 3:44 ` Grant Grundler 2023-06-06 3:45 ` Grant Grundler 2023-06-06 3:45 ` Grant Grundler 2023-03-17 18:50 ` [PATCHv2 pci-next 1/2] PCI/AER: correctable error message as KERN_INFO Sathyanarayanan Kuppuswamy 2023-03-17 18:50 ` Sathyanarayanan Kuppuswamy 2023-03-17 19:30 ` Bjorn Helgaas 2023-03-17 19:30 ` Bjorn Helgaas 2023-03-19 6:00 ` Grant Grundler 2023-03-19 6:00 ` Grant Grundler
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230317175109.3859943-1-grundler@chromium.org \ --to=grundler@chromium.org \ --cc=bhelgaas@google.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mahesh@linux.ibm.com \ --cc=oohall@gmail.com \ --cc=rajat.khandelwal@linux.intel.com \ --cc=rajatja@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.