[PATCH] blk-mq: fix forward declaration for rdma mapping

[PATCH] blk-mq: fix forward declaration for rdma mapping

[Keith Busch]

From: Keith Busch <kbusch@kernel.org>

blk_mq_rdma_map_queues() used to take a 'blk_mq_tag_set *' parameter,
but was changed to 'blk_mq_queue_map *'. The forward declaration needs
to be updated so .c files won't have to include headers in a specific
order.

Fixes: e42b3867de4bd5e ("blk-mq-rdma: pass in queue map to blk_mq_rdma_map_queues")
Cc: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 include/linux/blk-mq-rdma.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/blk-mq-rdma.h b/include/linux/blk-mq-rdma.h
index 53b58c610e767..d7ead42f1c6ad 100644
--- a/include/linux/blk-mq-rdma.h
+++ b/include/linux/blk-mq-rdma.h
@@ -2,7 +2,7 @@
 #ifndef _LINUX_BLK_MQ_RDMA_H
 #define _LINUX_BLK_MQ_RDMA_H
 
-struct blk_mq_tag_set;
+struct blk_mq_queue_map;
 struct ib_device;
 
 void blk_mq_rdma_map_queues(struct blk_mq_queue_map *map,
-- 
2.34.1

Re: [PATCH] blk-mq: fix forward declaration for rdma mapping

[Chaitanya Kulkarni]

On 3/21/2023 2:50 PM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
> 
> blk_mq_rdma_map_queues() used to take a 'blk_mq_tag_set *' parameter,
> but was changed to 'blk_mq_queue_map *'. The forward declaration needs
> to be updated so .c files won't have to include headers in a specific
> order.
> 
> Fixes: e42b3867de4bd5e ("blk-mq-rdma: pass in queue map to blk_mq_rdma_map_queues")
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---

LGTM.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck

Re: [PATCH] blk-mq: fix forward declaration for rdma mapping

[Sagi Grimberg]

> From: Keith Busch <kbusch@kernel.org>
> 
> blk_mq_rdma_map_queues() used to take a 'blk_mq_tag_set *' parameter,
> but was changed to 'blk_mq_queue_map *'. The forward declaration needs
> to be updated so .c files won't have to include headers in a specific
> order.
> 
> Fixes: e42b3867de4bd5e ("blk-mq-rdma: pass in queue map to blk_mq_rdma_map_queues")
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
>   include/linux/blk-mq-rdma.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/blk-mq-rdma.h b/include/linux/blk-mq-rdma.h
> index 53b58c610e767..d7ead42f1c6ad 100644
> --- a/include/linux/blk-mq-rdma.h
> +++ b/include/linux/blk-mq-rdma.h
> @@ -2,7 +2,7 @@
>   #ifndef _LINUX_BLK_MQ_RDMA_H
>   #define _LINUX_BLK_MQ_RDMA_H
>   
> -struct blk_mq_tag_set;
> +struct blk_mq_queue_map;
>   struct ib_device;
>   
>   void blk_mq_rdma_map_queues(struct blk_mq_queue_map *map,

BTW, afaik this is dead code because no rdma device exposes
.get_vector_affinity. I'll send a patch to remove it altogether.

Re: [PATCH] blk-mq: fix forward declaration for rdma mapping

[Daniel Wagner]

On Tue, Mar 21, 2023 at 02:50:01PM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
> 
> blk_mq_rdma_map_queues() used to take a 'blk_mq_tag_set *' parameter,
> but was changed to 'blk_mq_queue_map *'. The forward declaration needs
> to be updated so .c files won't have to include headers in a specific
> order.
> 
> Fixes: e42b3867de4bd5e ("blk-mq-rdma: pass in queue map to blk_mq_rdma_map_queues")
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Signed-off-by: Keith Busch <kbusch@kernel.org>

Reviewed-by: Daniel Wagner <dwagner@suse.de>