[PATCH] net: mdio: thunder: Add missing fwnode_handle_put()

[PATCH] net: mdio: thunder: Add missing fwnode_handle_put()

[Liang He]

In device_for_each_child_node(), we should add fwnode_handle_put()
when break out of the iteration device_for_each_child_node()
as it will automatically increase and decrease the refcounter.

Fixes: 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.")
Signed-off-by: Liang He <windhl@126.com>
---
 drivers/net/mdio/mdio-thunder.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mdio/mdio-thunder.c b/drivers/net/mdio/mdio-thunder.c
index 822d2cdd2f35..394b864aaa37 100644
--- a/drivers/net/mdio/mdio-thunder.c
+++ b/drivers/net/mdio/mdio-thunder.c
@@ -104,6 +104,7 @@ static int thunder_mdiobus_pci_probe(struct pci_dev *pdev,
 		if (i >= ARRAY_SIZE(nexus->buses))
 			break;
 	}
+	fwnode_handle_put(fwn);
 	return 0;
 
 err_release_regions:
-- 
2.25.1

Re: [PATCH] net: mdio: thunder: Add missing fwnode_handle_put()

[Horatiu Vultur]

The 03/22/2023 14:20, Liang He wrote:
> 
> In device_for_each_child_node(), we should add fwnode_handle_put()
> when break out of the iteration device_for_each_child_node()
> as it will automatically increase and decrease the refcounter.

Don't forget to mention the tree which you are targeting.
It shoud be something like:
"[PATCH net] net: mdio: thunder: Add missing fwnode_handle_put()" and
you can achieve this using option --subject-prefix when you create your
patch:
git format-patch ... --subject-prefix "PATCH net"


> 
> Fixes: 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.")
> Signed-off-by: Liang He <windhl@126.com>
> ---
>  drivers/net/mdio/mdio-thunder.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/mdio/mdio-thunder.c b/drivers/net/mdio/mdio-thunder.c
> index 822d2cdd2f35..394b864aaa37 100644
> --- a/drivers/net/mdio/mdio-thunder.c
> +++ b/drivers/net/mdio/mdio-thunder.c
> @@ -104,6 +104,7 @@ static int thunder_mdiobus_pci_probe(struct pci_dev *pdev,
>                 if (i >= ARRAY_SIZE(nexus->buses))
>                         break;
>         }
> +       fwnode_handle_put(fwn);

Can you declare only 1 mdio bus in the DT under this pci device?
Because in that case, I don't think this is correct, because then
'device_for_each_child_node' will exit before all 4 mdio buses are probed.
And according to the comments for 'fwnode_handle_put' you need to use
with break or return.

>         return 0;
> 
>  err_release_regions:
> --
> 2.25.1
> 

-- 
/Horatiu

Re:Re: [PATCH] net: mdio: thunder: Add missing fwnode_handle_put()

[Liang He]

At 2023-03-22 16:55:38, "Horatiu Vultur" <horatiu.vultur@microchip.com> wrote:
>The 03/22/2023 14:20, Liang He wrote:
>> 
>> In device_for_each_child_node(), we should add fwnode_handle_put()
>> when break out of the iteration device_for_each_child_node()
>> as it will automatically increase and decrease the refcounter.
>
>Don't forget to mention the tree which you are targeting.
>It shoud be something like:
>"[PATCH net] net: mdio: thunder: Add missing fwnode_handle_put()" and
>you can achieve this using option --subject-prefix when you create your
>patch:
>git format-patch ... --subject-prefix "PATCH net"
>

Thanks for your reply and advise, I will add it in my future patches.

>
>> 
>> Fixes: 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.")
>> Signed-off-by: Liang He <windhl@126.com>
>> ---
>>  drivers/net/mdio/mdio-thunder.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/net/mdio/mdio-thunder.c b/drivers/net/mdio/mdio-thunder.c
>> index 822d2cdd2f35..394b864aaa37 100644
>> --- a/drivers/net/mdio/mdio-thunder.c
>> +++ b/drivers/net/mdio/mdio-thunder.c
>> @@ -104,6 +104,7 @@ static int thunder_mdiobus_pci_probe(struct pci_dev *pdev,
>>                 if (i >= ARRAY_SIZE(nexus->buses))
>>                         break;
>>         }
>> +       fwnode_handle_put(fwn);
>
>Can you declare only 1 mdio bus in the DT under this pci device?
>Because in that case, I don't think this is correct, because then
>'device_for_each_child_node' will exit before all 4 mdio buses are probed.
>And according to the comments for 'fwnode_handle_put' you need to use
>with break or return.
>

In fact, the fwnode_handle_put(fwn) consider the NULL-check of fwn, and 
there are only break, not return, so I think it can work in this case.
However, if you prefer to add fwnode_handle_put before break, I can
send a new patch.

Thanks,
Liang

>>         return 0;
>> 
>>  err_release_regions:
>> --
>> 2.25.1
>> 
>
>-- 
>/Horatiu

Re: [PATCH] net: mdio: thunder: Add missing fwnode_handle_put()

[Horatiu Vultur]

The 03/23/2023 09:53, Liang He wrote:
> 
> At 2023-03-22 16:55:38, "Horatiu Vultur" <horatiu.vultur@microchip.com> wrote:
> >The 03/22/2023 14:20, Liang He wrote:
> >>
> >> In device_for_each_child_node(), we should add fwnode_handle_put()
> >> when break out of the iteration device_for_each_child_node()
> >> as it will automatically increase and decrease the refcounter.
> >
> >Don't forget to mention the tree which you are targeting.
> >It shoud be something like:
> >"[PATCH net] net: mdio: thunder: Add missing fwnode_handle_put()" and
> >you can achieve this using option --subject-prefix when you create your
> >patch:
> >git format-patch ... --subject-prefix "PATCH net"
> >
> 
> Thanks for your reply and advise, I will add it in my future patches.
> 
> >
> >>
> >> Fixes: 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.")
> >> Signed-off-by: Liang He <windhl@126.com>
> >> ---
> >>  drivers/net/mdio/mdio-thunder.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/net/mdio/mdio-thunder.c b/drivers/net/mdio/mdio-thunder.c
> >> index 822d2cdd2f35..394b864aaa37 100644
> >> --- a/drivers/net/mdio/mdio-thunder.c
> >> +++ b/drivers/net/mdio/mdio-thunder.c
> >> @@ -104,6 +104,7 @@ static int thunder_mdiobus_pci_probe(struct pci_dev *pdev,
> >>                 if (i >= ARRAY_SIZE(nexus->buses))
> >>                         break;
> >>         }
> >> +       fwnode_handle_put(fwn);
> >
> >Can you declare only 1 mdio bus in the DT under this pci device?
> >Because in that case, I don't think this is correct, because then
> >'device_for_each_child_node' will exit before all 4 mdio buses are probed.
> >And according to the comments for 'fwnode_handle_put' you need to use
> >with break or return.
> >
> 
> In fact, the fwnode_handle_put(fwn) consider the NULL-check of fwn, and
> there are only break, not return, so I think it can work in this case.
> However, if you prefer to add fwnode_handle_put before break, I can
> send a new patch.

You are right, fwnode_handle_put checks for NULL.
It is up too you how you prefer.

> 
> Thanks,
> Liang
> 
> >>         return 0;
> >>
> >>  err_release_regions:
> >> --
> >> 2.25.1
> >>
> >
> >--
> >/Horatiu

-- 
/Horatiu

Re: [PATCH] net: mdio: thunder: Add missing fwnode_handle_put()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Wed, 22 Mar 2023 14:20:57 +0800 you wrote:
> In device_for_each_child_node(), we should add fwnode_handle_put()
> when break out of the iteration device_for_each_child_node()
> as it will automatically increase and decrease the refcounter.
> 
> Fixes: 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.")
> Signed-off-by: Liang He <windhl@126.com>
> 
> [...]

Here is the summary with links:
  - net: mdio: thunder: Add missing fwnode_handle_put()
    https://git.kernel.org/netdev/net/c/b1de5c78ebe9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html