* [PATCH] Input: cma3000_d0x - Clean up some inconsistent indenting
@ 2023-03-22 6:41 Jiapeng Chong
2023-04-02 1:46 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2023-03-22 6:41 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel, Jiapeng Chong, Abaci Robot
No functional modification involved.
drivers/input/misc/cma3000_d0x.c:328 cma3000_init() warn: inconsistent indenting.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4588
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/input/misc/cma3000_d0x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c
index e6feb73bb52b..c444a44e4576 100644
--- a/drivers/input/misc/cma3000_d0x.c
+++ b/drivers/input/misc/cma3000_d0x.c
@@ -325,7 +325,7 @@ struct cma3000_accl_data *cma3000_init(struct device *dev, int irq,
input_dev->open = cma3000_open;
input_dev->close = cma3000_close;
- __set_bit(EV_ABS, input_dev->evbit);
+ __set_bit(EV_ABS, input_dev->evbit);
input_set_abs_params(input_dev, ABS_X,
-data->g_range, data->g_range, pdata->fuzz_x, 0);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: cma3000_d0x - Clean up some inconsistent indenting
2023-03-22 6:41 [PATCH] Input: cma3000_d0x - Clean up some inconsistent indenting Jiapeng Chong
@ 2023-04-02 1:46 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2023-04-02 1:46 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: linux-input, linux-kernel, Abaci Robot
Hi Jiapeng,
On Wed, Mar 22, 2023 at 02:41:58PM +0800, Jiapeng Chong wrote:
> No functional modification involved.
>
> drivers/input/misc/cma3000_d0x.c:328 cma3000_init() warn: inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4588
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/input/misc/cma3000_d0x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c
> index e6feb73bb52b..c444a44e4576 100644
> --- a/drivers/input/misc/cma3000_d0x.c
> +++ b/drivers/input/misc/cma3000_d0x.c
> @@ -325,7 +325,7 @@ struct cma3000_accl_data *cma3000_init(struct device *dev, int irq,
> input_dev->open = cma3000_open;
> input_dev->close = cma3000_close;
>
> - __set_bit(EV_ABS, input_dev->evbit);
> + __set_bit(EV_ABS, input_dev->evbit);
We should simply remove this, as input_set_abs_params() will set EV_ABS
bit for us.
>
> input_set_abs_params(input_dev, ABS_X,
> -data->g_range, data->g_range, pdata->fuzz_x, 0);
> --
> 2.20.1.7.g153144c
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-02 1:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-22 6:41 [PATCH] Input: cma3000_d0x - Clean up some inconsistent indenting Jiapeng Chong
2023-04-02 1:46 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.