From: Jonathan Cameron <Jonathan.Cameron@huawei.com> To: Michael Tsirkin <mst@redhat.com>, <qemu-devel@nongnu.org> Cc: <linuxarm@huawei.com>, Fan Ni <fan.ni@samsung.com>, Dave Jiang <dave.jiang@intel.com>, <linux-cxl@vger.kernel.org> Subject: [RESEND PATCH 0/2] hw/cxl: Fix decoder commit and uncommit handling Date: Wed, 22 Mar 2023 10:27:29 +0000 [thread overview] Message-ID: <20230322102731.4219-1-Jonathan.Cameron@huawei.com> (raw) Resending because all but patch 1 seem to have failed to make it out of our network. Issue reported in discussion of: https://lore.kernel.org/all/20230228224014.1402545-1-fan.ni@samsung.com/ The committed bit for HDM decoders is expected reset when commit transitions from 1->0. Whilst looking at that it was noticed that hardware was resetting the commit bit which is not an option allowed by the CXL spec. In common with many other areas the code did not take into account big endian architectures, so fix that whilst we are here. Note testing this exposed a kernel bug around repeated attempts to clear a decoder out of order. That's been reported but not yet fixed. Jonathan Cameron (2): hw/cxl: Fix endian handling for decoder commit. hw/cxl: Fix incorrect reset of commit and associated clearing of committed. hw/cxl/cxl-component-utils.c | 14 ++++++++------ hw/mem/cxl_type3.c | 28 +++++++++++++++++++++++++--- 2 files changed, 33 insertions(+), 9 deletions(-) -- 2.37.2
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron via <qemu-devel@nongnu.org> To: Michael Tsirkin <mst@redhat.com>, <qemu-devel@nongnu.org> Cc: <linuxarm@huawei.com>, Fan Ni <fan.ni@samsung.com>, Dave Jiang <dave.jiang@intel.com>, <linux-cxl@vger.kernel.org> Subject: [RESEND PATCH 0/2] hw/cxl: Fix decoder commit and uncommit handling Date: Wed, 22 Mar 2023 10:27:29 +0000 [thread overview] Message-ID: <20230322102731.4219-1-Jonathan.Cameron@huawei.com> (raw) Resending because all but patch 1 seem to have failed to make it out of our network. Issue reported in discussion of: https://lore.kernel.org/all/20230228224014.1402545-1-fan.ni@samsung.com/ The committed bit for HDM decoders is expected reset when commit transitions from 1->0. Whilst looking at that it was noticed that hardware was resetting the commit bit which is not an option allowed by the CXL spec. In common with many other areas the code did not take into account big endian architectures, so fix that whilst we are here. Note testing this exposed a kernel bug around repeated attempts to clear a decoder out of order. That's been reported but not yet fixed. Jonathan Cameron (2): hw/cxl: Fix endian handling for decoder commit. hw/cxl: Fix incorrect reset of commit and associated clearing of committed. hw/cxl/cxl-component-utils.c | 14 ++++++++------ hw/mem/cxl_type3.c | 28 +++++++++++++++++++++++++--- 2 files changed, 33 insertions(+), 9 deletions(-) -- 2.37.2
next reply other threads:[~2023-03-22 10:27 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-22 10:27 Jonathan Cameron [this message] 2023-03-22 10:27 ` [RESEND PATCH 0/2] hw/cxl: Fix decoder commit and uncommit handling Jonathan Cameron via 2023-03-22 10:27 ` [RESEND PATCH 1/2] hw/cxl: Fix endian handling for decoder commit Jonathan Cameron 2023-03-22 10:27 ` Jonathan Cameron via 2023-03-22 10:34 ` Philippe Mathieu-Daudé 2023-03-22 10:27 ` [RESEND PATCH 2/2] hw/cxl: Fix incorrect reset of commit and associated clearing of committed Jonathan Cameron 2023-03-22 10:27 ` Jonathan Cameron via 2023-03-22 10:33 ` Jonathan Cameron 2023-03-22 10:33 ` Jonathan Cameron via 2023-03-22 16:21 ` Fan Ni 2023-03-24 14:01 ` Jonathan Cameron 2023-03-24 14:01 ` Jonathan Cameron via 2023-03-24 17:05 ` Dave Jiang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230322102731.4219-1-Jonathan.Cameron@huawei.com \ --to=jonathan.cameron@huawei.com \ --cc=dave.jiang@intel.com \ --cc=fan.ni@samsung.com \ --cc=linux-cxl@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=mst@redhat.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.